1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
|
/*
* Copyright (C) 2019 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
* OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "config.h"
#include "DFGValueRepReductionPhase.h"
#if ENABLE(DFG_JIT)
#include "DFGGraph.h"
#include "DFGInsertionSet.h"
#include "DFGPhase.h"
#include "DFGPhiChildren.h"
#include "JSCJSValueInlines.h"
namespace JSC { namespace DFG {
class ValueRepReductionPhase : public Phase {
static constexpr bool verbose = false;
public:
ValueRepReductionPhase(Graph& graph)
: Phase(graph, "ValueRep reduction"_s)
, m_insertionSet(graph)
{
}
bool run()
{
ASSERT(m_graph.m_form == SSA);
return convertValueRepsToDouble();
}
private:
bool convertValueRepsToDouble()
{
UncheckedKeyHashSet<Node*> candidates;
for (BasicBlock* block : m_graph.blocksInNaturalOrder()) {
for (Node* node : *block) {
switch (node->op()) {
case ValueRep: {
if (node->child1().useKind() == DoubleRepUse)
candidates.add(node);
break;
}
#if CPU(ARM64)
case DoubleRep: {
switch (node->child1()->op()) {
case GetClosureVar:
case GetGlobalVar:
case GetGlobalLexicalVariable:
case MultiGetByOffset:
case GetByOffset: {
if (node->child1().useKind() == RealNumberUse || node->child1().useKind() == NumberUse) {
if (node->child1()->origin.exitOK)
candidates.add(node->child1().node());
break;
}
break;
}
default:
break;
}
break;
}
#endif
default:
break;
}
}
}
if (candidates.isEmpty())
return false;
UncheckedKeyHashMap<Node*, Vector<Node*>> usersOf;
auto getUsersOf = [&] (Node* candidate) {
auto iter = usersOf.find(candidate);
RELEASE_ASSERT(iter != usersOf.end());
return iter->value;
};
for (BasicBlock* block : m_graph.blocksInPreOrder()) {
for (Node* node : *block) {
switch (node->op()) {
case Phi: {
usersOf.add(node, Vector<Node*>());
break;
}
#if CPU(ARM64)
case GetClosureVar:
case GetGlobalVar:
case GetGlobalLexicalVariable:
case MultiGetByOffset:
case GetByOffset: {
if (candidates.contains(node))
usersOf.add(node, Vector<Node*>());
break;
}
#endif
case ValueRep: {
if (candidates.contains(node))
usersOf.add(node, Vector<Node*>());
break;
}
default:
break;
}
Vector<Node*, 3> alreadyAdded;
m_graph.doToChildren(node, [&] (Edge edge) {
Node* candidate = edge.node();
if (alreadyAdded.contains(candidate))
return;
auto iter = usersOf.find(candidate);
if (iter == usersOf.end())
return;
iter->value.append(node);
alreadyAdded.append(candidate);
});
}
}
PhiChildren phiChildren(m_graph);
// - Any candidate that forwards into a Phi turns that Phi into a candidate.
// - Any Phi-1 that forwards into another Phi-2, where Phi-2 is a candidate,
// makes Phi-1 a candidate too.
do {
UncheckedKeyHashSet<Node*> eligiblePhis;
for (Node* candidate : candidates) {
if (candidate->op() == Phi) {
phiChildren.forAllIncomingValues(candidate, [&] (Node* incoming) {
if (incoming->op() == Phi)
eligiblePhis.add(incoming);
});
}
for (Node* user : getUsersOf(candidate)) {
if (user->op() == Upsilon)
eligiblePhis.add(user->phi());
}
}
bool sawNewCandidate = false;
for (Node* phi : eligiblePhis)
sawNewCandidate |= candidates.add(phi).isNewEntry;
if (!sawNewCandidate)
break;
} while (true);
do {
UncheckedKeyHashSet<Node*> toRemove;
auto isEscaped = [&] (Node* node) {
return !candidates.contains(node) || toRemove.contains(node);
};
// Escape rules are as follows:
// - Any non-well-known use is an escape. Currently, we allow DoubleRep, Hints,
// Upsilons, PutByOffset, MultiPutByOffset, PutClosureVar, PutGlobalVariable (described below).
// - Any Upsilon that forwards the candidate into an escaped phi escapes the candidate.
// - A Phi remains a candidate as long as all values flowing into it can be made a double.
// Currently, this means these are valid things we support to forward into the Phi:
// - A JSConstant(some number "x") => DoubleConstant("x")
// - ValueRep(DoubleRepUse:@x) => @x
// - A Phi so long as that Phi is not escaped.
for (Node* candidate : candidates) {
bool ok = true;
auto dumpEscape = [&](const char* description, Node* node) {
if constexpr (!verbose)
return;
WTF::dataFile().atomically([&](auto&) {
dataLogLn(description);
dataLog(" candidate: ");
m_graph.dump(WTF::dataFile(), Prefix::noString, candidate);
dataLog(" reason: ");
m_graph.dump(WTF::dataFile(), Prefix::noString, node);
dataLogLn();
});
};
if (candidate->op() == Phi) {
phiChildren.forAllIncomingValues(candidate, [&] (Node* node) {
switch (node->op()) {
case JSConstant: {
if (!node->asJSValue().isNumber()) {
ok = false;
dumpEscape("Phi Incoming JSConstant not a number: ", node);
}
break;
}
#if CPU(ARM64)
case GetClosureVar:
case GetGlobalVar:
case GetGlobalLexicalVariable:
case MultiGetByOffset:
case GetByOffset: {
if (isEscaped(node)) {
ok = false;
dumpEscape("Phi Incoming Get is escaped: ", node);
}
break;
}
#endif
case ValueRep: {
if (node->child1().useKind() != DoubleRepUse) {
ok = false;
dumpEscape("Phi Incoming ValueRep not DoubleRepUse: ", node);
}
break;
}
case Phi: {
if (isEscaped(node)) {
ok = false;
dumpEscape("An incoming Phi to another Phi is escaped: ", node);
}
break;
}
default: {
ok = false;
dumpEscape("Unsupported incoming value to Phi: ", node);
break;
}
}
});
if (!ok) {
toRemove.add(candidate);
continue;
}
}
for (Node* user : getUsersOf(candidate)) {
switch (user->op()) {
case DoubleRep: {
switch (user->child1().useKind()) {
case RealNumberUse:
case NumberUse:
break;
default: {
ok = false;
dumpEscape("DoubleRep escape: ", user);
break;
}
}
break;
}
case PutHint:
case MovHint:
break;
#if CPU(ARM64)
// We can handle these nodes only when we have FPRReg addition in integer form.
case PutByOffset:
case MultiPutByOffset:
case PutClosureVar:
case PutGlobalVariable:
break;
#endif
case Upsilon: {
Node* phi = user->phi();
if (isEscaped(phi)) {
dumpEscape("Upsilon of escaped phi escapes candidate: ", phi);
ok = false;
}
break;
}
default:
dumpEscape("Normal escape: ", user);
ok = false;
break;
}
if (!ok)
break;
}
if (!ok)
toRemove.add(candidate);
}
if (toRemove.isEmpty())
break;
for (Node* node : toRemove)
candidates.remove(node);
} while (true);
if (candidates.isEmpty())
return false;
NodeOrigin originForConstant = m_graph.block(0)->at(0)->origin;
UncheckedKeyHashSet<Node*> doubleRepRealCheckLocations;
for (Node* candidate : candidates) {
dataLogLnIf(verbose, "Optimized: ", candidate);
Node* resultNode = nullptr;
switch (candidate->op()) {
case Phi: {
resultNode = candidate;
for (Node* upsilon : phiChildren.upsilonsOf(candidate)) {
Node* incomingValue = upsilon->child1().node();
Node* newChild = nullptr;
switch (incomingValue->op()) {
case JSConstant: {
double number = incomingValue->asJSValue().asNumber();
newChild = m_insertionSet.insertConstant(0, originForConstant, jsDoubleNumber(number), DoubleConstant);
break;
}
case ValueRep: {
// We don't care about the incoming value being an impure NaN because users of
// this Phi are either OSR exit, DoubleRep(RealNumberUse:@phi), or PurifyNaN(@phi).
ASSERT(incomingValue->child1().useKind() == DoubleRepUse);
newChild = incomingValue->child1().node();
break;
}
case Phi: {
newChild = incomingValue;
break;
}
#if CPU(ARM64)
case GetClosureVar:
case GetGlobalVar:
case GetGlobalLexicalVariable:
case MultiGetByOffset:
case GetByOffset: {
newChild = incomingValue;
break;
}
#endif
default:
RELEASE_ASSERT_NOT_REACHED();
break;
}
upsilon->child1() = Edge(newChild, DoubleRepUse);
}
candidate->setResult(NodeResultDouble);
break;
}
case ValueRep: {
resultNode = candidate->child1().node();
break;
}
#if CPU(ARM64)
case GetClosureVar:
case GetGlobalVar:
case GetGlobalLexicalVariable:
case MultiGetByOffset:
case GetByOffset: {
candidate->setResult(NodeResultDouble);
resultNode = candidate;
break;
}
#endif
default:
RELEASE_ASSERT_NOT_REACHED();
break;
}
for (Node* user : getUsersOf(candidate)) {
switch (user->op()) {
case DoubleRep: {
if (user->child1().useKind() == RealNumberUse) {
user->convertToIdentityOn(resultNode);
doubleRepRealCheckLocations.add(user);
} else
user->convertToPurifyNaN(resultNode);
break;
}
case PutHint:
user->child2() = Edge(resultNode, DoubleRepUse);
break;
case MovHint:
user->child1() = Edge(resultNode, DoubleRepUse);
break;
#if CPU(ARM64)
case PutByOffset:
user->child3() = Edge(resultNode, DoubleRepUse);
break;
case MultiPutByOffset:
user->child2() = Edge(resultNode, DoubleRepUse);
break;
case PutClosureVar:
user->child2() = Edge(resultNode, DoubleRepUse);
break;
case PutGlobalVariable:
user->child2() = Edge(resultNode, DoubleRepUse);
break;
#endif
case Upsilon: {
Node* phi = user->phi();
ASSERT_UNUSED(phi, candidates.contains(phi));
break;
}
default:
RELEASE_ASSERT_NOT_REACHED();
break;
}
}
}
// Insert constants.
m_insertionSet.execute(m_graph.block(0));
// Insert checks that are needed when removing DoubleRep(RealNumber:@x)
if (!doubleRepRealCheckLocations.isEmpty()) {
for (BasicBlock* block : m_graph.blocksInNaturalOrder()) {
for (unsigned i = 0; i < block->size(); ++i) {
Node* node = block->at(i);
if (node->op() != Identity) {
ASSERT(!doubleRepRealCheckLocations.contains(node));
continue;
}
if (!doubleRepRealCheckLocations.contains(node))
continue;
m_insertionSet.insertNode(
i, SpecNone, Check, node->origin,
Edge(node->child1().node(), DoubleRepRealUse));
}
m_insertionSet.execute(block);
}
}
return true;
}
InsertionSet m_insertionSet;
};
bool performValueRepReduction(Graph& graph)
{
return runPhase<ValueRepReductionPhase>(graph);
}
} } // namespace JSC::DFG
#endif // ENABLE(DFG_JIT)
|