1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746
|
/*
* Copyright (c) 2023 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
* OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "config.h"
#include "AttributeValidator.h"
#include "AST.h"
#include "ASTVisitor.h"
#include "Constraints.h"
#include "WGSLShaderModule.h"
#include <wtf/CheckedArithmetic.h>
#include <wtf/text/MakeString.h>
namespace WGSL {
enum class Direction : uint8_t {
Input,
Output,
};
class AttributeValidator : public AST::Visitor {
public:
AttributeValidator(ShaderModule&);
std::optional<FailedCheck> validate();
std::optional<FailedCheck> validateIO();
void visit(AST::Function&) override;
void visit(AST::Parameter&) override;
void visit(AST::Variable&) override;
void visit(AST::Structure&) override;
void visit(AST::StructureMember&) override;
void visit(AST::CompoundStatement&) override;
private:
bool parseBuiltin(AST::Function*, std::optional<Builtin>&, AST::Attribute&);
bool parseInterpolate(std::optional<AST::Interpolation>&, AST::Attribute&);
bool parseInvariant(bool&, AST::Attribute&);
bool parseLocation(AST::Function*, std::optional<unsigned>&, AST::Attribute&, const Type*);
void validateInterpolation(const SourceSpan&, const std::optional<AST::Interpolation>&, const std::optional<unsigned>&);
void validateInvariant(const SourceSpan&, const std::optional<Builtin>&, bool);
using Builtins = HashSet<Builtin, WTF::IntHash<Builtin>, WTF::StrongEnumHashTraits<Builtin>>;
using Locations = HashSet<uint64_t, DefaultHash<uint64_t>, WTF::UnsignedWithZeroKeyHashTraits<uint64_t>>;
void validateBuiltinIO(const SourceSpan&, const Type*, ShaderStage, Builtin, Direction, Builtins&);
void validateLocationIO(const SourceSpan&, const Type*, ShaderStage, unsigned, Locations&);
void validateStructIO(ShaderStage, const Types::Struct&, Direction, Builtins&, Locations&);
void validateAlignment(const SourceSpan&, AddressSpace, const Type*);
template<typename T>
void update(const SourceSpan&, std::optional<T>&, const T&);
void set(const SourceSpan&, bool&);
template<typename... Arguments>
void error(const SourceSpan&, Arguments&&...);
AST::Function* m_currentFunction { nullptr };
ShaderModule& m_shaderModule;
Vector<Error> m_errors;
bool m_hasSizeOrAlignmentAttributes { false };
};
AttributeValidator::AttributeValidator(ShaderModule& shaderModule)
: m_shaderModule(shaderModule)
{
}
std::optional<FailedCheck> AttributeValidator::validate()
{
AST::Visitor::visit(m_shaderModule);
if (m_errors.isEmpty())
return std::nullopt;
return FailedCheck { WTFMove(m_errors), { } };
}
void AttributeValidator::visit(AST::Function& function)
{
for (auto& attribute : function.attributes()) {
if (is<AST::MustUseAttribute>(attribute)) {
if (!function.maybeReturnType())
error(attribute.span(), "@must_use can only be applied to functions that return a value"_s);
set(attribute.span(), function.m_mustUse);
continue;
}
if (auto* stageAttribute = dynamicDowncast<AST::StageAttribute>(attribute)) {
update(attribute.span(), function.m_stage, stageAttribute->stage());
continue;
}
if (auto* workgroupSizeAttribute = dynamicDowncast<AST::WorkgroupSizeAttribute>(attribute)) {
auto& workgroupSize = workgroupSizeAttribute->workgroupSize();
const auto& check = [&](AST::Expression* dimension) {
if (!dimension)
return;
auto value = dimension->constantValue();
if (!value.has_value())
return;
if (value->integerValue() < 1)
error(dimension->span(), "@workgroup_size argument must be at least 1"_s);
};
check(workgroupSize.x);
check(workgroupSize.y);
check(workgroupSize.z);
update(attribute.span(), function.m_workgroupSize, workgroupSize);
continue;
}
error(attribute.span(), "invalid attribute for function declaration"_s);
}
if (function.workgroupSize().has_value() && (!function.stage().has_value() || *function.stage() != ShaderStage::Compute))
error(function.span(), "@workgroup_size must only be applied to compute shader entry point function"_s);
for (auto& attribute : function.returnAttributes()) {
if (parseBuiltin(&function, function.m_returnTypeBuiltin, attribute))
continue;
if (parseInterpolate(function.m_returnTypeInterpolation, attribute))
continue;
if (parseInvariant(function.m_returnTypeInvariant, attribute))
continue;
if (parseLocation(&function, function.m_returnTypeLocation, attribute, function.maybeReturnType()->inferredType()))
continue;
error(attribute.span(), "invalid attribute for function return type"_s);
}
if (function.maybeReturnType()) {
validateInterpolation(function.maybeReturnType()->span(), function.returnTypeInterpolation(), function.returnTypeLocation());
validateInvariant(function.maybeReturnType()->span(), function.returnTypeBuiltin(), function.returnTypeInvariant());
}
m_currentFunction = &function;
AST::Visitor::visit(function);
m_currentFunction = nullptr;
}
void AttributeValidator::visit(AST::Parameter& parameter)
{
for (auto& attribute : parameter.attributes()) {
if (parseBuiltin(m_currentFunction, parameter.m_builtin, attribute))
continue;
if (parseInterpolate(parameter.m_interpolation, attribute))
continue;
if (parseInvariant(parameter.m_invariant, attribute))
continue;
if (parseLocation(m_currentFunction, parameter.m_location, attribute, parameter.typeName().inferredType()))
continue;
error(attribute.span(), "invalid attribute for function parameter"_s);
}
validateInterpolation(parameter.span(), parameter.interpolation(), parameter.location());
validateInvariant(parameter.span(), parameter.builtin(), parameter.invariant());
AST::Visitor::visit(parameter);
}
void AttributeValidator::visit(AST::Variable& variable)
{
bool isResource = [&]() -> bool {
auto addressSpace = variable.addressSpace();
if (!addressSpace.has_value())
return false;
switch (*addressSpace) {
case AddressSpace::Handle:
case AddressSpace::Storage:
case AddressSpace::Uniform:
return true;
case AddressSpace::Function:
case AddressSpace::Private:
case AddressSpace::Workgroup:
return false;
}
}();
for (auto& attribute : variable.attributes()) {
if (auto* bindingAttribute = dynamicDowncast<AST::BindingAttribute>(attribute)) {
if (!isResource)
error(attribute.span(), "@binding attribute must only be applied to resource variables"_s);
// https://gpuweb.github.io/cts/standalone/?q=webgpu:shader,validation,parse,attribute:expressions:value=%22override%22;attribute=%22binding%22
auto& constantValue = bindingAttribute->binding().constantValue();
if (!constantValue) {
error(attribute.span(), "@binding attribute must only be applied to resource variables"_s);
continue;
}
auto bindingValue = constantValue->integerValue();
if (bindingValue < 0)
error(attribute.span(), "@binding value must be non-negative"_s);
else
update(attribute.span(), variable.m_binding, static_cast<unsigned>(bindingValue));
continue;
}
if (auto* groupAttribute = dynamicDowncast<AST::GroupAttribute>(attribute)) {
if (!isResource)
error(attribute.span(), "@group attribute must only be applied to resource variables"_s);
// https://gpuweb.github.io/cts/standalone/?q=webgpu:shader,validation,parse,attribute:expressions:value=%22override%22;attribute=%22binding%22
auto& constantValue = groupAttribute->group().constantValue();
if (!constantValue) {
error(attribute.span(), "@group attribute must only be applied to resource variables"_s);
continue;
}
auto groupValue = constantValue->integerValue();
if (groupValue < 0)
error(attribute.span(), "@group value must be non-negative"_s);
else
update(attribute.span(), variable.m_group, static_cast<unsigned>(groupValue));
continue;
}
if (auto* idAttribute = dynamicDowncast<AST::IdAttribute>(attribute)) {
auto& idExpression = idAttribute->value();
if (variable.flavor() != AST::VariableFlavor::Override)
error(attribute.span(), "@id attribute must only be applied to override variables"_s);
else
RELEASE_ASSERT(satisfies(variable.storeType(), Constraints::Scalar));
// https://gpuweb.github.io/cts/standalone/?q=webgpu:shader,validation,parse,attribute:expressions:value=%22override%22;attribute=%22binding%22
auto& constantValue = idExpression.constantValue();
RELEASE_ASSERT(constantValue);
auto idValue = constantValue->integerValue();
if (idValue < 0)
error(attribute.span(), "@id value must be non-negative"_s);
else if (idValue > std::numeric_limits<uint16_t>::max())
error(attribute.span(), "@id value must be between 0 and 65535"_s);
else {
auto uintIdValue = static_cast<unsigned>(idValue);
if (m_shaderModule.containsOverride(uintIdValue))
error(attribute.span(), "@id value must be unique"_s);
else {
update(attribute.span(), variable.m_id, uintIdValue);
m_shaderModule.addOverride(uintIdValue);
}
}
continue;
}
error(attribute.span(), "invalid attribute for variable declaration"_s);
}
if (isResource && (!variable.m_group || !variable.m_binding))
error(variable.span(), "resource variables require @group and @binding attributes"_s);
if (isResource && m_errors.isEmpty())
validateAlignment(variable.span(), *variable.addressSpace(), variable.storeType());
}
void AttributeValidator::validateAlignment(const SourceSpan& span, AddressSpace addressSpace, const Type* type)
{
const auto& requiredAlignment = [&](const Type* type) {
auto alignment = type->alignment();
if (addressSpace == AddressSpace::Uniform && (std::holds_alternative<Types::Array>(*type) || std::holds_alternative<Types::Struct>(*type)))
alignment = WTF::roundUpToMultipleOf(16, alignment);
return alignment;
};
if (auto* arrayType = std::get_if<Types::Array>(type)) {
if (arrayType->stride() % requiredAlignment(arrayType->element))
error(span, "array must have a stride multiple of "_s, String::number(requiredAlignment(arrayType->element)), " bytes, but has a stride of "_s, String::number(arrayType->stride()), " bytes"_s);
if (addressSpace == AddressSpace::Uniform && (arrayType->stride() % 16))
error(span, "arrays in the uniform address space must have a stride multiple of 16 bytes, but has a stride of "_s, String::number(arrayType->stride()), " bytes"_s);
validateAlignment(span, addressSpace, arrayType->element);
}
if (auto* structType = std::get_if<Types::Struct>(type)) {
auto& structure = structType->structure;
auto memberCount = structure.members().size();
for (unsigned i = 0; i < memberCount; ++i) {
auto& member = structure.members()[i];
auto* type = member.type().inferredType();
validateAlignment(member.span(), addressSpace, type);
if (member.offset() % requiredAlignment(type))
error(member.span(), "offset of struct member "_s, structure.name(), "::"_s, member.name(), " must be a multiple of "_s, String::number(requiredAlignment(type)), " bytes, but its offset is "_s, String::number(member.offset()), " bytes"_s);
if (addressSpace == AddressSpace::Uniform && std::holds_alternative<Types::Struct>(*type) && (i + 1) < memberCount) {
auto& nextMember = structure.members()[i + 1];
auto spaceBetweenMembers = nextMember.offset() - member.offset();
auto minimumNumberOfBytes = WTF::roundUpToMultipleOf(16, type->size());
if (spaceBetweenMembers < minimumNumberOfBytes)
error(member.span(), "uniform address space requires that the number of bytes between "_s, structure.name(), "::"_s, member.name(), " and "_s, structure.name(), "::"_s, nextMember.name(), " must be at least "_s, String::number(minimumNumberOfBytes), " bytes, but it is "_s, String::number(spaceBetweenMembers), " bytes"_s);
}
}
}
}
void AttributeValidator::visit(AST::Structure& structure)
{
AST::Visitor::visit(structure);
// Bail as we will stop the compilation after this pass, so the computed
// properties of the struct will never be read, and the size and alignment
// for the struct members might be invalid.
if (m_errors.size())
return;
structure.m_hasSizeOrAlignmentAttributes = std::exchange(m_hasSizeOrAlignmentAttributes, false);
CheckedUint32 previousSize = 0;
unsigned alignment = 0;
CheckedUint32 size = 0;
AST::StructureMember* previousMember = nullptr;
for (auto& member : structure.members()) {
auto* type = member.type().inferredType();
auto fieldAlignment = member.m_alignment;
if (!fieldAlignment) {
fieldAlignment = type->alignment();
member.m_alignment = fieldAlignment;
}
auto typeSize = type->size();
auto fieldSize = member.m_size;
if (!fieldSize) {
fieldSize = typeSize;
member.m_size = fieldSize;
}
unsigned currentSize = UNLIKELY(size.hasOverflowed()) ? std::numeric_limits<unsigned>::max() : size.value();
unsigned offset;
if (UNLIKELY(size.hasOverflowed()))
offset = currentSize;
else {
CheckedUint32 checkedOffset = WTF::roundUpToMultipleOf(*fieldAlignment, static_cast<uint64_t>(currentSize));
offset = UNLIKELY(checkedOffset.hasOverflowed()) ? std::numeric_limits<unsigned>::max() : checkedOffset.value();
}
member.m_offset = offset;
alignment = std::max(alignment, *fieldAlignment);
size = offset;
size += *fieldSize;
if (UNLIKELY(size.hasOverflowed()))
size = std::numeric_limits<unsigned>::max();
if (previousMember)
previousMember->m_padding = offset - previousSize;
previousMember = &member;
previousSize = offset;
previousSize += typeSize;
if (UNLIKELY(previousSize.hasOverflowed()))
previousSize = currentSize;
}
unsigned finalSize;
if (UNLIKELY(size.hasOverflowed()))
finalSize = std::numeric_limits<unsigned>::max();
else {
CheckedUint32 checkedFinalSize = WTF::roundUpToMultipleOf(alignment, static_cast<uint64_t>(size.value()));
finalSize = UNLIKELY(checkedFinalSize.hasOverflowed()) ? std::numeric_limits<unsigned>::max() : checkedFinalSize.value();
}
previousMember->m_padding = finalSize - previousSize;
structure.m_alignment = alignment;
structure.m_size = finalSize;
}
void AttributeValidator::visit(AST::StructureMember& member)
{
for (auto& attribute : member.attributes()) {
if (parseBuiltin(nullptr, member.m_builtin, attribute))
continue;
if (parseInterpolate(member.m_interpolation, attribute))
continue;
if (parseInvariant(member.m_invariant, attribute))
continue;
if (parseLocation(nullptr, member.m_location, attribute, member.type().inferredType()))
continue;
if (auto* sizeAttribute = dynamicDowncast<AST::SizeAttribute>(attribute)) {
m_hasSizeOrAlignmentAttributes = true;
if (!member.type().inferredType()->hasCreationFixedFootprint()) {
error(attribute.span(), "@size can only be applied to members that have a type with a size that is fully determined at shader creation time."_s);
continue;
}
// https://gpuweb.github.io/cts/standalone/?q=webgpu:shader,validation,parse,attribute:expressions:value=%22override%22;*
auto& constantValue = sizeAttribute->size().constantValue();
if (!constantValue) {
error(attribute.span(), "@size constant value is not found"_s);
continue;
}
auto sizeValue = constantValue->integerValue();
if (sizeValue < 0)
error(attribute.span(), "@size value must be non-negative"_s);
else if (m_errors.isEmpty() && sizeValue < member.type().inferredType()->size()) {
// We can't call Type::size() if we already have errors, as we might
// try to read the size of a struct, which we will not have computed
// if we already encountered errors
error(attribute.span(), "@size value must be at least the byte-size of the type of the member"_s);
}
update(attribute.span(), member.m_size, static_cast<unsigned>(sizeValue));
continue;
}
if (auto* alignAttribute = dynamicDowncast<AST::AlignAttribute>(attribute)) {
m_hasSizeOrAlignmentAttributes = true;
// https://gpuweb.github.io/cts/standalone/?q=webgpu:shader,validation,parse,attribute:expressions:value=%22override%22;attribute=%22align%22
auto constantValue = alignAttribute->alignment().constantValue();
if (!constantValue) {
error(attribute.span(), "@align constant value does not exist"_s);
continue;
}
auto alignmentValue = constantValue->integerValue();
auto isPowerOf2 = !(alignmentValue & (alignmentValue - 1));
if (alignmentValue < 1)
error(attribute.span(), "@align value must be positive"_s);
else if (!isPowerOf2)
error(attribute.span(), "@align value must be a power of two"_s);
if (UNLIKELY(!m_errors.isEmpty())) {
// It's not safe to access Type::alignment below if errors have
// already occurred
continue;
}
auto* type = member.type().inferredType();
if (type && (alignmentValue % type->alignment()))
error(attribute.span(), "@align attribute "_s, alignmentValue, " of struct member is not a multiple of the type's alignment "_s, type->alignment());
update<unsigned>(attribute.span(), member.m_alignment, alignmentValue);
continue;
}
error(attribute.span(), "invalid attribute for structure member"_s);
}
validateInterpolation(member.span(), member.interpolation(), member.location());
validateInvariant(member.span(), member.builtin(), member.invariant());
AST::Visitor::visit(member);
}
void AttributeValidator::visit(AST::CompoundStatement& statement)
{
for (auto& attribute : statement.attributes()) {
if (!is<AST::DiagnosticAttribute>(attribute))
error(attribute.span(), "invalid attribute for compound statement"_s);
}
AST::Visitor::visit(statement);
}
bool AttributeValidator::parseBuiltin(AST::Function* function, std::optional<Builtin>& builtin, AST::Attribute& attribute)
{
auto* builtinAttribute = dynamicDowncast<AST::BuiltinAttribute>(attribute);
if (!builtinAttribute)
return false;
if (function && !function->stage())
error(attribute.span(), "@builtin is not valid for non-entry point function types"_s);
update(attribute.span(), builtin, builtinAttribute->builtin());
return true;
}
bool AttributeValidator::parseInterpolate(std::optional<AST::Interpolation>& interpolation, AST::Attribute& attribute)
{
auto* interpolateAttribute = dynamicDowncast<AST::InterpolateAttribute>(attribute);
if (!interpolateAttribute)
return false;
update(attribute.span(), interpolation, interpolateAttribute->interpolation());
return true;
}
bool AttributeValidator::parseInvariant(bool& invariant, AST::Attribute& attribute)
{
if (!is<AST::InvariantAttribute>(attribute))
return false;
set(attribute.span(), invariant);
return true;
}
bool AttributeValidator::parseLocation(AST::Function* function, std::optional<unsigned>& location, AST::Attribute& attribute, const Type* declarationType)
{
auto* locationAttribute = dynamicDowncast<AST::LocationAttribute>(attribute);
if (!locationAttribute)
return false;
if (function && !function->stage())
error(attribute.span(), "@location is not valid for non-entry point function types"_s);
else if (function && *function->stage() == ShaderStage::Compute)
error(attribute.span(), "@location may not be used in the compute shader stage"_s);
bool isNumeric = satisfies(declarationType, Constraints::Number);
bool isNumericVector = false;
if (!isNumeric) {
if (auto* vectorType = std::get_if<Types::Vector>(declarationType))
isNumericVector = satisfies(vectorType->element, Constraints::Number);
}
if (!isNumeric && !isNumericVector)
error(attribute.span(), "@location must only be applied to declarations of numeric scalar or numeric vector type"_s);
auto& constantValue = locationAttribute->location().constantValue();
// https://gpuweb.github.io/cts/standalone/?q=webgpu:shader,validation,parse,attribute:expressions:value=%22override%22;*
if (!constantValue) {
error(attribute.span(), "@location constant value is missing"_s);
return false;
}
auto locationValue = constantValue->integerValue();
if (locationValue < 0)
error(attribute.span(), "@location value must be non-negative"_s);
else
update(attribute.span(), location, static_cast<unsigned>(locationValue));
return true;
}
void AttributeValidator::validateInterpolation(const SourceSpan& span, const std::optional<AST::Interpolation>& interpolation, const std::optional<unsigned>& location)
{
if (interpolation && !location)
error(span, "@interpolate is only allowed on declarations that have a @location attribute"_s);
}
void AttributeValidator::validateInvariant(const SourceSpan& span, const std::optional<Builtin>& builtin, bool invariant)
{
if (invariant && (!builtin || *builtin != Builtin::Position))
error(span, "@invariant is only allowed on declarations that have a @builtin(position) attribute"_s);
}
template<typename T>
void AttributeValidator::update(const SourceSpan& span, std::optional<T>& destination, const T& source)
{
if (destination.has_value())
error(span, "duplicate attribute"_s);
else
destination = source;
}
void AttributeValidator::set(const SourceSpan& span, bool& destination)
{
if (destination)
error(span, "duplicate attribute"_s);
else
destination = true;
}
template<typename... Arguments>
void AttributeValidator::error(const SourceSpan& span, Arguments&&... arguments)
{
m_errors.append({ makeString(std::forward<Arguments>(arguments)...), span });
}
std::optional<FailedCheck> AttributeValidator::validateIO()
{
for (auto& entryPoint : m_shaderModule.callGraph().entrypoints()) {
auto& function = entryPoint.function;
Builtins builtins;
Locations locations;
for (auto& parameter : function.parameters()) {
const auto& span = parameter.span();
const auto* type = parameter.typeName().inferredType();
if (auto builtin = parameter.builtin()) {
validateBuiltinIO(span, type, entryPoint.stage, *builtin, Direction::Input, builtins);
continue;
}
if (auto location = parameter.location()) {
validateLocationIO(span, type, entryPoint.stage, *location, locations);
continue;
}
if (auto* structType = std::get_if<Types::Struct>(type)) {
validateStructIO(entryPoint.stage, *structType, Direction::Input, builtins, locations);
continue;
}
error(span, "missing entry point IO attribute on parameter"_s);
}
if (!function.maybeReturnType()) {
if (entryPoint.stage == ShaderStage::Vertex)
error(function.span(), "a vertex shader must include the 'position' builtin in its return type"_s);
continue;
}
builtins.clear();
locations.clear();
const auto& span = function.maybeReturnType()->span();
const auto* type = function.maybeReturnType()->inferredType();
if (auto builtin = function.returnTypeBuiltin())
validateBuiltinIO(span, type, entryPoint.stage, *builtin, Direction::Output, builtins);
else if (auto location = function.returnTypeLocation())
validateLocationIO(span, type, entryPoint.stage, *location, locations);
else if (auto* structType = std::get_if<Types::Struct>(type))
validateStructIO(entryPoint.stage, *structType, Direction::Output, builtins, locations);
else {
error(span, "missing entry point IO attribute on return type"_s);
continue;
}
if (entryPoint.stage == ShaderStage::Vertex && !builtins.contains(Builtin::Position))
error(span, "a vertex shader must include the 'position' builtin in its return type"_s);
}
if (m_errors.isEmpty())
return std::nullopt;
return FailedCheck { WTFMove(m_errors), { } };
}
void AttributeValidator::validateBuiltinIO(const SourceSpan& span, const Type* type, ShaderStage stage, Builtin builtin, Direction direction, Builtins& builtins)
{
#define TYPE_CHECK(__type) \
type != m_shaderModule.types().__type##Type(), *m_shaderModule.types().__type##Type()
#define VEC_CHECK(__count, __elementType) \
auto* vector = std::get_if<Types::Vector>(type); !vector || vector->size != __count || vector->element != m_shaderModule.types().__elementType##Type(), "vec" #__count "<" #__elementType ">"_s
#define CASE_(__case, __typeCheck, __type) \
case Builtin::__case: \
if (__typeCheck) { \
error(span, "store type of @builtin("_s, toString(Builtin::__case), ") must be '"_s, __type, '\''); \
return; \
} \
#define CASE(__case, __typeCheck, __stage, __direction) \
CASE_(__case, __typeCheck); \
if (stage != ShaderStage::__stage || direction != Direction::__direction) { \
error(span, "@builtin("_s, toString(Builtin::__case), ") cannot be used for "_s, toString(stage), " shader "_s, direction == Direction::Input ? "input"_s : "output"_s); \
return; \
} \
break;
#define CASE2(__case, __typeCheck, __stage1, __direction1, __stage2, __direction2) \
CASE_(__case, __typeCheck); \
if ((stage != ShaderStage::__stage1 || direction != Direction::__direction1) && (stage != ShaderStage::__stage2 || direction != Direction::__direction2)) { \
error(span, "@builtin("_s, toString(Builtin::__case), ") cannot be used for "_s, toString(stage), " shader "_s, direction == Direction::Input ? "input"_s : "output"_s); \
return; \
} \
break;
switch (builtin) {
CASE(FragDepth, TYPE_CHECK(f32), Fragment, Output)
CASE(FrontFacing, TYPE_CHECK(bool), Fragment, Input)
CASE(GlobalInvocationId, VEC_CHECK(3, u32), Compute, Input)
CASE(InstanceIndex, TYPE_CHECK(u32), Vertex, Input)
CASE(LocalInvocationId, VEC_CHECK(3, u32), Compute, Input)
CASE(LocalInvocationIndex, TYPE_CHECK(u32), Compute, Input)
CASE(NumWorkgroups, VEC_CHECK(3, u32), Compute, Input)
CASE(SampleIndex, TYPE_CHECK(u32), Fragment, Input)
CASE(VertexIndex, TYPE_CHECK(u32), Vertex, Input)
CASE(WorkgroupId, VEC_CHECK(3, u32), Compute, Input)
CASE2(SampleMask, TYPE_CHECK(u32), Fragment, Input, Fragment, Output)
CASE2(Position, VEC_CHECK(4, f32), Vertex, Output, Fragment, Input)
}
auto result = builtins.add(builtin);
if (!result.isNewEntry)
error(span, "@builtin("_s, toString(builtin), ") appears multiple times as pipeline input"_s);
}
void AttributeValidator::validateLocationIO(const SourceSpan& span, const Type* type, ShaderStage stage, unsigned location, Locations& locations)
{
if (stage == ShaderStage::Compute) {
error(span, "@location cannot be used by compute shaders"_s);
return;
}
if (!satisfies(type, Constraints::Number)) {
auto* vector = std::get_if<Types::Vector>(type);
if (!vector || !satisfies(vector->element, Constraints::Number)) {
error(span, "cannot apply @location to declaration of type '"_s, *type, '\'');
return;
}
}
auto result = locations.add(location);
if (!result.isNewEntry)
error(span, "@location("_s, location, ") appears multiple times"_s);
}
void AttributeValidator::validateStructIO(ShaderStage stage, const Types::Struct& structType, Direction direction, Builtins& builtins, Locations& locations)
{
for (auto& member : structType.structure.members()) {
const auto& span = member.span();
const auto* type = member.type().inferredType();
if (auto builtin = member.builtin()) {
validateBuiltinIO(span, type, stage, *builtin, direction, builtins);
continue;
}
if (auto location = member.location()) {
validateLocationIO(span, type, stage, *location, locations);
continue;
}
if (auto inferredType = member.type().inferredType(); inferredType && std::holds_alternative<Types::Struct>(*inferredType)) {
error(span, "nested structures cannot be used for entry point IO"_s);
continue;
}
error(span, "missing entry point IO attribute"_s);
}
}
std::optional<FailedCheck> validateAttributes(ShaderModule& shaderModule)
{
return AttributeValidator(shaderModule).validate();
}
std::optional<FailedCheck> validateIO(ShaderModule& shaderModule)
{
return AttributeValidator(shaderModule).validateIO();
}
} // namespace WGSL
|