1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112 6113 6114 6115 6116 6117 6118 6119 6120 6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152 6153 6154 6155 6156 6157 6158 6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179 6180 6181 6182 6183 6184 6185 6186 6187 6188 6189 6190 6191 6192 6193 6194 6195 6196 6197 6198 6199 6200 6201 6202 6203 6204 6205 6206 6207 6208 6209 6210 6211 6212 6213 6214 6215 6216 6217 6218 6219 6220 6221 6222 6223 6224 6225 6226 6227 6228 6229 6230 6231 6232 6233 6234 6235 6236 6237 6238 6239 6240 6241 6242 6243 6244 6245 6246 6247 6248 6249 6250 6251 6252 6253 6254 6255 6256 6257 6258 6259 6260 6261 6262 6263 6264 6265 6266 6267 6268 6269 6270 6271 6272 6273 6274 6275 6276 6277 6278 6279 6280 6281 6282 6283 6284 6285 6286 6287 6288 6289 6290 6291 6292 6293 6294 6295 6296 6297 6298 6299 6300 6301 6302 6303 6304 6305 6306 6307 6308 6309 6310 6311 6312 6313 6314 6315 6316 6317 6318 6319 6320 6321 6322 6323 6324 6325 6326 6327 6328 6329 6330 6331 6332 6333 6334 6335 6336 6337 6338 6339 6340 6341 6342 6343 6344 6345 6346 6347 6348 6349 6350 6351 6352 6353 6354 6355 6356 6357 6358 6359 6360 6361 6362 6363 6364 6365 6366 6367 6368 6369 6370 6371 6372 6373 6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441 6442 6443 6444 6445 6446 6447 6448 6449 6450 6451 6452 6453 6454 6455 6456 6457 6458 6459 6460 6461 6462 6463 6464 6465 6466 6467 6468 6469 6470 6471 6472 6473 6474 6475 6476 6477 6478 6479 6480 6481 6482 6483 6484 6485 6486 6487 6488 6489 6490 6491 6492 6493 6494 6495 6496 6497 6498 6499 6500 6501 6502 6503 6504 6505 6506 6507 6508 6509 6510 6511 6512 6513 6514 6515 6516 6517 6518 6519 6520 6521 6522 6523 6524 6525 6526 6527 6528 6529 6530 6531 6532 6533 6534 6535 6536 6537 6538 6539 6540 6541 6542 6543 6544 6545 6546 6547 6548 6549 6550 6551 6552 6553 6554 6555 6556 6557 6558 6559 6560 6561 6562 6563 6564 6565 6566 6567 6568 6569 6570 6571 6572 6573 6574 6575 6576 6577 6578 6579 6580 6581 6582 6583 6584 6585 6586 6587 6588 6589 6590 6591 6592 6593 6594 6595 6596 6597 6598 6599 6600 6601 6602 6603 6604 6605 6606 6607 6608 6609 6610 6611 6612 6613 6614 6615 6616 6617 6618 6619 6620 6621 6622 6623 6624 6625 6626 6627 6628 6629 6630 6631 6632 6633 6634 6635 6636 6637 6638 6639 6640 6641 6642 6643 6644 6645 6646 6647 6648 6649 6650 6651 6652 6653 6654 6655 6656 6657 6658 6659 6660 6661 6662 6663 6664 6665 6666 6667 6668 6669 6670 6671 6672 6673 6674 6675 6676 6677 6678 6679 6680 6681 6682 6683 6684 6685 6686 6687 6688 6689 6690 6691 6692 6693 6694 6695 6696 6697 6698 6699 6700 6701 6702 6703 6704 6705 6706 6707 6708 6709 6710 6711 6712 6713 6714 6715 6716 6717 6718 6719 6720 6721 6722 6723 6724 6725 6726 6727 6728 6729 6730 6731 6732 6733 6734 6735 6736 6737 6738 6739 6740 6741 6742 6743 6744 6745 6746 6747 6748 6749 6750 6751 6752 6753 6754 6755 6756 6757 6758 6759 6760 6761 6762 6763 6764 6765 6766 6767 6768 6769 6770 6771 6772 6773 6774 6775 6776 6777 6778 6779 6780 6781 6782 6783 6784 6785 6786 6787 6788 6789 6790 6791 6792 6793 6794 6795 6796 6797 6798 6799 6800 6801 6802 6803 6804 6805 6806 6807 6808 6809 6810 6811 6812 6813 6814 6815 6816 6817 6818 6819 6820 6821 6822 6823 6824 6825 6826 6827 6828 6829 6830 6831 6832 6833 6834 6835 6836 6837 6838 6839 6840 6841 6842 6843 6844 6845 6846 6847 6848 6849 6850 6851 6852 6853 6854 6855 6856 6857 6858 6859 6860 6861 6862 6863 6864 6865 6866 6867 6868 6869 6870 6871 6872 6873 6874 6875 6876 6877 6878 6879 6880 6881 6882 6883 6884 6885 6886 6887 6888 6889 6890 6891 6892 6893 6894 6895 6896 6897 6898 6899 6900 6901 6902 6903 6904 6905 6906 6907 6908 6909 6910 6911 6912 6913 6914 6915 6916 6917 6918 6919 6920 6921 6922 6923 6924 6925 6926 6927 6928 6929 6930 6931 6932 6933 6934 6935 6936 6937 6938 6939 6940 6941 6942 6943 6944 6945 6946 6947 6948 6949 6950 6951 6952 6953 6954 6955 6956 6957 6958 6959 6960 6961 6962 6963 6964 6965 6966 6967 6968 6969 6970 6971 6972 6973 6974 6975 6976 6977 6978 6979 6980 6981 6982 6983 6984 6985 6986 6987 6988 6989 6990 6991 6992 6993 6994 6995 6996 6997 6998 6999 7000 7001 7002 7003 7004 7005 7006 7007 7008 7009 7010 7011 7012 7013 7014 7015 7016 7017 7018 7019 7020 7021 7022 7023 7024 7025 7026 7027 7028 7029 7030 7031 7032 7033 7034 7035 7036 7037 7038 7039 7040 7041 7042 7043 7044 7045 7046 7047 7048 7049 7050 7051 7052 7053 7054 7055 7056 7057 7058 7059 7060 7061 7062 7063 7064 7065 7066 7067 7068 7069 7070 7071 7072 7073 7074 7075 7076 7077 7078 7079 7080 7081 7082 7083 7084 7085 7086 7087 7088 7089 7090 7091 7092 7093 7094 7095 7096 7097 7098 7099 7100 7101 7102 7103 7104 7105 7106 7107 7108 7109 7110 7111 7112 7113 7114 7115 7116 7117 7118 7119 7120 7121 7122 7123 7124 7125 7126 7127 7128 7129 7130 7131 7132 7133 7134 7135 7136 7137 7138 7139 7140 7141 7142 7143 7144 7145 7146 7147 7148 7149 7150 7151 7152 7153 7154 7155 7156 7157 7158 7159 7160 7161 7162 7163 7164 7165 7166 7167 7168 7169 7170 7171 7172 7173 7174 7175 7176 7177 7178 7179 7180 7181 7182 7183 7184 7185 7186 7187 7188 7189 7190 7191 7192 7193 7194 7195 7196 7197 7198 7199 7200 7201 7202 7203 7204 7205 7206 7207 7208 7209 7210 7211 7212 7213 7214 7215 7216 7217 7218 7219 7220 7221 7222 7223 7224 7225 7226 7227 7228 7229 7230 7231 7232 7233 7234 7235 7236 7237 7238 7239 7240 7241 7242 7243 7244 7245 7246 7247 7248 7249 7250 7251 7252 7253 7254 7255 7256 7257 7258 7259 7260 7261 7262 7263 7264 7265 7266 7267 7268 7269 7270 7271 7272 7273 7274 7275 7276 7277 7278 7279 7280 7281 7282 7283 7284 7285 7286 7287 7288 7289 7290 7291 7292 7293 7294 7295 7296 7297 7298 7299 7300 7301 7302 7303 7304 7305 7306 7307 7308 7309 7310 7311 7312 7313 7314 7315 7316 7317 7318 7319 7320 7321 7322 7323 7324 7325 7326 7327 7328 7329 7330 7331 7332 7333 7334 7335 7336 7337 7338 7339 7340 7341 7342 7343 7344 7345 7346 7347 7348 7349 7350 7351 7352 7353 7354 7355 7356 7357 7358 7359 7360 7361 7362 7363 7364 7365 7366 7367 7368 7369 7370 7371 7372 7373 7374 7375 7376 7377 7378 7379 7380 7381 7382 7383 7384 7385 7386 7387 7388 7389 7390 7391 7392 7393 7394 7395 7396 7397 7398 7399 7400 7401 7402 7403 7404 7405 7406 7407 7408 7409 7410 7411 7412 7413 7414 7415 7416 7417 7418 7419 7420 7421 7422 7423 7424 7425 7426 7427 7428 7429 7430 7431 7432 7433 7434 7435 7436 7437 7438 7439 7440 7441 7442 7443 7444 7445 7446 7447 7448 7449 7450 7451 7452 7453 7454 7455 7456 7457 7458 7459 7460 7461 7462 7463 7464 7465 7466 7467 7468 7469 7470 7471 7472 7473 7474 7475 7476 7477 7478 7479 7480 7481 7482 7483 7484 7485 7486 7487 7488 7489 7490 7491 7492 7493 7494 7495 7496 7497 7498 7499 7500 7501 7502 7503 7504 7505 7506 7507 7508 7509 7510 7511 7512 7513 7514 7515 7516 7517 7518 7519 7520 7521 7522 7523 7524 7525 7526 7527 7528 7529 7530 7531 7532 7533 7534 7535 7536 7537 7538 7539 7540 7541 7542 7543 7544 7545 7546 7547 7548 7549 7550 7551 7552 7553 7554 7555 7556 7557 7558 7559 7560 7561 7562 7563 7564 7565 7566 7567 7568 7569 7570 7571 7572 7573 7574 7575 7576 7577 7578 7579 7580 7581 7582 7583 7584 7585 7586 7587 7588 7589 7590 7591 7592 7593 7594 7595 7596 7597 7598 7599 7600 7601 7602 7603 7604 7605 7606 7607 7608 7609 7610 7611 7612 7613 7614 7615 7616 7617 7618 7619 7620 7621 7622 7623 7624 7625 7626 7627 7628 7629 7630 7631 7632 7633 7634 7635 7636 7637 7638 7639 7640 7641 7642 7643 7644 7645 7646 7647 7648 7649 7650 7651 7652 7653 7654 7655 7656 7657 7658 7659 7660 7661 7662 7663 7664 7665 7666 7667 7668 7669 7670 7671 7672 7673 7674 7675 7676 7677 7678 7679 7680 7681 7682 7683 7684 7685 7686 7687 7688 7689 7690 7691 7692 7693 7694 7695 7696 7697 7698 7699 7700 7701 7702 7703 7704 7705 7706 7707 7708 7709 7710 7711 7712 7713 7714 7715 7716 7717 7718 7719 7720 7721 7722 7723 7724 7725 7726 7727 7728 7729 7730 7731 7732 7733 7734 7735 7736 7737 7738 7739 7740 7741 7742 7743 7744 7745 7746 7747 7748 7749 7750 7751 7752 7753 7754 7755 7756 7757 7758 7759 7760 7761 7762 7763 7764 7765 7766 7767 7768 7769 7770 7771 7772 7773 7774 7775 7776 7777 7778 7779 7780 7781 7782 7783 7784 7785 7786 7787 7788 7789 7790 7791 7792 7793 7794 7795 7796 7797 7798 7799 7800 7801 7802 7803 7804 7805 7806 7807 7808 7809 7810 7811 7812 7813 7814 7815 7816 7817 7818 7819 7820 7821 7822 7823 7824 7825 7826 7827 7828 7829 7830 7831 7832 7833 7834 7835 7836 7837 7838 7839 7840 7841 7842 7843 7844 7845 7846 7847 7848 7849 7850 7851 7852 7853 7854 7855 7856 7857 7858 7859 7860 7861 7862 7863 7864 7865 7866 7867 7868 7869 7870 7871 7872 7873 7874 7875 7876 7877 7878 7879 7880 7881 7882 7883 7884 7885 7886 7887 7888 7889 7890 7891 7892 7893 7894 7895 7896 7897 7898 7899 7900 7901 7902 7903 7904 7905 7906 7907 7908 7909 7910 7911 7912 7913 7914 7915 7916 7917 7918 7919 7920 7921 7922 7923 7924 7925 7926 7927 7928 7929 7930 7931 7932 7933 7934 7935 7936 7937 7938 7939 7940 7941 7942 7943 7944 7945 7946 7947 7948 7949 7950 7951 7952 7953 7954 7955 7956 7957 7958 7959 7960 7961 7962 7963 7964 7965 7966 7967 7968 7969 7970 7971 7972 7973 7974 7975 7976 7977 7978 7979 7980 7981 7982 7983 7984 7985 7986 7987 7988 7989 7990 7991 7992 7993 7994 7995 7996 7997 7998 7999 8000 8001 8002 8003 8004 8005 8006 8007 8008 8009 8010 8011 8012 8013 8014 8015 8016 8017 8018 8019 8020 8021 8022 8023 8024 8025 8026 8027 8028 8029 8030 8031 8032 8033 8034 8035 8036 8037 8038 8039 8040 8041 8042 8043 8044 8045 8046 8047 8048 8049 8050 8051 8052 8053 8054 8055 8056 8057 8058 8059 8060 8061 8062 8063 8064 8065 8066 8067 8068 8069 8070 8071 8072 8073 8074 8075 8076 8077 8078 8079 8080 8081 8082 8083 8084 8085 8086 8087 8088 8089 8090 8091 8092 8093 8094 8095 8096 8097 8098 8099 8100 8101 8102 8103 8104 8105 8106 8107 8108 8109 8110 8111 8112 8113 8114 8115 8116 8117 8118 8119 8120 8121 8122 8123 8124 8125 8126 8127 8128 8129 8130 8131 8132 8133 8134 8135 8136 8137 8138 8139 8140 8141 8142 8143 8144 8145 8146 8147 8148 8149 8150 8151 8152 8153 8154 8155 8156 8157 8158 8159 8160 8161 8162 8163 8164 8165 8166 8167 8168 8169 8170 8171 8172 8173 8174 8175 8176 8177 8178 8179 8180 8181 8182 8183 8184 8185 8186 8187 8188 8189 8190 8191 8192 8193 8194 8195 8196 8197 8198 8199 8200 8201 8202 8203 8204 8205 8206 8207 8208 8209 8210 8211 8212 8213 8214 8215 8216 8217 8218 8219 8220 8221 8222 8223 8224 8225 8226 8227 8228 8229 8230 8231 8232 8233 8234 8235 8236 8237 8238 8239 8240 8241 8242 8243 8244 8245 8246 8247 8248 8249 8250 8251 8252 8253 8254 8255 8256 8257 8258 8259 8260 8261 8262 8263 8264 8265 8266 8267 8268 8269 8270 8271 8272 8273 8274 8275 8276 8277 8278 8279 8280 8281 8282 8283 8284 8285 8286 8287 8288 8289 8290 8291 8292 8293 8294 8295 8296 8297 8298 8299 8300 8301 8302 8303 8304 8305 8306 8307 8308 8309 8310 8311
|
diff --git a/doc/ExtensionSupport.md b/doc/ExtensionSupport.md
index 128feb6dc8e8f54700c347773a7482b8b857495c..0e7c26b19dca917879380ca46337f6f5b67a1191 100644
--- a/doc/ExtensionSupport.md
+++ b/doc/ExtensionSupport.md
@@ -235,6 +235,7 @@ using data from registry_xml.py and gl.xml.
| [GL_CHROMIUM_copy_compressed_texture](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/CHROMIUM_copy_compressed_texture.txt) | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ |
| [GL_CHROMIUM_copy_texture](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/CHROMIUM_copy_texture.txt) | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ |
| [GL_ANGLE_copy_texture_3d](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_copy_texture_3d.txt) | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ |
+| [GL_WEBKIT_explicit_resolve_target](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/WEBKIT_explicit_resolve_target.txt) | | | | | | | |
| [GL_CHROMIUM_framebuffer_mixed_samples](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/CHROMIUM_framebuffer_mixed_samples.txt) | | | | | | | |
| [GL_ANGLE_framebuffer_multisample](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_framebuffer_multisample.txt) | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ |
| [GL_ANGLE_get_image](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_get_image.txt) | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ |
@@ -271,6 +272,7 @@ using data from registry_xml.py and gl.xml.
| [GL_ANGLE_texture_external_update](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_texture_external_update.txt) | | | | | | | |
| [GL_ANGLE_texture_multisample](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_texture_multisample.txt) | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ |
| [GL_ANGLE_texture_rectangle](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_texture_rectangle.txt) | | | | | | | |
+| [GL_ANGLE_variable_rasterization_rate_metal](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_variable_rasterization_rate_metal.txt) | | | | | | | |
| [GL_ANGLE_vulkan_image](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_vulkan_image.txt) | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ | ✔ |
| [GL_ANGLE_webgl_compatibility](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_webgl_compatibility.txt) | | | | | | | |
| [GL_ANGLE_yuv_internal_format](https://chromium.googlesource.com/angle/angle/+/refs/heads/main/extensions/ANGLE_yuv_internal_format.txt) | ✔ | | ✔ | ✔ | ✔ | ✔ | ✔ |
diff --git a/include/GLES2/gl2ext_angle.h b/include/GLES2/gl2ext_angle.h
index 46b52b05a9f490f1ea686d1915aef7508878d77a..7ac187ffe7048404f7f3fd16bb93cfe74f4b3eed 100644
--- a/include/GLES2/gl2ext_angle.h
+++ b/include/GLES2/gl2ext_angle.h
@@ -743,5 +743,23 @@ GL_APICALL void GL_APIENTRY glGetPointervANGLE (GLenum pname, void **params);
#endif
#endif /* GL_ANGLE_blob_cache */
+#ifndef GL_WEBKIT_explicit_resolve_target
+typedef void (GL_APIENTRYP PFNGLFRAMEBUFFERRESOLVERENDERBUFFERWEBKITPROC) (GLenum, GLenum, GLenum, GLuint);
+#ifdef GL_GLEXT_PROTOTYPES
+GL_APICALL void GL_APIENTRY glFramebufferResolveRenderbufferWEBKIT(GLenum target, GLenum attachment, GLenum renderbuffertarget, GLuint renderbuffer);
+#endif
+#endif /* GL_WEBKIT_explicit_resolve_target */
+
+#ifndef GL_ANGLE_variable_rasterization_rate_metal
+#define GL_ANGLE_variable_rasterization_rate_metal 1
+
+#define GL_VARIABLE_RASTERIZATION_RATE_ANGLE 0x96BC
+#define GL_METAL_RASTERIZATION_RATE_MAP_BINDING_ANGLE 0x96BD
+typedef void *GLMTLRasterizationRateMapANGLE;
+typedef void (GL_APIENTRYP PFNGLBINDMETALRASTERIZATIONRATEMAPANGLEPROC) (GLuint, GLMTLRasterizationRateMapANGLE);
+#ifdef GL_GLEXT_PROTOTYPES
+GL_APICALL void GL_APIENTRY glBindMetalRasterizationRateMapANGLE(GLuint framebuffer, GLMTLRasterizationRateMapANGLE map);
+#endif
+#endif /* GL_ANGLE_variable_rasterization_rate_metal */
#endif // INCLUDE_GLES2_GL2EXT_ANGLE_H_
diff --git a/include/platform/autogen/FeaturesMtl_autogen.h b/include/platform/autogen/FeaturesMtl_autogen.h
index 3efcc4506a4b77ca33015eabf90434970dfa5c79..0131400374a4393cb055900e57bae4411b3478e2 100644
--- a/include/platform/autogen/FeaturesMtl_autogen.h
+++ b/include/platform/autogen/FeaturesMtl_autogen.h
@@ -74,6 +74,12 @@ struct FeaturesMtl : FeatureSetBase
&members,
};
+ FeatureInfo hasVariableRasterizationRate = {
+ "hasVariableRasterizationRate",
+ FeatureCategory::MetalFeatures,
+ &members,
+ };
+
FeatureInfo allowInlineConstVertexData = {
"allowInlineConstVertexData",
FeatureCategory::MetalFeatures,
diff --git a/include/platform/mtl_features.json b/include/platform/mtl_features.json
index 386e3a83132a2e7f2a5e7e9df5f51e51fe10b614..d4f403aa893f883b5c4adc7f041103cc2491443b 100644
--- a/include/platform/mtl_features.json
+++ b/include/platform/mtl_features.json
@@ -70,6 +70,13 @@
"The renderer supports MTL(Shared)Event"
]
},
+ {
+ "name": "has_variable_rasterization_rate",
+ "category": "Features",
+ "description": [
+ "The renderer supports variable rasterization rate"
+ ]
+ },
{
"name": "allow_inline_const_vertex_data",
"category": "Features",
diff --git a/scripts/code_generation_hashes/ANGLE_shader_preprocessor.json b/scripts/code_generation_hashes/ANGLE_shader_preprocessor.json
index de0ca8f77984dacc4db9aa7b3600ab517648a70f..08f8365da45eba2fd96a637ba818ae640222e422 100644
--- a/scripts/code_generation_hashes/ANGLE_shader_preprocessor.json
+++ b/scripts/code_generation_hashes/ANGLE_shader_preprocessor.json
@@ -1,6 +1,6 @@
{
"src/compiler/generate_parser_tools.py":
- "bb5b9d7e3b890ad55fe9dba470cd86fe",
+ "b2d9f7155fabd2391545e23d96b8094f",
"src/compiler/preprocessor/generate_parser.py":
"9a4588fdf009298fe49c52b9252789c7",
"src/compiler/preprocessor/preprocessor.l":
@@ -10,7 +10,7 @@
"src/compiler/preprocessor/preprocessor_lex_autogen.cpp":
"c58edcc71ed87ab9613539a3acd5e194",
"src/compiler/preprocessor/preprocessor_tab_autogen.cpp":
- "000f93c6b244dcae862efa319a737a7f",
+ "ff3120300799cd96965e4c424b2d2ffb",
"tools/flex-bison/linux/bison.sha1":
"dfc9209e0c76eddd9bed0601c6c189e5",
"tools/flex-bison/linux/flex.sha1":
diff --git a/scripts/code_generation_hashes/ANGLE_shader_translator.json b/scripts/code_generation_hashes/ANGLE_shader_translator.json
index bd722e0a9f9a24072e292d1f31cc8aa1190c35f0..25a972ec41f7443c497904038bc6410c31cb77f6 100644
--- a/scripts/code_generation_hashes/ANGLE_shader_translator.json
+++ b/scripts/code_generation_hashes/ANGLE_shader_translator.json
@@ -1,6 +1,6 @@
{
"src/compiler/generate_parser_tools.py":
- "bb5b9d7e3b890ad55fe9dba470cd86fe",
+ "b2d9f7155fabd2391545e23d96b8094f",
"src/compiler/translator/generate_parser.py":
"ad919972a040d9b3b4aa5dc547fadc75",
"src/compiler/translator/glslang.l":
@@ -10,9 +10,9 @@
"src/compiler/translator/glslang_lex_autogen.cpp":
"14c0f0593c173936c5be7f87a05a20b9",
"src/compiler/translator/glslang_tab_autogen.cpp":
- "b3a90dde9dea633233d929586571a487",
+ "217d186699b4fdd8a688137526c84322",
"src/compiler/translator/glslang_tab_autogen.h":
- "028bdaebf359aefbcdaafae466993ebe",
+ "11aef96205adbc2809c6652e099ccaa7",
"tools/flex-bison/linux/bison.sha1":
"dfc9209e0c76eddd9bed0601c6c189e5",
"tools/flex-bison/linux/flex.sha1":
diff --git a/scripts/code_generation_hashes/Extension_files.json b/scripts/code_generation_hashes/Extension_files.json
index b745ed3e6af1eaa9104284e11b70587737b70b69..6c1a743f4cd137c4c547acda47937f2d000d9b19 100644
--- a/scripts/code_generation_hashes/Extension_files.json
+++ b/scripts/code_generation_hashes/Extension_files.json
@@ -1,6 +1,6 @@
{
"doc/ExtensionSupport.md":
- "6a19f6bfb8a9b60fda0811822cc68982",
+ "4d970d444b6f5b531a383aefb5348db1",
"scripts/egl_angle_ext.xml":
"8389749098fae1d5c832a06b5be51dc1",
"scripts/extension_data/intel_630_linux.json":
@@ -20,15 +20,15 @@
"scripts/extension_data/swiftshader_win10_gles1.json":
"bea8e2106d62e1ea0e8938f150865a37",
"scripts/gl_angle_ext.xml":
- "da4ecccdd77635f1b0e9d4664f856706",
+ "2cba159af592da788a15449eae941cb4",
"scripts/registry_xml.py":
- "4824b51dafdbdbf6eb109a4d0c5b86b8",
+ "cf2238984047673faa30d75bdfc3f6e7",
"src/libANGLE/gen_extensions.py":
"dc4727460d1ece9f98a2ae47bf15ddb3",
"src/libANGLE/gles_extensions_autogen.cpp":
- "1fc44732ce9af3e33ebbf508748494c8",
+ "44adef75b9f3d699727fa1a589b3aa4c",
"src/libANGLE/gles_extensions_autogen.h":
- "256c663cc00d5ef2ad89536f263ef6ab",
+ "2178701d90b5cc3a37d7095b14697925",
"third_party/EGL-Registry/src/api/egl.xml":
"2056d54ea07156f1988ca1366bdee21a",
"third_party/OpenCL-Docs/src/xml/cl.xml":
diff --git a/scripts/code_generation_hashes/GL_EGL_WGL_loader.json b/scripts/code_generation_hashes/GL_EGL_WGL_loader.json
index e5e57532446fadaca63ead55d6cde7cc14b3e3d0..9ce61b4755792eb355f7d0176ff911caa182fdb1 100644
--- a/scripts/code_generation_hashes/GL_EGL_WGL_loader.json
+++ b/scripts/code_generation_hashes/GL_EGL_WGL_loader.json
@@ -4,9 +4,9 @@
"scripts/generate_loader.py":
"93c78a8d11323fa311fed5118fbcf083",
"scripts/gl_angle_ext.xml":
- "da4ecccdd77635f1b0e9d4664f856706",
+ "2cba159af592da788a15449eae941cb4",
"scripts/registry_xml.py":
- "4824b51dafdbdbf6eb109a4d0c5b86b8",
+ "cf2238984047673faa30d75bdfc3f6e7",
"src/libEGL/egl_loader_autogen.cpp":
"2aca2a57c51fc2b1c7e1da0a7ccf6107",
"src/libEGL/egl_loader_autogen.h":
@@ -26,17 +26,17 @@
"util/capture/trace_egl_loader_autogen.h":
"9adc81af729078b16b36647f02401342",
"util/capture/trace_gles_loader_autogen.cpp":
- "16cb9f0cdf7ee7dbf4d12085f4a2ae1e",
+ "7dbfa63a3fa955eabc4fcbb25b7f10f2",
"util/capture/trace_gles_loader_autogen.h":
- "1a94e35a444206870daafa18412debe3",
+ "757429264980274769e2247af262df9a",
"util/egl_loader_autogen.cpp":
"ae6abfc6c2c0a997ad59258dfc0339ce",
"util/egl_loader_autogen.h":
"ea5f73048616a6fc80eaa7e93ef5f0ce",
"util/gles_loader_autogen.cpp":
- "adef140eeb58bc8d6bde25700d3c23ca",
+ "ea86a10d2d24087237bb848d190a925d",
"util/gles_loader_autogen.h":
- "29cd08fade2c117cd6bfb31036054e71",
+ "3d694e6a0b96deffd537065f2590b17b",
"util/windows/wgl_loader_autogen.cpp":
"373b062587eab8a163121255f54597dc",
"util/windows/wgl_loader_autogen.h":
diff --git a/scripts/code_generation_hashes/GL_EGL_entry_points.json b/scripts/code_generation_hashes/GL_EGL_entry_points.json
index 266f857f229d495559384ee1e02a0e258552c2c7..903ba3966142a3b971dfbcbee9993bcc5b1544c3 100644
--- a/scripts/code_generation_hashes/GL_EGL_entry_points.json
+++ b/scripts/code_generation_hashes/GL_EGL_entry_points.json
@@ -4,21 +4,21 @@
"scripts/entry_point_packed_egl_enums.json":
"a72ae855c6b403912103b519139951a1",
"scripts/entry_point_packed_gl_enums.json":
- "be374e5742cda78e3189bbeddf9ab6f7",
+ "8b8f78d43f213f3c52049f7d974d488d",
"scripts/generate_entry_points.py":
- "8fe4cc91467ea2f644923527aba3139f",
+ "7b4237598219fcbea82eebb8c9a5dbbc",
"scripts/gl_angle_ext.xml":
- "da4ecccdd77635f1b0e9d4664f856706",
+ "2cba159af592da788a15449eae941cb4",
"scripts/registry_xml.py":
- "4824b51dafdbdbf6eb109a4d0c5b86b8",
+ "cf2238984047673faa30d75bdfc3f6e7",
"src/common/entry_points_enum_autogen.cpp":
- "0b8ff1d91b8893bcdbf9fdc4fd0f79d8",
+ "4f3df9ac717cbee53bedf3c271917b92",
"src/common/entry_points_enum_autogen.h":
- "50d36abe85f61158cf0dba3affbcfc74",
+ "2aacb58b77c4e8c07de6ebbda3507325",
"src/common/frame_capture_utils_autogen.cpp":
- "740c827e5fa32ac4b6bce98a9225907e",
+ "3db48981ed6af73bf8ba4c4c269df74d",
"src/common/frame_capture_utils_autogen.h":
- "92492e0b08610fe09af507a3075fe203",
+ "7175e2b92f1a3d9b9819d83ca4228bbe",
"src/libANGLE/Context_gles_1_0_autogen.h":
"cb1cfe652972d301a5a98b4f233fcc4f",
"src/libANGLE/Context_gles_2_0_autogen.h":
@@ -30,7 +30,7 @@
"src/libANGLE/Context_gles_3_2_autogen.h":
"cf9900e0067812fc6773e8ae4664da33",
"src/libANGLE/Context_gles_ext_autogen.h":
- "7c55a082377ba3dc7eb738e67bd33e1a",
+ "5dd6184e2a1c14157de92a257acc4e8c",
"src/libANGLE/capture/capture_cl_autogen.cpp":
"e07bd3ced621b3c2c23da910ef912036",
"src/libANGLE/capture/capture_cl_autogen.h":
@@ -60,9 +60,9 @@
"src/libANGLE/capture/capture_gles_3_2_autogen.h":
"5e956a19d9e3ba697fb05049c4be9936",
"src/libANGLE/capture/capture_gles_ext_autogen.cpp":
- "bbd218a49ad64826c2c0f21172b0b2d6",
+ "d5f6b37d76c3ab5c64550aa86d74e034",
"src/libANGLE/capture/capture_gles_ext_autogen.h":
- "546b398a83720dd0b4cc363ab83eadd1",
+ "dd99ae9ceb99a114d422e957774a51ab",
"src/libANGLE/context_private_call_autogen.h":
"b12e4b57d792fda9b12600082d6d960f",
"src/libANGLE/validationCL_autogen.h":
@@ -80,7 +80,7 @@
"src/libANGLE/validationES3_autogen.h":
"8d5b4de6479691eb63a687246491182f",
"src/libANGLE/validationESEXT_autogen.h":
- "835bfb5c77246922435f5f0e6c47ea2c",
+ "323b194412b5efda9f38efb3a442e4da",
"src/libEGL/libEGL_autogen.cpp":
"77d82db4a45c2f08108929ef7fe8b698",
"src/libEGL/libEGL_autogen.def":
@@ -130,19 +130,19 @@
"src/libGLESv2/entry_points_gles_3_2_autogen.h":
"647f932a299cdb4726b60bbba059f0d2",
"src/libGLESv2/entry_points_gles_ext_autogen.cpp":
- "29916b3f787723badd54fe4cc36b7ebf",
+ "6a7f9f0a47c9d375471332f2acac76d3",
"src/libGLESv2/entry_points_gles_ext_autogen.h":
- "5b573c79cc90490671b76f4e7a337209",
+ "2caecc2adf08a3576d104985f4b15e30",
"src/libGLESv2/libGLESv2_autogen.cpp":
- "7122ecb20b43aa3c64ff4c328b2cc57b",
+ "8e377deee26cd73f110779bd78b8c1aa",
"src/libGLESv2/libGLESv2_autogen.def":
- "45a89ae956e11715533654d16d15ffad",
+ "bad23ed8d95bd2f5d90c5f7af266c5e3",
"src/libGLESv2/libGLESv2_no_capture_autogen.def":
- "23ca160e2450347f2db2ef6b94a6c578",
+ "6aee07f80f6c6d5f3eef22f027f9ebb3",
"src/libGLESv2/libGLESv2_vulkan_secondaries_autogen.def":
- "1cee6dd4fa82e361586e4c691cc057d6",
+ "ae881b1b6622aa0d35c45c4e15f618fb",
"src/libGLESv2/libGLESv2_with_capture_autogen.def":
- "b91e41c6c54beedabbefeb8aece0e192",
+ "c853232047a646e25d7da78fa74fa6ce",
"src/libOpenCL/libOpenCL_autogen.cpp":
"0248415990d5c99ba8e9d41aecd0e3ab",
"third_party/EGL-Registry/src/api/egl.xml":
@@ -156,5 +156,5 @@
"third_party/OpenGL-Registry/src/xml/wgl.xml":
"eae784bf4d1b983a42af5671b140b7c4",
"util/capture/frame_capture_replay_autogen.cpp":
- "281ce957461793303bc4b62efaf8e445"
+ "fd2c06f322d5abf1765261362fe3676f"
}
diff --git a/scripts/code_generation_hashes/GLenum_value_to_string_map.json b/scripts/code_generation_hashes/GLenum_value_to_string_map.json
index 1bd2d3e15061c82f435d9daeec495f25e29778b6..7c53f81b3ed31f78e2bd9858ecf76ab77f79743b 100644
--- a/scripts/code_generation_hashes/GLenum_value_to_string_map.json
+++ b/scripts/code_generation_hashes/GLenum_value_to_string_map.json
@@ -2,11 +2,11 @@
"scripts/gen_gl_enum_utils.py":
"3ec60ab12923f4825b57fe183f2152b2",
"scripts/gl_angle_ext.xml":
- "da4ecccdd77635f1b0e9d4664f856706",
+ "2cba159af592da788a15449eae941cb4",
"scripts/registry_xml.py":
- "4824b51dafdbdbf6eb109a4d0c5b86b8",
+ "cf2238984047673faa30d75bdfc3f6e7",
"src/common/gl_enum_utils_autogen.cpp":
- "b411692252eaf6daad1917f8f5624fd7",
+ "3e9c6ac81b1279017d75d2b7d09c5352",
"src/common/gl_enum_utils_autogen.h":
"e3dc3844be83f15653389012e4c21b6b",
"third_party/OpenGL-Registry/src/xml/gl.xml":
diff --git a/scripts/code_generation_hashes/interpreter_utils.json b/scripts/code_generation_hashes/interpreter_utils.json
index 1a9feae5b1bbe1b66fde54c7e85356d8cdd8fc00..2d76d1d8e544c1d1c655e2205037615148e7ce31 100644
--- a/scripts/code_generation_hashes/interpreter_utils.json
+++ b/scripts/code_generation_hashes/interpreter_utils.json
@@ -4,9 +4,9 @@
"scripts/gen_interpreter_utils.py":
"7c21cda140a45527c02ddd003ebe7914",
"scripts/gl_angle_ext.xml":
- "da4ecccdd77635f1b0e9d4664f856706",
+ "2cba159af592da788a15449eae941cb4",
"scripts/registry_xml.py":
- "4824b51dafdbdbf6eb109a4d0c5b86b8",
+ "cf2238984047673faa30d75bdfc3f6e7",
"third_party/EGL-Registry/src/api/egl.xml":
"2056d54ea07156f1988ca1366bdee21a",
"third_party/OpenCL-Docs/src/xml/cl.xml":
@@ -20,5 +20,5 @@
"util/capture/trace_fixture.h":
"c9183d0fbb0418e0630ff25f377cc822",
"util/capture/trace_interpreter_autogen.cpp":
- "bc405d620aae95dc997337872f4d94c0"
+ "7a1e6c76e485ecca695b7720a36e0b5c"
}
diff --git a/scripts/code_generation_hashes/proc_table.json b/scripts/code_generation_hashes/proc_table.json
index b3e213de8c77d7f00ffdf5ad3de2c173d5142f52..189cae07d8b59b1f5944e4d9507a51cc80b84294 100644
--- a/scripts/code_generation_hashes/proc_table.json
+++ b/scripts/code_generation_hashes/proc_table.json
@@ -4,11 +4,11 @@
"scripts/gen_proc_table.py":
"23ebf460dda78d2c21625e0d41d3cb97",
"scripts/gl_angle_ext.xml":
- "da4ecccdd77635f1b0e9d4664f856706",
+ "2cba159af592da788a15449eae941cb4",
"scripts/registry_xml.py":
- "4824b51dafdbdbf6eb109a4d0c5b86b8",
+ "cf2238984047673faa30d75bdfc3f6e7",
"src/libGLESv2/egl_stubs_getprocaddress_autogen.cpp":
- "d394fb57688dc5eb89c19aeae23d8bf3",
+ "e9b8cdb847756179dd2e6f5a1a534f2f",
"src/libGLESv2/proc_table_cl_autogen.cpp":
"f863172e26c6a463f6f23df217b23a48",
"src/libOpenCL/libOpenCL_autogen.map":
diff --git a/scripts/entry_point_packed_gl_enums.json b/scripts/entry_point_packed_gl_enums.json
index 285c52f14ec233b3636194679c1d6b6f2f631933..4680e75892b8f118fc30e6fa3d5317dfd21603f7 100644
--- a/scripts/entry_point_packed_gl_enums.json
+++ b/scripts/entry_point_packed_gl_enums.json
@@ -440,6 +440,9 @@
"glFramebufferFoveationParameters": {
"framebuffer": "FramebufferID"
},
+ "glFramebufferResolveRenderbufferWEBKIT": {
+ "renderbuffer": "RenderbufferID"
+ },
"glFramebufferRenderbuffer": {
"renderbuffer": "RenderbufferID"
},
diff --git a/scripts/generate_entry_points.py b/scripts/generate_entry_points.py
index 1f45174cefd2237294a434403fae8dad6a67df6a..e3a6760f8cd51f73c975f1cab109e080e60351e9 100755
--- a/scripts/generate_entry_points.py
+++ b/scripts/generate_entry_points.py
@@ -1017,6 +1017,7 @@ FORMAT_DICT = {
"GLint": "%d",
"GLintptr": UNSIGNED_LONG_LONG_FORMAT,
"GLSETBLOBPROCANGLE": POINTER_FORMAT,
+ "GLMTLRasterizationRateMapANGLE": POINTER_FORMAT,
"GLshort": "%d",
"GLsizei": "%d",
"GLsizeiptr": UNSIGNED_LONG_LONG_FORMAT,
diff --git a/scripts/gl_angle_ext.xml b/scripts/gl_angle_ext.xml
index 0389244dd9232e3b4cd18bfd7d8a03721643eeb8..40eb16fc1619a3e63d6befd5b574c1216901bbf9 100644
--- a/scripts/gl_angle_ext.xml
+++ b/scripts/gl_angle_ext.xml
@@ -13,6 +13,7 @@
<types>
<type>typedef GLsizeiptr (<apientry/> *<name>GLGETBLOBPROCANGLE</name>)(const void *key, GLsizeiptr keySize, void *value, GLsizeiptr valueSize, const void *userParam);</type>
<type>typedef void (<apientry/> *<name>GLSETBLOBPROCANGLE</name>)(const void *key, GLsizeiptr keySize, const void *value, GLsizeiptr valueSize, const void *userParam);</type>
+ <type>typedef void *<name>GLMTLRasterizationRateMapANGLE</name>;</type>
</types>
<!-- SECTION: GL parameter class type definitions. -->
@@ -1066,6 +1067,18 @@
<param len="1">void **<name>params</name></param>
<alias name="glGetPointerv"/>
</command>
+ <command>
+ <proto>void <name>glBindMetalRasterizationRateMapANGLE</name></proto>
+ <param><ptype>GLuint</ptype> <name>framebuffer</name></param>
+ <param><ptype>GLMTLRasterizationRateMapANGLE</ptype> <name>map</name></param>
+ </command>
+ <command>
+ <proto>void <name>glFramebufferResolveRenderbufferWEBKIT</name></proto>
+ <param><ptype>GLenum</ptype> <name>target</name></param>
+ <param><ptype>GLenum</ptype> <name>attachment</name></param>
+ <param><ptype>GLenum</ptype> <name>renderbuffertarget</name></param>
+ <param><ptype>GLuint</ptype> <name>renderbuffer</name></param>
+ </command>
</commands>
<!-- SECTION: ANGLE extension interface definitions -->
@@ -1467,6 +1480,18 @@
<enum name="GL_SHADER_BINARY_ANGLE"/>
</require>
</extension>
+ <extension name="GL_ANGLE_variable_rasterization_rate_metal" supported="gles2">
+ <require>
+ <enum name="GL_VARIABLE_RASTERIZATION_RATE_ANGLE"/>
+ <enum name="GL_METAL_RASTERIZATION_RATE_MAP_BINDING_ANGLE"/>
+ <command name="glBindMetalRasterizationRateMapANGLE"/>
+ </require>
+ </extension>
+ <extension name="GL_WEBKIT_explicit_resolve_target" supported='gles2'>
+ <require>
+ <command name="glFramebufferResolveRenderbufferWEBKIT"/>
+ </require>
+ </extension>
<extension name="GL_ANGLE_blob_cache" supported="gles2">
<require>
<command name="glBlobCacheCallbacksANGLE"/>
@@ -1656,4 +1681,8 @@
<enum value="0x96EF" name="GL_BLOB_CACHE_SET_FUNCTION_ANGLE"/>
<enum value="0x972D" name="GL_BLOB_CACHE_USER_PARAM_ANGLE"/>
</enums>
+ <enums namespace="GL" start="0x96BC" end="0x96BD" vendor="ANGLE">
+ <enum value="0x96BC" name="GL_VARIABLE_RASTERIZATION_RATE_ANGLE"/>
+ <enum value="0x96BD" name="GL_METAL_RASTERIZATION_RATE_MAP_BINDING_ANGLE"/>
+ </enums>
</registry>
diff --git a/scripts/registry_xml.py b/scripts/registry_xml.py
index e70a9e42f1bcfc4a54791a8f45aebe0a1a48493d..144a9df4e795103f58bf45cfc98c6b153ac81777 100644
--- a/scripts/registry_xml.py
+++ b/scripts/registry_xml.py
@@ -74,11 +74,13 @@ angle_requestable_extensions = [
"GL_ANGLE_texture_external_update",
"GL_ANGLE_texture_multisample",
"GL_ANGLE_texture_rectangle",
+ "GL_ANGLE_variable_rasterization_rate_metal",
"GL_ANGLE_vulkan_image",
"GL_ANGLE_yuv_internal_format",
"GL_CHROMIUM_color_buffer_float_rgb",
"GL_CHROMIUM_color_buffer_float_rgba",
"GL_CHROMIUM_lose_context",
+ "GL_WEBKIT_explicit_resolve_target",
]
gles_requestable_extensions = [
diff --git a/src/common/PoolAlloc.cpp b/src/common/PoolAlloc.cpp
index a512771e918885deed5e0a1c226c2c9f86e88bfe..45b7526c48d7e03d734934f28c27fd3fc942cd7f 100644
--- a/src/common/PoolAlloc.cpp
+++ b/src/common/PoolAlloc.cpp
@@ -4,7 +4,7 @@
// found in the LICENSE file.
//
// PoolAlloc.cpp:
-// Implements the class methods for PoolAllocator and Allocation classes.
+// Implements the PoolAllocator.
//
#ifdef UNSAFE_BUFFERS_BUILD
@@ -13,16 +13,10 @@
#include "common/PoolAlloc.h"
-#include <assert.h>
#include <stdint.h>
-#include <stdio.h>
-#include <utility>
-#include <utility>
-
-#include "common/mathutil.h"
+#include "common/aligned_memory.h"
#include "common/platform.h"
-#include "common/tls.h"
#if defined(ANGLE_WITH_ASAN)
# include <sanitizer/asan_interface.h>
@@ -30,395 +24,153 @@
namespace angle
{
-// If we are using guard blocks, we must track each individual allocation. If we aren't using guard
-// blocks, these never get instantiated, so won't have any impact.
-class Allocation
-{
- public:
- Allocation(size_t size, unsigned char *mem, Allocation *prev = 0)
- : mSize(size), mMem(mem), mPrevAlloc(prev)
- {
- // Allocations are bracketed:
- //
- // [allocationHeader][initialGuardBlock][userData][finalGuardBlock]
- //
- // This would be cleaner with if (kGuardBlockSize)..., but that makes the compiler print
- // warnings about 0 length memsets, even with the if() protecting them.
+// The PoolAllocator memory is aligned by starting with an aligned pointer
+// and reserving aligned size amount of memory.
+// This is, as opposed to aligning the current pointer and reserving the
+// exact amount.
+// The layout is:
+// [client][pad][client][pad]...
+// With ANGLE_POOL_ALLOC_GUARD_BLOCKS, the layout is:
+// [guard][client][pad/guard][guard][client][pad/guard]
+// ANGLE_POOL_ALLOC_GUARD_BLOCKS asserts that guards and pads are not overwritten
+// by the client.
+
#if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
- memset(preGuard(), kGuardBlockBeginVal, kGuardBlockSize);
- memset(data(), kUserDataFill, mSize);
- memset(postGuard(), kGuardBlockEndVal, kGuardBlockSize);
+constexpr uint8_t kGuardFillValue = 0xfe;
#endif
- }
-
- void checkAllocList() const;
- static size_t AlignedHeaderSize(uint8_t *allocationBasePtr, size_t alignment)
+class PoolAllocator::Segment
+{
+ public:
+ Segment() = default;
+ explicit Segment(Span<uint8_t> data) : mData(data) {}
+ Segment(Segment &&other) : mData(std::exchange(other.mData, {})) {}
+ ~Segment()
{
- // Make sure that the data offset after the header is aligned to the given alignment.
- size_t base = reinterpret_cast<size_t>(allocationBasePtr);
- return rx::roundUpPow2(base + kGuardBlockSize + HeaderSize(), alignment) - base;
- }
-
- // Return total size needed to accommodate user buffer of 'size',
- // plus our tracking data and any necessary alignments.
- static size_t AllocationSize(uint8_t *allocationBasePtr,
- size_t size,
- size_t alignment,
- size_t *preAllocationPaddingOut)
+ uint8_t *data = mData.data();
+ if (data != nullptr)
{
- // The allocation will be laid out as such:
- //
- // Aligned to |alignment|
- // ^
- // preAllocationPaddingOut |
- // ___^___ |
- // / \ |
- // <padding>[header][guard][data][guard]
- // \___________ __________/
- // V
- // dataOffset
- //
- // Note that alignment is at least as much as a pointer alignment, so the pointers in the
- // header are also necessarily aligned appropriately.
- //
- size_t dataOffset = AlignedHeaderSize(allocationBasePtr, alignment);
- *preAllocationPaddingOut = dataOffset - HeaderSize() - kGuardBlockSize;
-
- return dataOffset + size + kGuardBlockSize;
+ size_t size = mData.size();
+ ANGLE_UNUSED_VARIABLE(size);
+ ANGLE_ALLOC_PROFILE(POOL_DEALLOCATION, data, size, size > kSegmentSize);
+ AlignedFree(data);
}
-
- // Given memory pointing to |header|, returns |data|.
- static uint8_t *GetDataPointer(uint8_t *memory, size_t alignment)
+ }
+ Segment &operator=(Segment &&other)
{
- uint8_t *alignedPtr = memory + kGuardBlockSize + HeaderSize();
-
- // |memory| must be aligned already such that user data is aligned to |alignment|.
- ASSERT((reinterpret_cast<uintptr_t>(alignedPtr) & (alignment - 1)) == 0);
-
- return alignedPtr;
+ mData = std::exchange(other.mData, {});
+ return *this;
}
-
- private:
- void checkGuardBlock(unsigned char *blockMem, unsigned char val, const char *locText) const;
-
- void checkAlloc() const
+ static Segment Allocate(size_t size)
+ {
+ ANGLE_ALLOC_PROFILE(POOL_ALLOCATION, size, size > kSegmentSize);
+ uint8_t *result = reinterpret_cast<uint8_t *>(AlignedAlloc(size, kAlignment));
+ if (ANGLE_UNLIKELY(result == nullptr))
{
- checkGuardBlock(preGuard(), kGuardBlockBeginVal, "before");
- checkGuardBlock(postGuard(), kGuardBlockEndVal, "after");
+ return {};
}
+ return Segment{{result, size}};
+ }
+ uint8_t *data() const { return mData.data(); }
- // Find offsets to pre and post guard blocks, and user data buffer
- unsigned char *preGuard() const { return mMem + HeaderSize(); }
- unsigned char *data() const { return preGuard() + kGuardBlockSize; }
- unsigned char *postGuard() const { return data() + mSize; }
- size_t mSize; // size of the user data area
- unsigned char *mMem; // beginning of our allocation (points to header)
- Allocation *mPrevAlloc; // prior allocation in the chain
-
- static constexpr unsigned char kGuardBlockBeginVal = 0xfb;
- static constexpr unsigned char kGuardBlockEndVal = 0xfe;
- static constexpr unsigned char kUserDataFill = 0xcd;
-#if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
- static constexpr size_t kGuardBlockSize = 16;
- static constexpr size_t HeaderSize() { return sizeof(Allocation); }
-#else
- static constexpr size_t kGuardBlockSize = 0;
- static constexpr size_t HeaderSize() { return 0; }
-#endif
+ private:
+ Span<uint8_t> mData;
};
-#if !defined(ANGLE_DISABLE_POOL_ALLOC)
-class PageHeader
+PoolAllocator::PoolAllocator() = default;
+
+PoolAllocator::~PoolAllocator()
{
- public:
- PageHeader(PageHeader *nextPage, size_t pageCount)
- : nextPage(nextPage),
- pageCount(pageCount)
- {
- }
+ reset();
+}
- PageHeader *nextPage;
- size_t pageCount;
-# if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
- Allocation *lastAllocation = nullptr;
-# endif
-};
-#endif
+void PoolAllocator::lock()
+{
+ ASSERT(!mLocked);
+ mLocked = true;
+}
-//
-// Implement the functionality of the PoolAllocator class, which
-// is documented in PoolAlloc.h.
-//
-PoolAllocator::PoolAllocator(int growthIncrement, int allocationAlignment)
- : mAlignment(allocationAlignment),
-#if !defined(ANGLE_DISABLE_POOL_ALLOC)
- mPageSize(growthIncrement),
- mFreeList(nullptr),
- mInUseList(nullptr),
- mNumCalls(0),
- mTotalBytes(0),
-#endif
- mLocked(false)
+void PoolAllocator::unlock()
{
-#if !defined(ANGLE_DISABLE_POOL_ALLOC)
- mPageHeaderSkip = sizeof(PageHeader);
+ ASSERT(mLocked);
+ mLocked = false;
+}
- // Alignment == 1 is a special fast-path where fastAllocate() is enabled
- if (mAlignment != 1)
- {
-#endif
- // Adjust mAlignment to be at least pointer aligned and
- // power of 2.
- //
- size_t minAlign = sizeof(void *);
- if (mAlignment < minAlign)
- {
- mAlignment = minAlign;
- }
- mAlignment = gl::ceilPow2(static_cast<unsigned int>(mAlignment));
-#if !defined(ANGLE_DISABLE_POOL_ALLOC)
- }
- //
- // Don't allow page sizes we know are smaller than all common
- // OS page sizes.
- //
- if (mPageSize < 4 * 1024)
- {
- mPageSize = 4 * 1024;
- }
+#if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
- //
- // A large mCurrentPageOffset indicates a new page needs to
- // be obtained to allocate memory.
- //
- mCurrentPageOffset = mPageSize;
-#endif
+void PoolAllocator::addGuard(Span<uint8_t> guardData)
+{
+ memset(guardData.data(), kGuardFillValue, guardData.size());
+ mGuards.push_back(guardData);
}
-PoolAllocator::~PoolAllocator()
-{
- reset();
-#if !defined(ANGLE_DISABLE_POOL_ALLOC)
- while (mFreeList)
- {
- PageHeader *next = mFreeList->nextPage;
- delete[] reinterpret_cast<char *>(mFreeList);
- mFreeList = next;
- }
#endif
-}
-//
-// Check a single guard block for damage
-//
-void Allocation::checkGuardBlock(unsigned char *blockMem,
- unsigned char val,
- const char *locText) const
+void PoolAllocator::reset()
{
#if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
- for (size_t x = 0; x < kGuardBlockSize; x++)
+ for (Span<uint8_t> guard : mGuards)
{
- if (blockMem[x] != val)
+ for (uint8_t value : guard)
{
- char assertMsg[80];
- // We don't print the assert message. It's here just to be helpful.
- snprintf(assertMsg, sizeof(assertMsg),
- "PoolAlloc: Damage %s %zu byte allocation at 0x%p\n", locText, mSize, data());
- assert(0 && "PoolAlloc: Damage in guard block");
+ ASSERT(value == kGuardFillValue);
}
}
+ mGuards.clear();
#endif
-}
-
-void PoolAllocator::reset()
-{
#if !defined(ANGLE_DISABLE_POOL_ALLOC)
- mNumCalls = 0;
- mTotalBytes = 0;
-
- mCurrentPageOffset = mPageSize;
- PageHeader *page = std::exchange(mInUseList, nullptr);
- while (page)
- {
- const size_t pageCount = page->pageCount;
- PageHeader *nextInUse = page->nextPage;
-
-# if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
- if (page->lastAllocation)
- {
- Allocation *allocations = std::exchange(page->lastAllocation, nullptr);
- allocations->checkAllocList();
- }
-# endif
-
- if (pageCount > 1)
- {
- delete[] reinterpret_cast<uint8_t *>(page);
- }
- else
- {
+ mCurrentPool = {};
+ mUnusedSegments = std::exchange(mPoolSegments, {});
# if defined(ANGLE_WITH_ASAN)
+ for (auto &segment : mUnusedSegments)
+ {
// Clear any container annotations left over from when the memory
// was last used. (crbug.com/1419798)
- __asan_unpoison_memory_region(page, mPageSize);
-# endif
- page->nextPage = mFreeList;
- mFreeList = page;
+ __asan_unpoison_memory_region(segment.data(), kSegmentSize);
}
- page = nextInUse;
- }
-#else // !defined(ANGLE_DISABLE_POOL_ALLOC)
- mStack.clear();
+# endif
#endif
+ mSingleObjectSegments.clear();
}
-void *PoolAllocator::allocate(size_t numBytes)
-{
- ASSERT(!mLocked);
-
#if !defined(ANGLE_DISABLE_POOL_ALLOC)
- //
- // Just keep some interesting statistics.
- //
- ++mNumCalls;
- mTotalBytes += numBytes;
-
- uint8_t *currentPagePtr = reinterpret_cast<uint8_t *>(mInUseList) + mCurrentPageOffset;
-
- size_t preAllocationPadding = 0;
- size_t allocationSize =
- Allocation::AllocationSize(currentPagePtr, numBytes, mAlignment, &preAllocationPadding);
-
- // Integer overflow is unexpected.
- ASSERT(allocationSize >= numBytes);
-
- // Do the allocation, most likely case first, for efficiency.
- if (allocationSize <= mPageSize - mCurrentPageOffset)
- {
- // There is enough room to allocate from the current page at mCurrentPageOffset.
- uint8_t *memory = currentPagePtr + preAllocationPadding;
- mCurrentPageOffset += allocationSize;
-
- return initializeAllocation(memory, numBytes);
- }
-
- if (allocationSize > mPageSize - mPageHeaderSkip)
- {
- // If the allocation is larger than a whole page, do a multi-page allocation. These are not
- // mixed with the others. The OS is efficient in allocating and freeing multiple pages.
-
- // We don't know what the alignment of the new allocated memory will be, so conservatively
- // allocate enough memory for up to alignment extra bytes being needed.
- allocationSize = Allocation::AllocationSize(reinterpret_cast<uint8_t *>(mPageHeaderSkip),
- numBytes, mAlignment, &preAllocationPadding);
-
- size_t numBytesToAlloc = allocationSize + mPageHeaderSkip + mAlignment;
-
- // Integer overflow is unexpected.
- ASSERT(numBytesToAlloc >= allocationSize);
- uint8_t *memory = new (std::nothrow) uint8_t[numBytesToAlloc];
- if (memory == nullptr)
- {
- return nullptr;
- }
- mInUseList =
- new (memory) PageHeader(mInUseList, (numBytesToAlloc + mPageSize - 1) / mPageSize);
-
- // Make next allocation come from a new page
- mCurrentPageOffset = mPageSize;
-
- // Now that we actually have the pointer, make sure the data pointer will be aligned.
- currentPagePtr = reinterpret_cast<uint8_t *>(mInUseList) + mPageHeaderSkip;
- Allocation::AllocationSize(currentPagePtr, numBytes, mAlignment, &preAllocationPadding);
-
- return initializeAllocation(currentPagePtr + preAllocationPadding, numBytes);
- }
-
- uint8_t *newPageAddr = allocateNewPage(numBytes);
- return initializeAllocation(newPageAddr, numBytes);
-
-#else // !defined(ANGLE_DISABLE_POOL_ALLOC)
-
- uint8_t *alloc = new (std::nothrow) uint8_t[numBytes + mAlignment - 1];
- mStack.emplace_back(std::unique_ptr<uint8_t[]>(alloc));
-
- intptr_t intAlloc = reinterpret_cast<intptr_t>(alloc);
- intAlloc = rx::roundUpPow2<intptr_t>(intAlloc, mAlignment);
- return reinterpret_cast<void *>(intAlloc);
-#endif
-}
-
-#if !defined(ANGLE_DISABLE_POOL_ALLOC)
-uint8_t *PoolAllocator::allocateNewPage(size_t numBytes)
+bool PoolAllocator::allocateNewPoolSegment()
{
- // Need a simple page to allocate from. Pick a page from the free list, if any. Otherwise need
- // to make the allocation.
- if (mFreeList)
+ Segment segment;
+ if (!mUnusedSegments.empty())
{
- PageHeader *page = mFreeList;
- mFreeList = mFreeList->nextPage;
- page->nextPage = mInUseList;
- mInUseList = page;
+ segment = std::move(mUnusedSegments.back());
+ mUnusedSegments.pop_back();
}
else
{
- uint8_t *memory = new (std::nothrow) uint8_t[mPageSize];
- if (memory == nullptr)
+ segment = Segment::Allocate(kSegmentSize);
+ if (ANGLE_UNLIKELY(segment.data() == nullptr))
{
- return nullptr;
+ return false;
}
- mInUseList = new (memory) PageHeader(mInUseList, 1);
}
- // Leave room for the page header.
- mCurrentPageOffset = mPageHeaderSkip;
- uint8_t *currentPagePtr = reinterpret_cast<uint8_t *>(mInUseList) + mCurrentPageOffset;
-
- size_t preAllocationPadding = 0;
- size_t allocationSize =
- Allocation::AllocationSize(currentPagePtr, numBytes, mAlignment, &preAllocationPadding);
-
- mCurrentPageOffset += allocationSize;
-
- // The new allocation is made after the page header and any alignment required before it.
- return reinterpret_cast<uint8_t *>(mInUseList) + mPageHeaderSkip + preAllocationPadding;
+ mCurrentPool = {segment.data(), kSegmentSize};
+ mPoolSegments.push_back(std::move(segment));
+ return true;
}
-void *PoolAllocator::initializeAllocation(uint8_t *memory, size_t numBytes)
-{
-# if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
- mInUseList->lastAllocation =
- new (memory) Allocation(numBytes, memory, mInUseList->lastAllocation);
-# endif
-
- return Allocation::GetDataPointer(memory, mAlignment);
-}
#endif
-void PoolAllocator::lock()
-{
- ASSERT(!mLocked);
- mLocked = true;
-}
-
-void PoolAllocator::unlock()
-{
- ASSERT(mLocked);
- mLocked = false;
-}
-
-//
-// Check all allocations in a list for damage by calling check on each.
-//
-void Allocation::checkAllocList() const
+Span<uint8_t> PoolAllocator::allocateSingleObject(size_t size)
{
- for (const Allocation *alloc = this; alloc != nullptr; alloc = alloc->mPrevAlloc)
+ Segment segment = Segment::Allocate(size);
+ if (ANGLE_UNLIKELY(segment.data() == nullptr))
{
- alloc->checkAlloc();
+ return {};
}
+ Span<uint8_t> result{segment.data(), size};
+ mSingleObjectSegments.push_back(std::move(segment));
+ ANGLE_ALLOC_PROFILE(LOCAL_BUMP_ALLOCATION, result, true);
+ return result;
}
} // namespace angle
diff --git a/src/common/PoolAlloc.h b/src/common/PoolAlloc.h
index dab10d9c23f9d9c7ac40c6b8298c5fa26f3f8692..0adba197ea0b9722f83d3cb58c5c886555d68d39 100644
--- a/src/common/PoolAlloc.h
+++ b/src/common/PoolAlloc.h
@@ -37,74 +37,41 @@
#include <stdint.h>
+#include <memory>
+#include <utility>
+#include <vector>
+
#include "common/angleutils.h"
#include "common/log_utils.h"
+#include "common/mathutil.h"
+#include "common/span.h"
+#ifdef ANGLE_PLATFORM_APPLE
+# if __has_include(<WebKitAdditions/ANGLEAllocProfile.h>)
+# include <WebKitAdditions/ANGLEAllocProfile.h>
+# endif
+#endif
-#if defined(ANGLE_DISABLE_POOL_ALLOC)
-# include <memory>
-# include <vector>
+#if !defined(ANGLE_ALLOC_PROFILE)
+#define ANGLE_ALLOC_PROFILE(kind, ...)
+#define ANGLE_ALLOC_PROFILE_ALIGNMENT(x) (x)
#endif
namespace angle
{
-class PageHeader;
-// Pages are linked together with a simple header at the beginning
-// of each allocation obtained from the underlying OS.
-// The "page size" used is not, nor must it match, the underlying OS
-// page size. But, having it be about that size or equal to a set of
-// pages is likely most optimal.
-//
+// Allocator that allocates memory aligned to kAlignment and releases it when the instance is
+// destroyed.
class PoolAllocator : angle::NonCopyable
{
public:
-
- static const int kDefaultAlignment = sizeof(void *);
- //
- // Create PoolAllocator. If alignment is set to 1 byte then fastAllocate()
- // function can be used to make allocations with less overhead.
- //
- PoolAllocator(int growthIncrement = 8 * 1024, int allocationAlignment = kDefaultAlignment);
+ PoolAllocator();
~PoolAllocator();
- // Marks all allocated memory as unused. The memory will be reused.
- void reset();
-
- // Call allocate() to actually acquire memory. Returns 0 if no memory
- // available, otherwise a properly aligned pointer to 'numBytes' of memory.
- //
+ // Returns aligned pointer to 'numBytes' of memory or nullptr on allocation failure.
void *allocate(size_t numBytes);
- //
- // Call fastAllocate() for a faster allocate function that does minimal bookkeeping
- // preCondition: Allocator must have been created w/ alignment of 1
- ANGLE_INLINE uint8_t *fastAllocate(size_t numBytes)
- {
-#if defined(ANGLE_DISABLE_POOL_ALLOC)
- return reinterpret_cast<uint8_t *>(allocate(numBytes));
-#else
- ASSERT(mAlignment == 1);
- // No multi-page allocations
- ASSERT(numBytes <= (mPageSize - mPageHeaderSkip));
- //
- // Do the allocation, most likely case inline first, for efficiency.
- //
- if (numBytes <= mPageSize - mCurrentPageOffset)
- {
- //
- // Safe to allocate from mCurrentPageOffset.
- //
- uint8_t *memory = reinterpret_cast<uint8_t *>(mInUseList) + mCurrentPageOffset;
- mCurrentPageOffset += numBytes;
- return memory;
- }
- return allocateNewPage(numBytes);
-#endif
- }
-
- // There is no deallocate. The point of this class is that deallocation can be skipped by the
- // user of it, as the model of use is to simultaneously deallocate everything at once by
- // destroying the instance or reset().
+ // Marks all allocated memory as unused. The memory will be reused.
+ void reset();
// Catch unwanted allocations.
// TODO(jmadill): Remove this when we remove the global allocator.
@@ -112,40 +79,78 @@ class PoolAllocator : angle::NonCopyable
void unlock();
private:
- size_t mAlignment; // all returned allocations will be aligned at
- // this granularity, which will be a power of 2
+ static constexpr size_t kAlignment = ANGLE_ALLOC_PROFILE_ALIGNMENT(sizeof(void *));
+ Span<uint8_t> allocateSingleObject(size_t size);
+ class Segment;
+ std::vector<Segment> mSingleObjectSegments; // Large objects.
+
#if !defined(ANGLE_DISABLE_POOL_ALLOC)
- // Slow path of allocation when we have to get a new page.
- uint8_t *allocateNewPage(size_t numBytes);
- // Track allocations if and only if we're using guard blocks
- void *initializeAllocation(uint8_t *memory, size_t numBytes);
-
- // Granularity of allocation from the OS
- size_t mPageSize;
- // Amount of memory to skip to make room for the page header (which is the size of the page
- // header, or PageHeader in PoolAlloc.cpp)
- size_t mPageHeaderSkip;
- // Next offset in top of inUseList to allocate from. This offset is not necessarily aligned to
- // anything. When an allocation is made, the data is aligned to mAlignment, and the header (if
- // any) will align to pointer size by extension (since mAlignment is made aligned to at least
- // pointer size).
- size_t mCurrentPageOffset;
- // List of unused memory.
- PageHeader *mFreeList;
- // List of all memory currently being used. The head of this list is where allocations are
- // currently being made from.
- PageHeader *mInUseList;
-
- int mNumCalls; // just an interesting statistic
- size_t mTotalBytes; // just an interesting statistic
-
-#else // !defined(ANGLE_DISABLE_POOL_ALLOC)
- std::vector<std::unique_ptr<uint8_t[]>> mStack;
+ static constexpr size_t kSegmentSize = 32768;
+ bool allocateNewPoolSegment();
+
+ Span<uint8_t> mCurrentPool; // The unused part of memory in last entry of mPoolSegments.
+ std::vector<Segment> mPoolSegments; // List of currently in use memory allocations.
+ std::vector<Segment> mUnusedSegments; // List of unused allocations after reset().
#endif
- bool mLocked;
+#if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
+ void addGuard(Span<uint8_t> guardData);
+
+ std::vector<Span<uint8_t>> mGuards; // Guards, memory which is asserted to stay prestine.
+#endif
+ bool mLocked = false;
};
+inline void *PoolAllocator::allocate(size_t size)
+{
+ ASSERT(!mLocked);
+ Span<uint8_t> data;
+
+ size_t extent = size;
+#if !defined(ANGLE_DISABLE_POOL_ALLOC)
+ // Allocate with kAlignment granularity to keep the next allocation aligned.
+ extent = rx::roundUpPow2(extent, kAlignment);
+#endif
+#if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
+ // Add space for guard block before. Add space for guard block after if there is no alignment
+ // padding, else use the padding as the guard block after.
+ extent += kAlignment + (extent == size ? kAlignment : 0);
+#endif
+#if !defined(ANGLE_DISABLE_POOL_ALLOC)
+ if (extent <= mCurrentPool.size())
+ {
+ data = mCurrentPool.first(extent);
+ mCurrentPool = mCurrentPool.subspan(extent);
+ ANGLE_ALLOC_PROFILE(LOCAL_BUMP_ALLOCATION, data, false);
+ }
+ else if (extent < kSegmentSize)
+ {
+ if (ANGLE_UNLIKELY(!allocateNewPoolSegment()))
+ {
+ return nullptr;
+ }
+ data = mCurrentPool.first(extent);
+ mCurrentPool = mCurrentPool.subspan(extent);
+ ANGLE_ALLOC_PROFILE(LOCAL_BUMP_ALLOCATION, data, false);
+ }
+ else
+#endif
+ {
+ data = allocateSingleObject(extent);
+ if (data.empty())
+ {
+ return nullptr;
+ }
+ }
+
+#if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
+ addGuard(data.first(kAlignment));
+ data = data.subspan(kAlignment);
+ addGuard(data.subspan(size));
+#endif
+ return data.first(size).data();
+}
+
} // namespace angle
#endif // COMMON_POOLALLOC_H_
diff --git a/src/common/PoolAlloc_unittest.cpp b/src/common/PoolAlloc_unittest.cpp
index 118adbaa010da5f7437b5401b8951522b349b754..09adaa262762643221de4ae7ca141645e6b21951 100644
--- a/src/common/PoolAlloc_unittest.cpp
+++ b/src/common/PoolAlloc_unittest.cpp
@@ -17,8 +17,16 @@
namespace angle
{
+
+class PoolAllocatorTest : public testing::Test
+{
+ protected:
+ static constexpr size_t kPoolAllocatorPageSize = 32768;
+ static constexpr size_t kPoolAllocatorAlignment = sizeof(void *);
+};
+
// Verify the public interface of PoolAllocator class
-TEST(PoolAllocatorTest, Interface)
+TEST_F(PoolAllocatorTest, Interface)
{
size_t numBytes = 1024;
constexpr uint32_t kTestValue = 0xbaadbeef;
@@ -42,42 +50,108 @@ TEST(PoolAllocatorTest, Interface)
// Verify first allocation still has data
EXPECT_EQ(kTestValue, *writePtr);
// Make a bunch of allocations
+ for (uint32_t j = 0; j < 100; ++j)
+ {
for (uint32_t i = 0; i < 1000; ++i)
{
- numBytes = (rand() % (1024 * 4)) + 1;
+ numBytes = (rand() % kPoolAllocatorPageSize * 3) + 1;
allocation = poolAllocator.allocate(numBytes);
EXPECT_NE(nullptr, allocation);
// Write data into full allocation. In debug case if we
// overwrite any other allocation we get error.
memset(allocation, 0xb8, numBytes);
}
+ poolAllocator.reset();
+ }
}
-#if !defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
-// Verify allocations are correctly aligned for different alignments
-class PoolAllocatorAlignmentTest : public testing::TestWithParam<int>
-{};
-
-TEST_P(PoolAllocatorAlignmentTest, Alignment)
+// Tests that PoolAllocator returns pointers with expected alignment.
+TEST_F(PoolAllocatorTest, Alignment)
{
- int alignment = GetParam();
- // Create a pool allocator to allocate from
- PoolAllocator poolAllocator(4096, alignment);
- // Test a number of allocation sizes for each alignment
+ PoolAllocator poolAllocator;
+ for (uint32_t j = 0; j < 10; ++j)
+ {
for (uint32_t i = 0; i < 100; ++i)
{
- // Vary the allocation size around 4k to hit some multi-page allocations
- const size_t numBytes = rand() % (1024 * 4) + 1;
+ // Vary the allocation size to hit some large object allocations.
+ const size_t numBytes = (rand() % kPoolAllocatorPageSize * 3) + 1;
void *allocation = poolAllocator.allocate(numBytes);
// Verify alignment of allocation matches expected default
- EXPECT_EQ(0u, reinterpret_cast<uintptr_t>(allocation) % alignment)
- << "Iteration " << i << " allocating " << numBytes;
+ EXPECT_EQ(0u, reinterpret_cast<uintptr_t>(allocation) % kPoolAllocatorAlignment)
+ << "Iteration " << j << ", " << i << " allocating " << numBytes
+ << " got: " << allocation;
+ memset(allocation, i, numBytes);
}
+ poolAllocator.reset();
+ }
+}
+
+#if !defined(ANGLE_DISABLE_POOL_ALLOC)
+
+// Test that reset recycles memory.
+TEST_F(PoolAllocatorTest, ResetRecyclesMemory)
+{
+ PoolAllocator poolAllocator;
+ void *allocation1 = poolAllocator.allocate(1);
+ void *allocation2 = poolAllocator.allocate(2);
+ memset(allocation1, 11, 1);
+ memset(allocation2, 12, 2);
+ ANGLE_ALLOC_PROFILE(POINTER, allocation1);
+ ANGLE_ALLOC_PROFILE(POINTER, allocation2);
+ poolAllocator.reset();
+ void *allocation3 = poolAllocator.allocate(1);
+ void *allocation4 = poolAllocator.allocate(2);
+ memset(allocation3, 21, 1);
+ memset(allocation4, 22, 2);
+ ANGLE_ALLOC_PROFILE(POINTER, allocation3);
+ ANGLE_ALLOC_PROFILE(POINTER, allocation4);
+ EXPECT_NE(allocation1, nullptr);
+ EXPECT_NE(allocation2, nullptr);
+ EXPECT_NE(allocation1, allocation2);
+ EXPECT_EQ(allocation1, allocation3);
+ EXPECT_EQ(allocation2, allocation4);
}
-INSTANTIATE_TEST_SUITE_P(,
- PoolAllocatorAlignmentTest,
- testing::Values(2, 4, 8, 16, 32, 64, 128),
- testing::PrintToStringParamName());
#endif
+
+#if defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
+
+class PoolAllocatorGuardTest : public PoolAllocatorTest
+{};
+
+// Verify that alignment guard detects overflowing write.
+TEST_F(PoolAllocatorGuardTest, AlignmentGuardDetectsOverflowWrite)
+{
+ auto testOverflowAlignment = []() {
+ PoolAllocator poolAllocator;
+ void *allocation = poolAllocator.allocate(15);
+ memset(allocation, 11, 16);
+ };
+ ASSERT_DEATH(testOverflowAlignment(), "");
+}
+
+// Verify that allocation guard detects overflowing write.
+TEST_F(PoolAllocatorGuardTest, AllocationGuardsDetectsOverflowWrite)
+{
+ auto testOverflow = []() {
+ PoolAllocator poolAllocator;
+ void *allocation1 = poolAllocator.allocate(16);
+ memset(allocation1, 11, 17);
+ };
+ ASSERT_DEATH(testOverflow(), "");
+}
+
+// Verify that allocation guard detects underflowing write.
+TEST_F(PoolAllocatorGuardTest, AllocationGuardsDetectsUnderflowWrite)
+{
+ auto testUnderflow = []() {
+ PoolAllocator poolAllocator;
+ void *allocation1 = poolAllocator.allocate(16);
+ memset(reinterpret_cast<uint8_t *>(allocation1) - 1, 11, 1);
+ };
+ ASSERT_DEATH(testUnderflow(), "");
+}
+
+#endif
+
} // namespace angle
diff --git a/src/common/debug.cpp b/src/common/debug.cpp
index 2c7f18b509f77805f2a200c3077931a5347b8548..f4c919fcb364066eb2ab1e5ce39f873c97b4a9b0 100644
--- a/src/common/debug.cpp
+++ b/src/common/debug.cpp
@@ -40,6 +40,14 @@
#include "common/entry_points_enum_autogen.h"
#include "common/system_utils.h"
+#if defined(ANGLE_ENABLE_ASSERTS)
+bool AreAssertionsEnabled()
+{
+ static bool enabled = [] { return angle::GetEnvironmentVar("ANGLE_DISABLE_ASSERTS") != "1"; }();
+ return enabled;
+}
+#endif // defined(ANGLE_ENABLE_ASSERTS)
+
namespace gl
{
diff --git a/src/common/debug.h b/src/common/debug.h
index 48a1979e5edb3165d659c000c789f9a705809923..0ae642f624bca7ae94c595327058fb76bb6c8e50 100644
--- a/src/common/debug.h
+++ b/src/common/debug.h
@@ -177,4 +177,15 @@ angle::SimpleMutex &GetDebugMutex();
# define ANGLE_REENABLE_UNUSED_FUNCTION_WARNING
#endif
+// clang-format off
+#if defined(__clang__)
+# define ANGLE_DISABLE_NONLITERAL_FORMAT_WARNING \
+ _Pragma("clang diagnostic push") _Pragma("clang diagnostic ignored \"-Wformat-nonliteral\"")
+# define ANGLE_REENABLE_NONLITERAL_FORMAT_WARNING _Pragma("clang diagnostic pop")
+#else
+# define ANGLE_DISABLE_NONLITERAL_FORMAT_WARNING
+# define ANGLE_REENABLE_NONLITERAL_FORMAT_WARNING
+#endif
+// clang-format on
+
#endif // COMMON_DEBUG_H_
diff --git a/src/common/entry_points_enum_autogen.cpp b/src/common/entry_points_enum_autogen.cpp
index 8335bd85159ab70cfd1dbc8434e5eadcc49d576d..d6f7fa2ff9e674e8b09f788fae56d155721320f5 100644
--- a/src/common/entry_points_enum_autogen.cpp
+++ b/src/common/entry_points_enum_autogen.cpp
@@ -526,6 +526,8 @@ const char *GetEntryPointName(EntryPoint ep)
return "glBindFramebufferOES";
case EntryPoint::GLBindImageTexture:
return "glBindImageTexture";
+ case EntryPoint::GLBindMetalRasterizationRateMapANGLE:
+ return "glBindMetalRasterizationRateMapANGLE";
case EntryPoint::GLBindProgramPipeline:
return "glBindProgramPipeline";
case EntryPoint::GLBindProgramPipelineEXT:
@@ -954,6 +956,8 @@ const char *GetEntryPointName(EntryPoint ep)
return "glFramebufferRenderbuffer";
case EntryPoint::GLFramebufferRenderbufferOES:
return "glFramebufferRenderbufferOES";
+ case EntryPoint::GLFramebufferResolveRenderbufferWEBKIT:
+ return "glFramebufferResolveRenderbufferWEBKIT";
case EntryPoint::GLFramebufferShadingRateEXT:
return "glFramebufferShadingRateEXT";
case EntryPoint::GLFramebufferTexture:
diff --git a/src/common/entry_points_enum_autogen.h b/src/common/entry_points_enum_autogen.h
index 7245b9b2ccedb8e7274c5f91980b72e22eac21ff..41e23a2601855adce0f4db1daab6e0c46dd3cad9 100644
--- a/src/common/entry_points_enum_autogen.h
+++ b/src/common/entry_points_enum_autogen.h
@@ -269,6 +269,7 @@ enum class EntryPoint
GLBindFramebuffer,
GLBindFramebufferOES,
GLBindImageTexture,
+ GLBindMetalRasterizationRateMapANGLE,
GLBindProgramPipeline,
GLBindProgramPipelineEXT,
GLBindRenderbuffer,
@@ -483,6 +484,7 @@ enum class EntryPoint
GLFramebufferPixelLocalStorageRestoreANGLE,
GLFramebufferRenderbuffer,
GLFramebufferRenderbufferOES,
+ GLFramebufferResolveRenderbufferWEBKIT,
GLFramebufferShadingRateEXT,
GLFramebufferTexture,
GLFramebufferTexture2D,
diff --git a/src/common/frame_capture_utils_autogen.cpp b/src/common/frame_capture_utils_autogen.cpp
index 3311a744f3f878b7db0ab228592567a8f247d05b..ef73a62ff41cee2772f20563dee84c203a1361d1 100644
--- a/src/common/frame_capture_utils_autogen.cpp
+++ b/src/common/frame_capture_utils_autogen.cpp
@@ -225,6 +225,10 @@ void WriteParamCaptureReplay(std::ostream &os, const CallCapture &call, const Pa
WriteParamValueReplay<ParamType::TGLGETBLOBPROCANGLE>(
os, call, param.value.GLGETBLOBPROCANGLEVal);
break;
+ case ParamType::TGLMTLRasterizationRateMapANGLE:
+ WriteParamValueReplay<ParamType::TGLMTLRasterizationRateMapANGLE>(
+ os, call, param.value.GLMTLRasterizationRateMapANGLEVal);
+ break;
case ParamType::TGLSETBLOBPROCANGLE:
WriteParamValueReplay<ParamType::TGLSETBLOBPROCANGLE>(
os, call, param.value.GLSETBLOBPROCANGLEVal);
@@ -1003,6 +1007,8 @@ const char *ParamTypeToString(ParamType paramType)
return "GLDEBUGPROCKHR";
case ParamType::TGLGETBLOBPROCANGLE:
return "GLGETBLOBPROCANGLE";
+ case ParamType::TGLMTLRasterizationRateMapANGLE:
+ return "GLMTLRasterizationRateMapANGLE";
case ParamType::TGLSETBLOBPROCANGLE:
return "GLSETBLOBPROCANGLE";
case ParamType::TGLbitfield:
diff --git a/src/common/frame_capture_utils_autogen.h b/src/common/frame_capture_utils_autogen.h
index 4b4287dd7b3b53dd6d0857be5de713f2254ea80d..436a9027cc6a5044fcd8492d2c4b7362077fb142 100644
--- a/src/common/frame_capture_utils_autogen.h
+++ b/src/common/frame_capture_utils_autogen.h
@@ -101,6 +101,7 @@ enum class ParamType
TGLDEBUGPROC,
TGLDEBUGPROCKHR,
TGLGETBLOBPROCANGLE,
+ TGLMTLRasterizationRateMapANGLE,
TGLSETBLOBPROCANGLE,
TGLbitfield,
TGLboolean,
@@ -273,7 +274,7 @@ enum class ParamType
TvoidPointerPointer,
};
-constexpr uint32_t kParamTypeCount = 236;
+constexpr uint32_t kParamTypeCount = 237;
union ParamValue
{
@@ -337,6 +338,7 @@ union ParamValue
GLDEBUGPROC GLDEBUGPROCVal;
GLDEBUGPROCKHR GLDEBUGPROCKHRVal;
GLGETBLOBPROCANGLE GLGETBLOBPROCANGLEVal;
+ GLMTLRasterizationRateMapANGLE GLMTLRasterizationRateMapANGLEVal;
GLSETBLOBPROCANGLE GLSETBLOBPROCANGLEVal;
GLbitfield GLbitfieldVal;
GLboolean GLbooleanVal;
@@ -901,6 +903,14 @@ inline GLGETBLOBPROCANGLE GetParamVal<ParamType::TGLGETBLOBPROCANGLE, GLGETBLOBP
return value.GLGETBLOBPROCANGLEVal;
}
+template <>
+inline GLMTLRasterizationRateMapANGLE
+GetParamVal<ParamType::TGLMTLRasterizationRateMapANGLE, GLMTLRasterizationRateMapANGLE>(
+ const ParamValue &value)
+{
+ return value.GLMTLRasterizationRateMapANGLEVal;
+}
+
template <>
inline GLSETBLOBPROCANGLE GetParamVal<ParamType::TGLSETBLOBPROCANGLE, GLSETBLOBPROCANGLE>(
const ParamValue &value)
@@ -2230,6 +2240,8 @@ T AccessParamValue(ParamType paramType, const ParamValue &value)
return GetParamVal<ParamType::TGLDEBUGPROCKHR, T>(value);
case ParamType::TGLGETBLOBPROCANGLE:
return GetParamVal<ParamType::TGLGETBLOBPROCANGLE, T>(value);
+ case ParamType::TGLMTLRasterizationRateMapANGLE:
+ return GetParamVal<ParamType::TGLMTLRasterizationRateMapANGLE, T>(value);
case ParamType::TGLSETBLOBPROCANGLE:
return GetParamVal<ParamType::TGLSETBLOBPROCANGLE, T>(value);
case ParamType::TGLbitfield:
@@ -2944,6 +2956,14 @@ inline void SetParamVal<ParamType::TGLGETBLOBPROCANGLE>(GLGETBLOBPROCANGLE value
valueOut->GLGETBLOBPROCANGLEVal = valueIn;
}
+template <>
+inline void SetParamVal<ParamType::TGLMTLRasterizationRateMapANGLE>(
+ GLMTLRasterizationRateMapANGLE valueIn,
+ ParamValue *valueOut)
+{
+ valueOut->GLMTLRasterizationRateMapANGLEVal = valueIn;
+}
+
template <>
inline void SetParamVal<ParamType::TGLSETBLOBPROCANGLE>(GLSETBLOBPROCANGLE valueIn,
ParamValue *valueOut)
@@ -4312,6 +4332,9 @@ void InitParamValue(ParamType paramType, T valueIn, ParamValue *valueOut)
case ParamType::TGLGETBLOBPROCANGLE:
SetParamVal<ParamType::TGLGETBLOBPROCANGLE>(valueIn, valueOut);
break;
+ case ParamType::TGLMTLRasterizationRateMapANGLE:
+ SetParamVal<ParamType::TGLMTLRasterizationRateMapANGLE>(valueIn, valueOut);
+ break;
case ParamType::TGLSETBLOBPROCANGLE:
SetParamVal<ParamType::TGLSETBLOBPROCANGLE>(valueIn, valueOut);
break;
diff --git a/src/common/gl_enum_utils_autogen.cpp b/src/common/gl_enum_utils_autogen.cpp
index f35e1ad6a1b5fb3c6670f1347c3af5d092bfd7e5..3600e32a1343805c10751a3f81de9451d6ca4d4d 100644
--- a/src/common/gl_enum_utils_autogen.cpp
+++ b/src/common/gl_enum_utils_autogen.cpp
@@ -2828,6 +2828,10 @@ const char *GLenumToString(GLESEnum enumGroup, unsigned int value)
return "GL_RGBX8_ANGLE";
case 0x96BB:
return "GL_SHADER_BINARY_ANGLE";
+ case 0x96BC:
+ return "GL_VARIABLE_RASTERIZATION_RATE_ANGLE";
+ case 0x96BD:
+ return "GL_METAL_RASTERIZATION_RATE_MAP_BINDING_ANGLE";
case 0x96BE:
return "GL_PROGRAM_BINARY_READY_ANGLE";
case 0x96C0:
@@ -22439,6 +22443,7 @@ static StringEnumEntry g_stringEnumTable[] = {
{"GL_MESH_SUBROUTINE_UNIFORM_NV", 0x957E},
{"GL_MESH_VERTICES_OUT_NV", 0x9579},
{"GL_MESH_WORK_GROUP_SIZE_NV", 0x953E},
+ {"GL_METAL_RASTERIZATION_RATE_MAP_BINDING_ANGLE", 0x96BD},
{"GL_MIN", 0x8007},
{"GL_MINMAX", 0x802E},
{"GL_MINMAX_EXT", 0x802E},
@@ -25108,6 +25113,7 @@ static StringEnumEntry g_stringEnumTable[] = {
{"GL_VARIABLE_E_NV", 0x8527},
{"GL_VARIABLE_F_NV", 0x8528},
{"GL_VARIABLE_G_NV", 0x8529},
+ {"GL_VARIABLE_RASTERIZATION_RATE_ANGLE", 0x96BC},
{"GL_VARIANT_ARRAY_EXT", 0x87E8},
{"GL_VARIANT_ARRAY_POINTER_EXT", 0x87E9},
{"GL_VARIANT_ARRAY_STRIDE_EXT", 0x87E6},
diff --git a/src/common/log_utils.h b/src/common/log_utils.h
index fc1aa2cccb169a6580cff7b2f144fe1768dbf6c5..de2ccdab42b3a77f3104e03c0715be22e8df2264 100644
--- a/src/common/log_utils.h
+++ b/src/common/log_utils.h
@@ -262,10 +262,13 @@ std::ostream &FmtHex(std::ostream &os, T value)
// A macro asserting a condition and outputting failures to the debug log
#if defined(ANGLE_ENABLE_ASSERTS)
+bool AreAssertionsEnabled();
# define ASSERT(expression) \
(expression ? static_cast<void>(0) \
- : (FATAL() << "\t! Assert failed in " << __FUNCTION__ << " (" << __FILE__ \
- << ":" << __LINE__ << "): " << #expression))
+ : (!AreAssertionsEnabled() \
+ ? static_cast<void>(0) \
+ : (FATAL() << "\t! Assert failed in " << __FUNCTION__ << " (" \
+ << __FILE__ << ":" << __LINE__ << "): " << #expression)))
#else
# define ASSERT(condition) ANGLE_EAT_STREAM_PARAMETERS << !(condition)
#endif // defined(ANGLE_ENABLE_ASSERTS)
diff --git a/src/common/span.h b/src/common/span.h
index a2ebec2c0d8a8a59a38d568aedd149c889fcafa2..fd6e9f573dd804a2ccdc183c6b815ef73e834519 100644
--- a/src/common/span.h
+++ b/src/common/span.h
@@ -106,6 +106,12 @@ class Span
return count == 0 ? Span() : Span(mData + offset, count);
}
+ constexpr Span subspan(size_type offset) const
+ {
+ ASSERT(offset <= mSize);
+ return offset == mSize ? Span() : Span(mData + offset, mSize - offset);
+ }
+
private:
T *mData = nullptr;
size_t mSize = 0;
diff --git a/src/common/tls.cpp b/src/common/tls.cpp
index 9600bae1a49fc9b6c409dfe311439a630b3b29f2..b66a225f407cc74f50e0be4015692a8cd94dffd0 100644
--- a/src/common/tls.cpp
+++ b/src/common/tls.cpp
@@ -20,7 +20,6 @@
# include <wrl/async.h>
# include <wrl/client.h>
-using namespace std;
using namespace Windows::Foundation;
using namespace ABI::Windows::System::Threading;
diff --git a/src/common/utilities.cpp b/src/common/utilities.cpp
index 47c454edb6813f269f12ffa8ebe52b04bba3ec59..fe0d347a937e68e90a5d5d006f0464007f505041 100644
--- a/src/common/utilities.cpp
+++ b/src/common/utilities.cpp
@@ -10,6 +10,12 @@
// utilities.cpp: Conversion functions and other utility routines.
+// Older clang versions have a false positive on this warning here.
+// TODO(dino): Is this still necessary?
+#if defined(__clang__)
+# pragma clang diagnostic ignored "-Wglobal-constructors"
+#endif
+
#include "common/utilities.h"
#include "GLES3/gl3.h"
#include "common/mathutil.h"
diff --git a/src/compiler/fuzz/translator_fuzzer.cpp b/src/compiler/fuzz/translator_fuzzer.cpp
index 53c7fe8b2cc2608122fb5a4ac8cf568d95f6d960..e442e0d6601b49a8fadf9b83a7a191fec4c60a9a 100644
--- a/src/compiler/fuzz/translator_fuzzer.cpp
+++ b/src/compiler/fuzz/translator_fuzzer.cpp
@@ -159,6 +159,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
}
std::vector<uint32_t> validOutputs;
+#ifndef ANGLE_TRANSLATOR_FUZZER_METAL_ONLY
validOutputs.push_back(SH_ESSL_OUTPUT);
validOutputs.push_back(SH_GLSL_COMPATIBILITY_OUTPUT);
validOutputs.push_back(SH_GLSL_130_OUTPUT);
@@ -174,6 +175,10 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
validOutputs.push_back(SH_SPIRV_VULKAN_OUTPUT);
validOutputs.push_back(SH_HLSL_3_0_OUTPUT);
validOutputs.push_back(SH_HLSL_4_1_OUTPUT);
+#endif
+#ifdef ANGLE_ENABLE_METAL
+ validOutputs.push_back(SH_MSL_METAL_OUTPUT);
+#endif
bool found = false;
for (auto valid : validOutputs)
{
@@ -205,6 +210,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
if (translator == nullptr)
{
+ sh::Finalize();
return 0;
}
@@ -239,6 +245,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
if (!translator->Init(resources))
{
+ sh::Finalize();
return 0;
}
@@ -251,5 +258,6 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
const char *shaderStrings[] = {reinterpret_cast<const char *>(data)};
translator->compile(shaderStrings, 1, options);
+ sh::Finalize();
return 0;
}
diff --git a/src/compiler/generate_parser_tools.py b/src/compiler/generate_parser_tools.py
index 71b370065e00ed5cb20738f977ac0243d2c9c4c6..3422ace60c834f8b3064a5251886e80965444e31 100644
--- a/src/compiler/generate_parser_tools.py
+++ b/src/compiler/generate_parser_tools.py
@@ -16,6 +16,10 @@ is_linux = platform.system() == 'Linux'
is_mac = platform.system() == 'Darwin'
is_windows = platform.system() == 'Windows'
+license_note = """/* Apple Note: For the avoidance of doubt, Apple elects to distribute this file under the terms of
+ * the BSD license. */
+
+"""
def get_tool_path_platform(tool_name, platform):
exe_path = os.path.join(sys.path[0], '..', '..', '..', 'tools', 'flex-bison', platform)
@@ -122,6 +126,15 @@ def run_bison(basename, generate_header):
process = subprocess.Popen(bison_args, env=bison_env, cwd=sys.path[0])
process.communicate()
+
+ for fn in [output_source] + ([output_header] if generate_header else []):
+ with open(fn, 'r') as output_file:
+ text = output_file.read()
+
+ with open(fn, 'w') as output_file:
+ output_file.write(license_note)
+ output_file.write(text)
+
return process.returncode
diff --git a/src/compiler/preprocessor/preprocessor_tab_autogen.cpp b/src/compiler/preprocessor/preprocessor_tab_autogen.cpp
index cfb4bc1b2a0113b0d6ea863be78fbbd60afd922c..8702d01fef25765c4778172a2a45cd5e54addbd8 100644
--- a/src/compiler/preprocessor/preprocessor_tab_autogen.cpp
+++ b/src/compiler/preprocessor/preprocessor_tab_autogen.cpp
@@ -1,3 +1,6 @@
+/* Apple Note: For the avoidance of doubt, Apple elects to distribute this file under the terms of
+ * the BSD license. */
+
/* A Bison parser, made by GNU Bison 3.8.2. */
/* Bison implementation for Yacc-like parsers in C
diff --git a/src/compiler/translator/InfoSink.h b/src/compiler/translator/InfoSink.h
index af8914a52e3a838afed41b98da82b2ed07e90420..ba40416d77dcd9aa9d6623f971637dc8b2a9f9a2 100644
--- a/src/compiler/translator/InfoSink.h
+++ b/src/compiler/translator/InfoSink.h
@@ -22,7 +22,11 @@ class TSymbol;
class TType;
// Returns the fractional part of the given floating-point number.
-inline float fractionalPart(float f)
+#ifdef WK_WORKAROUND_RDAR_145268301_ASAN_STACK_USE_AFTER_SCOPE
+__attribute__((no_sanitize_address))
+#endif
+inline float
+fractionalPart(float f)
{
float intPart = 0.0f;
return modff(f, &intPart);
diff --git a/src/compiler/translator/Types.h b/src/compiler/translator/Types.h
index 4ff73f4f667c6b1a0fffeca528ef7a15faebc104..b4ff27f8388adadcab0c89af78020cc536a1a5e2 100644
--- a/src/compiler/translator/Types.h
+++ b/src/compiler/translator/Types.h
@@ -255,6 +255,7 @@ class TType
}
bool isScalarFloat() const { return isScalar() && type == EbtFloat; }
bool isScalarInt() const { return isScalar() && (type == EbtInt || type == EbtUInt); }
+ bool isSignedInt() const { return type == EbtInt; }
bool canBeConstructed() const;
diff --git a/src/compiler/translator/glslang_tab_autogen.cpp b/src/compiler/translator/glslang_tab_autogen.cpp
index 15e399b6556026a8ef7f632175607b56eefca55b..9f292fd48d12adbe48f83695a971de6096f5a147 100644
--- a/src/compiler/translator/glslang_tab_autogen.cpp
+++ b/src/compiler/translator/glslang_tab_autogen.cpp
@@ -1,3 +1,6 @@
+/* Apple Note: For the avoidance of doubt, Apple elects to distribute this file under the terms of
+ * the BSD license. */
+
/* A Bison parser, made by GNU Bison 3.8.2. */
/* Bison implementation for Yacc-like parsers in C
diff --git a/src/compiler/translator/glslang_tab_autogen.h b/src/compiler/translator/glslang_tab_autogen.h
index d5a48edd40f382359db76acf1a1ce75b6a6dc6d5..817bb46f9ca4b6fe0294c0fec72878a567c32ef6 100644
--- a/src/compiler/translator/glslang_tab_autogen.h
+++ b/src/compiler/translator/glslang_tab_autogen.h
@@ -1,3 +1,6 @@
+/* Apple Note: For the avoidance of doubt, Apple elects to distribute this file under the terms of
+ * the BSD license. */
+
/* A Bison parser, made by GNU Bison 3.8.2. */
/* Bison interface for Yacc-like parsers in C
diff --git a/src/compiler/translator/msl/EmitMetal.cpp b/src/compiler/translator/msl/EmitMetal.cpp
index c0c1084f1b852d7eb851dc0ccaf8f306b708d89b..330f7d683a11b3709e3a78ccd9a061b126938a5e 100644
--- a/src/compiler/translator/msl/EmitMetal.cpp
+++ b/src/compiler/translator/msl/EmitMetal.cpp
@@ -185,12 +185,17 @@ class GenMetalTraverser : public TIntermTraverser
void emitSingleConstant(const TConstantUnion *const constUnion);
+ void emitForwardProgressStore();
+ void emitForwardProgressSignal();
+ bool shouldEnsureForwardProgress() const { return mForwardProgressStoreNestingCount >= 0; }
+
private:
Sink &mOut;
const TCompiler &mCompiler;
const PipelineStructs &mPipelineStructs;
SymbolEnv &mSymbolEnv;
IdGen &mIdGen;
+ int mForwardProgressStoreNestingCount = -1; // Negative means forward progress is not ensured.
int mIndentLevel = -1;
int mLastIndentationPos = -1;
int mOpenPointerParenCount = 0;
@@ -205,8 +210,45 @@ class GenMetalTraverser : public TIntermTraverser
size_t mDriverUniformsBindingIndex = 0;
size_t mUBOArgumentBufferBindingIndex = 0;
bool mRasterOrderGroupsSupported = false;
- bool mInjectAsmStatementIntoLoopBodies = false;
+ friend class ScopedForwardProgressStore;
+};
+
+class ScopedForwardProgressStore
+{
+ public:
+ ScopedForwardProgressStore(GenMetalTraverser &traverser);
+ ~ScopedForwardProgressStore();
+
+ private:
+ GenMetalTraverser &mTraverser;
};
+
+ScopedForwardProgressStore::ScopedForwardProgressStore(GenMetalTraverser &traverser)
+ : mTraverser(traverser)
+{
+ if (mTraverser.shouldEnsureForwardProgress())
+ {
+ if (mTraverser.mForwardProgressStoreNestingCount == 0)
+ {
+ mTraverser.emitOpenBrace();
+ mTraverser.emitForwardProgressStore();
+ }
+ ++mTraverser.mForwardProgressStoreNestingCount;
+ }
+}
+
+ScopedForwardProgressStore::~ScopedForwardProgressStore()
+{
+ if (mTraverser.shouldEnsureForwardProgress())
+ {
+ --mTraverser.mForwardProgressStoreNestingCount;
+ if (mTraverser.mForwardProgressStoreNestingCount == 0)
+ {
+ mTraverser.emitCloseBrace();
+ }
+ }
+}
+
} // anonymous namespace
GenMetalTraverser::~GenMetalTraverser()
@@ -232,9 +274,13 @@ GenMetalTraverser::GenMetalTraverser(const TCompiler &compiler,
mDriverUniformsBindingIndex(compileOptions.metal.driverUniformsBindingIndex),
mUBOArgumentBufferBindingIndex(compileOptions.metal.UBOArgumentBufferBindingIndex),
mRasterOrderGroupsSupported(compileOptions.pls.fragmentSyncType ==
- ShFragmentSynchronizationType::RasterOrderGroups_Metal),
- mInjectAsmStatementIntoLoopBodies(compileOptions.metal.injectAsmStatementIntoLoopBodies)
-{}
+ ShFragmentSynchronizationType::RasterOrderGroups_Metal)
+{
+ if (compileOptions.metal.injectAsmStatementIntoLoopBodies)
+ {
+ mForwardProgressStoreNestingCount = 0;
+ }
+}
void GenMetalTraverser::emitIndentation()
{
@@ -283,19 +329,9 @@ static const char *GetOperatorString(TOperator op,
case TOperator::EOpInitialize:
return "=";
case TOperator::EOpAddAssign:
- return "+=";
+ return resultType.isSignedInt() ? "ANGLE_addAssignInt" : "+=";
case TOperator::EOpSubAssign:
- return "-=";
- case TOperator::EOpMulAssign:
- return "*=";
- case TOperator::EOpDivAssign:
- return "/=";
- case TOperator::EOpIModAssign:
- return "%=";
- case TOperator::EOpBitShiftLeftAssign:
- return "<<="; // TODO: Check logical vs arithmetic shifting.
- case TOperator::EOpBitShiftRightAssign:
- return ">>="; // TODO: Check logical vs arithmetic shifting.
+ return resultType.isSignedInt() ? "ANGLE_subAssignInt" : "-=";
case TOperator::EOpBitwiseAndAssign:
return "&=";
case TOperator::EOpBitwiseXorAssign:
@@ -303,19 +339,9 @@ static const char *GetOperatorString(TOperator op,
case TOperator::EOpBitwiseOrAssign:
return "|=";
case TOperator::EOpAdd:
- return "+";
+ return resultType.isSignedInt() ? "ANGLE_addInt" : "+";
case TOperator::EOpSub:
- return "-";
- case TOperator::EOpMul:
- return "*";
- case TOperator::EOpDiv:
- return "/";
- case TOperator::EOpIMod:
- return "%";
- case TOperator::EOpBitShiftLeft:
- return "<<"; // TODO: Check logical vs arithmetic shifting.
- case TOperator::EOpBitShiftRight:
- return ">>"; // TODO: Check logical vs arithmetic shifting.
+ return resultType.isSignedInt() ? "ANGLE_subInt" : "-";
case TOperator::EOpBitwiseAnd:
return "&";
case TOperator::EOpBitwiseXor:
@@ -360,23 +386,19 @@ static const char *GetOperatorString(TOperator op,
case TOperator::EOpBitwiseNot:
return "~";
case TOperator::EOpPostIncrement:
- return "++";
+ return resultType.isSignedInt() ? "ANGLE_postIncrementInt" : "++";
case TOperator::EOpPostDecrement:
- return "--";
+ return resultType.isSignedInt() ? "ANGLE_postDecrementInt" : "--";
case TOperator::EOpPreIncrement:
- return "++";
+ return resultType.isSignedInt() ? "ANGLE_preIncrementInt" : "++";
case TOperator::EOpPreDecrement:
- return "--";
- case TOperator::EOpVectorTimesScalarAssign:
- return "*=";
+ return resultType.isSignedInt() ? "ANGLE_preDecrementInt" : "--";
case TOperator::EOpVectorTimesMatrixAssign:
return "*=";
case TOperator::EOpMatrixTimesScalarAssign:
return "*=";
case TOperator::EOpMatrixTimesMatrixAssign:
return "*=";
- case TOperator::EOpVectorTimesScalar:
- return "*";
case TOperator::EOpVectorTimesMatrix:
return "*";
case TOperator::EOpMatrixTimesVector:
@@ -390,6 +412,30 @@ static const char *GetOperatorString(TOperator op,
case TOperator::EOpNotEqualComponentWise:
return "!=";
+ case TOperator::EOpBitShiftRight:
+ case TOperator::EOpBitShiftRightAssign:
+ // TODO: Check logical vs arithmetic shifting.
+ return "ANGLE_rshift";
+
+ case TOperator::EOpBitShiftLeft:
+ case TOperator::EOpBitShiftLeftAssign:
+ // TODO: Check logical vs arithmetic shifting.
+ return resultType.isSignedInt() ? "ANGLE_ilshift" : "ANGLE_ulshift";
+
+ case TOperator::EOpMulAssign:
+ case TOperator::EOpMul:
+ case TOperator::EOpVectorTimesScalarAssign:
+ case TOperator::EOpVectorTimesScalar:
+ return resultType.isSignedInt() ? "ANGLE_imul" : "*";
+
+ case TOperator::EOpDiv:
+ case TOperator::EOpDivAssign:
+ return resultType.isSignedInt() ? "ANGLE_div" : "/";
+
+ case TOperator::EOpIMod:
+ case TOperator::EOpIModAssign:
+ return resultType.isSignedInt() ? "ANGLE_imod" : "%";
+
case TOperator::EOpEqual:
if ((argType0->getStruct() && argType1->getStruct()) &&
(argType0->isArray() && argType1->isArray()))
@@ -888,17 +934,14 @@ void GenMetalTraverser::emitPostQualifier(const EmitVariableDeclarationConfig &e
void GenMetalTraverser::emitLoopBody(TIntermBlock *bodyNode)
{
- if (mInjectAsmStatementIntoLoopBodies)
+ const bool emitForwardProgress = shouldEnsureForwardProgress();
+ if (emitForwardProgress)
{
emitOpenBrace();
-
- emitIndentation();
- mOut << "__asm__(\"\");\n";
+ emitForwardProgressSignal();
}
-
bodyNode->traverse(this);
-
- if (mInjectAsmStatementIntoLoopBodies)
+ if (emitForwardProgress)
{
emitCloseBrace();
}
@@ -1819,6 +1862,18 @@ bool GenMetalTraverser::visitBinary(Visit, TIntermBinary *binaryNode)
}
break;
+ case TOperator::EOpDivAssign:
+ case TOperator::EOpIModAssign:
+ case TOperator::EOpBitShiftRightAssign:
+ case TOperator::EOpBitShiftLeftAssign:
+ case TOperator::EOpAddAssign:
+ case TOperator::EOpSubAssign:
+ case TOperator::EOpMulAssign:
+ case TOperator::EOpVectorTimesScalarAssign:
+ leftNode.traverse(this);
+ mOut << " = ";
+ [[fallthrough]];
+
default:
{
const TType &resultType = binaryNode->getType();
@@ -2255,7 +2310,31 @@ bool GenMetalTraverser::visitAggregate(Visit, TIntermAggregate *aggregateNode)
}
else
{
+ bool isFtoi = [&]() {
+ if ((!retType.isScalar() && !retType.isVector()) ||
+ !IsInteger(retType.getBasicType()))
+ {
+ return false;
+ }
+ if (aggregateNode->getChildCount() != 1)
+ {
+ return false;
+ }
+ auto &argType = aggregateNode->getChildNode(0)->getAsTyped()->getType();
+ return (argType.isScalar() || argType.isVector()) &&
+ argType.getBasicType() == EbtFloat;
+ }();
+
+ if (isFtoi)
+ {
+ mOut << "ANGLE_ftoi<";
emitType(retType, etConfig);
+ mOut << ">";
+ }
+ else
+ {
+ emitType(retType, etConfig);
+ }
emitArgList("(", ")");
}
@@ -2380,6 +2459,26 @@ void GenMetalTraverser::emitCloseBrace()
mOut << "}";
}
+void GenMetalTraverser::emitForwardProgressStore()
+{
+ // https://eel.is/c++draft/intro.progress
+ // "The implementation may assume that any thread will eventually do one of the following:""
+ // - ...
+ // - "perform an access through a volatile glvalue"
+ // Emit a volatile variable which all loops in the stack will access.
+ emitIndentation();
+ mOut << "volatile bool ANGLE_p;\n";
+}
+
+void GenMetalTraverser::emitForwardProgressSignal()
+{
+ // Emit a read though the volatile variable. This marks the loop as making forward progress even
+ // if the compiler can otherwise analyze it to be infinite. This ensures that the loop
+ // has defined behavior.
+ emitIndentation();
+ mOut << "(void) ANGLE_p;\n";
+}
+
static bool RequiresSemicolonTerminator(TIntermNode &node)
{
if (node.getAsBlock())
@@ -2581,6 +2680,8 @@ bool GenMetalTraverser::visitForLoop(TIntermLoop *loopNode)
TIntermTyped *condNode = loopNode->getCondition();
TIntermTyped *exprNode = loopNode->getExpression();
+ ScopedForwardProgressStore scopedProgress(*this);
+
mOut << "for (";
if (initNode)
@@ -2623,6 +2724,7 @@ bool GenMetalTraverser::visitWhileLoop(TIntermLoop *loopNode)
ASSERT(condNode);
ASSERT(!initNode && !exprNode);
+ ScopedForwardProgressStore scopedProgress(*this);
emitIndentation();
mOut << "while (";
condNode->traverse(this);
@@ -2642,6 +2744,7 @@ bool GenMetalTraverser::visitDoWhileLoop(TIntermLoop *loopNode)
ASSERT(condNode);
ASSERT(!initNode && !exprNode);
+ ScopedForwardProgressStore scopedProgress(*this);
emitIndentation();
mOut << "do\n";
emitLoopBody(loopNode->getBody());
diff --git a/src/compiler/translator/msl/ProgramPrelude.cpp b/src/compiler/translator/msl/ProgramPrelude.cpp
index 8b3b1d2d2be8c852c0b765cd282745a031e02208..b4eb7117e7d00d18452859f685895ba4b85b5b4e 100644
--- a/src/compiler/translator/msl/ProgramPrelude.cpp
+++ b/src/compiler/translator/msl/ProgramPrelude.cpp
@@ -117,6 +117,13 @@ class ProgramPrelude : public TIntermTraverser
void degrees();
void radians();
void mod();
+ void div();
+ void imod();
+ void imul();
+ void ilshift();
+ void ulshift();
+ void rshift();
+ void ftoi();
void mixBool();
void postIncrementMatrix();
void preIncrementMatrix();
@@ -281,6 +288,14 @@ class ProgramPrelude : public TIntermTraverser
void interpolateAtCentroid();
void interpolateAtSample();
void interpolateAtOffset();
+ void postIncrementInt();
+ void preIncrementInt();
+ void postDecrementInt();
+ void preDecrementInt();
+ void addInt();
+ void addAssignInt();
+ void subInt();
+ void subAssignInt();
void loopForwardProgress();
private:
@@ -436,6 +451,116 @@ ANGLE_ALWAYS_INLINE X ANGLE_mod(X x, Y y)
}
)")
+// Avoid undefined behavior when:
+// - the divisor is 0
+// - the dividend is INT_MIN and the divisor is -1 (integer overflow)
+// When the behavior would be undefined the result is `x`.
+// FIXME: This function should also handle INT_MIN / -1, but currently this hits a bug in the metal
+// compiler
+PROGRAM_PRELUDE_DECLARE(div,
+ R"(
+template<typename X, typename Y, typename Z = metal::conditional_t<metal::is_scalar_v<Y>, X, Y>>
+ANGLE_ALWAYS_INLINE Z ANGLE_div(X x, Y y)
+{
+ Z zx = Z(x);
+ Z zy = Z(y);
+ auto predicate = zy == Z(0);
+ return zx / metal::select(zy, Z(1), predicate);
+}
+)")
+
+// Avoid undefined behavior when:
+// - the divisor is 0
+// - the dividend is INT_MIN and the divisor is -1 (integer overflow)
+// - either of the operands is negative (undefined behavior in Metal)
+// When the behavior would be undefined the result is 0.
+// FIXME: This function should also handle INT_MIN % -1, but currently this hits a bug in the metal
+// compiler
+PROGRAM_PRELUDE_DECLARE(imod,
+ R"(
+template<typename X, typename Y, typename Z = metal::conditional_t<metal::is_scalar_v<Y>, X, Y>>
+ANGLE_ALWAYS_INLINE Z ANGLE_imod(X x, Y y)
+{
+ if constexpr (metal::is_signed_v<Z>) {
+ Z y_or_one = metal::select(Z(y), Z(1), Z(y) == Z(0));
+ if (metal::any(((Z(x) | y_or_one) & Z(2147483648u)) != Z(0u)))
+ {
+ return as_type<Z>(
+ metal::make_unsigned_t<Z>(x) - metal::make_unsigned_t<Z>(x / y_or_one) * metal::make_unsigned_t<Z>(y_or_one)
+ );
+ }
+ else
+ {
+ return x % y_or_one;
+ }
+ }
+ else
+ {
+ return x % metal::select(Z(y), Z(1u), Z(y) == Z(0u));
+ }
+}
+)")
+
+// Avoid undefined behavior when the operand is outside the range of values that can be represented.
+// When the behavior would be undefined the value is clamped to fit the target type.
+PROGRAM_PRELUDE_DECLARE(ftoi,
+ R"(
+template <typename X, typename Y>
+ANGLE_ALWAYS_INLINE X ANGLE_ftoi(Y y)
+{
+ auto min = metal::numeric_limits<X>::min();
+ auto max = metal::numeric_limits<X>::max();
+ return X(metal::clamp(y, Y(min), Y(max)));
+}
+)")
+
+// Avoid undefined behavior due to integer overflow
+PROGRAM_PRELUDE_DECLARE(imul,
+ R"(
+template<typename X, typename Y, typename Z = metal::conditional_t<metal::is_scalar_v<Y>, X, Y>>
+ANGLE_ALWAYS_INLINE Z ANGLE_imul(X x, Y y)
+{
+ return as_type<Z>(metal::make_unsigned_t<Z>(x) * metal::make_unsigned_t<Z>(y));
+}
+)")
+
+// Avoid undefined behavior in e1 << e2 when:
+// 1) e2 is larger than the bit width of the type
+// 2) e2 is a negative value.
+// 3) e1 is a negative value
+PROGRAM_PRELUDE_DECLARE(ilshift,
+ R"(
+template <typename X, typename Y>
+ANGLE_ALWAYS_INLINE X ANGLE_ilshift(X x, Y y)
+{
+ return as_type<X>(metal::select(metal::make_unsigned_t<X>(0), metal::make_unsigned_t<X>(x) << (y & Y(31)), metal::make_unsigned_t<Y>(y) < metal::make_unsigned_t<Y>(32)));
+}
+)")
+
+// Avoid undefined behavior in e1 << e2 when:
+// 1) e2 is larger than the bit width of the type
+// 2) e2 is a negative value.
+PROGRAM_PRELUDE_DECLARE(ulshift,
+ R"(
+template <typename X, typename Y>
+ANGLE_ALWAYS_INLINE X ANGLE_ulshift(X x, Y y)
+{
+ return metal::select(X(0), x << (y & Y(31)), metal::make_unsigned_t<Y>(y) < metal::make_unsigned_t<Y>(32));
+}
+)")
+
+// Avoid undefined behavior in e1 >> e2 when:
+// 1) e2 is larger than the bit width of the type
+// 2) e2 is a negative value.
+PROGRAM_PRELUDE_DECLARE(rshift,
+ R"(
+template <typename X, typename Y>
+ANGLE_ALWAYS_INLINE X ANGLE_rshift(X x, Y y)
+{
+ return metal::select(X(0), x >> (y & Y(31)), metal::make_unsigned_t<Y>(y) < metal::make_unsigned_t<Y>(32));
+}
+)")
+
PROGRAM_PRELUDE_DECLARE(mixBool,
R"(
template <typename T, int N>
@@ -2773,6 +2898,164 @@ template <typename T>
ANGLE_ALWAYS_INLINE T ANGLE_interpolateAtOffset(T value, float2) { return value; }
)")
+PROGRAM_PRELUDE_DECLARE(preIncrementInt,
+ R"(
+ANGLE_ALWAYS_INLINE int ANGLE_preIncrementInt(thread int &a)
+{
+ a = as_type<int>(as_type<metal::uint>(a) + 1u);
+ return a;
+}
+
+ANGLE_ALWAYS_INLINE metal::int2 ANGLE_preIncrementInt(thread metal::int2 &a)
+{
+ a = as_type<metal::int2>(as_type<metal::uint2>(a) + 1u);
+ return a;
+}
+
+ANGLE_ALWAYS_INLINE metal::int3 ANGLE_preIncrementInt(thread metal::int3 &a)
+{
+ a = as_type<metal::int3>(as_type<metal::uint3>(a) + 1u);
+ return a;
+}
+
+ANGLE_ALWAYS_INLINE metal::int4 ANGLE_preIncrementInt(thread metal::int4 &a)
+{
+ a = as_type<metal::int4>(as_type<metal::uint4>(a) + 1u);
+ return a;
+}
+)")
+
+PROGRAM_PRELUDE_DECLARE(postIncrementInt,
+ R"(
+ANGLE_ALWAYS_INLINE int ANGLE_postIncrementInt(thread int &a)
+{
+ int r = a;
+ a = as_type<int>(as_type<metal::uint>(a) + 1u);
+ return r;
+}
+
+ANGLE_ALWAYS_INLINE metal::int2 ANGLE_postIncrementInt(thread metal::int2 &a)
+{
+ metal::int2 r = a;
+ a = as_type<metal::int2>(as_type<metal::uint2>(a) + 1u);
+ return r;
+}
+
+ANGLE_ALWAYS_INLINE metal::int3 ANGLE_postIncrementInt(thread metal::int3 &a)
+{
+ metal::int3 r = a;
+ a = as_type<metal::int3>(as_type<metal::uint3>(a) + 1u);
+ return r;
+}
+
+ANGLE_ALWAYS_INLINE metal::int4 ANGLE_postIncrementInt(thread metal::int4 &a)
+{
+ metal::int4 r = a;
+ a = as_type<metal::int4>(as_type<metal::uint4>(a) + 1u);
+ return r;
+}
+)")
+
+PROGRAM_PRELUDE_DECLARE(preDecrementInt,
+ R"(
+ANGLE_ALWAYS_INLINE int ANGLE_preDecrementInt(thread int &a)
+{
+ a = as_type<int>(as_type<metal::uint>(a) - 1u);
+ return a;
+}
+
+ANGLE_ALWAYS_INLINE metal::int2 ANGLE_preDecrementInt(thread metal::int2 &a)
+{
+ a = as_type<metal::int2>(as_type<metal::uint2>(a) - 1u);
+ return a;
+}
+
+ANGLE_ALWAYS_INLINE metal::int3 ANGLE_preDecrementInt(thread metal::int3 &a)
+{
+ a = as_type<metal::int3>(as_type<metal::uint3>(a) - 1u);
+ return a;
+}
+
+ANGLE_ALWAYS_INLINE metal::int4 ANGLE_preDecrementInt(thread metal::int4 &a)
+{
+ a = as_type<metal::int4>(as_type<metal::uint4>(a) - 1u);
+ return a;
+}
+)")
+
+PROGRAM_PRELUDE_DECLARE(postDecrementInt,
+ R"(
+ANGLE_ALWAYS_INLINE int ANGLE_postDecrementInt(thread int &a)
+{
+ int r = a;
+ a = as_type<int>(as_type<metal::uint>(a) - 1u);
+ return r;
+}
+
+ANGLE_ALWAYS_INLINE metal::int2 ANGLE_postDecrementInt(thread metal::int2 &a)
+{
+ metal::int2 r = a;
+ a = as_type<metal::int2>(as_type<metal::uint2>(a) - 1u);
+ return r;
+}
+
+ANGLE_ALWAYS_INLINE metal::int3 ANGLE_postDecrementInt(thread metal::int3 &a)
+{
+ metal::int3 r = a;
+ a = as_type<metal::int3>(as_type<metal::uint3>(a) - 1u);
+ return r;
+}
+
+ANGLE_ALWAYS_INLINE metal::int4 ANGLE_postDecrementInt(thread metal::int4 &a)
+{
+ metal::int4 r = a;
+ a = as_type<metal::int4>(as_type<metal::uint4>(a) - 1u);
+ return r;
+}
+)")
+
+// Avoid undefined behavior due to integer overflow.
+PROGRAM_PRELUDE_DECLARE(addInt,
+ R"(
+template<typename X, typename Y, typename Z = metal::conditional_t<metal::is_scalar_v<Y>, X, Y>>
+ANGLE_ALWAYS_INLINE Z ANGLE_addInt(X x, Y y)
+{
+ return as_type<Z>(metal::make_unsigned_t<Z>(x) + metal::make_unsigned_t<Z>(y));
+}
+)")
+
+// Avoid undefined behavior due to integer overflow.
+PROGRAM_PRELUDE_DECLARE(addAssignInt,
+ R"(
+template<typename X, typename Y>
+ANGLE_ALWAYS_INLINE thread X &ANGLE_addAssignInt(thread X &x, Y y)
+{
+ x = as_type<X>(metal::make_unsigned_t<X>(x) + metal::make_unsigned_t<Y>(y));
+ return x;
+}
+)")
+
+// Avoid undefined behavior due to integer underflow.
+PROGRAM_PRELUDE_DECLARE(subInt,
+ R"(
+template<typename X, typename Y, typename Z = metal::conditional_t<metal::is_scalar_v<Y>, X, Y>>
+ANGLE_ALWAYS_INLINE Z ANGLE_subInt(X x, Y y)
+{
+ return as_type<Z>(metal::make_unsigned_t<Z>(x) - metal::make_unsigned_t<Z>(y));
+}
+)")
+
+// Avoid undefined behavior due to integer underflow.
+PROGRAM_PRELUDE_DECLARE(subAssignInt,
+ R"(
+template<typename X, typename Y>
+ANGLE_ALWAYS_INLINE thread X &ANGLE_subAssignInt(thread X &x, Y y)
+{
+ x = as_type<X>(metal::make_unsigned_t<X>(x) - metal::make_unsigned_t<Y>(y));
+ return x;
+}
+)")
+
PROGRAM_PRELUDE_DECLARE(loopForwardProgress,
R"(
ANGLE_ALWAYS_INLINE void ANGLE_loopForwardProgress()
@@ -3292,6 +3575,10 @@ void ProgramPrelude::visitOperator(TOperator op,
case TOperator::EOpMod:
mod();
break;
+ case TOperator::EOpIModAssign:
+ case TOperator::EOpIMod:
+ imod();
+ break;
case TOperator::EOpRefract:
if (argType0->isScalar())
{
@@ -3443,6 +3730,10 @@ void ProgramPrelude::visitOperator(TOperator op,
{
addScalarMatrix();
}
+ if (argType0->isSignedInt())
+ {
+ addInt();
+ }
break;
case TOperator::EOpAddAssign:
@@ -3450,6 +3741,10 @@ void ProgramPrelude::visitOperator(TOperator op,
{
addMatrixScalarAssign();
}
+ if (argType0->isSignedInt())
+ {
+ addAssignInt();
+ }
break;
case TOperator::EOpSub:
@@ -3461,6 +3756,10 @@ void ProgramPrelude::visitOperator(TOperator op,
{
subScalarMatrix();
}
+ if (argType0->isSignedInt())
+ {
+ subInt();
+ }
break;
case TOperator::EOpSubAssign:
@@ -3468,9 +3767,28 @@ void ProgramPrelude::visitOperator(TOperator op,
{
subMatrixScalarAssign();
}
+ if (argType0->isSignedInt())
+ {
+ subAssignInt();
+ }
+ break;
+
+ case TOperator::EOpMul:
+ case TOperator::EOpMulAssign:
+ case TOperator::EOpVectorTimesScalar:
+ case TOperator::EOpVectorTimesScalarAssign:
+ if (argType0->isSignedInt())
+ {
+ imul();
+ }
+ if (argType0->isSignedInt())
+ {
+ subAssignInt();
+ }
break;
case TOperator::EOpDiv:
+ case TOperator::EOpDivAssign:
if (argType1->isMatrix())
{
if (argType0->isMatrix())
@@ -3482,12 +3800,9 @@ void ProgramPrelude::visitOperator(TOperator op,
divScalarMatrix();
}
}
- break;
-
- case TOperator::EOpDivAssign:
- if (argType0->isMatrix() && argType1->isMatrix())
+ else
{
- componentWiseDivideAssign();
+ div();
}
break;
@@ -3528,6 +3843,10 @@ void ProgramPrelude::visitOperator(TOperator op,
{
preIncrementMatrix();
}
+ if (argType0->isSignedInt())
+ {
+ preIncrementInt();
+ }
break;
case TOperator::EOpPostIncrement:
@@ -3535,6 +3854,10 @@ void ProgramPrelude::visitOperator(TOperator op,
{
postIncrementMatrix();
}
+ if (argType0->isSignedInt())
+ {
+ postIncrementInt();
+ }
break;
case TOperator::EOpPreDecrement:
@@ -3542,6 +3865,10 @@ void ProgramPrelude::visitOperator(TOperator op,
{
preDecrementMatrix();
}
+ if (argType0->isSignedInt())
+ {
+ preDecrementInt();
+ }
break;
case TOperator::EOpPostDecrement:
@@ -3549,6 +3876,10 @@ void ProgramPrelude::visitOperator(TOperator op,
{
postDecrementMatrix();
}
+ if (argType0->isSignedInt())
+ {
+ postDecrementInt();
+ }
break;
case TOperator::EOpNegative:
@@ -3558,20 +3889,31 @@ void ProgramPrelude::visitOperator(TOperator op,
}
break;
+ case TOperator::EOpBitShiftLeft:
+ case TOperator::EOpBitShiftLeftAssign:
+ {
+ if (argType0->isSignedInt())
+ {
+ ilshift();
+ }
+ else
+ {
+ ulshift();
+ }
+ break;
+ }
+
+ case TOperator::EOpBitShiftRight:
+ case TOperator::EOpBitShiftRightAssign:
+ rshift();
+ break;
+
case TOperator::EOpComma:
case TOperator::EOpAssign:
case TOperator::EOpInitialize:
- case TOperator::EOpMulAssign:
- case TOperator::EOpIModAssign:
- case TOperator::EOpBitShiftLeftAssign:
- case TOperator::EOpBitShiftRightAssign:
case TOperator::EOpBitwiseAndAssign:
case TOperator::EOpBitwiseXorAssign:
case TOperator::EOpBitwiseOrAssign:
- case TOperator::EOpMul:
- case TOperator::EOpIMod:
- case TOperator::EOpBitShiftLeft:
- case TOperator::EOpBitShiftRight:
case TOperator::EOpBitwiseAnd:
case TOperator::EOpBitwiseXor:
case TOperator::EOpBitwiseOr:
@@ -3590,10 +3932,8 @@ void ProgramPrelude::visitOperator(TOperator op,
case TOperator::EOpLogicalNot:
case TOperator::EOpNotComponentWise:
case TOperator::EOpBitwiseNot:
- case TOperator::EOpVectorTimesScalarAssign:
case TOperator::EOpVectorTimesMatrixAssign:
case TOperator::EOpMatrixTimesScalarAssign:
- case TOperator::EOpVectorTimesScalar:
case TOperator::EOpVectorTimesMatrix:
case TOperator::EOpMatrixTimesVector:
case TOperator::EOpMatrixTimesScalar:
@@ -3765,6 +4105,17 @@ bool ProgramPrelude::visitAggregate(Visit visit, TIntermAggregate *node)
const TFunction *func = node->getFunction();
+ if (node->isConstructor() && argCount == 1)
+ {
+ const TType &retType = node->getType();
+ const TType &argType = getArgType(0);
+ if (((retType.isScalar() || retType.isVector()) && IsInteger(retType.getBasicType())) &&
+ ((argType.isScalar() || argType.isVector()) && argType.getBasicType() == EbtFloat))
+ {
+ ftoi();
+ }
+ }
+
switch (node->getChildCount())
{
case 0:
diff --git a/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp b/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp
index 77262ed6e5b598fde791b1b4b9ce9e76afaf288f..4fe85335464b239c04da3f100c57962c10426e46 100644
--- a/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp
+++ b/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp
@@ -39,18 +39,20 @@ using StructureMap = angle::HashMap<const TStructure *, StructureData>;
using StructureUniformMap = angle::HashMap<const TVariable *, const TVariable *>;
using ExtractedSamplerMap = angle::HashMap<std::string, const TVariable *>;
-TIntermTyped *RewriteModifiedStructFieldSelectionExpression(
+bool RewriteModifiedStructFieldSelectionExpression(
TCompiler *compiler,
TIntermBinary *node,
const StructureMap &structureMap,
const StructureUniformMap &structureUniformMap,
- const ExtractedSamplerMap &extractedSamplers);
+ const ExtractedSamplerMap &extractedSamplers,
+ TIntermTyped **rewritten);
-TIntermTyped *RewriteExpressionVisitBinaryHelper(TCompiler *compiler,
+bool RewriteExpressionVisitBinaryHelper(TCompiler *compiler,
TIntermBinary *node,
const StructureMap &structureMap,
const StructureUniformMap &structureUniformMap,
- const ExtractedSamplerMap &extractedSamplers)
+ const ExtractedSamplerMap &extractedSamplers,
+ TIntermTyped **rewritten)
{
// Only interested in EOpIndex* binary nodes.
switch (node->getOp())
@@ -61,20 +63,22 @@ TIntermTyped *RewriteExpressionVisitBinaryHelper(TCompiler *compiler,
case EOpIndexDirectStruct:
break;
default:
- return nullptr;
+ *rewritten = nullptr;
+ return true;
}
const TStructure *structure = node->getLeft()->getType().getStruct();
if (structure == nullptr)
{
- return nullptr;
+ return true;
}
// If the result of the index is not a sampler and the struct is not replaced, there's nothing
// to do.
if (!node->getType().isSampler() && structureMap.find(structure) == structureMap.end())
{
- return nullptr;
+ *rewritten = nullptr;
+ return true;
}
// Otherwise, replace the whole expression such that:
@@ -84,8 +88,14 @@ TIntermTyped *RewriteExpressionVisitBinaryHelper(TCompiler *compiler,
// the intermediate nodes would have the correct type (and therefore fields).
ASSERT(structureMap.find(structure) != structureMap.end());
- return RewriteModifiedStructFieldSelectionExpression(compiler, node, structureMap,
- structureUniformMap, extractedSamplers);
+ if (!RewriteModifiedStructFieldSelectionExpression(compiler, node, structureMap,
+ structureUniformMap, extractedSamplers,
+ rewritten))
+ {
+ return false;
+ }
+
+ return true;
}
// Given an expression, this traverser calculates a new expression where sampler-in-structs are
@@ -103,13 +113,17 @@ class RewriteExpressionTraverser final : public TIntermTraverser
mCompiler(compiler),
mStructureMap(structureMap),
mStructureUniformMap(structureUniformMap),
- mExtractedSamplers(extractedSamplers)
+ mExtractedSamplers(extractedSamplers),
+ mUnsupportedError(false)
{}
bool visitBinary(Visit visit, TIntermBinary *node) override
{
- TIntermTyped *rewritten = RewriteExpressionVisitBinaryHelper(
- mCompiler, node, mStructureMap, mStructureUniformMap, mExtractedSamplers);
+ TIntermTyped *rewritten = nullptr;
+ if (!RewriteExpressionVisitBinaryHelper(mCompiler, node, mStructureMap, mStructureUniformMap, mExtractedSamplers, &rewritten))
+ {
+ mUnsupportedError = true;
+ }
if (rewritten == nullptr)
{
@@ -138,6 +152,10 @@ class RewriteExpressionTraverser final : public TIntermTraverser
const StructureMap &mStructureMap;
const StructureUniformMap &mStructureUniformMap;
const ExtractedSamplerMap &mExtractedSamplers;
+
+ // FIXME: Used to communicate that an error occurred during the rewrite process that is currently not
+ // supported so that a failure can be returned to callers of sh::RewriteStructSamplers().
+ bool mUnsupportedError;
};
// Rewrite the index of an EOpIndexIndirect expression. The root can never need replacing, because
@@ -179,12 +197,13 @@ void RewriteIndexExpression(TCompiler *compiler,
//
// If the expression is not a sampler, it only replaces the struct with the modified one, while
// still processing the EOpIndexIndirect expressions (which may contain more structs to map).
-TIntermTyped *RewriteModifiedStructFieldSelectionExpression(
+bool RewriteModifiedStructFieldSelectionExpression(
TCompiler *compiler,
TIntermBinary *node,
const StructureMap &structureMap,
const StructureUniformMap &structureUniformMap,
- const ExtractedSamplerMap &extractedSamplers)
+ const ExtractedSamplerMap &extractedSamplers,
+ TIntermTyped **rewritten)
{
const bool isSampler = node->getType().isSampler();
@@ -221,18 +240,17 @@ TIntermTyped *RewriteModifiedStructFieldSelectionExpression(
iter = iter->getLeft()->getAsBinaryNode();
}
- TIntermTyped *rewritten = nullptr;
if (isSampler)
{
ASSERT(extractedSamplers.find(samplerName) != extractedSamplers.end());
- rewritten = new TIntermSymbol(extractedSamplers.at(samplerName));
+ *rewritten = new TIntermSymbol(extractedSamplers.at(samplerName));
}
else
{
const TVariable *baseUniformVar = &baseUniform->variable();
ASSERT(structureUniformMap.find(baseUniformVar) != structureUniformMap.end());
- rewritten = new TIntermSymbol(structureUniformMap.at(baseUniformVar));
+ *rewritten = new TIntermSymbol(structureUniformMap.at(baseUniformVar));
}
// Iterate again and build the expression from bottom up.
@@ -245,13 +263,27 @@ TIntermTyped *RewriteModifiedStructFieldSelectionExpression(
case EOpIndexDirectStruct:
if (!isSampler)
{
- rewritten =
- new TIntermBinary(EOpIndexDirectStruct, rewritten, indexNode->getRight());
+ // FIXME: Fix accessing fields of structs containing other structs that only contain samplers.
+ // Currently, given the following example definitions:
+ // (e.g., struct S1 { sampler2D sampler; }; struct S2 { int i; S1 s; }; uniform S2 uni;)
+ // an out of bounds access can occur when trying to access uni.s.sampler because s has been stripped
+ // out of the replacement structure definition for S2. For now, check that indexing into the field
+ // list of a structure will not result in an out of bounds array access before attempting to
+ // create the binary operator node.
+ const TFieldList &fields = (*rewritten)->getType().getStruct()->fields();
+ const size_t fieldIndex = indexNode->getRight()->getAsConstantUnion()->getIConst(0);
+ if (fieldIndex >= fields.size())
+ {
+ return false;
+ }
+
+ *rewritten =
+ new TIntermBinary(EOpIndexDirectStruct, *rewritten, indexNode->getRight());
}
break;
case EOpIndexDirect:
- rewritten = new TIntermBinary(EOpIndexDirect, rewritten, indexNode->getRight());
+ *rewritten = new TIntermBinary(EOpIndexDirect, *rewritten, indexNode->getRight());
break;
case EOpIndexIndirect:
@@ -262,7 +294,7 @@ TIntermTyped *RewriteModifiedStructFieldSelectionExpression(
TIntermTyped *indexExpression = indexNode->getRight();
RewriteIndexExpression(compiler, indexExpression, structureMap, structureUniformMap,
extractedSamplers);
- rewritten = new TIntermBinary(EOpIndexIndirect, rewritten, indexExpression);
+ *rewritten = new TIntermBinary(EOpIndexIndirect, *rewritten, indexExpression);
break;
}
@@ -272,7 +304,7 @@ TIntermTyped *RewriteModifiedStructFieldSelectionExpression(
}
}
- return rewritten;
+ return true;
}
class RewriteStructSamplersTraverser final : public TIntermTraverser
@@ -281,7 +313,8 @@ class RewriteStructSamplersTraverser final : public TIntermTraverser
explicit RewriteStructSamplersTraverser(TCompiler *compiler, TSymbolTable *symbolTable)
: TIntermTraverser(true, false, false, symbolTable),
mCompiler(compiler),
- mRemovedUniformsCount(0)
+ mRemovedUniformsCount(0),
+ mUnsupportedError(false)
{}
int removedUniformsCount() const { return mRemovedUniformsCount; }
@@ -344,8 +377,11 @@ class RewriteStructSamplersTraverser final : public TIntermTraverser
// Same implementation as in RewriteExpressionTraverser. That traverser cannot replace root.
bool visitBinary(Visit visit, TIntermBinary *node) override
{
- TIntermTyped *rewritten = RewriteExpressionVisitBinaryHelper(
- mCompiler, node, mStructureMap, mStructureUniformMap, mExtractedSamplers);
+ TIntermTyped *rewritten = nullptr;
+ if (!RewriteExpressionVisitBinaryHelper(mCompiler, node, mStructureMap, mStructureUniformMap, mExtractedSamplers, &rewritten))
+ {
+ mUnsupportedError = true;
+ }
if (rewritten == nullptr)
{
@@ -369,6 +405,8 @@ class RewriteStructSamplersTraverser final : public TIntermTraverser
}
}
+ bool hasUnsupportedError() const { return mUnsupportedError; }
+
private:
bool isActiveUniform(const ImmutableString &rootStructureName)
{
@@ -635,6 +673,10 @@ class RewriteStructSamplersTraverser final : public TIntermTraverser
// Caches the names of all inactive uniforms.
TSet<ImmutableString> *mActiveUniforms = nullptr;
+
+ // FIXME: Used to communicate that an error occurred during the rewrite process that is currently not
+ // supported so that a failure can be returned to callers of sh::RewriteStructSamplers().
+ bool mUnsupportedError;
};
} // anonymous namespace
@@ -645,6 +687,8 @@ bool RewriteStructSamplers(TCompiler *compiler,
{
RewriteStructSamplersTraverser traverser(compiler, symbolTable);
root->traverse(&traverser);
+ if (traverser.hasUnsupportedError())
+ return false;
*removedUniformsCountOut = traverser.removedUniformsCount();
return traverser.updateTree(compiler, root);
}
diff --git a/src/compiler/translator/tree_ops/msl/RewriteUnaddressableReferences.cpp b/src/compiler/translator/tree_ops/msl/RewriteUnaddressableReferences.cpp
index 609f7a1f1e3bd96b2c0eb9188354bb207ec76f7c..31602d0cc4e5439a58c86db645667d2f78a11f0f 100644
--- a/src/compiler/translator/tree_ops/msl/RewriteUnaddressableReferences.cpp
+++ b/src/compiler/translator/tree_ops/msl/RewriteUnaddressableReferences.cpp
@@ -135,17 +135,10 @@ bool ReturnsReference(TOperator op)
case TOperator::EOpBitwiseAndAssign:
case TOperator::EOpBitwiseXorAssign:
case TOperator::EOpBitwiseOrAssign:
-
- case TOperator::EOpPostIncrement:
- case TOperator::EOpPostDecrement:
- case TOperator::EOpPreIncrement:
- case TOperator::EOpPreDecrement:
-
case TOperator::EOpIndexDirect:
case TOperator::EOpIndexIndirect:
case TOperator::EOpIndexDirectStruct:
case TOperator::EOpIndexDirectInterfaceBlock:
-
return true;
default:
@@ -153,6 +146,28 @@ bool ReturnsReference(TOperator op)
}
}
+bool IsLValueUnaryOp(TOperator op)
+{
+ switch (op)
+ {
+ case EOpPostIncrement:
+ case EOpPostDecrement:
+ case EOpPreIncrement:
+ case EOpPreDecrement:
+ return true;
+ case EOpNegative:
+ case EOpPositive:
+ case EOpLogicalNot:
+ case EOpBitwiseNot:
+ case EOpArrayLength:
+ return false;
+ default:
+ break;
+ }
+ // At the time, we cannot use UNREACHABLE(); because builtin function calls might be unary ops.
+ return false;
+}
+
TIntermTyped &DecomposeCompoundAssignment(TIntermBinary &node)
{
TOperator op = node.getOp();
@@ -355,6 +370,21 @@ class Rewriter2 : public TIntermRebuild
*new TIntermSequence{&newLeft, &newRight}),
VisitBits::Neither};
}
+
+ PreResult visitUnaryPre(TIntermUnary &node) override
+ {
+ // Unary ++, -- operators for signed ints are implemented as functions. These take in a reference. Addressing is needed to
+ // support swizzles. This can be removed when a pass is added to replace the operators with builtin function calls.
+ bool childRequiresAddressing = IsLValueUnaryOp(node.getOp()) && node.getType().isSignedInt();
+ mRequiresAddressingStack.push_back(childRequiresAddressing);
+ return {node, VisitBits::Both};
+ }
+
+ PostResult visitUnaryPost(TIntermUnary &node) override
+ {
+ mRequiresAddressingStack.pop_back();
+ return {node};
+ }
};
} // anonymous namespace
diff --git a/src/gpu_info_util/SystemInfo_internal.h b/src/gpu_info_util/SystemInfo_internal.h
index 5cef5d49eea1b1f1e6c22543446b2e5391ee88f2..5bfff7a4587126abada2d0a2560fb32cce79bd37 100644
--- a/src/gpu_info_util/SystemInfo_internal.h
+++ b/src/gpu_info_util/SystemInfo_internal.h
@@ -41,11 +41,10 @@ uint64_t GetGpuIDFromDisplayID(uint32_t displayID);
uint64_t GetGpuIDFromOpenGLDisplayMask(uint32_t displayMask);
# endif
-#endif
-
-#if defined(ANGLE_PLATFORM_MACOS) && ANGLE_ENABLE_METAL
+# if ANGLE_ENABLE_METAL
// Get VendorID from metal device's registry ID
VendorID GetVendorIDFromMetalDeviceRegistryID(uint64_t registryID);
+# endif
#endif
diff --git a/src/libANGLE/Context.cpp b/src/libANGLE/Context.cpp
index 9177909b54a4b3bffe10842b4856732443212dab..372619c911eef9d1eb6b255594a15cee57fea076 100644
--- a/src/libANGLE/Context.cpp
+++ b/src/libANGLE/Context.cpp
@@ -9819,6 +9819,33 @@ void Context::textureFoveationParameters(TextureID texturePacked,
texture->setFocalPoint(layer, focalPoint, focalX, focalY, gainX, gainY, foveaArea);
}
+void Context::framebufferResolveRenderbufferWEBKIT(GLenum target,
+ GLenum attachment,
+ GLenum renderbuffertarget,
+ RenderbufferID renderbuffer)
+{
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ Framebuffer *framebuffer = mState.getTargetFramebuffer(target);
+ ASSERT(framebuffer);
+
+ if (renderbuffer.value != 0)
+ {
+ Renderbuffer *renderbufferObject = getRenderbuffer(renderbuffer);
+
+ framebuffer->setAttachmentResolve(this, GL_RENDERBUFFER, attachment, gl::ImageIndex(),
+ renderbufferObject);
+ }
+ else
+ {
+ framebuffer->resetAttachmentResolve(this, attachment);
+ }
+
+ mState.setObjectDirty(target);
+#else
+ UNIMPLEMENTED();
+#endif
+}
+
void Context::endTiling(GLbitfield preserveMask)
{
ANGLE_CONTEXT_TRY(mImplementation->endTiling(this, preserveMask));
@@ -9893,6 +9920,16 @@ void Context::blobCacheCallbacks(GLSETBLOBPROCANGLE set,
mState.getBlobCacheCallbacks() = {set, get, userParam};
}
+void Context::bindMetalRasterizationRateMap(GLuint renderbufferHandle,
+ GLMTLRasterizationRateMapANGLE map)
+{
+ Renderbuffer *renderbuffer = getRenderbuffer({renderbufferHandle});
+ rx::RenderbufferImpl *renderbufferImpl =
+ renderbuffer ? renderbuffer->getImplementation() : nullptr;
+ ANGLE_CONTEXT_TRY(mImplementation->bindMetalRasterizationRateMap(this, renderbufferImpl, map));
+ getMutablePrivateState()->setVariableRasterizationRateMap(map);
+}
+
void Context::texStorageAttribs2D(GLenum target,
GLsizei levels,
GLenum internalFormat,
diff --git a/src/libANGLE/Context_gles_ext_autogen.h b/src/libANGLE/Context_gles_ext_autogen.h
index a0923c528a0d1fd1bc3bdc6d64ea7794ecdf5a98..8bb23339bf5748b7bfdf8c51a8643ab7040ddd7e 100644
--- a/src/libANGLE/Context_gles_ext_autogen.h
+++ b/src/libANGLE/Context_gles_ext_autogen.h
@@ -652,6 +652,8 @@
void invalidateTexture(TextureType targetPacked); \
/* GL_ANGLE_texture_multisample */ \
/* GL_ANGLE_texture_rectangle */ \
+ /* GL_ANGLE_variable_rasterization_rate_metal */ \
+ void bindMetalRasterizationRateMap(GLuint framebuffer, GLMTLRasterizationRateMapANGLE map); \
/* GL_ANGLE_vulkan_image */ \
void acquireTextures(GLuint numTextures, const TextureID *texturesPacked, \
const GLenum *layouts); \
@@ -678,6 +680,10 @@
GLboolean unpackUnmultiplyAlpha); \
/* GL_CHROMIUM_framebuffer_mixed_samples */ \
/* GL_CHROMIUM_lose_context */ \
- void loseContext(GraphicsResetStatus currentPacked, GraphicsResetStatus otherPacked);
+ void loseContext(GraphicsResetStatus currentPacked, GraphicsResetStatus otherPacked); \
+ /* GL_WEBKIT_explicit_resolve_target */ \
+ void framebufferResolveRenderbufferWEBKIT(GLenum target, GLenum attachment, \
+ GLenum renderbuffertarget, \
+ RenderbufferID renderbufferPacked);
#endif // ANGLE_CONTEXT_API_EXT_AUTOGEN_H_
diff --git a/src/libANGLE/Display.cpp b/src/libANGLE/Display.cpp
index a724b259ed2148ecef5e8d28d3988c00c15a2d7d..bcbcf5a9e9b1b6dac20e755d2cf15bd7a4a19723 100644
--- a/src/libANGLE/Display.cpp
+++ b/src/libANGLE/Display.cpp
@@ -2303,7 +2303,7 @@ Error Display::validateImageClientBuffer(const gl::Context *context,
return mImplementation->validateImageClientBuffer(context, target, clientBuffer, attribs);
}
-Error Display::valdiatePixmap(const Config *config,
+Error Display::validatePixmap(const Config *config,
EGLNativePixmapType pixmap,
const AttributeMap &attributes) const
{
diff --git a/src/libANGLE/Display.h b/src/libANGLE/Display.h
index aea0acc7cb8b630ee9092ffde7bfae8e46503b4b..5c6ff476f4f7328a806d159dac0a531b8b5f6431 100644
--- a/src/libANGLE/Display.h
+++ b/src/libANGLE/Display.h
@@ -217,7 +217,7 @@ class Display final : public LabeledObject,
EGLenum target,
EGLClientBuffer clientBuffer,
const egl::AttributeMap &attribs) const;
- Error valdiatePixmap(const Config *config,
+ Error validatePixmap(const Config *config,
EGLNativePixmapType pixmap,
const AttributeMap &attributes) const;
diff --git a/src/libANGLE/Framebuffer.cpp b/src/libANGLE/Framebuffer.cpp
index 624cb4830c6c59d7e165fd048491096e03f5996b..ce0f6bac1d45b2c90221697185a5c56f04bdcae9 100644
--- a/src/libANGLE/Framebuffer.cpp
+++ b/src/libANGLE/Framebuffer.cpp
@@ -171,6 +171,48 @@ FramebufferStatus CheckAttachmentCompleteness(const Context *context,
return FramebufferStatus::Complete();
}
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+// Check the |checkAttachment| in reference to |firstAttachment| for the sake of explicit resolve
+// target framebuffer completeness.
+FramebufferStatus CheckResolveTargetMatchesForCompleteness(
+ const Context *context,
+ const FramebufferAttachment &firstAttachment,
+ const FramebufferAttachment &checkAttachment)
+{
+ ASSERT(firstAttachment.isAttached() && checkAttachment.isAttached());
+
+ FramebufferStatus attachmentCompleteness =
+ CheckAttachmentCompleteness(context, checkAttachment);
+ if (!attachmentCompleteness.isComplete())
+ {
+ return attachmentCompleteness;
+ }
+
+ if (checkAttachment.getSamples() != 0)
+ {
+ return FramebufferStatus::Incomplete(
+ GL_FRAMEBUFFER_UNSUPPORTED,
+ "Framebuffer is incomplete: Resolve attachments have multiple samples.");
+ }
+
+ if (firstAttachment.getSize() != checkAttachment.getSize())
+ {
+ return gl::FramebufferStatus::Incomplete(
+ GL_FRAMEBUFFER_UNSUPPORTED,
+ gl::err::kFramebufferIncompleteUnsupportedMissmatchedDimensions);
+ }
+
+ if (!Format::EquivalentForBlit(firstAttachment.getFormat(), checkAttachment.getFormat()))
+ {
+ return gl::FramebufferStatus::Incomplete(GL_FRAMEBUFFER_UNSUPPORTED,
+ "Framebuffer is incomplete: Attempting to resolve "
+ "to target with non-equivalent format for blit");
+ }
+
+ return FramebufferStatus::Complete();
+}
+#endif
+
FramebufferStatus CheckAttachmentSampleCounts(const Context *context,
GLsizei currAttachmentSamples,
GLsizei samples,
@@ -400,6 +442,9 @@ FramebufferState::FramebufferState(rx::UniqueSerial serial)
mFramebufferSerial(serial),
mLabel(),
mColorAttachments(1),
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ mColorResolveAttachments(1),
+#endif
mColorAttachmentsMask(0),
mDrawBufferStates(1, GL_NONE),
mReadBufferState(GL_BACK),
@@ -423,6 +468,9 @@ FramebufferState::FramebufferState(const Caps &caps, FramebufferID id, rx::Uniqu
mFramebufferSerial(serial),
mLabel(),
mColorAttachments(caps.maxColorAttachments),
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ mColorResolveAttachments(caps.maxColorAttachments),
+#endif
mColorAttachmentsMask(0),
mDrawBufferStates(caps.maxDrawBuffers, GL_NONE),
mReadBufferState(GL_COLOR_ATTACHMENT0_EXT),
@@ -593,6 +641,27 @@ const FramebufferAttachment *FramebufferState::getDepthStencilAttachment() const
return nullptr;
}
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+const FramebufferAttachment *FramebufferState::getColorResolveAttachment(
+ size_t colorAttachment) const
+{
+ ASSERT(colorAttachment < mColorResolveAttachments.size());
+ return mColorResolveAttachments[colorAttachment].isAttached()
+ ? &mColorResolveAttachments[colorAttachment]
+ : nullptr;
+}
+
+const FramebufferAttachment *FramebufferState::getDepthResolveAttachment() const
+{
+ return mDepthResolveAttachment.isAttached() ? &mDepthResolveAttachment : nullptr;
+}
+
+const FramebufferAttachment *FramebufferState::getStencilResolveAttachment() const
+{
+ return mStencilResolveAttachment.isAttached() ? &mStencilResolveAttachment : nullptr;
+}
+#endif
+
const Extents FramebufferState::getAttachmentExtentsIntersection() const
{
int32_t width = std::numeric_limits<int32_t>::max();
@@ -823,6 +892,10 @@ Framebuffer::Framebuffer(const Context *context, rx::GLImplFactory *factory, Fra
ASSERT(mImpl != nullptr);
ASSERT(mState.mColorAttachments.size() ==
static_cast<size_t>(context->getCaps().maxColorAttachments));
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ ASSERT(mState.mColorResolveAttachments.size() ==
+ static_cast<size_t>(context->getCaps().maxColorAttachments));
+#endif
for (uint32_t colorIndex = 0;
colorIndex < static_cast<uint32_t>(mState.mColorAttachments.size()); ++colorIndex)
@@ -857,6 +930,15 @@ void Framebuffer::onDestroy(const Context *context)
mState.mWebGLStencilAttachment.detach(context, mState.mFramebufferSerial);
mState.mWebGLDepthStencilAttachment.detach(context, mState.mFramebufferSerial);
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ for (auto &attachment : mState.mColorResolveAttachments)
+ {
+ attachment.detach(context, mState.mFramebufferSerial);
+ }
+ mState.mDepthResolveAttachment.detach(context, mState.mFramebufferSerial);
+ mState.mStencilResolveAttachment.detach(context, mState.mFramebufferSerial);
+#endif
+
if (mPixelLocalStorage)
{
mPixelLocalStorage->onFramebufferDestroyed(context);
@@ -1151,6 +1233,23 @@ size_t Framebuffer::getDrawbufferStateCount() const
return mState.mDrawBufferStates.size();
}
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+const FramebufferAttachment *Framebuffer::getColorResolveAttachment(size_t colorAttachment) const
+{
+ return mState.getColorResolveAttachment(colorAttachment);
+}
+
+const FramebufferAttachment *Framebuffer::getDepthResolveAttachment() const
+{
+ return mState.getDepthResolveAttachment();
+}
+
+const FramebufferAttachment *Framebuffer::getStencilResolveAttachment() const
+{
+ return mState.getStencilResolveAttachment();
+}
+#endif
+
GLenum Framebuffer::getDrawBufferState(size_t drawBuffer) const
{
ASSERT(drawBuffer < mState.mDrawBufferStates.size());
@@ -1402,6 +1501,25 @@ FramebufferStatus Framebuffer::checkStatusWithGLFrontEnd(const Context *context)
}
}
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ for (size_t index = 0; index < mState.mColorAttachments.size(); ++index)
+ {
+ const FramebufferAttachment &colorAttachment = mState.mColorAttachments[index];
+ const FramebufferAttachment &colorResolveAttachment =
+ mState.mColorResolveAttachments[index];
+ if (colorResolveAttachment.isAttached() && colorAttachment.isAttached())
+ {
+ FramebufferStatus resolveAttachmentCompleteness =
+ CheckResolveTargetMatchesForCompleteness(context, colorAttachment,
+ colorResolveAttachment);
+ if (!resolveAttachmentCompleteness.isComplete())
+ {
+ return resolveAttachmentCompleteness;
+ }
+ }
+ }
+#endif
+
const FramebufferAttachment &depthAttachment = mState.mDepthAttachment;
if (depthAttachment.isAttached())
{
@@ -1455,6 +1573,20 @@ FramebufferStatus Framebuffer::checkStatusWithGLFrontEnd(const Context *context)
err::kFramebufferIncompleteMismatchedLayeredAttachments);
}
}
+
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ const FramebufferAttachment &depthResolveAttachment = mState.mDepthResolveAttachment;
+ if (depthResolveAttachment.isAttached())
+ {
+ FramebufferStatus resolveAttachmentCompleteness =
+ CheckResolveTargetMatchesForCompleteness(context, depthAttachment,
+ depthResolveAttachment);
+ if (!resolveAttachmentCompleteness.isComplete())
+ {
+ return resolveAttachmentCompleteness;
+ }
+ }
+#endif
}
const FramebufferAttachment &stencilAttachment = mState.mStencilAttachment;
@@ -1510,6 +1642,20 @@ FramebufferStatus Framebuffer::checkStatusWithGLFrontEnd(const Context *context)
err::kFramebufferIncompleteMismatchedLayeredAttachments);
}
}
+
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ const FramebufferAttachment &stencilResolveAttachment = mState.mStencilResolveAttachment;
+ if (stencilResolveAttachment.isAttached())
+ {
+ FramebufferStatus resolveAttachmentCompleteness =
+ CheckResolveTargetMatchesForCompleteness(context, stencilAttachment,
+ stencilResolveAttachment);
+ if (!resolveAttachmentCompleteness.isComplete())
+ {
+ return resolveAttachmentCompleteness;
+ }
+ }
+#endif
}
// Starting from ES 3.0 stencil and depth, if present, should be the same image
@@ -1980,6 +2126,66 @@ void Framebuffer::setAttachmentMultiview(const Context *context,
FramebufferAttachment::kDefaultRenderToTextureSamples);
}
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+void Framebuffer::setAttachmentResolve(const Context *context,
+ GLenum type,
+ GLenum binding,
+ const ImageIndex &textureIndex,
+ FramebufferAttachmentObject *resource)
+{
+ switch (binding)
+ {
+ case GL_DEPTH_STENCIL:
+ case GL_DEPTH_STENCIL_ATTACHMENT:
+ updateAttachmentResolve(context, &mState.mDepthResolveAttachment,
+ DIRTY_BIT_DEPTH_ATTACHMENT, &mDirtyDepthAttachmentBinding, type,
+ binding, textureIndex, resource);
+ updateAttachmentResolve(context, &mState.mStencilResolveAttachment,
+ DIRTY_BIT_STENCIL_ATTACHMENT, &mDirtyStencilAttachmentBinding,
+ type, binding, textureIndex, resource);
+ break;
+ case GL_DEPTH:
+ case GL_DEPTH_ATTACHMENT:
+ updateAttachmentResolve(context, &mState.mDepthResolveAttachment,
+ DIRTY_BIT_DEPTH_ATTACHMENT, &mDirtyDepthAttachmentBinding, type,
+ binding, textureIndex, resource);
+ if (context->isWebGL1())
+ {
+ updateAttachmentResolve(context, &mState.mStencilResolveAttachment,
+ DIRTY_BIT_STENCIL_ATTACHMENT,
+ &mDirtyStencilAttachmentBinding, GL_NONE,
+ GL_STENCIL_ATTACHMENT, ImageIndex(), nullptr);
+ }
+ break;
+
+ case GL_STENCIL:
+ case GL_STENCIL_ATTACHMENT:
+ updateAttachmentResolve(context, &mState.mStencilResolveAttachment,
+ DIRTY_BIT_STENCIL_ATTACHMENT, &mDirtyStencilAttachmentBinding,
+ type, binding, textureIndex, resource);
+ if (context->isWebGL1())
+ {
+ updateAttachmentResolve(context, &mState.mDepthResolveAttachment,
+ DIRTY_BIT_DEPTH_ATTACHMENT, &mDirtyDepthAttachmentBinding,
+ GL_NONE, GL_DEPTH_ATTACHMENT, ImageIndex(), nullptr);
+ }
+ break;
+
+ default:
+ {
+ const size_t colorIndex = binding - GL_COLOR_ATTACHMENT0;
+ ASSERT(colorIndex < mState.mColorResolveAttachments.size());
+
+ const size_t dirtyBit = DIRTY_BIT_COLOR_ATTACHMENT_0 + colorIndex;
+ updateAttachmentResolve(context, &mState.mColorResolveAttachments[colorIndex], dirtyBit,
+ &mDirtyColorAttachmentBindings[colorIndex], type, binding,
+ textureIndex, resource);
+ }
+ break;
+ }
+}
+#endif
+
void Framebuffer::commitWebGL1DepthStencilIfConsistent(const Context *context,
GLsizei numViews,
GLuint baseViewIndex,
@@ -2157,11 +2363,40 @@ void Framebuffer::updateAttachment(const Context *context,
invalidateCompletenessCache();
}
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+void Framebuffer::updateAttachmentResolve(const Context *context,
+ FramebufferAttachment *attachment,
+ size_t dirtyBit,
+ angle::ObserverBinding *onDirtyBinding,
+ GLenum type,
+ GLenum binding,
+ const ImageIndex &textureIndex,
+ FramebufferAttachmentObject *resource)
+{
+ attachment->attach(
+ context, type, binding, textureIndex, resource, FramebufferAttachment::kDefaultNumViews,
+ FramebufferAttachment::kDefaultBaseViewIndex, false,
+ FramebufferAttachment::kDefaultRenderToTextureSamples, mState.mFramebufferSerial);
+ mDirtyBits.set(dirtyBit);
+ onDirtyBinding->bind(resource);
+ mAttachmentChangedAfterEnablingFoveation = isFoveationEnabled();
+
+ invalidateCompletenessCache();
+}
+#endif
+
void Framebuffer::resetAttachment(const Context *context, GLenum binding)
{
setAttachment(context, GL_NONE, binding, ImageIndex(), nullptr);
}
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+void Framebuffer::resetAttachmentResolve(const Context *context, GLenum binding)
+{
+ setAttachmentResolve(context, GL_NONE, binding, ImageIndex(), nullptr);
+}
+#endif
+
void Framebuffer::setWriteControlMode(SrgbWriteControlMode srgbWriteControlMode)
{
if (srgbWriteControlMode != mState.getWriteControlMode())
@@ -2817,4 +3052,5 @@ angle::Result Framebuffer::syncAttachmentState(const Context *context,
return angle::Result::Continue;
}
+
} // namespace gl
diff --git a/src/libANGLE/Framebuffer.h b/src/libANGLE/Framebuffer.h
index 5bb706c9a19c72f8c4c37b9bfc6677851a4ef201..2172770ea95bb3d3a6b4bb6b133bf43cf63564b5 100644
--- a/src/libANGLE/Framebuffer.h
+++ b/src/libANGLE/Framebuffer.h
@@ -82,6 +82,13 @@ class FramebufferState final : angle::NonCopyable
const FramebufferAttachment *getDepthStencilAttachment() const;
const FramebufferAttachment *getReadPixelsAttachment(GLenum readFormat) const;
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ // GL_WEBKIT_explicit_resolve_target
+ const FramebufferAttachment *getColorResolveAttachment(size_t colorAttachment) const;
+ const FramebufferAttachment *getDepthResolveAttachment() const;
+ const FramebufferAttachment *getStencilResolveAttachment() const;
+#endif
+
const DrawBuffersVector<GLenum> &getDrawBufferStates() const { return mDrawBufferStates; }
DrawBufferMask getEnabledDrawBuffers() const { return mEnabledDrawBuffers; }
GLenum getReadBufferState() const { return mReadBufferState; }
@@ -155,6 +162,13 @@ class FramebufferState final : angle::NonCopyable
FramebufferAttachment mDepthAttachment;
FramebufferAttachment mStencilAttachment;
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ // GL_WEBKIT_explicit_resolve_target;
+ DrawBuffersVector<FramebufferAttachment> mColorResolveAttachments;
+ FramebufferAttachment mDepthResolveAttachment;
+ FramebufferAttachment mStencilResolveAttachment;
+#endif
+
// Tracks all the color buffers attached to this FramebufferDesc
DrawBufferMask mColorAttachmentsMask;
@@ -237,6 +251,16 @@ class Framebuffer final : public angle::ObserverInterface,
GLint baseViewIndex);
void resetAttachment(const Context *context, GLenum binding);
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ // GL_WEBKIT_explicit_resolve_target
+ void setAttachmentResolve(const Context *context,
+ GLenum type,
+ GLenum binding,
+ const ImageIndex &textureIndex,
+ FramebufferAttachmentObject *resource);
+ void resetAttachmentResolve(const Context *context, GLenum binding);
+#endif
+
bool detachTexture(Context *context, TextureID texture);
bool detachRenderbuffer(Context *context, RenderbufferID renderbuffer);
@@ -251,9 +275,16 @@ class Framebuffer final : public angle::ObserverInterface,
const FramebufferAttachment *getFirstColorAttachment() const;
const FramebufferAttachment *getFirstNonNullAttachment() const;
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ // GL_WEBKIT_explicit_resolve_target
+ const FramebufferAttachment *getColorResolveAttachment(size_t colorAttachment) const;
+ const FramebufferAttachment *getDepthResolveAttachment() const;
+ const FramebufferAttachment *getStencilResolveAttachment() const;
+#endif
+
const DrawBuffersVector<FramebufferAttachment> &getColorAttachments() const
{
- return mState.mColorAttachments;
+ return mState.getColorAttachments();
}
const FramebufferState &getState() const { return mState; }
@@ -522,6 +553,18 @@ class Framebuffer final : public angle::ObserverInterface,
bool isMultiview,
GLsizei samples);
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ // GL_WEBKIT_explicit_resolve_target
+ void updateAttachmentResolve(const Context *context,
+ FramebufferAttachment *attachment,
+ size_t dirtyBit,
+ angle::ObserverBinding *onDirtyBinding,
+ GLenum type,
+ GLenum binding,
+ const ImageIndex &textureIndex,
+ FramebufferAttachmentObject *resource);
+#endif
+
void markAttachmentsInitialized(const DrawBufferMask &color, bool depth, bool stencil);
// Checks that we have a partially masked clear:
diff --git a/src/libANGLE/State.cpp b/src/libANGLE/State.cpp
index 5270fbb0986e6650e17293602cf15087f16e7097..673570b94d3994109e338a4bf223bebe8aed95ca 100644
--- a/src/libANGLE/State.cpp
+++ b/src/libANGLE/State.cpp
@@ -10,6 +10,9 @@
# pragma allow_unsafe_buffers
#endif
+// Older clang versions have a false positive on this warning here.
+#pragma clang diagnostic ignored "-Wglobal-constructors"
+
#include "libANGLE/State.h"
#include <string.h>
@@ -372,6 +375,8 @@ PrivateState::PrivateState(const Version &clientVersion,
mLogicOp(LogicalOperation::Copy),
mPatchVertices(3),
mPixelLocalStorageActivePlanes(0),
+ mVariableRasterizationRateEnabled(false),
+ mVariableRasterizationRateMap(nullptr),
mNoSimultaneousConstantColorAndAlphaBlendFunc(false),
mSetBlendIndexedInvoked(false),
mSetBlendFactorsIndexedInvoked(false),
@@ -1425,6 +1430,26 @@ void PrivateState::setLogicOp(LogicalOperation opcode)
}
}
+void PrivateState::setVariableRasterizationRateEnabled(bool enabled)
+{
+ if (mVariableRasterizationRateEnabled != enabled)
+ {
+ mVariableRasterizationRateEnabled = enabled;
+ mDirtyBits.set(state::DIRTY_BIT_EXTENDED);
+ mExtendedDirtyBits.set(state::EXTENDED_DIRTY_BIT_VARIABLE_RASTERIZATION_RATE);
+ }
+}
+
+void PrivateState::setVariableRasterizationRateMap(GLMTLRasterizationRateMapANGLE map)
+{
+ if (mVariableRasterizationRateMap != map)
+ {
+ mVariableRasterizationRateMap = map;
+ mDirtyBits.set(state::DIRTY_BIT_EXTENDED);
+ mExtendedDirtyBits.set(state::EXTENDED_DIRTY_BIT_VARIABLE_RASTERIZATION_RATE);
+ }
+}
+
void PrivateState::setVertexAttribf(GLuint index, const GLfloat values[4])
{
ASSERT(static_cast<size_t>(index) < mVertexAttribCurrentValues.size());
@@ -1557,6 +1582,9 @@ void PrivateState::setEnableFeature(GLenum feature, bool enabled)
case GL_FETCH_PER_SAMPLE_ARM:
mFetchPerSample = enabled;
return;
+ case GL_VARIABLE_RASTERIZATION_RATE_ANGLE:
+ setVariableRasterizationRateEnabled(enabled);
+ return;
default:
break;
}
@@ -1723,6 +1751,8 @@ bool PrivateState::getEnableFeature(GLenum feature) const
return mShadingRatePreserveAspectRatio;
case GL_FETCH_PER_SAMPLE_ARM:
return mFetchPerSample;
+ case GL_VARIABLE_RASTERIZATION_RATE_ANGLE:
+ return mVariableRasterizationRateEnabled;
}
ASSERT(mClientVersion < ES_2_0);
@@ -3687,6 +3717,9 @@ void State::getPointerv(const Context *context, GLenum pname, void **params) con
case GL_BLOB_CACHE_USER_PARAM_ANGLE:
*params = const_cast<void *>(getBlobCacheCallbacks().userParam);
break;
+ case GL_METAL_RASTERIZATION_RATE_MAP_BINDING_ANGLE:
+ *params = privateState().getVariableRasterizationRateMap();
+ break;
default:
UNREACHABLE();
break;
diff --git a/src/libANGLE/State.h b/src/libANGLE/State.h
index 6d84b9d5a145e4aaa28ce8c1bcdc615e8f3f2c19..b542c239de79d29adc438a0fdac0b790c96b2a36 100644
--- a/src/libANGLE/State.h
+++ b/src/libANGLE/State.h
@@ -175,6 +175,7 @@ enum ExtendedDirtyBitType
EXTENDED_DIRTY_BIT_LOGIC_OP_ENABLED, // ANGLE_logic_op
EXTENDED_DIRTY_BIT_LOGIC_OP, // ANGLE_logic_op
EXTENDED_DIRTY_BIT_BLEND_ADVANCED_COHERENT, // KHR_blend_operation_advanced_coherent
+ EXTENDED_DIRTY_BIT_VARIABLE_RASTERIZATION_RATE, // ANGLE_variable_rasterization_rate_metal
EXTENDED_DIRTY_BIT_INVALID,
EXTENDED_DIRTY_BIT_MAX = EXTENDED_DIRTY_BIT_INVALID,
@@ -481,6 +482,15 @@ class PrivateState : angle::NonCopyable
bool hasActivelyOverriddenPLSDrawBuffers(GLint *firstActivePLSDrawBuffer) const;
bool isActivelyOverriddenPLSDrawBuffer(GLint drawbuffer) const;
+ // GL_ANGLE_variable_rasterization_rate_metal
+ void setVariableRasterizationRateEnabled(bool enabled);
+ bool isVariableRasterizationRateEnabled() const { return mVariableRasterizationRateEnabled; }
+ void setVariableRasterizationRateMap(GLMTLRasterizationRateMapANGLE map);
+ GLMTLRasterizationRateMapANGLE getVariableRasterizationRateMap() const
+ {
+ return mVariableRasterizationRateMap;
+ }
+
// Line width state setter
void setLineWidth(GLfloat width);
float getLineWidth() const { return mLineWidth; }
@@ -731,6 +741,10 @@ class PrivateState : angle::NonCopyable
DrawBufferMask mPLSDeferredBlendEnables;
BlendStateExt::ColorMaskStorage::Type mPLSDeferredColorMasks;
+ // GL_ANGLE_variable_rasterization_rate_metal
+ bool mVariableRasterizationRateEnabled;
+ GLMTLRasterizationRateMapANGLE mVariableRasterizationRateMap;
+
// GLES1 emulation: state specific to GLES1
GLES1State mGLES1State;
diff --git a/src/libANGLE/TransformFeedback.cpp b/src/libANGLE/TransformFeedback.cpp
index c40804720389aeebc4195a40758fbbc4b3a781c9..bf3d00bc12c7b1c264134263bf383d6410026a8f 100644
--- a/src/libANGLE/TransformFeedback.cpp
+++ b/src/libANGLE/TransformFeedback.cpp
@@ -152,26 +152,7 @@ angle::Result TransformFeedback::begin(const Context *context,
// In one of the angle_unittests - "TransformFeedbackTest.SideEffectsOfStartAndStop"
// there is a code path where <context> is a nullptr, account for that possiblity.
- const ProgramExecutable *programExecutable =
- context ? context->getState().getLinkedProgramExecutable(context) : nullptr;
- if (programExecutable)
- {
- // Compute the number of vertices we can draw before overflowing the bound buffers.
- auto strides = programExecutable->getTransformFeedbackStrides();
- ASSERT(strides.size() <= mState.mIndexedBuffers.size() && !strides.empty());
- GLsizeiptr minCapacity = std::numeric_limits<GLsizeiptr>::max();
- for (size_t index = 0; index < strides.size(); index++)
- {
- GLsizeiptr capacity =
- GetBoundBufferAvailableSize(mState.mIndexedBuffers[index]) / strides[index];
- minCapacity = std::min(minCapacity, capacity);
- }
- mState.mVertexCapacity = minCapacity;
- }
- else
- {
- mState.mVertexCapacity = 0;
- }
+ recomputeVertexCapacity(context);
return angle::Result::Continue;
}
@@ -202,6 +183,7 @@ angle::Result TransformFeedback::resume(const Context *context)
{
ANGLE_TRY(mImplementation->resume(context));
mState.mPaused = false;
+ recomputeVertexCapacity(context);
return angle::Result::Continue;
}
@@ -255,6 +237,31 @@ void TransformFeedback::bindProgram(const Context *context, Program *program)
}
}
+void TransformFeedback::recomputeVertexCapacity(const Context *context)
+{
+ const ProgramExecutable *programExecutable =
+ context ? context->getState().getLinkedProgramExecutable(context) : nullptr;
+ if (programExecutable)
+ {
+ // Compute the number of vertices we can draw before overflowing the bound buffers.
+ auto strides = programExecutable->getTransformFeedbackStrides();
+ ASSERT(strides.size() <= mState.mIndexedBuffers.size() && !strides.empty());
+ GLsizeiptr minCapacity = std::numeric_limits<GLsizeiptr>::max();
+ for (size_t index = 0; index < strides.size(); index++)
+ {
+ GLsizeiptr capacity =
+ GetBoundBufferAvailableSize(mState.mIndexedBuffers[index]) / strides[index];
+ minCapacity = std::min(minCapacity, capacity);
+ }
+ mState.mVertexCapacity = minCapacity;
+ }
+ else
+ {
+ mState.mVertexCapacity = 0;
+ }
+ mState.mVerticesDrawn = std::min(mState.mVerticesDrawn, mState.mVertexCapacity);
+}
+
bool TransformFeedback::hasBoundProgram(ShaderProgramID program) const
{
return mState.mProgram != nullptr && mState.mProgram->id().value == program.value;
diff --git a/src/libANGLE/TransformFeedback.h b/src/libANGLE/TransformFeedback.h
index 0c322217794c7494fabc8b77b4ef9ca205d0851d..9eb347930c88f2a17b6c31a9346543145e148c64 100644
--- a/src/libANGLE/TransformFeedback.h
+++ b/src/libANGLE/TransformFeedback.h
@@ -114,6 +114,7 @@ class TransformFeedback final : public RefCountObject<TransformFeedbackID>, publ
private:
void bindProgram(const Context *context, Program *program);
+ void recomputeVertexCapacity(const Context *context);
TransformFeedbackState mState;
rx::TransformFeedbackImpl *mImplementation;
diff --git a/src/libANGLE/capture/capture_gles_ext_autogen.cpp b/src/libANGLE/capture/capture_gles_ext_autogen.cpp
index 23d8b5de98f53ec6457df4a4ea1dfdf57d075904..72be6f72b4ca2596dd0d5b7abfd9d230f4273c48 100644
--- a/src/libANGLE/capture/capture_gles_ext_autogen.cpp
+++ b/src/libANGLE/capture/capture_gles_ext_autogen.cpp
@@ -5221,6 +5221,20 @@ CallCapture CaptureGetTranslatedShaderSourceANGLE(const State &glState,
return CallCapture(angle::EntryPoint::GLGetTranslatedShaderSourceANGLE, std::move(paramBuffer));
}
+CallCapture CaptureBindMetalRasterizationRateMapANGLE(const State &glState,
+ bool isCallValid,
+ GLuint framebuffer,
+ GLMTLRasterizationRateMapANGLE map)
+{
+ ParamBuffer paramBuffer;
+
+ paramBuffer.addValueParam("framebuffer", ParamType::TGLuint, framebuffer);
+ paramBuffer.addValueParam("map", ParamType::TGLMTLRasterizationRateMapANGLE, map);
+
+ return CallCapture(angle::EntryPoint::GLBindMetalRasterizationRateMapANGLE,
+ std::move(paramBuffer));
+}
+
CallCapture CaptureAcquireTexturesANGLE(const State &glState,
bool isCallValid,
GLuint numTextures,
@@ -12504,4 +12518,23 @@ CallCapture CaptureStartTilingQCOM(const State &glState,
return CallCapture(angle::EntryPoint::GLStartTilingQCOM, std::move(paramBuffer));
}
+CallCapture CaptureFramebufferResolveRenderbufferWEBKIT(const State &glState,
+ bool isCallValid,
+ GLenum target,
+ GLenum attachment,
+ GLenum renderbuffertarget,
+ RenderbufferID renderbufferPacked)
+{
+ ParamBuffer paramBuffer;
+
+ paramBuffer.addEnumParam("target", GLESEnum::AllEnums, ParamType::TGLenum, target);
+ paramBuffer.addEnumParam("attachment", GLESEnum::AllEnums, ParamType::TGLenum, attachment);
+ paramBuffer.addEnumParam("renderbuffertarget", GLESEnum::AllEnums, ParamType::TGLenum,
+ renderbuffertarget);
+ paramBuffer.addValueParam("renderbufferPacked", ParamType::TRenderbufferID, renderbufferPacked);
+
+ return CallCapture(angle::EntryPoint::GLFramebufferResolveRenderbufferWEBKIT,
+ std::move(paramBuffer));
+}
+
} // namespace gl
diff --git a/src/libANGLE/capture/capture_gles_ext_autogen.h b/src/libANGLE/capture/capture_gles_ext_autogen.h
index d397d7c519f0f8b63e5d37e652fcffa61bab6c30..9083b01505e51b9545010211cde29cb71d506af8 100644
--- a/src/libANGLE/capture/capture_gles_ext_autogen.h
+++ b/src/libANGLE/capture/capture_gles_ext_autogen.h
@@ -1007,6 +1007,12 @@ angle::CallCapture CaptureGetTranslatedShaderSourceANGLE(const State &glState,
GLsizei *length,
GLchar *source);
+// GL_ANGLE_variable_rasterization_rate_metal
+angle::CallCapture CaptureBindMetalRasterizationRateMapANGLE(const State &glState,
+ bool isCallValid,
+ GLuint framebuffer,
+ GLMTLRasterizationRateMapANGLE map);
+
// GL_ANGLE_vulkan_image
angle::CallCapture CaptureAcquireTexturesANGLE(const State &glState,
bool isCallValid,
@@ -2960,6 +2966,14 @@ angle::CallCapture CaptureStartTilingQCOM(const State &glState,
GLuint height,
GLbitfield preserveMask);
+// GL_WEBKIT_explicit_resolve_target
+angle::CallCapture CaptureFramebufferResolveRenderbufferWEBKIT(const State &glState,
+ bool isCallValid,
+ GLenum target,
+ GLenum attachment,
+ GLenum renderbuffertarget,
+ RenderbufferID renderbufferPacked);
+
// Parameter Captures
void CaptureDeletePerfMonitorsAMD_monitors(const State &glState,
diff --git a/src/libANGLE/features.h b/src/libANGLE/features.h
index a6fe076c72d043dba3fc347bf020ebf8ec895f51..add46e99c91d19bbd790d2de0d8768b8953d633e 100644
--- a/src/libANGLE/features.h
+++ b/src/libANGLE/features.h
@@ -44,4 +44,11 @@
# define ANGLE_PROGRAM_LINK_VALIDATE_UNIFORM_PRECISION 1
#endif
+// Lose context on Metal command queue error
+// ENABLED check Metal command buffer status on completion for error and lose context on error.
+// DISABLED Metal backed contexts are never lost.
+#if !defined(ANGLE_METAL_LOSE_CONTEXT_ON_ERROR)
+# define ANGLE_METAL_LOSE_CONTEXT_ON_ERROR ANGLE_ENABLED
+#endif
+
#endif // LIBANGLE_FEATURES_H_
diff --git a/src/libANGLE/formatutils.cpp b/src/libANGLE/formatutils.cpp
index 6f70ea77d97617ce80c83781a708817700db5891..70744adf4522f01b9af890bfe7846ffd8905f2d4 100644
--- a/src/libANGLE/formatutils.cpp
+++ b/src/libANGLE/formatutils.cpp
@@ -587,6 +587,7 @@ static GLenum EquivalentBlitInternalFormat(GLenum internalformat)
// multisampled RGBA8 renderbuffer to a BGRA8 texture). This could
// be expanded and/or autogenerated if that is found necessary.
if (internalformat == GL_BGRA_EXT || internalformat == GL_BGRA8_EXT ||
+ internalformat == GL_SRGB8_ALPHA8_EXT || internalformat == GL_BGRA8_EXT ||
internalformat == GL_BGRA8_SRGB_ANGLEX)
{
return GL_RGBA8;
diff --git a/src/libANGLE/gles_extensions_autogen.cpp b/src/libANGLE/gles_extensions_autogen.cpp
index 2f544eb8937bfc843d51434208e2be79b255fe13..57945e4f1e0ac3a21bf3d74435dabc932d5e4139 100644
--- a/src/libANGLE/gles_extensions_autogen.cpp
+++ b/src/libANGLE/gles_extensions_autogen.cpp
@@ -247,6 +247,7 @@ const ExtensionInfoMap &GetExtensionInfoMap()
map["GL_CHROMIUM_copy_compressed_texture"] = esOnlyExtension(&Extensions::copyCompressedTextureCHROMIUM);
map["GL_CHROMIUM_copy_texture"] = esOnlyExtension(&Extensions::copyTextureCHROMIUM);
map["GL_ANGLE_copy_texture_3d"] = enableableExtension(&Extensions::copyTexture3dANGLE);
+ map["GL_WEBKIT_explicit_resolve_target"] = enableableExtension(&Extensions::explicitResolveTargetWEBKIT);
map["GL_CHROMIUM_framebuffer_mixed_samples"] = esOnlyExtension(&Extensions::framebufferMixedSamplesCHROMIUM);
map["GL_ANGLE_framebuffer_multisample"] = enableableExtension(&Extensions::framebufferMultisampleANGLE);
map["GL_ANGLE_get_image"] = enableableExtension(&Extensions::getImageANGLE);
@@ -283,6 +284,7 @@ const ExtensionInfoMap &GetExtensionInfoMap()
map["GL_ANGLE_texture_external_update"] = enableableExtension(&Extensions::textureExternalUpdateANGLE);
map["GL_ANGLE_texture_multisample"] = enableableExtension(&Extensions::textureMultisampleANGLE);
map["GL_ANGLE_texture_rectangle"] = enableableExtension(&Extensions::textureRectangleANGLE);
+ map["GL_ANGLE_variable_rasterization_rate_metal"] = enableableExtension(&Extensions::variableRasterizationRateMetalANGLE);
map["GL_ANGLE_vulkan_image"] = enableableExtension(&Extensions::vulkanImageANGLE);
map["GL_ANGLE_webgl_compatibility"] = esOnlyExtension(&Extensions::webglCompatibilityANGLE);
map["GL_ANGLE_yuv_internal_format"] = enableableExtension(&Extensions::yuvInternalFormatANGLE);
diff --git a/src/libANGLE/gles_extensions_autogen.h b/src/libANGLE/gles_extensions_autogen.h
index e72c3f283236bc0ced7d01149ffc79a089290bbb..19b436c6f27a7ea647e3f012bd67f9029451e83d 100644
--- a/src/libANGLE/gles_extensions_autogen.h
+++ b/src/libANGLE/gles_extensions_autogen.h
@@ -701,6 +701,9 @@ struct Extensions
// GL_ANGLE_copy_texture_3d
bool copyTexture3dANGLE = false;
+ // GL_WEBKIT_explicit_resolve_target
+ bool explicitResolveTargetWEBKIT = false;
+
// GL_CHROMIUM_framebuffer_mixed_samples
bool framebufferMixedSamplesCHROMIUM = false;
@@ -809,6 +812,9 @@ struct Extensions
// GL_ANGLE_texture_rectangle
bool textureRectangleANGLE = false;
+ // GL_ANGLE_variable_rasterization_rate_metal
+ bool variableRasterizationRateMetalANGLE = false;
+
// GL_ANGLE_vulkan_image
bool vulkanImageANGLE = false;
diff --git a/src/libANGLE/renderer/ContextImpl.cpp b/src/libANGLE/renderer/ContextImpl.cpp
index 8b4a1de3939adf39d1199a35ca2ee97fbd415700..b09e5c64576579d99c07709726ef3272d66dfa63 100644
--- a/src/libANGLE/renderer/ContextImpl.cpp
+++ b/src/libANGLE/renderer/ContextImpl.cpp
@@ -115,4 +115,13 @@ const angle::ShadingRateMap &ContextImpl::getSupportedFragmentShadingRateEXTSamp
static angle::ShadingRateMap empty;
return empty;
}
+
+angle::Result ContextImpl::bindMetalRasterizationRateMap(gl::Context *,
+ RenderbufferImpl *renderbuffer,
+ GLMTLRasterizationRateMapANGLE map)
+{
+ UNREACHABLE();
+ return angle::Result::Stop;
+}
+
} // namespace rx
diff --git a/src/libANGLE/renderer/ContextImpl.h b/src/libANGLE/renderer/ContextImpl.h
index 6ead468ab44287e7e02ff6cff9c8a5bc6dc5b453..b6b017138b69b2dd88f1d17370ba37e225636dab 100644
--- a/src/libANGLE/renderer/ContextImpl.h
+++ b/src/libANGLE/renderer/ContextImpl.h
@@ -282,6 +282,11 @@ class ContextImpl : public GLImplFactory
// AMD_performance_monitor
virtual const angle::PerfMonitorCounterGroups &getPerfMonitorCounters();
+ // GL_ANGLE_variable_rasterization_rate_metal
+ virtual angle::Result bindMetalRasterizationRateMap(gl::Context *,
+ RenderbufferImpl *renderbuffer,
+ GLMTLRasterizationRateMapANGLE map);
+
protected:
const gl::State &mState;
gl::MemoryProgramCache *mMemoryProgramCache;
diff --git a/src/libANGLE/renderer/DisplayImpl.cpp b/src/libANGLE/renderer/DisplayImpl.cpp
index 8b4573f4d9dccfbeaccedfb8f6f07fb1ad1dc3f3..bf46443c7ed5449ffb31348a433e9c89ff99511c 100644
--- a/src/libANGLE/renderer/DisplayImpl.cpp
+++ b/src/libANGLE/renderer/DisplayImpl.cpp
@@ -102,7 +102,7 @@ egl::Error DisplayImpl::validatePixmap(const egl::Config *config,
const egl::AttributeMap &attributes) const
{
UNREACHABLE();
- return egl::Error(EGL_BAD_DISPLAY, "DisplayImpl::valdiatePixmap unimplemented.");
+ return egl::Error(EGL_BAD_DISPLAY, "DisplayImpl::validatePixmap unimplemented.");
}
const egl::Caps &DisplayImpl::getCaps() const
diff --git a/src/libANGLE/renderer/gl/FunctionsGL.cpp b/src/libANGLE/renderer/gl/FunctionsGL.cpp
index 7b6aa2a7a1f66dd8c06353959823d23dd17ae9c4..6798c79869bea01ee270764c234d7d216336bb3a 100644
--- a/src/libANGLE/renderer/gl/FunctionsGL.cpp
+++ b/src/libANGLE/renderer/gl/FunctionsGL.cpp
@@ -55,7 +55,11 @@ static std::vector<std::string> GetIndexedExtensions(PFNGLGETINTEGERVPROC getInt
for (GLint i = 0; i < numExtensions; i++)
{
- result.push_back(reinterpret_cast<const char *>(getStringIFunction(GL_EXTENSIONS, i)));
+ if (const char *extensionString =
+ reinterpret_cast<const char *>(getStringIFunction(GL_EXTENSIONS, i)))
+ {
+ result.push_back(extensionString);
+ }
}
return result;
diff --git a/src/libANGLE/renderer/gl/StateManagerGL.cpp b/src/libANGLE/renderer/gl/StateManagerGL.cpp
index 06f5faae870d706e748a5d66c75a19faf2ac21a8..0a7878520c8bf9602e91bc7b8c6916152a7c28e3 100644
--- a/src/libANGLE/renderer/gl/StateManagerGL.cpp
+++ b/src/libANGLE/renderer/gl/StateManagerGL.cpp
@@ -2517,6 +2517,9 @@ angle::Result StateManagerGL::syncState(const gl::Context *context,
case gl::state::EXTENDED_DIRTY_BIT_BLEND_ADVANCED_COHERENT:
setBlendAdvancedCoherent(state.isBlendAdvancedCoherentEnabled());
break;
+ case gl::state::EXTENDED_DIRTY_BIT_VARIABLE_RASTERIZATION_RATE:
+ // Unimplemented extensions.
+ break;
default:
UNREACHABLE();
break;
diff --git a/src/libANGLE/renderer/metal/BUILD.gn b/src/libANGLE/renderer/metal/BUILD.gn
index 96e9ee8420810f6a3ca9a0c290d4a654200eb7b9..8725219587ee8afc25e803bfd84f0fb117176372 100644
--- a/src/libANGLE/renderer/metal/BUILD.gn
+++ b/src/libANGLE/renderer/metal/BUILD.gn
@@ -15,7 +15,10 @@ assert(is_mac || is_ios)
assert(angle_enable_metal)
config("angle_metal_backend_config") {
- defines = [ "ANGLE_ENABLE_METAL" ]
+ defines = [
+ "ANGLE_ENABLE_METAL",
+ "ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED=1",
+ ]
ldflags = [
"-weak_framework",
"Metal",
diff --git a/src/libANGLE/renderer/metal/BufferMtl.mm b/src/libANGLE/renderer/metal/BufferMtl.mm
index 6ffe10c8a32092fc878bc54c2dfa57dca48a831a..cdcdd54b065aadc728417fe2f34a079f0b01a1fb 100644
--- a/src/libANGLE/renderer/metal/BufferMtl.mm
+++ b/src/libANGLE/renderer/metal/BufferMtl.mm
@@ -404,7 +404,7 @@ ConversionBufferMtl *BufferMtl::getUniformConversionBuffer(ContextMtl *context,
{
if (buffer.offset.second <= offset.second &&
(offset.second - buffer.offset.second) % buffer.uniformBufferBlockSize == 0)
- return &buffer;
+ return static_cast<ConversionBufferMtl *>(&buffer);
}
}
diff --git a/src/libANGLE/renderer/metal/ContextMtl.h b/src/libANGLE/renderer/metal/ContextMtl.h
index b9e9defcfc7710f28bb486f8dbd60430fabf758d..c2e93b49f666b52d88488c1893ee135958a21cbe 100644
--- a/src/libANGLE/renderer/metal/ContextMtl.h
+++ b/src/libANGLE/renderer/metal/ContextMtl.h
@@ -273,6 +273,10 @@ class ContextMtl : public ContextImpl, public mtl::Context
angle::Result memoryBarrier(const gl::Context *context, GLbitfield barriers) override;
angle::Result memoryBarrierByRegion(const gl::Context *context, GLbitfield barriers) override;
+ angle::Result bindMetalRasterizationRateMap(gl::Context *context,
+ RenderbufferImpl *renderbuffer,
+ GLMTLRasterizationRateMapANGLE map) override;
+
// override mtl::ErrorHandler
void handleError(GLenum error,
const char *message,
@@ -556,6 +560,7 @@ class ContextMtl : public ContextImpl, public mtl::Context
DIRTY_BIT_RENDER_PIPELINE,
DIRTY_BIT_UNIFORM_BUFFERS_BINDING,
DIRTY_BIT_RASTERIZER_DISCARD,
+ DIRTY_BIT_VARIABLE_RASTERIZATION_RATE,
DIRTY_BIT_INVALID,
DIRTY_BIT_MAX = DIRTY_BIT_INVALID,
@@ -649,6 +654,9 @@ class ContextMtl : public ContextImpl, public mtl::Context
IncompleteTextureSet mIncompleteTextures;
ProvokingVertexHelper mProvokingVertexHelper;
+ angle::ObjCPtr<id<MTLRasterizationRateMap>> mRasterizationRateMap;
+ id<MTLTexture> mRasterizationRateMapTexture;
+
mtl::ContextDevice mContextDevice;
};
diff --git a/src/libANGLE/renderer/metal/ContextMtl.mm b/src/libANGLE/renderer/metal/ContextMtl.mm
index 7fb29be9b780121a8026686d0cc408aadbe87a11..c0386f638df63962854624c09b2f274ec28350fa 100644
--- a/src/libANGLE/renderer/metal/ContextMtl.mm
+++ b/src/libANGLE/renderer/metal/ContextMtl.mm
@@ -250,6 +250,8 @@ void ContextMtl::onDestroy(const gl::Context *context)
mIncompleteTextures.onDestroy(context);
mProvokingVertexHelper.onDestroy(this);
mDummyXFBRenderTexture = nullptr;
+ mRasterizationRateMap.reset();
+ mRasterizationRateMapTexture = nil;
mContextDevice.reset();
}
@@ -1060,6 +1062,13 @@ angle::Result ContextMtl::multiDrawElementsInstancedBaseVertexBaseInstance(
// Device loss
gl::GraphicsResetStatus ContextMtl::getResetStatus()
{
+#if ANGLE_METAL_LOSE_CONTEXT_ON_ERROR == ANGLE_ENABLED
+ if (cmdQueue().isDeviceLost())
+ {
+ return gl::GraphicsResetStatus::UnknownContextReset;
+ }
+#endif
+
return gl::GraphicsResetStatus::NoError;
}
@@ -1398,6 +1407,9 @@ void ContextMtl::updateExtendedState(const gl::State &glState,
case gl::state::EXTENDED_DIRTY_BIT_POLYGON_OFFSET_LINE_ENABLED:
mDirtyBits.set(DIRTY_BIT_DEPTH_BIAS);
break;
+ case gl::state::EXTENDED_DIRTY_BIT_VARIABLE_RASTERIZATION_RATE:
+ mDirtyBits.set(DIRTY_BIT_VARIABLE_RASTERIZATION_RATE);
+ break;
default:
break;
}
@@ -1653,6 +1665,37 @@ angle::Result ContextMtl::memoryBarrierByRegion(const gl::Context *context, GLbi
return angle::Result::Stop;
}
+angle::Result ContextMtl::bindMetalRasterizationRateMap(gl::Context *context,
+ RenderbufferImpl *renderbuffer,
+ GLMTLRasterizationRateMapANGLE map)
+{
+ id<MTLRasterizationRateMap> rateMap = (__bridge id<MTLRasterizationRateMap>)(map);
+ if (rateMap && rateMap.device != mContextDevice.get())
+ {
+ return angle::Result::Stop;
+ }
+
+ if (auto *metalRenderbuffer = static_cast<RenderbufferMtl *>(renderbuffer))
+ {
+ FramebufferAttachmentRenderTarget *rtOut = nullptr;
+ gl::ImageIndex index;
+ GLenum binding = 0;
+ if (angle::Result::Continue ==
+ metalRenderbuffer->getAttachmentRenderTarget(context, binding, index, 1, &rtOut))
+ {
+ if (auto *renderTargetMetal = static_cast<RenderTargetMtl *>(rtOut))
+ {
+ mtl::RenderPassAttachmentDesc desc;
+ renderTargetMetal->toRenderPassAttachmentDesc(&desc);
+ mRasterizationRateMapTexture = desc.texture.get()->get();
+ }
+ }
+ }
+
+ mRasterizationRateMap = std::move(rateMap);
+ return angle::Result::Continue;
+}
+
// override mtl::ErrorHandler
void ContextMtl::handleError(GLenum glErrorCode,
const char *message,
@@ -2501,8 +2544,22 @@ angle::Result ContextMtl::setupDraw(const gl::Context *context,
return checkCommandBufferError();
}
// Setup with flushed state should either produce a working encoder or fail with an error
- // result.
- ASSERT(mRenderEncoder.valid());
+ // result. if that's not the case, something's gone seriously wrong. Try to
+ // recover from the error by bailing out of the draw call, and finishing the command buffer.
+ // This will result in an unfinished / corrupted draw, but will avoid a browser/GPU process
+ // crash.
+ if (ANGLE_UNLIKELY(!mRenderEncoder.valid() || !mRenderEncoder.hasPipelineState()))
+ {
+ // Completely flush the command buffer, waiting synchronously.
+ flushCommandBuffer(mtl::WaitUntilFinished);
+ // Invalidate all state
+ invalidateState(context);
+ // Return fail, and drop the draw call. This is
+ // a worst case scenario. If in a debug roots situation,
+ // we should try to catch the call stack.
+ ERR() << "Draw call is unusable - please report a bug on bugs.webkit.org";
+ return angle::Result::Stop;
+ }
}
return angle::Result::Continue;
}
@@ -2611,10 +2668,14 @@ angle::Result ContextMtl::setupDrawImpl(const gl::Context *context,
mState.getBlendColor().blue, mState.getBlendColor().alpha);
break;
case DIRTY_BIT_VIEWPORT:
- mRenderEncoder.setViewport(mViewport);
+ mRenderEncoder.setViewport(
+ mViewport, mRenderEncoder.rasterizationRateMapForPass(
+ mRasterizationRateMap, mRasterizationRateMapTexture));
break;
case DIRTY_BIT_SCISSOR:
- mRenderEncoder.setScissorRect(mScissorRect);
+ mRenderEncoder.setScissorRect(
+ mScissorRect, mRenderEncoder.rasterizationRateMapForPass(
+ mRasterizationRateMap, mRasterizationRateMapTexture));
break;
case DIRTY_BIT_DRAW_FRAMEBUFFER:
// Already handled.
@@ -2639,6 +2700,15 @@ angle::Result ContextMtl::setupDrawImpl(const gl::Context *context,
case DIRTY_BIT_RASTERIZER_DISCARD:
// Already handled.
break;
+ case DIRTY_BIT_VARIABLE_RASTERIZATION_RATE:
+ if (getState().privateState().isVariableRasterizationRateEnabled() &&
+ mRasterizationRateMap)
+ {
+ mRenderEncoder.setRasterizationRateMap(
+ mRenderEncoder.rasterizationRateMapForPass(mRasterizationRateMap,
+ mRasterizationRateMapTexture));
+ }
+ break;
default:
UNREACHABLE();
break;
diff --git a/src/libANGLE/renderer/metal/DisplayMtl.h b/src/libANGLE/renderer/metal/DisplayMtl.h
index c8b8ac3a69962eca7b567814167a86a5e8871a25..f601b886205b02975a9240fa8b8c8a3c23d836ea 100644
--- a/src/libANGLE/renderer/metal/DisplayMtl.h
+++ b/src/libANGLE/renderer/metal/DisplayMtl.h
@@ -140,6 +140,7 @@ class DisplayMtl : public DisplayImpl
bool supportsDepth24Stencil8PixelFormat() const;
bool supports32BitFloatFiltering() const;
bool supportsBCTextureCompression() const;
+ bool supportsVariableRasterizationRate() const;
bool isAMD() const;
bool isAMDBronzeDriver() const;
bool isAMDFireProDevice() const;
diff --git a/src/libANGLE/renderer/metal/DisplayMtl.mm b/src/libANGLE/renderer/metal/DisplayMtl.mm
index 84094329d83b54df93f1a7ad2154e3c26018acd3..a37c875a415bfe5dc2b72f42393dcf48b3c3e509 100644
--- a/src/libANGLE/renderer/metal/DisplayMtl.mm
+++ b/src/libANGLE/renderer/metal/DisplayMtl.mm
@@ -180,12 +180,22 @@ void DisplayMtl::terminate()
bool DisplayMtl::testDeviceLost()
{
+#if ANGLE_METAL_LOSE_CONTEXT_ON_ERROR == ANGLE_ENABLED
+ return mCmdQueue.isDeviceLost();
+#else
return false;
+#endif
}
egl::Error DisplayMtl::restoreLostDevice(const egl::Display *display)
{
+#if ANGLE_METAL_LOSE_CONTEXT_ON_ERROR == ANGLE_ENABLED
+ // A Metal device cannot be restored, the entire context would have to be
+ // re-created along with any other EGL objects that reference it.
+ return egl::Error(EGL_BAD_DISPLAY);
+#else
return egl::NoError();
+#endif
}
std::string DisplayMtl::getRendererDescription()
@@ -1130,6 +1140,15 @@ void DisplayMtl::initializeExtensions() const
mNativeCaps.maxImageUnits = gl::IMPLEMENTATION_MAX_PIXEL_LOCAL_STORAGE_PLANES;
}
}
+
+ // GL_ANGLE_variable_rasterization_rate_metal
+ mNativeExtensions.variableRasterizationRateMetalANGLE =
+ mFeatures.hasVariableRasterizationRate.enabled;
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ // GL_WEBKIT_explicit_resolve_target
+ mNativeExtensions.explicitResolveTargetWEBKIT = true;
+#endif
+
// "The GPUs in Apple3 through Apple8 families only support memory barriers for compute command
// encoders, and for vertex-to-vertex and vertex-to-fragment stages of render command encoders."
mHasFragmentMemoryBarriers = !supportsAppleGPUFamily(3);
@@ -1201,6 +1220,8 @@ void DisplayMtl::initializeFeatures()
ANGLE_FEATURE_CONDITION((&mFeatures), hasExplicitMemBarrier, (isOSX || isCatalyst) && !isARM);
ANGLE_FEATURE_CONDITION((&mFeatures), hasDepthAutoResolve, supportsEitherGPUFamily(3, 2));
ANGLE_FEATURE_CONDITION((&mFeatures), hasStencilAutoResolve, supportsEitherGPUFamily(5, 2));
+ ANGLE_FEATURE_CONDITION((&mFeatures), hasVariableRasterizationRate,
+ supportsVariableRasterizationRate());
ANGLE_FEATURE_CONDITION((&mFeatures), allowMultisampleStoreAndResolve,
supportsEitherGPUFamily(3, 1));
@@ -1391,6 +1412,17 @@ bool DisplayMtl::supportsDepth24Stencil8PixelFormat() const
return false;
#endif
}
+
+bool DisplayMtl::supportsVariableRasterizationRate() const
+{
+ if (@available(ios 13.0, macOS 10.15.4, macCatalyst 13.4, tvOS 16.0, *))
+ {
+ return [mMetalDevice supportsRasterizationRateMapWithLayerCount:1];
+ }
+
+ return false;
+}
+
bool DisplayMtl::isAMD() const
{
return angle::IsAMD(mMetalDeviceVendorId);
diff --git a/src/libANGLE/renderer/metal/FrameBufferMtl.h b/src/libANGLE/renderer/metal/FrameBufferMtl.h
index 84e5326b7270f29630d2c353a6ebadb5d10b6a21..0afffbbb5ad7f3961d49addf1f74d44bd1312e95 100644
--- a/src/libANGLE/renderer/metal/FrameBufferMtl.h
+++ b/src/libANGLE/renderer/metal/FrameBufferMtl.h
@@ -211,6 +211,14 @@ class FramebufferMtl : public FramebufferImpl
angle::FixedVector<RenderTargetMtl *, mtl::kMaxRenderTargets> mColorRenderTargets;
RenderTargetMtl *mDepthRenderTarget = nullptr;
RenderTargetMtl *mStencilRenderTarget = nullptr;
+
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ // GL_WEBKIT_explicit_resolve_target
+ angle::FixedVector<RenderTargetMtl *, mtl::kMaxRenderTargets> mColorResolveRenderTargets;
+ RenderTargetMtl *mDepthResolveRenderTarget = nullptr;
+ RenderTargetMtl *mStencilResolveRenderTarget = nullptr;
+#endif
+
mtl::RenderPassDesc mRenderPassDesc;
const mtl::Format *mRenderPassFirstColorAttachmentFormat = nullptr;
diff --git a/src/libANGLE/renderer/metal/FrameBufferMtl.mm b/src/libANGLE/renderer/metal/FrameBufferMtl.mm
index 41115775407bbd37101f9fa304c8c06e39e0367f..b016de77eb8704e26be220a35c8ba35f9485b656 100644
--- a/src/libANGLE/renderer/metal/FrameBufferMtl.mm
+++ b/src/libANGLE/renderer/metal/FrameBufferMtl.mm
@@ -132,6 +132,9 @@ angle::Result Copy2DTextureSlice0Level0ToTempTexture(const gl::Context *context,
FramebufferMtl::FramebufferMtl(const gl::FramebufferState &state, ContextMtl *context, bool flipY)
: FramebufferImpl(state),
mColorRenderTargets(context->getNativeCaps().maxColorAttachments, nullptr),
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ mColorResolveRenderTargets(context->getNativeCaps().maxColorAttachments, nullptr),
+#endif
mBackbuffer(nullptr),
mFlipY(flipY)
{
@@ -148,6 +151,14 @@ void FramebufferMtl::reset()
}
mDepthRenderTarget = mStencilRenderTarget = nullptr;
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ for (auto &rt : mColorResolveRenderTargets)
+ {
+ rt = nullptr;
+ }
+ mDepthResolveRenderTarget = mStencilResolveRenderTarget = nullptr;
+#endif
+
mRenderPassFirstColorAttachmentFormat = nullptr;
mReadPixelBuffer = nullptr;
@@ -947,7 +958,7 @@ void FramebufferMtl::setLoadStoreActionOnRenderPassFirstStart(
attachment.loadAction = MTLLoadActionLoad;
}
- if (attachment.hasImplicitMSTexture())
+ if (attachment.hasResolveTexture())
{
attachment.storeAction = MTLStoreActionStoreAndMultisampleResolve;
}
@@ -1014,22 +1025,47 @@ angle::Result FramebufferMtl::updateColorRenderTarget(const gl::Context *context
ASSERT(colorIndexGL < mColorRenderTargets.size());
// Reset load store action
mRenderPassDesc.colorAttachments[colorIndexGL].reset();
- return updateCachedRenderTarget(context, mState.getColorAttachment(colorIndexGL),
- &mColorRenderTargets[colorIndexGL]);
+ ANGLE_TRY(updateCachedRenderTarget(context, mState.getColorAttachment(colorIndexGL),
+ &mColorRenderTargets[colorIndexGL]));
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ if (mState.getColorResolveAttachment(colorIndexGL))
+ {
+ ANGLE_TRY(updateCachedRenderTarget(context, mState.getColorResolveAttachment(colorIndexGL),
+ &mColorResolveRenderTargets[colorIndexGL]));
+ }
+#endif
+ return angle::Result::Continue;
}
angle::Result FramebufferMtl::updateDepthRenderTarget(const gl::Context *context)
{
// Reset load store action
mRenderPassDesc.depthAttachment.reset();
- return updateCachedRenderTarget(context, mState.getDepthAttachment(), &mDepthRenderTarget);
+ ANGLE_TRY(updateCachedRenderTarget(context, mState.getDepthAttachment(), &mDepthRenderTarget));
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ if (mState.getDepthResolveAttachment())
+ {
+ ANGLE_TRY(updateCachedRenderTarget(context, mState.getDepthResolveAttachment(),
+ &mDepthResolveRenderTarget));
+ }
+#endif
+ return angle::Result::Continue;
}
angle::Result FramebufferMtl::updateStencilRenderTarget(const gl::Context *context)
{
// Reset load store action
mRenderPassDesc.stencilAttachment.reset();
- return updateCachedRenderTarget(context, mState.getStencilAttachment(), &mStencilRenderTarget);
+ ANGLE_TRY(
+ updateCachedRenderTarget(context, mState.getStencilAttachment(), &mStencilRenderTarget));
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ if (mState.getStencilResolveAttachment())
+ {
+ ANGLE_TRY(updateCachedRenderTarget(context, mState.getStencilResolveAttachment(),
+ &mStencilResolveRenderTarget));
+ }
+#endif
+ return angle::Result::Continue;
}
angle::Result FramebufferMtl::updateCachedRenderTarget(const gl::Context *context,
@@ -1071,6 +1107,9 @@ angle::Result FramebufferMtl::prepareRenderPass(const gl::Context *context,
mtl::RenderPassColorAttachmentDesc &colorAttachment = desc.colorAttachments[colorIndexGL];
const RenderTargetMtl *colorRenderTarget = mColorRenderTargets[colorIndexGL];
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ const RenderTargetMtl *colorResolveRenderTarget = mColorResolveRenderTargets[colorIndexGL];
+#endif
// GL allows data types of fragment shader color outputs to be incompatible with disabled
// color attachments. To prevent various Metal validation issues, assign textures only to
@@ -1078,6 +1117,12 @@ angle::Result FramebufferMtl::prepareRenderPass(const gl::Context *context,
if (colorRenderTarget && enabledDrawBuffers.test(colorIndexGL))
{
colorRenderTarget->toRenderPassAttachmentDesc(&colorAttachment);
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ if (colorResolveRenderTarget)
+ {
+ colorResolveRenderTarget->toRenderPassResolveAttachmentDesc(&colorAttachment);
+ }
+#endif
desc.numColorAttachments = std::max(desc.numColorAttachments, colorIndexGL + 1);
desc.rasterSampleCount =
@@ -1107,6 +1152,12 @@ angle::Result FramebufferMtl::prepareRenderPass(const gl::Context *context,
if (mDepthRenderTarget)
{
mDepthRenderTarget->toRenderPassAttachmentDesc(&desc.depthAttachment);
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ if (mDepthResolveRenderTarget)
+ {
+ mDepthResolveRenderTarget->toRenderPassResolveAttachmentDesc(&desc.depthAttachment);
+ }
+#endif
desc.rasterSampleCount =
std::max(desc.rasterSampleCount, mDepthRenderTarget->getRenderSamples());
}
@@ -1118,6 +1169,12 @@ angle::Result FramebufferMtl::prepareRenderPass(const gl::Context *context,
if (mStencilRenderTarget)
{
mStencilRenderTarget->toRenderPassAttachmentDesc(&desc.stencilAttachment);
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ if (mStencilResolveRenderTarget)
+ {
+ mStencilResolveRenderTarget->toRenderPassResolveAttachmentDesc(&desc.stencilAttachment);
+ }
+#endif
desc.rasterSampleCount =
std::max(desc.rasterSampleCount, mStencilRenderTarget->getRenderSamples());
}
@@ -1192,7 +1249,7 @@ angle::Result FramebufferMtl::clearWithLoadOpRenderPassNotStarted(
colorAttachment.loadAction = MTLLoadActionLoad;
}
- if (colorAttachment.hasImplicitMSTexture())
+ if (colorAttachment.hasResolveTexture())
{
colorAttachment.storeAction = MTLStoreActionStoreAndMultisampleResolve;
}
@@ -1212,7 +1269,7 @@ angle::Result FramebufferMtl::clearWithLoadOpRenderPassNotStarted(
tempDesc.depthAttachment.loadAction = MTLLoadActionLoad;
}
- if (tempDesc.depthAttachment.hasImplicitMSTexture())
+ if (tempDesc.depthAttachment.hasResolveTexture())
{
tempDesc.depthAttachment.storeAction = MTLStoreActionStoreAndMultisampleResolve;
}
@@ -1231,7 +1288,7 @@ angle::Result FramebufferMtl::clearWithLoadOpRenderPassNotStarted(
tempDesc.stencilAttachment.loadAction = MTLLoadActionLoad;
}
- if (tempDesc.stencilAttachment.hasImplicitMSTexture())
+ if (tempDesc.stencilAttachment.hasResolveTexture())
{
tempDesc.stencilAttachment.storeAction = MTLStoreActionStoreAndMultisampleResolve;
}
@@ -1469,31 +1526,54 @@ angle::Result FramebufferMtl::invalidateImpl(const gl::Context *context,
}
}
- mtl::RenderPassColorAttachmentDesc &colorAttachment =
- mRenderPassDesc.colorAttachments[i];
+ // If the invalidated color buffer has an associated resolve target
+ // then resolve the MSAA samples, otherwise discard the data.
+ auto &colorAttachment = mRenderPassDesc.colorAttachments[i];
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ auto *resolveRenderTarget = mColorResolveRenderTargets[i];
+ colorAttachment.storeAction =
+ resolveRenderTarget ? MTLStoreActionMultisampleResolve : MTLStoreActionDontCare;
+#else
colorAttachment.storeAction = MTLStoreActionDontCare;
+#endif
if (renderPassStarted)
{
- encoder->setColorStoreAction(MTLStoreActionDontCare, i);
+ encoder->setColorStoreAction(colorAttachment.storeAction, i);
}
}
}
if (invalidateDepthBuffer && mDepthRenderTarget)
{
- mRenderPassDesc.depthAttachment.storeAction = MTLStoreActionDontCare;
+ // If the invalidated depth buffer has an associated resolve target then
+ // resolve the MSAA samples, otherwise discard the data.
+ auto &depthAttachment = mRenderPassDesc.depthAttachment;
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ depthAttachment.storeAction =
+ mDepthResolveRenderTarget ? MTLStoreActionMultisampleResolve : MTLStoreActionDontCare;
+#else
+ depthAttachment.storeAction = MTLStoreActionDontCare;
+#endif
if (renderPassStarted)
{
- encoder->setDepthStoreAction(MTLStoreActionDontCare);
+ encoder->setDepthStoreAction(depthAttachment.storeAction);
}
}
if (invalidateStencilBuffer && mStencilRenderTarget)
{
- mRenderPassDesc.stencilAttachment.storeAction = MTLStoreActionDontCare;
+ // If the invalidated stencil buffer has an associated resolve target
+ // then resolve the MSAA samples, otherwise discard the data.
+ auto &stencilAttachment = mRenderPassDesc.stencilAttachment;
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ stencilAttachment.storeAction =
+ mStencilResolveRenderTarget ? MTLStoreActionMultisampleResolve : MTLStoreActionDontCare;
+#else
+ stencilAttachment.storeAction = MTLStoreActionDontCare;
+#endif
if (renderPassStarted)
{
- encoder->setStencilStoreAction(MTLStoreActionDontCare);
+ encoder->setStencilStoreAction(stencilAttachment.storeAction);
}
}
@@ -1679,7 +1759,8 @@ angle::Result FramebufferMtl::readPixelsToPBO(const gl::Context *context,
ContextMtl *contextMtl = mtl::GetImpl(context);
ANGLE_CHECK_GL_MATH(contextMtl,
- packPixelsParams.offset <= std::numeric_limits<uint32_t>::max());
+ static_cast<std::make_unsigned_t<decltype(packPixelsParams.offset)>>(
+ packPixelsParams.offset) <= std::numeric_limits<uint32_t>::max());
uint32_t offset = static_cast<uint32_t>(packPixelsParams.offset);
BufferMtl *packBufferMtl = mtl::GetImpl(packPixelsParams.packBuffer);
@@ -1827,9 +1908,8 @@ angle::Result FramebufferMtl::unresolveIfNeeded(const gl::Context *context,
const mtl::RenderPassColorAttachmentDesc &colorAttachment =
renderPassDesc.colorAttachments[colorIndexGL];
- if (colorAttachment.loadAction != MTLLoadActionLoad ||
- !colorAttachment.hasImplicitMSTexture() ||
- !colorAttachment.implicitMSTexture->shouldNotLoadStore())
+ if (colorAttachment.loadAction != MTLLoadActionLoad || !colorAttachment.texture ||
+ !colorAttachment.texture->shouldNotLoadStore())
{
continue;
}
@@ -1837,9 +1917,9 @@ angle::Result FramebufferMtl::unresolveIfNeeded(const gl::Context *context,
const angle::Format &angleFormat = colorRenderTarget->getFormat().actualAngleFormat();
// Blit the resolve texture to the MS texture.
- colorBlitParams.src = colorAttachment.texture;
- colorBlitParams.srcLevel = colorAttachment.level;
- colorBlitParams.srcLayer = colorAttachment.sliceOrDepth;
+ colorBlitParams.src = colorAttachment.resolveTexture;
+ colorBlitParams.srcLevel = colorAttachment.resolveLevel;
+ colorBlitParams.srcLayer = colorAttachment.resolveSliceOrDepth;
colorBlitParams.enabledBuffers.reset();
colorBlitParams.enabledBuffers.set(colorIndexGL);
@@ -1854,19 +1934,18 @@ angle::Result FramebufferMtl::unresolveIfNeeded(const gl::Context *context,
mtl::DepthStencilBlitParams dsBlitParams;
dsBlitParams.BlitParams::operator=(baseParams);
const mtl::RenderPassDepthAttachmentDesc &depthAttachment = renderPassDesc.depthAttachment;
- if (depthAttachment.loadAction == MTLLoadActionLoad && depthAttachment.hasImplicitMSTexture() &&
- depthAttachment.implicitMSTexture->shouldNotLoadStore())
+ if (depthAttachment.loadAction == MTLLoadActionLoad && depthAttachment.texture &&
+ depthAttachment.texture->shouldNotLoadStore())
{
- dsBlitParams.src = depthAttachment.texture;
- dsBlitParams.srcLevel = depthAttachment.level;
- dsBlitParams.srcLayer = depthAttachment.sliceOrDepth;
+ dsBlitParams.src = depthAttachment.resolveTexture;
+ dsBlitParams.srcLevel = depthAttachment.resolveLevel;
+ dsBlitParams.srcLayer = depthAttachment.resolveSliceOrDepth;
}
const mtl::RenderPassStencilAttachmentDesc &stencilAttachment =
renderPassDesc.stencilAttachment;
- if (stencilAttachment.loadAction == MTLLoadActionLoad &&
- stencilAttachment.hasImplicitMSTexture() &&
- stencilAttachment.implicitMSTexture->shouldNotLoadStore())
+ if (stencilAttachment.loadAction == MTLLoadActionLoad && stencilAttachment.texture &&
+ stencilAttachment.texture->shouldNotLoadStore())
{
if (mState.hasSeparateDepthAndStencilAttachments())
{
@@ -1876,9 +1955,9 @@ angle::Result FramebufferMtl::unresolveIfNeeded(const gl::Context *context,
dsBlitParams.src = nullptr;
}
- dsBlitParams.srcStencil = stencilAttachment.texture->getStencilView();
- dsBlitParams.srcLevel = stencilAttachment.level;
- dsBlitParams.srcLayer = stencilAttachment.sliceOrDepth;
+ dsBlitParams.srcStencil = stencilAttachment.resolveTexture->getStencilView();
+ dsBlitParams.srcLevel = stencilAttachment.resolveLevel;
+ dsBlitParams.srcLayer = stencilAttachment.resolveSliceOrDepth;
}
if (dsBlitParams.src || dsBlitParams.srcStencil)
diff --git a/src/libANGLE/renderer/metal/ImageMtl.mm b/src/libANGLE/renderer/metal/ImageMtl.mm
index 29f8f59906801cf6218a1517f9b749ce0b1e1d3e..fe46dfb83c88da315557aba10b607eac21b94ce3 100644
--- a/src/libANGLE/renderer/metal/ImageMtl.mm
+++ b/src/libANGLE/renderer/metal/ImageMtl.mm
@@ -86,7 +86,9 @@ egl::Error TextureImageSiblingMtl::ValidateClientBuffer(const DisplayMtl *displa
return egl::Error(EGL_BAD_ATTRIBUTE, "Unrecognized format");
}
- if (format.metalFormat != texture.pixelFormat)
+ angle::FormatID srcAngleFormatId = mtl::Format::MetalToAngleFormatID(texture.pixelFormat);
+ const mtl::Format &srcFormat = display->getPixelFormat(srcAngleFormatId);
+ if (!format.isViewCompatible(srcFormat))
{
return egl::Error(EGL_BAD_ATTRIBUTE, "Incompatible format");
}
@@ -123,18 +125,19 @@ angle::Result TextureImageSiblingMtl::initImpl(DisplayMtl *displayMtl)
{
mNativeTexture = mtl::Texture::MakeFromMetal((__bridge id<MTLTexture>)(mBuffer));
- if (mNativeTexture->textureType() == MTLTextureType2DArray)
+ angle::FormatID angleFormatId = intendedFormatForMTLTexture(mNativeTexture->get(), mAttribs);
+ mFormat = displayMtl->getPixelFormat(angleFormatId);
+
+ if (mNativeTexture->textureType() == MTLTextureType2DArray ||
+ mNativeTexture->pixelFormat() != mFormat.metalFormat)
{
mtl::TextureRef baseTexture = std::move(mNativeTexture);
unsigned textureArraySlice =
static_cast<unsigned>(mAttribs.getAsInt(EGL_METAL_TEXTURE_ARRAY_SLICE_ANGLE, 0));
- mNativeTexture =
- baseTexture->createSliceMipView(textureArraySlice, mtl::kZeroNativeMipLevel);
+ mNativeTexture = baseTexture->createSliceMipViewWithCompatibleFormat(
+ textureArraySlice, mtl::kZeroNativeMipLevel, mFormat.metalFormat);
}
- angle::FormatID angleFormatId = intendedFormatForMTLTexture(mNativeTexture->get(), mAttribs);
- mFormat = displayMtl->getPixelFormat(angleFormatId);
-
if (mNativeTexture)
{
size_t resourceSize = EstimateTextureSizeInBytes(
diff --git a/src/libANGLE/renderer/metal/ProgramExecutableMtl.mm b/src/libANGLE/renderer/metal/ProgramExecutableMtl.mm
index 9eddf9f163d0985d89eedac5af09d266c86efafa..6d2ccd768127d4c3b5e9553f84b08dfc7cf73270 100644
--- a/src/libANGLE/renderer/metal/ProgramExecutableMtl.mm
+++ b/src/libANGLE/renderer/metal/ProgramExecutableMtl.mm
@@ -881,7 +881,7 @@ angle::Result ProgramExecutableMtl::setupDraw(const gl::Context *glContext,
{
ContextMtl *context = mtl::GetImpl(glContext);
- if (pipelineDescChanged)
+ if (pipelineDescChanged || !cmdEncoder->hasPipelineState())
{
id<MTLFunction> vertexShader = nil;
ANGLE_TRY(
diff --git a/src/libANGLE/renderer/metal/RenderTargetMtl.h b/src/libANGLE/renderer/metal/RenderTargetMtl.h
index 281085bbc46eb7d96dabf73b9c75ee0a61125bab..a07218bc78473252b0b2b9e561ec74799959177e 100644
--- a/src/libANGLE/renderer/metal/RenderTargetMtl.h
+++ b/src/libANGLE/renderer/metal/RenderTargetMtl.h
@@ -51,6 +51,9 @@ class RenderTargetMtl final : public FramebufferAttachmentRenderTarget
const mtl::Format &getFormat() const { return mFormat; }
void toRenderPassAttachmentDesc(mtl::RenderPassAttachmentDesc *rpaDescOut) const;
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ void toRenderPassResolveAttachmentDesc(mtl::RenderPassAttachmentDesc *rpaDescOut) const;
+#endif
private:
mtl::TextureWeakRef mTexture;
diff --git a/src/libANGLE/renderer/metal/RenderTargetMtl.mm b/src/libANGLE/renderer/metal/RenderTargetMtl.mm
index 18e62da867b2916085794ba3b68ee4a3812d3929..6cbf2a58812184edb425d11689bdbce5574917f0 100644
--- a/src/libANGLE/renderer/metal/RenderTargetMtl.mm
+++ b/src/libANGLE/renderer/metal/RenderTargetMtl.mm
@@ -73,10 +73,33 @@ uint32_t RenderTargetMtl::getRenderSamples() const
void RenderTargetMtl::toRenderPassAttachmentDesc(mtl::RenderPassAttachmentDesc *rpaDescOut) const
{
- rpaDescOut->texture = mTexture.lock();
- rpaDescOut->implicitMSTexture = mImplicitMSTexture.lock();
+ mtl::TextureRef implicitMSTex = getImplicitMSTexture();
+ mtl::TextureRef tex = getTexture();
+ if (implicitMSTex)
+ {
+ rpaDescOut->texture = implicitMSTex;
+ rpaDescOut->resolveTexture = tex;
+ rpaDescOut->resolveLevel = mLevelIndex;
+ rpaDescOut->resolveSliceOrDepth = mLayerIndex;
+ }
+ else
+ {
+ rpaDescOut->texture = tex;
rpaDescOut->level = mLevelIndex;
rpaDescOut->sliceOrDepth = mLayerIndex;
+ }
rpaDescOut->blendable = mFormat.getCaps().blendable;
}
+
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+void RenderTargetMtl::toRenderPassResolveAttachmentDesc(
+ mtl::RenderPassAttachmentDesc *rpaDescOut) const
+{
+ ASSERT(!getImplicitMSTexture());
+ ASSERT(getRenderSamples() == 1);
+ rpaDescOut->resolveTexture = getTexture();
+ rpaDescOut->resolveLevel = mLevelIndex;
+ rpaDescOut->resolveSliceOrDepth = mLayerIndex;
+}
+#endif
} // namespace rx
diff --git a/src/libANGLE/renderer/metal/SurfaceMtl.mm b/src/libANGLE/renderer/metal/SurfaceMtl.mm
index e57fb5018b02aede76376ae68f119fe777d5d2c8..ae55c29a36b1601308808bea4c01cb9094c677ce 100644
--- a/src/libANGLE/renderer/metal/SurfaceMtl.mm
+++ b/src/libANGLE/renderer/metal/SurfaceMtl.mm
@@ -672,8 +672,9 @@ angle::Result WindowSurfaceMtl::obtainNextDrawable(const gl::Context *context)
}
mColorTextureInitialized = false;
- ANGLE_MTL_LOG("Current metal drawable size=%d,%d", mColorTexture->width(),
- mColorTexture->height());
+ ANGLE_MTL_LOG("Current metal drawable size=%d,%d",
+ mColorTexture->width(mtl::MipmapNativeLevel(0)),
+ mColorTexture->height(mtl::MipmapNativeLevel(0)));
// Now we have to resize depth stencil buffers if required.
ANGLE_TRY(ensureCompanionTexturesSizeCorrect(context));
diff --git a/src/libANGLE/renderer/metal/TextureMtl.h b/src/libANGLE/renderer/metal/TextureMtl.h
index 65283cdb644bb5b2bb2ded12addafaf7d4b78c3d..bb473e9e88c73ab2504a21f37df1da3eb6da179b 100644
--- a/src/libANGLE/renderer/metal/TextureMtl.h
+++ b/src/libANGLE/renderer/metal/TextureMtl.h
@@ -313,7 +313,7 @@ class TextureMtl : public TextureImpl
const uint8_t *pixels,
const ImageDefinitionMtl &imageDef);
- // Convert pixels to suported format before uploading to texture
+ // Convert pixels to supported format before uploading to texture.
angle::Result convertAndSetPerSliceSubImage(const gl::Context *context,
int slice,
const MTLRegion &mtlArea,
diff --git a/src/libANGLE/renderer/metal/VertexArrayMtl.mm b/src/libANGLE/renderer/metal/VertexArrayMtl.mm
index b887f5c2dfce5dcc04480660dc8884bb52eeb559..274588cb3d78eaefa26868f0b47cb4615093fece 100644
--- a/src/libANGLE/renderer/metal/VertexArrayMtl.mm
+++ b/src/libANGLE/renderer/metal/VertexArrayMtl.mm
@@ -1080,16 +1080,27 @@ angle::Result VertexArrayMtl::convertVertexBufferGPU(const gl::Context *glContex
ANGLE_TRY(conversion->data.allocate(contextMtl, numVertices * targetStride, nullptr, &newBuffer,
&newBufferOffset));
- ANGLE_CHECK_GL_MATH(contextMtl, binding.getOffset() <= std::numeric_limits<uint32_t>::max());
+ GLintptr bindingOffset = binding.getOffset();
+
+ if constexpr (sizeof(bindingOffset) > sizeof(uint32_t))
+ {
+ ANGLE_CHECK_GL_MATH(contextMtl, static_cast<std::make_unsigned_t<decltype(bindingOffset)>>(
+ bindingOffset) <= std::numeric_limits<uint32_t>::max());
+ }
ANGLE_CHECK_GL_MATH(contextMtl, newBufferOffset <= std::numeric_limits<uint32_t>::max());
ANGLE_CHECK_GL_MATH(contextMtl, numVertices <= std::numeric_limits<uint32_t>::max());
mtl::VertexFormatConvertParams params;
VertexConversionBufferMtl *vertexConversion =
static_cast<VertexConversionBufferMtl *>(conversion);
+ if constexpr (sizeof(vertexConversion->offset) > sizeof(uint32_t))
+ {
+ ANGLE_CHECK_GL_MATH(contextMtl,
+ vertexConversion->offset <= std::numeric_limits<uint32_t>::max());
+ }
params.srcBuffer = srcBuffer->getCurrentBuffer();
- params.srcBufferStartOffset = static_cast<uint32_t>(
- MIN(static_cast<GLintptr>(vertexConversion->offset), binding.getOffset()));
+ params.srcBufferStartOffset = std::min(static_cast<uint32_t>(vertexConversion->offset),
+ static_cast<uint32_t>(bindingOffset));
params.srcStride = binding.getStride();
params.srcDefaultAlphaData = convertedFormat.defaultAlpha;
diff --git a/src/libANGLE/renderer/metal/mtl_command_buffer.h b/src/libANGLE/renderer/metal/mtl_command_buffer.h
index f0eed119c63cf7607771b8c53ec55db3dddcb70c..000d134075badc39959fb98e8471b7e72466cd17 100644
--- a/src/libANGLE/renderer/metal/mtl_command_buffer.h
+++ b/src/libANGLE/renderer/metal/mtl_command_buffer.h
@@ -122,6 +122,8 @@ class CommandQueue final : public WrappedObject<id<MTLCommandQueue>>, angle::Non
double getTimeElapsedEntryInSeconds(uint64_t id);
MTLCommandBufferError popCmdBufferError() { return mCmdBufferError.pop(); }
+ bool isDeviceLost() const { return mIsDeviceLost; }
+
private:
void onCommandBufferCompleted(id<MTLCommandBuffer> buf,
uint64_t serial,
@@ -166,6 +168,8 @@ class CommandQueue final : public WrappedObject<id<MTLCommandQueue>>, angle::Non
void recordCommandBufferTimeElapsed(std::lock_guard<std::mutex> &lg,
uint64_t id,
double seconds);
+
+ std::atomic_bool mIsDeviceLost = false;
};
class CommandBuffer final : public WrappedObject<id<MTLCommandBuffer>>, angle::NonCopyable
@@ -440,8 +444,9 @@ class RenderCommandEncoder final : public CommandEncoder
RenderCommandEncoder &setStencilRefVals(uint32_t frontRef, uint32_t backRef);
RenderCommandEncoder &setStencilRefVal(uint32_t ref);
- RenderCommandEncoder &setViewport(const MTLViewport &viewport);
- RenderCommandEncoder &setScissorRect(const MTLScissorRect &rect);
+ RenderCommandEncoder &setViewport(const MTLViewport &viewport, id<MTLRasterizationRateMap> map);
+ RenderCommandEncoder &setScissorRect(const MTLScissorRect &rect,
+ id<MTLRasterizationRateMap> map);
RenderCommandEncoder &setBlendColor(float r, float g, float b, float a);
@@ -590,6 +595,8 @@ class RenderCommandEncoder final : public CommandEncoder
RenderCommandEncoder &setDepthLoadAction(MTLLoadAction action, double clearValue);
RenderCommandEncoder &setStencilLoadAction(MTLLoadAction action, uint32_t clearValue);
+ RenderCommandEncoder &setRasterizationRateMap(id<MTLRasterizationRateMap> map);
+
void setLabel(NSString *label);
void pushDebugGroup(NSString *label) override;
@@ -597,8 +604,11 @@ class RenderCommandEncoder final : public CommandEncoder
const RenderPassDesc &renderPassDesc() const { return mRenderPassDesc; }
bool hasDrawCalls() const { return mHasDrawCalls; }
+ bool hasPipelineState() const { return mPipelineStateSet; }
uint64_t getSerial() const { return mSerial; }
+ id<MTLRasterizationRateMap> rasterizationRateMapForPass(id<MTLRasterizationRateMap> map,
+ id<MTLTexture> colorTexture) const;
private:
// Override CommandEncoder
diff --git a/src/libANGLE/renderer/metal/mtl_command_buffer.mm b/src/libANGLE/renderer/metal/mtl_command_buffer.mm
index 913099d6f15adba261837de721a56774310b4c93..301b16efe2b8543edced6daf153a46df9e7ddfd7 100644
--- a/src/libANGLE/renderer/metal/mtl_command_buffer.mm
+++ b/src/libANGLE/renderer/metal/mtl_command_buffer.mm
@@ -651,6 +651,18 @@ void CommandQueue::onCommandBufferCompleted(id<MTLCommandBuffer> buf,
<< error.localizedDescription.UTF8String;
mCmdBufferError.store(static_cast<MTLCommandBufferError>(error.code));
}
+ MTLCommandBufferStatus status = buf.status;
+ if (status != MTLCommandBufferStatusCompleted)
+ {
+ // MTLCommandBufferErrorNotPermitted is non-fatal, all other errors
+ // result in device lost.
+ // TODO(djg): Should this also check error.domain for MTLCommandBufferErrorDomain?
+ mIsDeviceLost = !error || error.code != MTLCommandBufferErrorNotPermitted;
+ if (mIsDeviceLost)
+ {
+ return;
+ }
+ }
if (timeElapsedEntry != 0)
{
@@ -1365,6 +1377,7 @@ void RenderCommandEncoder::reset()
CommandEncoder::reset();
mRecording = false;
mPipelineStateSet = false;
+ setRasterizationRateMap(nil);
mCommands.clear();
}
@@ -1400,7 +1413,7 @@ bool RenderCommandEncoder::finalizeLoadStoreAction(
}
// Check if we need to disable MTLLoadActionLoad & MTLStoreActionStore
- mtl::TextureRef mainTextureRef = cppRenderPassAttachment.getImplicitMSTextureIfAvailOrTexture();
+ mtl::TextureRef mainTextureRef = cppRenderPassAttachment.texture;
ASSERT(mainTextureRef->get() == objCRenderPassAttachment.texture);
if (mainTextureRef->shouldNotLoadStore())
{
@@ -1544,13 +1557,13 @@ void RenderCommandEncoder::endEncodingImpl(bool considerDiscardSimulation)
inline void RenderCommandEncoder::initAttachmentWriteDependencyAndScissorRect(
const RenderPassAttachmentDesc &attachment)
{
- TextureRef texture = attachment.texture;
+ auto texture = attachment.hasResolveTexture() ? attachment.resolveTexture : attachment.texture;
+ auto &mipLevel = attachment.hasResolveTexture() ? attachment.resolveLevel : attachment.level;
+
if (texture)
{
cmdBuffer().setWriteDependency(texture, /*isRenderCommand=*/true);
- const MipmapNativeLevel &mipLevel = attachment.level;
-
mRenderPassMaxScissorRect.width =
std::min<NSUInteger>(mRenderPassMaxScissorRect.width, texture->width(mipLevel));
mRenderPassMaxScissorRect.height =
@@ -1828,7 +1841,8 @@ RenderCommandEncoder &RenderCommandEncoder::setStencilRefVal(uint32_t ref)
return setStencilRefVals(ref, ref);
}
-RenderCommandEncoder &RenderCommandEncoder::setViewport(const MTLViewport &viewport)
+RenderCommandEncoder &RenderCommandEncoder::setViewport(const MTLViewport &viewport,
+ id<MTLRasterizationRateMap> map)
{
if (mStateCache.viewport.valid() && mStateCache.viewport.value() == viewport)
{
@@ -1841,12 +1855,25 @@ RenderCommandEncoder &RenderCommandEncoder::setViewport(const MTLViewport &viewp
return *this;
}
-RenderCommandEncoder &RenderCommandEncoder::setScissorRect(const MTLScissorRect &rect)
+RenderCommandEncoder &RenderCommandEncoder::setScissorRect(const MTLScissorRect &rect,
+ id<MTLRasterizationRateMap> map)
{
+ auto maxScissorRect =
+ MTLCoordinate2DMake(mRenderPassMaxScissorRect.width, mRenderPassMaxScissorRect.height);
+
+ if (map)
+ {
+ maxScissorRect = [map mapPhysicalToScreenCoordinates:maxScissorRect forLayer:0];
+ if (!(rect.width * rect.height))
+ {
+ return *this;
+ }
+ }
+
NSUInteger clampedWidth =
- rect.x > mRenderPassMaxScissorRect.width ? 0 : mRenderPassMaxScissorRect.width - rect.x;
+ rect.x > maxScissorRect.x ? 0 : (NSUInteger)ceilf(maxScissorRect.x) - rect.x;
NSUInteger clampedHeight =
- rect.y > mRenderPassMaxScissorRect.height ? 0 : mRenderPassMaxScissorRect.height - rect.y;
+ rect.y > maxScissorRect.y ? 0 : (NSUInteger)ceilf(maxScissorRect.y) - rect.y;
MTLScissorRect clampedRect = {rect.x, rect.y, std::min(rect.width, clampedWidth),
std::min(rect.height, clampedHeight)};
@@ -1858,6 +1885,23 @@ RenderCommandEncoder &RenderCommandEncoder::setScissorRect(const MTLScissorRect
mStateCache.scissorRect = clampedRect;
+ if (map)
+ {
+ auto adjustedOrigin =
+ [map mapPhysicalToScreenCoordinates:MTLCoordinate2DMake(clampedRect.x, clampedRect.y)
+ forLayer:0];
+ auto adjustedSize =
+ [map mapPhysicalToScreenCoordinates:MTLCoordinate2DMake(clampedRect.width,
+ clampedRect.height)
+ forLayer:0];
+
+ clampedRect.x = (NSUInteger)roundf(adjustedOrigin.x);
+ clampedRect.y = (NSUInteger)roundf(adjustedOrigin.y);
+ MTLSize screenSize = [map screenSize];
+ clampedRect.width = std::min(screenSize.width, static_cast<NSUInteger>(roundf(adjustedSize.x)));
+ clampedRect.height = std::min(screenSize.height, static_cast<NSUInteger>(roundf(adjustedSize.y)));
+ }
+
mCommands.push(CmdType::SetScissorRect).push(clampedRect);
return *this;
@@ -2263,6 +2307,20 @@ void RenderCommandEncoder::popDebugGroup()
mCommands.push(CmdType::PopDebugGroup);
}
+id<MTLRasterizationRateMap> RenderCommandEncoder::rasterizationRateMapForPass(
+ id<MTLRasterizationRateMap> map,
+ id<MTLTexture> texture) const
+{
+ if (!mCachedRenderPassDescObjC.get())
+ {
+ return nil;
+ }
+
+ MTLSize size = [map physicalSizeForLayer:0];
+ id<MTLTexture> t = mCachedRenderPassDescObjC.get().colorAttachments[0].texture;
+ return t.width == size.width && t.height == size.height ? map : nil;
+}
+
RenderCommandEncoder &RenderCommandEncoder::setColorStoreAction(MTLStoreAction action,
uint32_t colorAttachmentIndex)
{
@@ -2358,6 +2416,16 @@ RenderCommandEncoder &RenderCommandEncoder::setStencilLoadAction(MTLLoadAction a
return *this;
}
+RenderCommandEncoder &RenderCommandEncoder::setRasterizationRateMap(id<MTLRasterizationRateMap> map)
+{
+ if (map != mCachedRenderPassDescObjC.get().rasterizationRateMap)
+ {
+ mCachedRenderPassDescObjC.get().rasterizationRateMap = map;
+ }
+
+ return *this;
+}
+
void RenderCommandEncoder::setLabel(NSString *label)
{
mLabel = std::move(label);
diff --git a/src/libANGLE/renderer/metal/mtl_format_utils.h b/src/libANGLE/renderer/metal/mtl_format_utils.h
index db95298598177500cebd0eb81cfcb845656031b2..8cbd1014b7dd9c2886272df3ae0923ccec49b512 100644
--- a/src/libANGLE/renderer/metal/mtl_format_utils.h
+++ b/src/libANGLE/renderer/metal/mtl_format_utils.h
@@ -89,6 +89,10 @@ struct Format : public FormatBase
// Need conversion between source format and this format?
bool needConversion(angle::FormatID srcFormatId) const;
+ // Are the formats view compatible without requiring
+ // MTLTextureUsagePixelFormatView?
+ bool isViewCompatible(const Format &srcFormat) const;
+
MTLPixelFormat metalFormat = MTLPixelFormatInvalid;
LoadFunctionMap textureLoadFunctions = nullptr;
diff --git a/src/libANGLE/renderer/metal/mtl_format_utils.mm b/src/libANGLE/renderer/metal/mtl_format_utils.mm
index 193b445b8d699e650b80669ab017a9601bb31eb2..33d78f5582e644816278baaedce7a44840d208e1 100644
--- a/src/libANGLE/renderer/metal/mtl_format_utils.mm
+++ b/src/libANGLE/renderer/metal/mtl_format_utils.mm
@@ -165,6 +165,34 @@ bool Format::needConversion(angle::FormatID srcFormatId) const
return srcFormatId != actualFormatId;
}
+bool Format::isViewCompatible(const Format &srcFormat) const
+{
+ if (srcFormat.metalFormat == metalFormat)
+ {
+ return true;
+ }
+
+ // The pixel layout is considered different if the number of components differs,
+ if (srcFormat.caps.channels != caps.channels)
+ {
+ return false;
+ }
+
+ // ... or if their size or order is different from the components in the original pixel format.
+ if (srcFormat.caps.pixelBytes != caps.pixelBytes)
+ {
+ return false;
+ }
+
+ // This is overly conservative but reject compressed formats
+ if (srcFormat.caps.compressed || caps.compressed)
+ {
+ return false;
+ }
+
+ return true;
+}
+
bool Format::isPVRTC() const
{
switch (metalFormat)
diff --git a/src/libANGLE/renderer/metal/mtl_render_utils.mm b/src/libANGLE/renderer/metal/mtl_render_utils.mm
index c11203e2a3543d10e24ba22655126f2c42acb3a9..4039dfe2b4484abdc5501d9097f5432dc8e42bd4 100644
--- a/src/libANGLE/renderer/metal/mtl_render_utils.mm
+++ b/src/libANGLE/renderer/metal/mtl_render_utils.mm
@@ -560,7 +560,8 @@ void DispatchCompute(ContextMtl *contextMtl,
id<MTLComputePipelineState> pipelineState,
size_t numThreads)
{
- NSUInteger w = std::min<NSUInteger>(pipelineState.threadExecutionWidth, numThreads);
+ ASSERT(numThreads != 0);
+ NSUInteger w = std::clamp<NSUInteger>(numThreads, 1u, pipelineState.threadExecutionWidth);
MTLSize threadsPerThreadgroup = MTLSizeMake(w, 1, 1);
if (contextMtl->getDisplay()->getFeatures().hasNonUniformDispatch.enabled)
@@ -640,8 +641,9 @@ void SetupCommonBlitWithDrawStates(const gl::Context *context,
GetViewport(params.dstRect, params.dstTextureSize.height, params.dstFlipY);
MTLScissorRect scissorRectMtl =
GetScissorRect(params.dstScissorRect, params.dstTextureSize.height, params.dstFlipY);
- cmdEncoder->setViewport(viewportMtl);
- cmdEncoder->setScissorRect(scissorRectMtl);
+
+ cmdEncoder->setViewport(viewportMtl, nil);
+ cmdEncoder->setScissorRect(scissorRectMtl, nil);
if (params.src)
{
@@ -1118,8 +1120,8 @@ angle::Result ClearUtils::setupClearWithDraw(const gl::Context *context,
scissorRect = GetScissorRect(params.clearArea, params.dstTextureSize.height, params.flipY);
- cmdEncoder->setViewport(viewport);
- cmdEncoder->setScissorRect(scissorRect);
+ cmdEncoder->setViewport(viewport, nil);
+ cmdEncoder->setScissorRect(scissorRect, nil);
// uniform
ClearParamsUniform uniformParams;
@@ -2486,8 +2488,8 @@ angle::Result CopyPixelsUtils::unpackPixelsWithDraw(const gl::Context *context,
scissorRect = GetScissorRect(rect);
- cmdEncoder->setViewport(viewport);
- cmdEncoder->setScissorRect(scissorRect);
+ cmdEncoder->setViewport(viewport, nil);
+ cmdEncoder->setScissorRect(scissorRect, nil);
// uniform
CopyPixelFromBufferUniforms options;
diff --git a/src/libANGLE/renderer/metal/mtl_resource_spi.h b/src/libANGLE/renderer/metal/mtl_resource_spi.h
index 3eaa9a64e79af26faa786102ece3f0bdea84d090..7ecb6db9d993df8985fcb6f701dfe7ca75857cae 100644
--- a/src/libANGLE/renderer/metal/mtl_resource_spi.h
+++ b/src/libANGLE/renderer/metal/mtl_resource_spi.h
@@ -1,9 +1,63 @@
-//
-// Copyright 2021 The ANGLE Project Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
+/*
+ * Copyright (C) 2021 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
//
// mtl_resource_spi.h:
-// Used to set Metal resource ownership identity with SPI.
-// Purposefully empty header file. Actual implementation will be hosted in WebKit.
+// Used to set Metal resource ownership identity with SPI
//
+
+#ifndef LIBANGLE_RENDERER_METAL_RESOURCE_SPI_H_
+#define LIBANGLE_RENDERER_METAL_RESOURCE_SPI_H_
+
+#import "common/apple/apple_platform.h"
+
+#if ANGLE_USE_METAL_OWNERSHIP_IDENTITY
+
+# import <Metal/MTLResource_Private.h>
+# import <Metal/Metal.h>
+# import <mach/mach_types.h>
+
+namespace rx
+{
+namespace mtl
+{
+inline void setOwnerWithIdentity(id<MTLResource> resource, task_id_token_t identityToken)
+{
+ if (identityToken != TASK_ID_TOKEN_NULL)
+ {
+ kern_return_t kr = [(id<MTLResourceSPI>)resource setOwnerWithIdentity:identityToken];
+ if (ANGLE_UNLIKELY(kr != KERN_SUCCESS))
+ {
+ ERR() << "setOwnerWithIdentity failed with: %s (%x)" << mach_error_string(kr) << kr;
+ ASSERT(false);
+ }
+ }
+ return;
+}
+} // namespace mtl
+} // namespace rx
+#endif
+
+#endif /* LIBANGLE_RENDERER_METAL_RESOURCE_SPI_H_ */
diff --git a/src/libANGLE/renderer/metal/mtl_resources.h b/src/libANGLE/renderer/metal/mtl_resources.h
index f622b484570562e6eebf6507ed83b20770be42d8..1e8ce4bb456dbfcb48c3728465ea864d466058ff 100644
--- a/src/libANGLE/renderer/metal/mtl_resources.h
+++ b/src/libANGLE/renderer/metal/mtl_resources.h
@@ -228,6 +228,11 @@ class Texture final : public Resource,
TextureRef createCubeFaceView(uint32_t face);
// Create a view of one slice at a level.
TextureRef createSliceMipView(uint32_t slice, const MipmapNativeLevel &level);
+ // Same as createSliceMipView but the target format must be compatible, for example sRGB to
+ // linear. In this case texture doesn't need format view usage flag.
+ TextureRef createSliceMipViewWithCompatibleFormat(uint32_t slice,
+ const MipmapNativeLevel &level,
+ MTLPixelFormat format);
// Create a levels range view
TextureRef createMipsView(const MipmapNativeLevel &baseLevel, uint32_t levels);
// Create a view of a level.
diff --git a/src/libANGLE/renderer/metal/mtl_resources.mm b/src/libANGLE/renderer/metal/mtl_resources.mm
index 2fa27bd06fc7c1d88b4c7917d6ec130b28aa55c6..49805ece99a7ee4cd3fbe2999c52dc61a9052183 100644
--- a/src/libANGLE/renderer/metal/mtl_resources.mm
+++ b/src/libANGLE/renderer/metal/mtl_resources.mm
@@ -82,12 +82,10 @@ MTLResourceOptions resourceOptionsForStorageMode(MTLStorageMode storageMode)
return MTLResourceStorageModePrivate;
case MTLStorageModeMemoryless:
return MTLResourceStorageModeMemoryless;
-#if TARGET_OS_SIMULATOR
default:
// TODO(http://anglebug.com/42266474): Remove me once hacked SDKs are fixed.
UNREACHABLE();
return MTLResourceStorageModeShared;
-#endif
}
}
@@ -709,7 +707,9 @@ TextureRef Texture::createCubeFaceView(uint32_t face)
}
}
-TextureRef Texture::createSliceMipView(uint32_t slice, const MipmapNativeLevel &level)
+TextureRef Texture::createSliceMipViewWithCompatibleFormat(uint32_t slice,
+ const MipmapNativeLevel &level,
+ MTLPixelFormat format)
{
ANGLE_MTL_OBJC_SCOPE
{
@@ -718,7 +718,7 @@ TextureRef Texture::createSliceMipView(uint32_t slice, const MipmapNativeLevel &
case MTLTextureTypeCube:
case MTLTextureType2D:
case MTLTextureType2DArray:
- return TextureRef(new Texture(this, pixelFormat(), MTLTextureType2D,
+ return TextureRef(new Texture(this, format, MTLTextureType2D,
NSMakeRange(level.get(), 1), NSMakeRange(slice, 1)));
default:
UNREACHABLE();
@@ -727,6 +727,11 @@ TextureRef Texture::createSliceMipView(uint32_t slice, const MipmapNativeLevel &
}
}
+TextureRef Texture::createSliceMipView(uint32_t slice, const MipmapNativeLevel &level)
+{
+ return createSliceMipViewWithCompatibleFormat(slice, level, pixelFormat());
+}
+
TextureRef Texture::createMipView(const MipmapNativeLevel &level)
{
ANGLE_MTL_OBJC_SCOPE
diff --git a/src/libANGLE/renderer/metal/mtl_state_cache.h b/src/libANGLE/renderer/metal/mtl_state_cache.h
index 6392bda51e826e5346666e623f589a8b31231213..4839de8394d92d8a57060b37f9372679c0a281bc 100644
--- a/src/libANGLE/renderer/metal/mtl_state_cache.h
+++ b/src/libANGLE/renderer/metal/mtl_state_cache.h
@@ -309,20 +309,21 @@ struct RenderPassAttachmentDesc
bool equalIgnoreLoadStoreOptions(const RenderPassAttachmentDesc &other) const;
bool operator==(const RenderPassAttachmentDesc &other) const;
- ANGLE_INLINE bool hasImplicitMSTexture() const { return implicitMSTexture.get(); }
-
- const TextureRef &getImplicitMSTextureIfAvailOrTexture() const
- {
- return hasImplicitMSTexture() ? implicitMSTexture : texture;
- }
+ ANGLE_INLINE bool hasResolveTexture() const { return resolveTexture.get(); }
+ // When rendering with implicit multisample, |texture| is the texture that
+ // will be rendered into and discarded at the end of a render pass. Its
+ // result will be automatically resolved into |resolveTexture|.
TextureRef texture;
// Implicit multisample texture that will be rendered into and discarded at the end of
// a render pass. Its result will be resolved into normal texture above.
- TextureRef implicitMSTexture;
+ TextureRef resolveTexture;
MipmapNativeLevel level;
uint32_t sliceOrDepth;
+ MipmapNativeLevel resolveLevel;
+ uint32_t resolveSliceOrDepth;
+
// This attachment is blendable or not.
bool blendable;
MTLLoadAction loadAction;
diff --git a/src/libANGLE/renderer/metal/mtl_state_cache.mm b/src/libANGLE/renderer/metal/mtl_state_cache.mm
index 0e4ea318bbe119442322cdbf0de18bcd33bee8a0..9e6bb7a8e3980ae053d0935c28c3c83b92a8e7da 100644
--- a/src/libANGLE/renderer/metal/mtl_state_cache.mm
+++ b/src/libANGLE/renderer/metal/mtl_state_cache.mm
@@ -145,44 +145,29 @@ id<MTLTexture> ToObjC(const TextureRef &texture)
void BaseRenderPassAttachmentDescToObjC(const RenderPassAttachmentDesc &src,
MTLRenderPassAttachmentDescriptor *dst)
{
- const TextureRef &implicitMsTexture = src.implicitMSTexture;
-
- if (implicitMsTexture)
- {
- dst.texture = ToObjC(implicitMsTexture);
- dst.level = 0;
- dst.slice = 0;
- dst.depthPlane = 0;
- dst.resolveTexture = ToObjC(src.texture);
- dst.resolveLevel = src.level.get();
- if (dst.resolveTexture.textureType == MTLTextureType3D)
- {
- dst.resolveDepthPlane = src.sliceOrDepth;
- dst.resolveSlice = 0;
- }
- else
- {
- dst.resolveSlice = src.sliceOrDepth;
- dst.resolveDepthPlane = 0;
- }
- }
- else
- {
dst.texture = ToObjC(src.texture);
dst.level = src.level.get();
if (dst.texture.textureType == MTLTextureType3D)
{
- dst.depthPlane = src.sliceOrDepth;
dst.slice = 0;
+ dst.depthPlane = src.sliceOrDepth;
}
else
{
dst.slice = src.sliceOrDepth;
dst.depthPlane = 0;
}
- dst.resolveTexture = nil;
- dst.resolveLevel = 0;
+
+ dst.resolveTexture = ToObjC(src.resolveTexture);
+ dst.resolveLevel = src.resolveLevel.get();
+ if (dst.resolveTexture.textureType == MTLTextureType3D)
+ {
dst.resolveSlice = 0;
+ dst.resolveDepthPlane = src.resolveSliceOrDepth;
+ }
+ else
+ {
+ dst.resolveSlice = src.resolveSliceOrDepth;
dst.resolveDepthPlane = 0;
}
@@ -672,9 +657,11 @@ RenderPassAttachmentDesc::RenderPassAttachmentDesc()
void RenderPassAttachmentDesc::reset()
{
texture.reset();
- implicitMSTexture.reset();
+ resolveTexture.reset();
level = mtl::kZeroNativeMipLevel;
sliceOrDepth = 0;
+ resolveLevel = mtl::kZeroNativeMipLevel;
+ resolveSliceOrDepth = 0;
blendable = false;
loadAction = MTLLoadActionLoad;
storeAction = MTLStoreActionStore;
@@ -684,7 +671,7 @@ void RenderPassAttachmentDesc::reset()
bool RenderPassAttachmentDesc::equalIgnoreLoadStoreOptions(
const RenderPassAttachmentDesc &other) const
{
- return texture == other.texture && implicitMSTexture == other.implicitMSTexture &&
+ return texture == other.texture && resolveTexture == other.resolveTexture &&
level == other.level && sliceOrDepth == other.sliceOrDepth &&
blendable == other.blendable;
}
diff --git a/src/libANGLE/renderer/metal/mtl_utils.mm b/src/libANGLE/renderer/metal/mtl_utils.mm
index 65060fcc1d9150643270dddd97e779365f5aea9c..5121e234ddab9bacfff2a019277cd4e5476beae5 100644
--- a/src/libANGLE/renderer/metal/mtl_utils.mm
+++ b/src/libANGLE/renderer/metal/mtl_utils.mm
@@ -1400,6 +1400,24 @@ bool SupportsAppleGPUFamily(id<MTLDevice> device, uint8_t appleFamily)
return [device supportsFamily:family];
}
+#if (defined(__MAC_13_0) && __MAC_OS_X_VERSION_MIN_REQUIRED >= __MAC_13_0) || \
+ (defined(__IPHONE_16_0) && __IPHONE_OS_VERSION_MIN_REQUIRED >= __IPHONE_16_0) || \
+ (defined(__TVOS_16_0) && __TV_OS_VERSION_MIN_REQUIRED >= __TVOS_16_0)
+# define ANGLE_MTL_FEATURE_SET_DEPRECATED 1
+# define ANGLE_MTL_GPU_FAMILY_MAC1_DEPRECATED 1
+#endif
+
+#if ANGLE_MTL_GPU_FAMILY_MAC1_DEPRECATED
+# define ANGLE_MTL_GPU_FAMILY_MAC1 MTLGPUFamilyMac2
+# define ANGLE_MTL_GPU_FAMILY_MAC2 MTLGPUFamilyMac2
+#elif TARGET_OS_MACCATALYST
+# define ANGLE_MTL_GPU_FAMILY_MAC1 MTLGPUFamilyMacCatalyst1
+# define ANGLE_MTL_GPU_FAMILY_MAC2 MTLGPUFamilyMacCatalyst2
+#else // !ANGLE_MTL_GPU_FAMILY_MAC1_DEPRECATED && !TARGET_OS_MACCATALYST
+# define ANGLE_MTL_GPU_FAMILY_MAC1 MTLGPUFamilyMac1
+# define ANGLE_MTL_GPU_FAMILY_MAC2 MTLGPUFamilyMac2
+#endif
+
bool SupportsMacGPUFamily(id<MTLDevice> device, uint8_t macFamily)
{
#if TARGET_OS_OSX || TARGET_OS_MACCATALYST
@@ -1445,8 +1463,7 @@ static NSUInteger getNextLocationForAttachment(const mtl::RenderPassAttachmentDe
const Context *context,
NSUInteger currentRenderTargetSize)
{
- mtl::TextureRef texture =
- attachment.implicitMSTexture ? attachment.implicitMSTexture : attachment.texture;
+ mtl::TextureRef texture = attachment.texture;
if (texture)
{
diff --git a/src/libANGLE/renderer/metal/shaders/create_mtl_internal_shaders.py b/src/libANGLE/renderer/metal/shaders/create_mtl_internal_shaders.py
new file mode 100644
index 0000000000000000000000000000000000000000..23e8295bcc16412d3aef3fc8e85748fa4ad77a70
--- /dev/null
+++ b/src/libANGLE/renderer/metal/shaders/create_mtl_internal_shaders.py
@@ -0,0 +1,65 @@
+#!/usr/bin/python3
+# Copyright 2021 The ANGLE Project Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+#
+# create_mtl_internal_shaders.py:
+# Script to compile a metalLib into NSData, for including the compilded
+# library in the ANGLE dylib.
+
+import os
+import sys
+import json
+from datetime import datetime
+
+sys.path.append('../..')
+
+template_header_boilerplate = """// GENERATED FILE - DO NOT EDIT.
+// Generated by {script_name}
+//
+// Copyright {copyright_year} The ANGLE Project Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+"""
+
+
+# Convert content of a file to byte array and store in a header file.
+# variable_name: name of C++ variable that will hold the file content as byte array.
+# filename: the file whose content will be converted to C++ byte array.
+# dest_src_file: destination header file that will contain the byte array.
+def append_file_as_byte_array_string(variable_name, filename, dest_src_file):
+ string = '// Generated from {0}:\n'.format(filename)
+ string += 'constexpr uint8_t {0}[]={{\n'.format(variable_name)
+ bytes_ = open(filename, "rb").read()
+ for byte in bytes_:
+ string += '0x{:02x}'.format(byte) + ", "
+ string += "\n};\n"
+ with open(dest_src_file, "a") as out_file:
+ out_file.write(string)
+
+
+def main():
+ input_file = sys.argv[1]
+ output_file = sys.argv[2]
+ os.chdir(sys.path[0])
+
+ boilerplate_code = template_header_boilerplate.format(
+ script_name=os.path.basename(sys.argv[0]), copyright_year=datetime.today().year)
+
+ # -------- Compile shaders -----------
+ # boiler plate code
+ os.system("echo \"{0}\" > \"{1}\"".format(boilerplate_code, output_file))
+ os.system(
+ 'echo "// Compiled binary for Metal default shaders.\n\n" >> \"{0}\"'.format(output_file))
+ os.system('echo "#include <TargetConditionals.h>\n\n" >> \"{0}\"'.format(output_file))
+
+ os.system('echo "// clang-format off" >> \"{0}\"'.format(output_file))
+
+ append_file_as_byte_array_string('gDefaultMetallib', input_file, output_file)
+
+ os.system('echo "// clang-format on" >> \"{0}\"'.format(output_file))
+
+
+if __name__ == '__main__':
+ sys.exit(main())
diff --git a/src/libANGLE/renderer/vulkan/AllocatorHelperPool.cpp b/src/libANGLE/renderer/vulkan/AllocatorHelperPool.cpp
index c7ea21b169cd27baaf9bd62cb320a54642a339f2..086756b248cfaf398524cf1d97f96cc813c512ea 100644
--- a/src/libANGLE/renderer/vulkan/AllocatorHelperPool.cpp
+++ b/src/libANGLE/renderer/vulkan/AllocatorHelperPool.cpp
@@ -49,7 +49,7 @@ bool DedicatedCommandBlockPool::empty() const
void DedicatedCommandBlockPool::allocateNewBlock(size_t blockSize)
{
ASSERT(mAllocator);
- mCurrentWritePointer = mAllocator->fastAllocate(blockSize);
+ mCurrentWritePointer = reinterpret_cast<uint8_t *>(mAllocator->allocate(blockSize));
mCurrentBytesRemaining = blockSize;
mCommandBuffer->pushToCommands(mCurrentWritePointer);
}
diff --git a/src/libANGLE/renderer/vulkan/AllocatorHelperPool.h b/src/libANGLE/renderer/vulkan/AllocatorHelperPool.h
index ea37c1e33040e2c4b6f6870c39efa2f4f14d8cd9..166144cdaf22136e46c1c02de2a15029b0d4c778 100644
--- a/src/libANGLE/renderer/vulkan/AllocatorHelperPool.h
+++ b/src/libANGLE/renderer/vulkan/AllocatorHelperPool.h
@@ -40,10 +40,9 @@ class DedicatedCommandBlockAllocator
DedicatedCommandMemoryAllocator *getAllocator() { return &mAllocator; }
private:
- static constexpr size_t kDefaultPoolAllocatorPageSize = 16 * 1024;
// Using a pool allocator per CBH to avoid threading issues that occur w/ shared allocator
// between multiple CBHs.
- DedicatedCommandMemoryAllocator mAllocator{kDefaultPoolAllocatorPageSize, 1};
+ DedicatedCommandMemoryAllocator mAllocator;
};
// Used in SecondaryCommandBuffer
@@ -61,8 +60,8 @@ class DedicatedCommandBlockPool final
using CommandHeaderIDType = uint16_t;
// Make sure the size of command header ID type is less than total command header size.
static_assert(sizeof(CommandHeaderIDType) < kCommandHeaderSize, "Check size of CommandHeader");
- // Pool Alloc uses 16kB pages w/ 16byte header = 16368bytes. To minimize waste
- // using a 16368/12 = 1364. Also better perf than 1024 due to fewer block allocations
+ // PoolAllocator uses 32768 byte pools. To minimize waste using a 32768/24 = 1365.
+ // Also better perf than 1024 due to fewer block allocations.
static constexpr size_t kBlockSize = 1360;
// Make sure block size is 8-byte aligned to avoid ASAN errors.
static_assert((kBlockSize % 8) == 0, "Check kBlockSize alignment");
diff --git a/src/libANGLE/renderer/vulkan/CLProgramVk.cpp b/src/libANGLE/renderer/vulkan/CLProgramVk.cpp
index 1356800718e69009432e05ba2855ab3cde62feb9..d0938bdf079ff0cd84cc0a37ccf98156e5cbb350 100644
--- a/src/libANGLE/renderer/vulkan/CLProgramVk.cpp
+++ b/src/libANGLE/renderer/vulkan/CLProgramVk.cpp
@@ -870,6 +870,11 @@ bool CLProgramVk::buildInternal(const cl::DevicePtrs &devices,
// add clspv compiler options based on device features
processedOptions += ClspvGetCompilerOptions(&device->getImpl<CLDeviceVk>());
+ cl_uint addressBits;
+ ANGLE_CL_IMPL_TRY(
+ device->getInfo(cl::DeviceInfo::AddressBits, sizeof(cl_uint), &addressBits, nullptr));
+ processedOptions += addressBits == 64 ? " -arch=spir64" : " -arch=spir";
+
if (buildType != BuildType::BINARY)
{
// Invoke clspv
diff --git a/src/libANGLE/renderer/vulkan/ContextVk.cpp b/src/libANGLE/renderer/vulkan/ContextVk.cpp
index bebab87247d9c9209e32098dd9c80957e2530d18..fb4f6e00358aef6041a4f1b8f9991ff29101a053 100644
--- a/src/libANGLE/renderer/vulkan/ContextVk.cpp
+++ b/src/libANGLE/renderer/vulkan/ContextVk.cpp
@@ -6072,6 +6072,10 @@ angle::Result ContextVk::syncState(const gl::Context *context,
break;
case gl::state::EXTENDED_DIRTY_BIT_BLEND_ADVANCED_COHERENT:
break;
+ case gl::state::EXTENDED_DIRTY_BIT_VARIABLE_RASTERIZATION_RATE:
+ // Noop until addition of backend support for
+ // ANGLE_variable_rasterization_rate_metal extension
+ break;
default:
UNREACHABLE();
}
diff --git a/src/libANGLE/renderer/vulkan/vk_format_utils.cpp b/src/libANGLE/renderer/vulkan/vk_format_utils.cpp
index 009479275213b09114c4c849486282e40c3ba510..bc5083539a8f8ad1b2255c9cc1a68a15e7201122 100644
--- a/src/libANGLE/renderer/vulkan/vk_format_utils.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_format_utils.cpp
@@ -345,7 +345,7 @@ angle::FormatID ExternalFormatTable::getOrAllocExternalFormatID(uint64_t externa
if (mExternalYuvFormats.size() >= kMaxExternalFormatCountSupported)
{
- ERR() << "ANGLE only suports maximum " << kMaxExternalFormatCountSupported
+ ERR() << "ANGLE only supports maximum " << kMaxExternalFormatCountSupported
<< " external renderable formats";
ASSERT(false);
return angle::FormatID::NONE;
diff --git a/src/libANGLE/validationEGL.cpp b/src/libANGLE/validationEGL.cpp
index f69bd954433d00a027f888ce86aa3c31ce7bb2e7..50481c4d6b2ee8619ce7f9ec1a3f66cfe0e44142 100644
--- a/src/libANGLE/validationEGL.cpp
+++ b/src/libANGLE/validationEGL.cpp
@@ -3492,11 +3492,11 @@ bool ValidateCreatePixmapSurface(const ValidationContext *val,
if (!(config->surfaceType & EGL_PIXMAP_BIT))
{
- val->setError(EGL_BAD_MATCH, "Congfig does not suport pixmaps.");
+ val->setError(EGL_BAD_MATCH, "Config does not support pixmaps.");
return false;
}
- ANGLE_EGL_TRY_RETURN(val->eglThread, display->valdiatePixmap(config, pixmap, attributes),
+ ANGLE_EGL_TRY_RETURN(val->eglThread, display->validatePixmap(config, pixmap, attributes),
val->entryPoint, val->labeledObject, false);
return true;
diff --git a/src/libANGLE/validationES2.cpp b/src/libANGLE/validationES2.cpp
index ac1149299999daf9e697adde36d821ec81a8ae38..4b9f09f958cd62a108dc5ac2029cba24fb4e6cf3 100644
--- a/src/libANGLE/validationES2.cpp
+++ b/src/libANGLE/validationES2.cpp
@@ -704,6 +704,9 @@ bool ValidCapUncommon(const PrivateState &state, ErrorSet *errors, GLenum cap, b
case GL_BLEND_ADVANCED_COHERENT_KHR:
return state.getExtensions().blendEquationAdvancedCoherentKHR;
+ case GL_VARIABLE_RASTERIZATION_RATE_ANGLE:
+ return state.getExtensions().variableRasterizationRateMetalANGLE;
+
default:
break;
}
@@ -5933,6 +5936,19 @@ bool ValidateMaxShaderCompilerThreadsKHR(const Context *context,
return true;
}
+bool ValidateBindMetalRasterizationRateMapANGLE(const Context *context,
+ angle::EntryPoint entryPoint,
+ GLuint framebuffer,
+ GLMTLRasterizationRateMapANGLE map)
+{
+ if (!context->getExtensions().variableRasterizationRateMetalANGLE)
+ {
+ ANGLE_VALIDATION_ERROR(GL_INVALID_OPERATION, kExtensionNotEnabled);
+ return false;
+ }
+ return true;
+}
+
bool ValidateMultiDrawArraysANGLE(const Context *context,
angle::EntryPoint entryPoint,
PrimitiveMode mode,
diff --git a/src/libANGLE/validationES32.cpp b/src/libANGLE/validationES32.cpp
index 63d4b9d2e2f231bc9f545924b5f03756e37cab23..48f98e8a1d049a83b7e18f39e6cc331b9a868bf4 100644
--- a/src/libANGLE/validationES32.cpp
+++ b/src/libANGLE/validationES32.cpp
@@ -431,12 +431,13 @@ bool ValidateGetPointerv(const Context *context,
return false;
}
break;
-
+ // GL_ANGLE_variable_rasterization_rate_metal
+ case GL_METAL_RASTERIZATION_RATE_MAP_BINDING_ANGLE:
+ return context->getExtensions().variableRasterizationRateMetalANGLE;
default:
ANGLE_VALIDATION_ERROR(GL_INVALID_ENUM, kInvalidPointerQuery);
return false;
}
-
return true;
}
diff --git a/src/libANGLE/validationESEXT.cpp b/src/libANGLE/validationESEXT.cpp
index aac8c8d654371ca359dc38338da67bdf3d68136a..e13641ce7e1f9e67c3eeffe3ca6a0c8d39917564 100644
--- a/src/libANGLE/validationESEXT.cpp
+++ b/src/libANGLE/validationESEXT.cpp
@@ -3913,6 +3913,29 @@ bool ValidateLogicOpANGLE(const PrivateState &state,
return ValidateLogicOpCommon(state, errors, entryPoint, opcodePacked);
}
+// GL_WEBKIT_explicit_resolve_target
+bool ValidateFramebufferResolveRenderbufferWEBKIT(const Context *context,
+ angle::EntryPoint entryPoint,
+ GLenum target,
+ GLenum attachment,
+ GLenum renderbuffertarget,
+ RenderbufferID renderbuffer)
+{
+#if ANGLE_WEBKIT_EXPLICIT_RESOLVE_TARGET_ENABLED
+ if (!context->getExtensions().explicitResolveTargetWEBKIT)
+ {
+ ANGLE_VALIDATION_ERROR(GL_INVALID_OPERATION, kExtensionNotEnabled);
+ return false;
+ }
+
+ return ValidateFramebufferRenderbufferBase(context, entryPoint, target, attachment,
+ renderbuffertarget, renderbuffer);
+#else
+ UNIMPLEMENTED();
+ return false;
+#endif
+}
+
bool ValidateFramebufferFoveationConfigQCOM(const Context *context,
angle::EntryPoint entryPoint,
FramebufferID framebufferPacked,
diff --git a/src/libANGLE/validationESEXT_autogen.h b/src/libANGLE/validationESEXT_autogen.h
index 26437c7f65e1daf6ed6e03149e7fcd529333abba..4cb0b89f721c8c9137f14b5bbcc8c475d77a7a2c 100644
--- a/src/libANGLE/validationESEXT_autogen.h
+++ b/src/libANGLE/validationESEXT_autogen.h
@@ -1008,6 +1008,12 @@ bool ValidateGetTranslatedShaderSourceANGLE(const Context *context,
const GLsizei *length,
const GLchar *source);
+// GL_ANGLE_variable_rasterization_rate_metal
+bool ValidateBindMetalRasterizationRateMapANGLE(const Context *context,
+ angle::EntryPoint entryPoint,
+ GLuint framebuffer,
+ GLMTLRasterizationRateMapANGLE map);
+
// GL_ANGLE_vulkan_image
bool ValidateAcquireTexturesANGLE(const Context *context,
angle::EntryPoint entryPoint,
@@ -2966,6 +2972,14 @@ bool ValidateStartTilingQCOM(const Context *context,
GLuint width,
GLuint height,
GLbitfield preserveMask);
+
+// GL_WEBKIT_explicit_resolve_target
+bool ValidateFramebufferResolveRenderbufferWEBKIT(const Context *context,
+ angle::EntryPoint entryPoint,
+ GLenum target,
+ GLenum attachment,
+ GLenum renderbuffertarget,
+ RenderbufferID renderbufferPacked);
} // namespace gl
#endif // LIBANGLE_VALIDATION_ESEXT_AUTOGEN_H_
diff --git a/src/libGLESv2/egl_stubs_getprocaddress_autogen.cpp b/src/libGLESv2/egl_stubs_getprocaddress_autogen.cpp
index 56107cd5748a045c3708f23f5243169edfd635b8..39d5accee31a28e9986a86d3c4cd48a0b3ee4e71 100644
--- a/src/libGLESv2/egl_stubs_getprocaddress_autogen.cpp
+++ b/src/libGLESv2/egl_stubs_getprocaddress_autogen.cpp
@@ -181,6 +181,7 @@ const ProcEntry g_procTable[] = {
{"glBindFramebuffer", P(GL_BindFramebuffer)},
{"glBindFramebufferOES", P(GL_BindFramebufferOES)},
{"glBindImageTexture", P(GL_BindImageTexture)},
+ {"glBindMetalRasterizationRateMapANGLE", P(GL_BindMetalRasterizationRateMapANGLE)},
{"glBindProgramPipeline", P(GL_BindProgramPipeline)},
{"glBindProgramPipelineEXT", P(GL_BindProgramPipelineEXT)},
{"glBindRenderbuffer", P(GL_BindRenderbuffer)},
@@ -395,6 +396,7 @@ const ProcEntry g_procTable[] = {
{"glFramebufferPixelLocalStorageRestoreANGLE", P(GL_FramebufferPixelLocalStorageRestoreANGLE)},
{"glFramebufferRenderbuffer", P(GL_FramebufferRenderbuffer)},
{"glFramebufferRenderbufferOES", P(GL_FramebufferRenderbufferOES)},
+ {"glFramebufferResolveRenderbufferWEBKIT", P(GL_FramebufferResolveRenderbufferWEBKIT)},
{"glFramebufferShadingRateEXT", P(GL_FramebufferShadingRateEXT)},
{"glFramebufferTexture", P(GL_FramebufferTexture)},
{"glFramebufferTexture2D", P(GL_FramebufferTexture2D)},
diff --git a/src/libGLESv2/entry_points_gles_ext_autogen.cpp b/src/libGLESv2/entry_points_gles_ext_autogen.cpp
index b5905f3ff5cd8237e1780dfd298f631fe9fb260b..39c5116109faeefc4ed6178a0dcb095de8dd3c58 100644
--- a/src/libGLESv2/entry_points_gles_ext_autogen.cpp
+++ b/src/libGLESv2/entry_points_gles_ext_autogen.cpp
@@ -6850,6 +6850,55 @@ void GL_APIENTRY GL_GetTranslatedShaderSourceANGLE(GLuint shader,
ASSERT(!egl::Display::GetCurrentThreadUnlockedTailCall()->any());
}
+// GL_ANGLE_variable_rasterization_rate_metal
+void GL_APIENTRY GL_BindMetalRasterizationRateMapANGLE(GLuint framebuffer,
+ GLMTLRasterizationRateMapANGLE map)
+{
+ ASSERT(!egl::Display::GetCurrentThreadUnlockedTailCall()->any());
+ Context *context = GetValidGlobalContext();
+ EVENT(context, GLBindMetalRasterizationRateMapANGLE,
+ "context = %d, framebuffer = %u, map = 0x%016" PRIxPTR "", CID(context), framebuffer,
+ (uintptr_t)map);
+
+ if (ANGLE_LIKELY(context != nullptr))
+ {
+ SCOPED_SHARE_CONTEXT_LOCK(context);
+ bool isCallValid = context->skipValidation();
+ if (!isCallValid)
+ {
+ if (ANGLE_LIKELY(context->getExtensions().variableRasterizationRateMetalANGLE))
+ {
+#if defined(ANGLE_ENABLE_ASSERTS)
+ const uint32_t errorCount = context->getPushedErrorCount();
+#endif
+ isCallValid = ValidateBindMetalRasterizationRateMapANGLE(
+ context, angle::EntryPoint::GLBindMetalRasterizationRateMapANGLE, framebuffer,
+ map);
+#if defined(ANGLE_ENABLE_ASSERTS)
+ ASSERT(context->getPushedErrorCount() - errorCount == (isCallValid ? 0 : 1));
+#endif
+ }
+ else
+ {
+ RecordVersionErrorESEXT(context,
+ angle::EntryPoint::GLBindMetalRasterizationRateMapANGLE);
+ }
+ }
+ if (ANGLE_LIKELY(isCallValid))
+ {
+ context->bindMetalRasterizationRateMap(framebuffer, map);
+ }
+ ANGLE_CAPTURE_GL(BindMetalRasterizationRateMapANGLE, isCallValid, context, framebuffer,
+ map);
+ }
+ else
+ {
+ GenerateContextLostErrorOnCurrentGlobalContext(
+ angle::EntryPoint::GLBindMetalRasterizationRateMapANGLE);
+ }
+ ASSERT(!egl::Display::GetCurrentThreadUnlockedTailCall()->any());
+}
+
// GL_ANGLE_vulkan_image
void GL_APIENTRY GL_AcquireTexturesANGLE(GLuint numTextures,
const GLuint *textures,
@@ -20617,4 +20666,59 @@ GL_StartTilingQCOM(GLuint x, GLuint y, GLuint width, GLuint height, GLbitfield p
ASSERT(!egl::Display::GetCurrentThreadUnlockedTailCall()->any());
}
+// GL_WEBKIT_explicit_resolve_target
+void GL_APIENTRY GL_FramebufferResolveRenderbufferWEBKIT(GLenum target,
+ GLenum attachment,
+ GLenum renderbuffertarget,
+ GLuint renderbuffer)
+{
+ ASSERT(!egl::Display::GetCurrentThreadUnlockedTailCall()->any());
+ Context *context = GetValidGlobalContext();
+ EVENT(context, GLFramebufferResolveRenderbufferWEBKIT,
+ "context = %d, target = %s, attachment = %s, renderbuffertarget = %s, renderbuffer = %u",
+ CID(context), GLenumToString(GLESEnum::AllEnums, target),
+ GLenumToString(GLESEnum::AllEnums, attachment),
+ GLenumToString(GLESEnum::AllEnums, renderbuffertarget), renderbuffer);
+
+ if (ANGLE_LIKELY(context != nullptr))
+ {
+ RenderbufferID renderbufferPacked = PackParam<RenderbufferID>(renderbuffer);
+ SCOPED_SHARE_CONTEXT_LOCK(context);
+ bool isCallValid = context->skipValidation();
+ if (!isCallValid)
+ {
+ if (ANGLE_LIKELY(context->getExtensions().explicitResolveTargetWEBKIT))
+ {
+#if defined(ANGLE_ENABLE_ASSERTS)
+ const uint32_t errorCount = context->getPushedErrorCount();
+#endif
+ isCallValid = ValidateFramebufferResolveRenderbufferWEBKIT(
+ context, angle::EntryPoint::GLFramebufferResolveRenderbufferWEBKIT, target,
+ attachment, renderbuffertarget, renderbufferPacked);
+#if defined(ANGLE_ENABLE_ASSERTS)
+ ASSERT(context->getPushedErrorCount() - errorCount == (isCallValid ? 0 : 1));
+#endif
+ }
+ else
+ {
+ RecordVersionErrorESEXT(context,
+ angle::EntryPoint::GLFramebufferResolveRenderbufferWEBKIT);
+ }
+ }
+ if (ANGLE_LIKELY(isCallValid))
+ {
+ context->framebufferResolveRenderbufferWEBKIT(target, attachment, renderbuffertarget,
+ renderbufferPacked);
+ }
+ ANGLE_CAPTURE_GL(FramebufferResolveRenderbufferWEBKIT, isCallValid, context, target,
+ attachment, renderbuffertarget, renderbufferPacked);
+ }
+ else
+ {
+ GenerateContextLostErrorOnCurrentGlobalContext(
+ angle::EntryPoint::GLFramebufferResolveRenderbufferWEBKIT);
+ }
+ ASSERT(!egl::Display::GetCurrentThreadUnlockedTailCall()->any());
+}
+
} // extern "C"
diff --git a/src/libGLESv2/entry_points_gles_ext_autogen.h b/src/libGLESv2/entry_points_gles_ext_autogen.h
index 31038dbb5e6e3447a310c9062fdb7e290044a0b8..d4f546aacd85b22007b02168605863320fed106d 100644
--- a/src/libGLESv2/entry_points_gles_ext_autogen.h
+++ b/src/libGLESv2/entry_points_gles_ext_autogen.h
@@ -744,6 +744,10 @@ ANGLE_EXPORT void GL_APIENTRY GL_GetTranslatedShaderSourceANGLE(GLuint shader,
GLsizei *length,
GLchar *source);
+// GL_ANGLE_variable_rasterization_rate_metal
+ANGLE_EXPORT void GL_APIENTRY
+GL_BindMetalRasterizationRateMapANGLE(GLuint framebuffer, GLMTLRasterizationRateMapANGLE map);
+
// GL_ANGLE_vulkan_image
ANGLE_EXPORT void GL_APIENTRY GL_AcquireTexturesANGLE(GLuint numTextures,
const GLuint *textures,
@@ -1993,6 +1997,12 @@ ANGLE_EXPORT void GL_APIENTRY GL_TextureFoveationParametersQCOM(GLuint texture,
ANGLE_EXPORT void GL_APIENTRY GL_EndTilingQCOM(GLbitfield preserveMask);
ANGLE_EXPORT void GL_APIENTRY
GL_StartTilingQCOM(GLuint x, GLuint y, GLuint width, GLuint height, GLbitfield preserveMask);
+
+// GL_WEBKIT_explicit_resolve_target
+ANGLE_EXPORT void GL_APIENTRY GL_FramebufferResolveRenderbufferWEBKIT(GLenum target,
+ GLenum attachment,
+ GLenum renderbuffertarget,
+ GLuint renderbuffer);
} // extern "C"
#endif // LIBGLESV2_ENTRY_POINTS_GLES_EXT_AUTOGEN_H_
diff --git a/src/libGLESv2/libGLESv2_autogen.cpp b/src/libGLESv2/libGLESv2_autogen.cpp
index c639ba94915155cde44266e86e9ed4208b828e5c..469e47dc38d61fb7c0281eedd6770f78b5eacf1a 100644
--- a/src/libGLESv2/libGLESv2_autogen.cpp
+++ b/src/libGLESv2/libGLESv2_autogen.cpp
@@ -3949,6 +3949,13 @@ void GL_APIENTRY glGetTranslatedShaderSourceANGLE(GLuint shader,
return GL_GetTranslatedShaderSourceANGLE(shader, bufSize, length, source);
}
+// GL_ANGLE_variable_rasterization_rate_metal
+void GL_APIENTRY glBindMetalRasterizationRateMapANGLE(GLuint framebuffer,
+ GLMTLRasterizationRateMapANGLE map)
+{
+ return GL_BindMetalRasterizationRateMapANGLE(framebuffer, map);
+}
+
// GL_ANGLE_vulkan_image
void GL_APIENTRY glAcquireTexturesANGLE(GLuint numTextures,
const GLuint *textures,
@@ -6151,4 +6158,14 @@ glStartTilingQCOM(GLuint x, GLuint y, GLuint width, GLuint height, GLbitfield pr
return GL_StartTilingQCOM(x, y, width, height, preserveMask);
}
+// GL_WEBKIT_explicit_resolve_target
+void GL_APIENTRY glFramebufferResolveRenderbufferWEBKIT(GLenum target,
+ GLenum attachment,
+ GLenum renderbuffertarget,
+ GLuint renderbuffer)
+{
+ return GL_FramebufferResolveRenderbufferWEBKIT(target, attachment, renderbuffertarget,
+ renderbuffer);
+}
+
} // extern "C"
diff --git a/src/libGLESv2/libGLESv2_autogen.def b/src/libGLESv2/libGLESv2_autogen.def
index e8460365a5fd3749cf6f0b6bbfe134efc531081c..2482ca6c10d9fb080f9f795453cb9c8495eb1c96 100644
--- a/src/libGLESv2/libGLESv2_autogen.def
+++ b/src/libGLESv2/libGLESv2_autogen.def
@@ -672,6 +672,9 @@ EXPORTS
; GL_ANGLE_translated_shader_source
glGetTranslatedShaderSourceANGLE
+ ; GL_ANGLE_variable_rasterization_rate_metal
+ glBindMetalRasterizationRateMapANGLE
+
; GL_ANGLE_vulkan_image
glAcquireTexturesANGLE
glReleaseTexturesANGLE
@@ -1303,6 +1306,9 @@ EXPORTS
glEndTilingQCOM
glStartTilingQCOM
+ ; GL_WEBKIT_explicit_resolve_target
+ glFramebufferResolveRenderbufferWEBKIT
+
; EGL 1.0
EGL_ChooseConfig
EGL_CopyBuffers
diff --git a/src/libGLESv2/libGLESv2_no_capture_autogen.def b/src/libGLESv2/libGLESv2_no_capture_autogen.def
index 2699a826a02ca9475a6a9f2a0a1014faf0e4b92a..4f75d2a4c64326758161505503ffa6117336e320 100644
--- a/src/libGLESv2/libGLESv2_no_capture_autogen.def
+++ b/src/libGLESv2/libGLESv2_no_capture_autogen.def
@@ -672,6 +672,9 @@ EXPORTS
; GL_ANGLE_translated_shader_source
glGetTranslatedShaderSourceANGLE
+ ; GL_ANGLE_variable_rasterization_rate_metal
+ glBindMetalRasterizationRateMapANGLE
+
; GL_ANGLE_vulkan_image
glAcquireTexturesANGLE
glReleaseTexturesANGLE
@@ -1303,6 +1306,9 @@ EXPORTS
glEndTilingQCOM
glStartTilingQCOM
+ ; GL_WEBKIT_explicit_resolve_target
+ glFramebufferResolveRenderbufferWEBKIT
+
; EGL 1.0
EGL_ChooseConfig
EGL_CopyBuffers
diff --git a/src/libGLESv2/libGLESv2_vulkan_secondaries_autogen.def b/src/libGLESv2/libGLESv2_vulkan_secondaries_autogen.def
index b901572edc688f6e03462aab9336f222e96f812e..12a133119032c4847de1f7886c6a4ee881486c0e 100644
--- a/src/libGLESv2/libGLESv2_vulkan_secondaries_autogen.def
+++ b/src/libGLESv2/libGLESv2_vulkan_secondaries_autogen.def
@@ -672,6 +672,9 @@ EXPORTS
; GL_ANGLE_translated_shader_source
glGetTranslatedShaderSourceANGLE
+ ; GL_ANGLE_variable_rasterization_rate_metal
+ glBindMetalRasterizationRateMapANGLE
+
; GL_ANGLE_vulkan_image
glAcquireTexturesANGLE
glReleaseTexturesANGLE
@@ -1303,6 +1306,9 @@ EXPORTS
glEndTilingQCOM
glStartTilingQCOM
+ ; GL_WEBKIT_explicit_resolve_target
+ glFramebufferResolveRenderbufferWEBKIT
+
; EGL 1.0
EGL_ChooseConfig
EGL_CopyBuffers
diff --git a/src/libGLESv2/libGLESv2_with_capture_autogen.def b/src/libGLESv2/libGLESv2_with_capture_autogen.def
index 4a3ef946cb167e227a10f65bae141d7f5052696b..4392305d330e24001de260a0ad9cf40e26fbc6d0 100644
--- a/src/libGLESv2/libGLESv2_with_capture_autogen.def
+++ b/src/libGLESv2/libGLESv2_with_capture_autogen.def
@@ -672,6 +672,9 @@ EXPORTS
; GL_ANGLE_translated_shader_source
glGetTranslatedShaderSourceANGLE
+ ; GL_ANGLE_variable_rasterization_rate_metal
+ glBindMetalRasterizationRateMapANGLE
+
; GL_ANGLE_vulkan_image
glAcquireTexturesANGLE
glReleaseTexturesANGLE
@@ -1303,6 +1306,9 @@ EXPORTS
glEndTilingQCOM
glStartTilingQCOM
+ ; GL_WEBKIT_explicit_resolve_target
+ glFramebufferResolveRenderbufferWEBKIT
+
; EGL 1.0
EGL_ChooseConfig
EGL_CopyBuffers
diff --git a/src/tests/angle_end2end_tests.gni b/src/tests/angle_end2end_tests.gni
index ba8174497c9d30f3d371cde8d8e3d5bb7eecb0a3..7b4601fe81f16f78f6cfad7547b0d9485b8c64bd 100644
--- a/src/tests/angle_end2end_tests.gni
+++ b/src/tests/angle_end2end_tests.gni
@@ -90,6 +90,7 @@ angle_end2end_tests_sources = [
"gl_tests/FramebufferRenderMipmapTest.cpp",
"gl_tests/FramebufferTest.cpp",
"gl_tests/GLSLTest.cpp",
+ "gl_tests/GLSLUBTest.cpp",
"gl_tests/GeometryShaderTest.cpp",
"gl_tests/GetImageTest.cpp",
"gl_tests/GetTexLevelParameterTest.cpp",
diff --git a/src/tests/angle_unittest_main.cpp b/src/tests/angle_unittest_main.cpp
index 31be8e39d1d191618162e559b84b4610b62c1973..9c35afd9c21d6af3a20e206d4637b33fc2523808 100644
--- a/src/tests/angle_unittest_main.cpp
+++ b/src/tests/angle_unittest_main.cpp
@@ -10,7 +10,9 @@
#include "GLSLANG/ShaderLang.h"
#include "gtest/gtest.h"
-#include "test_utils/runner/TestSuite.h"
+#if defined(ANGLE_HAS_RAPIDJSON)
+# include "test_utils/runner/TestSuite.h"
+#endif
class CompilerTestEnvironment : public testing::Environment
{
@@ -44,8 +46,13 @@ int main(int argc, char **argv)
gVerbose = true;
}
}
-
+#if defined(ANGLE_HAS_RAPIDJSON)
angle::TestSuite testSuite(&argc, argv);
testing::AddGlobalTestEnvironment(new CompilerTestEnvironment());
return testSuite.run();
+#else
+ testing::AddGlobalTestEnvironment(new CompilerTestEnvironment());
+ ::testing::InitGoogleTest(&argc, argv);
+ return RUN_ALL_TESTS();
+#endif // defined(ANGLE_HAS_RAPIDJSON)
}
diff --git a/src/tests/compiler_tests/MSLOutput_test.cpp b/src/tests/compiler_tests/MSLOutput_test.cpp
index b525c5b983d4aeb60ec91730af1a891609787fb8..f5741f6b13e82498d689cade7f7540e16bcf2c3e 100644
--- a/src/tests/compiler_tests/MSLOutput_test.cpp
+++ b/src/tests/compiler_tests/MSLOutput_test.cpp
@@ -11,6 +11,7 @@
#include "GLSLANG/ShaderLang.h"
#include "angle_gl.h"
#include "gtest/gtest.h"
+#include "gmock/gmock.h"
#include "tests/test_utils/compiler_test.h"
using namespace sh;
@@ -1115,3 +1116,99 @@ TEST_F(MSLOutputTest, EnsureLoopForwardProgressFinite)
compile(shaderString, options);
ASSERT_FALSE(foundInCode(SH_MSL_METAL_OUTPUT, "loopForwardProgress();"));
}
+
+// Tests that uint assignment operators use the expected functions.
+TEST_F(MSLOutputTest, UintAssignmentOperators)
+{
+ const std::string &shaderString =R"(#version 300 es
+precision highp float;
+in vec4 i;
+out vec4 o;
+void main() {
+ ivec4 ii = ivec4(i);
+ ii += 2;
+ ii -= 3;
+ ii *= 4;
+ ii /= 5;
+ ii %= 6;
+ ii &= 7;
+ ii |= 8;
+ ii ^= 9;
+ ii <<= 10;
+ ii >>= 11;
+ ii++;
+ ++ii;
+ ii--;
+ --ii;
+ o = vec4(ii);
+})";
+ const char expected[] = R"(void ANGLE__0_main(thread ANGLE_FragmentOut & ANGLE_fragmentOut, thread ANGLE_FragmentIn & ANGLE_fragmentIn)
+{
+ metal::int4 _uii = ANGLE_ftoi<metal::int4>(ANGLE_fragmentIn._ui);
+ _uii = ANGLE_addAssignInt(_uii, 2);
+ _uii = ANGLE_subAssignInt(_uii, 3);
+ _uii = ANGLE_imul(_uii, 4);
+ _uii = ANGLE_div(_uii, 5);
+ _uii = ANGLE_imod(_uii, 6);
+ _uii &= 7;
+ _uii |= 8;
+ _uii ^= 9;
+ _uii = ANGLE_ilshift(_uii, 10);
+ _uii = ANGLE_rshift(_uii, 11);
+ ANGLE_postIncrementInt(_uii);
+ ANGLE_preIncrementInt(_uii);
+ ANGLE_postDecrementInt(_uii);
+ ANGLE_preDecrementInt(_uii);
+ ANGLE_fragmentOut._uo = metal::float4(_uii);
+})";
+ compile(shaderString);
+ EXPECT_THAT(outputCode(SH_MSL_METAL_OUTPUT), testing::HasSubstr(expected));
+}
+
+// Tests that some uint assignment operators use the swizzle ref helper if the swizzle is in lvalue position in the generated code.
+TEST_F(MSLOutputTest, UintSwizzleAssignmentOperators)
+{
+ const std::string &shaderString =R"(#version 300 es
+precision highp float;
+in vec4 i;
+out vec4 o;
+void main() {
+ ivec4 ii = ivec4(i);
+ ii.x += 2;
+ ii.y -= 3;
+ ii.z *= 4;
+ ii.w /= 5;
+ ii.x %= 6;
+ ii.y &= 7;
+ ii.y |= 8;
+ ii.z ^= 9;
+ ii.y <<= 10;
+ ii.z >>= 11;
+ ii.x++;
+ ++ii.y;
+ ii.x--;
+ --ii.y;
+ o = vec4(ii);
+})";
+ const char expected[] = R"(void ANGLE__0_main(thread ANGLE_FragmentOut & ANGLE_fragmentOut, thread ANGLE_FragmentIn & ANGLE_fragmentIn)
+{
+ metal::int4 _uii = ANGLE_ftoi<metal::int4>(ANGLE_fragmentIn._ui);
+ _uii.x = ANGLE_addInt(_uii.x, 2);
+ _uii.y = ANGLE_subInt(_uii.y, 3);
+ _uii.z = ANGLE_imul(_uii.z, 4);
+ _uii.w = ANGLE_div(_uii.w, 5);
+ _uii.x = ANGLE_imod(_uii.x, 6);
+ _uii.y = (_uii.y & 7);
+ _uii.y = (_uii.y | 8);
+ _uii.z = (_uii.z ^ 9);
+ _uii.y = ANGLE_ilshift(_uii.y, 10);
+ _uii.z = ANGLE_rshift(_uii.z, 11);
+ ANGLE_postIncrementInt(ANGLE_swizzle_ref(_uii, 0u));
+ ANGLE_preIncrementInt(ANGLE_swizzle_ref(_uii, 1u));
+ ANGLE_postDecrementInt(ANGLE_swizzle_ref(_uii, 0u));
+ ANGLE_preDecrementInt(ANGLE_swizzle_ref(_uii, 1u));
+ ANGLE_fragmentOut._uo = metal::float4(_uii);
+})";
+ compile(shaderString);
+ EXPECT_THAT(outputCode(SH_MSL_METAL_OUTPUT), testing::HasSubstr(expected));
+}
diff --git a/src/tests/egl_tests/EGLContextCompatibilityTest.cpp b/src/tests/egl_tests/EGLContextCompatibilityTest.cpp
index 38e7afe9118d00a180477a6d4bcf86d1b29a8f34..53c8599c3223da87b2f34203baf81bcd28803a5d 100644
--- a/src/tests/egl_tests/EGLContextCompatibilityTest.cpp
+++ b/src/tests/egl_tests/EGLContextCompatibilityTest.cpp
@@ -173,8 +173,9 @@ class EGLContextCompatibilityTest : public ANGLETestBase
void SetUp() final
{
ANGLETestBase::ANGLETestSetUp();
+#if !defined(EGL_EGL_PROTOTYPES) || !EGL_EGL_PROTOTYPES
ASSERT_TRUE(eglGetPlatformDisplay != nullptr);
-
+#endif
EGLAttrib dispattrs[] = {EGL_PLATFORM_ANGLE_TYPE_ANGLE, mRenderer, EGL_NONE};
mDisplay = eglGetPlatformDisplay(GetEglPlatform(),
reinterpret_cast<void *>(EGL_DEFAULT_DISPLAY), dispattrs);
@@ -490,11 +491,13 @@ void RegisterContextCompatibilityTests()
LoadEntryPointsWithUtilLoader(kDefaultGLESDriver);
+#if !defined(EGL_EGL_PROTOTYPES) || !EGL_EGL_PROTOTYPES
if (eglGetPlatformDisplay == nullptr)
{
std::cerr << "EGLContextCompatibilityTest: missing eglGetPlatformDisplay\n";
return;
}
+#endif
for (EGLint renderer : renderers)
{
diff --git a/src/tests/egl_tests/EGLDisplayTest.cpp b/src/tests/egl_tests/EGLDisplayTest.cpp
index b51b5f07cba261dddef39cc80115986108722bab..817668c08b7a018ad2525aa9999914c42836ddc7 100644
--- a/src/tests/egl_tests/EGLDisplayTest.cpp
+++ b/src/tests/egl_tests/EGLDisplayTest.cpp
@@ -182,7 +182,9 @@ TEST_P(EGLDisplayTest, GetPlatformDisplayEXT)
// eglGetPlatformDisplayEXT() requires EGL_EXT_platform_base.
ANGLE_SKIP_TEST_IF(!IsEGLClientExtensionEnabled("EGL_EXT_platform_base"));
+#if !defined(EGL_EGLEXT_PROTOTYPES) || !EGL_EGLEXT_PROTOTYPES
ASSERT_TRUE(eglGetPlatformDisplayEXT != nullptr);
+#endif
EGLint dispattrs[] = {EGL_PLATFORM_ANGLE_TYPE_ANGLE, GetParam().getRenderer(), EGL_NONE};
EGLDisplay display = eglGetPlatformDisplayEXT(
diff --git a/src/tests/gl_tests/CopyCompressedTextureTest.cpp b/src/tests/gl_tests/CopyCompressedTextureTest.cpp
index 6ddadba63706defe665858101598abf43d7bf3aa..29c31ecfb445af09eb5c5be7c7e9b5819be3cc2f 100644
--- a/src/tests/gl_tests/CopyCompressedTextureTest.cpp
+++ b/src/tests/gl_tests/CopyCompressedTextureTest.cpp
@@ -67,12 +67,13 @@ class CopyCompressedTextureTest : public ANGLETest<>
return false;
}
+#if !defined(GL_GLEXT_PROTOTYPES) || !GL_GLEXT_PROTOTYPES
EXPECT_NE(nullptr, glCompressedCopyTextureCHROMIUM);
if (glCompressedCopyTextureCHROMIUM == nullptr)
{
return false;
}
-
+#endif
return true;
}
diff --git a/src/tests/gl_tests/CubeMapTextureTest.cpp b/src/tests/gl_tests/CubeMapTextureTest.cpp
index 1cc913612a0c4398b47c087f9dbbec049ce0909d..b1fbf775a1ce943277ecc196a53035247c07efff 100644
--- a/src/tests/gl_tests/CubeMapTextureTest.cpp
+++ b/src/tests/gl_tests/CubeMapTextureTest.cpp
@@ -11,7 +11,6 @@
#include "test_utils/ANGLETest.h"
#include "test_utils/angle_test_configs.h"
#include "test_utils/gl_raii.h"
-#include "util/gles_loader_autogen.h"
using namespace angle;
diff --git a/src/tests/gl_tests/GLSLTest.cpp b/src/tests/gl_tests/GLSLTest.cpp
index c9792173ca1729cf74a835d72f9df331833d9c4d..1c8da83d5d4cd44451baf3726ca5281925e754dc 100644
--- a/src/tests/gl_tests/GLSLTest.cpp
+++ b/src/tests/gl_tests/GLSLTest.cpp
@@ -597,6 +597,29 @@ TEST_P(GLSLTest, SwizzledChainedAssignIncrement)
EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(75, 75, 38, 38));
}
+// This shader uses chained assign-equals ops with swizzle, often reusing the same variable
+// as part of a swizzle, ivec variant
+TEST_P(GLSLTest, SwizzledChainedAssignIncrementIvec)
+{
+ constexpr char kFS[] = R"(
+precision mediump float;
+void main() {
+ ivec2 v = ivec2(1,5);
+ // at the end of next statement, values in
+ // v.x = 12, v.y = 12
+ v.xy += v.yx += v.xy;
+ // v1 and v2, both are initialized with (12,12)
+ ivec2 v1 = v, v2 = v;
+ v1.xy += v2.yx += ++(v.xy); // v1 = 37, v2 = 25 each
+ v1.xy += v2.yx += (v.xy)++; // v1 = 75, v2 = 38 each
+ gl_FragColor = vec4(vec2(v1),vec2(v2))/255.; // 75, 75, 38, 38
+})";
+ ANGLE_GL_PROGRAM(program, essl1_shaders::vs::Simple(), kFS);
+ drawQuad(program, essl1_shaders::PositionAttrib(), 0.5f);
+ ASSERT_GL_NO_ERROR();
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(75, 75, 38, 38));
+}
+
TEST_P(GLSLTest, NamelessScopedStructs)
{
constexpr char kFS[] = R"(precision mediump float;
@@ -6966,6 +6989,64 @@ void main()
EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
}
+// Tests that extracting samplers from structs that are members of other structs
+// will not cause a error when accessing any fields (e.g., uni.b)
+// (This is a modification of the above test "SamplerInStructMemberIndexing").
+TEST_P(GLSLTest, SamplerInStructInStructMemberIndexing)
+{
+ const char kVertexShader[] = R"(attribute vec2 position;
+varying vec2 texCoord;
+void main()
+{
+ gl_Position = vec4(position, 0, 1);
+ texCoord = position * 0.5 + vec2(0.5);
+})";
+
+ const char kFragmentShader[] = R"(precision mediump float;
+struct S1 { sampler2D samp; };
+struct S2 { S1 s1; bool b; };
+uniform S2 uni;
+varying vec2 texCoord;
+void main()
+{
+ uni;
+ if (uni.b)
+ {
+ gl_FragColor = texture2D(uni.s1.samp, texCoord);
+ }
+ else
+ {
+ gl_FragColor = vec4(1, 0, 0, 1);
+ }
+})";
+
+ ANGLE_GL_PROGRAM(program, kVertexShader, kFragmentShader);
+ glUseProgram(program);
+
+ GLint bLoc = glGetUniformLocation(program, "uni.b");
+ ASSERT_NE(-1, bLoc);
+ GLint sampLoc = glGetUniformLocation(program, "uni.s1.samp");
+ ASSERT_NE(-1, sampLoc);
+
+ glUniform1i(bLoc, 1);
+
+ std::array<GLColor, 4> kGreenPixels = {
+ {GLColor::green, GLColor::green, GLColor::green, GLColor::green}};
+
+ GLTexture tex;
+ glBindTexture(GL_TEXTURE_2D, tex);
+ glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE,
+ kGreenPixels.data());
+ glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+ glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+ ASSERT_GL_NO_ERROR();
+
+ drawQuad(program, "position", 0.5f);
+ ASSERT_GL_NO_ERROR();
+
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
+}
+
// Tests that rewriting samplers in structs works when passed as function argument. In this test,
// the function references another struct, which is not being modified. Regression test for AST
// validation applied to a multipass transformation, where references to declarations were attempted
@@ -11042,6 +11123,43 @@ void main()
EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::white);
}
+// Test that modf(u, v.x) works correctly.
+TEST_P(GLSLTest_ES3, ModFIntegerToSwizzle)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp float;
+out vec4 o;
+uniform vec2 u;
+bool isEq(vec2 a, vec2 b) { return all(lessThan(abs(a-b), vec2(0.001))); }
+void main()
+{
+ vec4 i1;
+ vec2 r1 = modf(u, i1.xy);
+ vec2 r2;
+ r2.x = modf(u.x, i1.z);
+ r2.y = modf(u.y, i1.w);
+ vec2 i2;
+ vec2 r4 = modf(u, i2.yx);
+
+ o = vec4(0.0, 0.0, 0.0, 1.0);
+ if (isEq(r1, vec2(0.14, 0.15)) && isEq(i1.xy, vec2(3.0, 4.0)))
+ o.r = 1.0;
+ if (isEq(r2, vec2(0.14, 0.15)) && isEq(i1.zw, vec2(3.0, 4.0)))
+ o.g = 1.0;
+ if (isEq(r4, vec2(0.14, 0.15)) && isEq(i2, vec2(4.0, 3.0)))
+ o.b = 1.0;
+})";
+ ANGLE_GL_PROGRAM(program, essl3_shaders::vs::Simple(), kFS);
+ glUseProgram(program);
+ ASSERT_GL_NO_ERROR();
+ GLint uloc = glGetUniformLocation(program, "u");
+ ASSERT_NE(uloc, -1);
+ glUniform2f(uloc, 3.14f, 4.15f);
+ drawQuad(program, essl3_shaders::PositionAttrib(), 0.5f);
+ ASSERT_GL_NO_ERROR();
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::white);
+}
+
// Test a fragment shader that returns inside if (that being the only branch that actually gets
// executed). Regression test for http://anglebug.com/42261034
TEST_P(GLSLTest, IfElseIfAndReturn)
@@ -21468,6 +21586,816 @@ void main() {
EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::transparentBlack);
}
+
+// Test highp int scalar + vec
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingAdd1)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = u + ivec4(0, -1, 1, 2147483645);
+ o.r = r.x == 2 ? 1.0 : 0.0;
+ o.g = r.y == 1 ? 1.0 : 0.0;
+ o.b = r.z == 3 ? 1.0 : 0.0;
+ o.a = r.w == 2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec + scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingAdd2)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, 2147483645) + u;
+ o.r = r.x == 2 ? 1.0 : 0.0;
+ o.g = r.y == 1 ? 1.0 : 0.0;
+ o.b = r.z == 3 ? 1.0 : 0.0;
+ o.a = r.w == 2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec += scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingAdd3)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, 2147483645);
+ r += u;
+ o.r = r.x == 2 ? 1.0 : 0.0;
+ o.g = r.y == 1 ? 1.0 : 0.0;
+ o.b = r.z == 3 ? 1.0 : 0.0;
+ o.a = r.w == 2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int scalar + vec handles UB
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingAddUB)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = u + ivec4(0, -1, 1, 2147483647);
+ o.r = r.x == 2 ? 1.0 : 0.0;
+ o.g = r.y == 1 ? 1.0 : 0.0;
+ o.b = r.z == 3 ? 1.0 : 0.0;
+ o.a = r.w == -2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int scalar - vec
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingSub1)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = u - ivec4(0, -1, 1, 2147483647);
+ o.r = r.x == 2 ? 1.0 : 0.0;
+ o.g = r.y == 3 ? 1.0 : 0.0;
+ o.b = r.z == 1 ? 1.0 : 0.0;
+ o.a = r.w == -2147483645 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec - scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingSub2)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, -2147483646) - u;
+ o.r = r.x == -2 ? 1.0 : 0.0;
+ o.g = r.y == -3 ? 1.0 : 0.0;
+ o.b = r.z == -1 ? 1.0 : 0.0;
+ o.a = r.w == -2147483648 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec -= scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingSub3)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, -2147483646);
+ r -= u;
+ o.r = r.x == -2 ? 1.0 : 0.0;
+ o.g = r.y == -3 ? 1.0 : 0.0;
+ o.b = r.z == -1 ? 1.0 : 0.0;
+ o.a = r.w == -2147483648 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+//
+// Test highp int scalar - vec handles UB
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingSubUB)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, -2147483648) - u;
+ o.r = r.x == -2 ? 1.0 : 0.0;
+ o.g = r.y == -3 ? 1.0 : 0.0;
+ o.b = r.z == -1 ? 1.0 : 0.0;
+ o.a = r.w == 2147483646 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int scalar * vec
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingMul1)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = u * ivec4(0, -1, 1, 3);
+ o.r = r.x == 0 ? 1.0 : 0.0;
+ o.g = r.y == -2 ? 1.0 : 0.0;
+ o.b = r.z == 2 ? 1.0 : 0.0;
+ o.a = r.w == 6 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec * scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingMul2)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, 3) * u;
+ o.r = r.x == 0 ? 1.0 : 0.0;
+ o.g = r.y == -2 ? 1.0 : 0.0;
+ o.b = r.z == 2 ? 1.0 : 0.0;
+ o.a = r.w == 6 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec *= scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingMul3)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, 3);
+ r *= u;
+ o.r = r.x == 0 ? 1.0 : 0.0;
+ o.g = r.y == -2 ? 1.0 : 0.0;
+ o.b = r.z == 2 ? 1.0 : 0.0;
+ o.a = r.w == 6 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int scalar * vector handles UB
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingMulUB)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = u * ivec4(0, -1, 1, -2147483648);
+ o.r = r.x == 0 ? 1.0 : 0.0;
+ o.g = r.y == 1 ? 1.0 : 0.0;
+ o.b = r.z == -1 ? 1.0 : 0.0;
+ o.a = r.w == -2147483648 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, -1);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int scalar / vec
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingDiv1)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = u / ivec4(2, -1, 1, 3);
+ o.r = r.x == 1 ? 1.0 : 0.0;
+ o.g = r.y == -2 ? 1.0 : 0.0;
+ o.b = r.z == 2 ? 1.0 : 0.0;
+ o.a = r.w == 0 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec / scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingDiv2)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(2, -1, 1, 3) / u;
+ o.r = r.x == 1 ? 1.0 : 0.0;
+ o.g = r.y == 0 ? 1.0 : 0.0;
+ o.b = r.z == 0 ? 1.0 : 0.0;
+ o.a = r.w == 1 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec /= scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingDiv3)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(2, -1, 1, 3);
+ r /= u;
+ o.r = r.x == 1 ? 1.0 : 0.0;
+ o.g = r.y == 0 ? 1.0 : 0.0;
+ o.b = r.z == 0 ? 1.0 : 0.0;
+ o.a = r.w == 1 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int scalar / vec handles UB
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingDivUB)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = u / ivec4(0, -1, 1, 3);
+ o.r = r.x == -2147483648 ? 1.0 : 0.0;
+ // FIXME: ANGLE_div should also handle -INT_MAX / -1
+ // o.g = r.y == -2147483648 ? 1.0 : 0.0;
+ o.g = 1.0;
+ o.b = r.z == -2147483648 ? 1.0 : 0.0;
+ o.a = r.w == -715827882 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, -2147483648);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int scalar % vec
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingMod1)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = u % ivec4(2, 7, 1, 3);
+ o.r = r.x == 0 ? 1.0 : 0.0;
+ o.g = r.y == 2 ? 1.0 : 0.0;
+ o.b = r.z == 0 ? 1.0 : 0.0;
+ o.a = r.w == 2 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec % scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingMod2)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(2147483647, 0, 1, 3) % u;
+ o.r = r.x == 1 ? 1.0 : 0.0;
+ o.g = r.y == 0 ? 1.0 : 0.0;
+ o.b = r.z == 1 ? 1.0 : 0.0;
+ o.a = r.w == 1 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec %= scalar
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingMod3)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(2147483647, 0, 1, 3);
+ r %= u;
+ o.r = r.x == 1 ? 1.0 : 0.0;
+ o.g = r.y == 0 || r.y == 1 ? 1.0 : 0.0;
+ o.b = r.z == 1 ? 1.0 : 0.0;
+ o.a = r.w == 1 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int scalar % vec handles UB
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingModUB)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = u % ivec4(0, -1, 1, 3);
+ o.r = r.x == 0 ? 1.0 : 0.0;
+ o.g = r.y == 0 ? 1.0 : 0.0;
+ o.b = r.z == 0 ? 1.0 : 0.0;
+ o.a = r.w == -2 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, -2147483648);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int float to int vector conversion
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingFtoi1)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform vec4 u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(u);
+ o.r = r.x == 0 ? 1.0 : 0.0;
+ o.g = r.y == -1 ? 1.0 : 0.0;
+ o.b = r.z == -2147483648 ? 1.0 : 0.0;
+ o.a = r.w == 83645 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4f(u, 0., -1., -2147483648., 83645.);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int float to int scalar conversion
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingFtoi2)
+{
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform vec4 u;
+out vec4 o;
+void main() {
+ int rx = int(u.x);
+ int ry = int(u.y);
+ int rz = int(u.z);
+ int rw = int(u.w);
+ o.r = rx == 0 ? 1.0 : 0.0;
+ o.g = ry == -1 ? 1.0 : 0.0;
+ o.b = rz == -2147483648 ? 1.0 : 0.0;
+ o.a = rw == 83645 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4f(u, 0., -1., -2147483648., 83645.);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+//
+// Test highp int float to int vector conversion handles UB
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingFtoiUB1)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform vec4 u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(u);
+ o.r = r.x == 0 ? 1.0 : 0.0;
+ o.g = r.y == -1 ? 1.0 : 0.0;
+ o.b = r.z == -2147483648 ? 1.0 : 0.0;
+ o.a = r.w == 2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4f(u, 0., -1., -2147483649., 2147483648.);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int float to int scalar conversion handles UB
+TEST_P(GLSLTest_ES3, IntVecOperatorOverloadingFtoiUB2)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform vec4 u;
+out vec4 o;
+void main() {
+ int rx = int(u.x);
+ int ry = int(u.y);
+ int rz = int(u.z);
+ int rw = int(u.w);
+ o.r = rx == 0 ? 1.0 : 0.0;
+ o.g = ry == -1 ? 1.0 : 0.0;
+ o.b = rz == -2147483648 ? 1.0 : 0.0;
+ o.a = rw == 2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4f(u, 0., -1., -2147483649., 2147483648.);
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int wrap behavior with plus and minus.
+TEST_P(GLSLTest_ES3, IntVecAdditionSubtractionWrap)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(u) + ivec4(0, -1, 1, 3);
+ r -= ivec4(2147483647, 2147483647, 2147483647, 0);
+ r += ivec4(0, 0, 0, 2147483647);
+ o.r = r.x == -2147483647 ? 1.0 : 0.0;
+ o.g = r.y == -2147483648 ? 1.0 : 0.0;
+ o.b = r.z == -2147483646 ? 1.0 : 0.0;
+ o.a = r.w == -2147483646 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int wrap behavior with multiplication.
+TEST_P(GLSLTest_ES3, IntVecMultiplicationWrap)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(u) + ivec4(-2, 2, 1, -1);
+ r *= ivec4(2147483647, 2147483647, -2147483648, -2147483648);
+ o.r = r.x == 2 ? 1.0 : 0.0;
+ o.g = r.y == -2 ? 1.0 : 0.0;
+ o.b = r.z == -2147483648 ? 1.0 : 0.0;
+ o.a = r.w == -2147483648 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int wrap behavior with division.
+TEST_P(GLSLTest_ES3, IntVecDivisionWrap)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(u) + ivec4(2147483647, 2147483647, -2147483648, -2147483648);
+ r /= ivec4(1, -1, 1, -1);
+ o.r = r.x == 2147483647 ? 1.0 : 0.0;
+ o.g = r.y == -2147483647 ? 1.0 : 0.0;
+ o.b = r.z == -2147483648 ? 1.0 : 0.0;
+ o.a = 1.0;
+
+ // FIXME
+ //o.a = r.w == -2147483648 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int wrap behavior with modulus.
+TEST_P(GLSLTest_ES3, IntScalarModulus)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(u) + ivec4(2147483647, 2147483647, -2147483648, -2147483648);
+ r %= 8;
+ o.r = r.x == 7 ? 1.0 : 0.0;
+ o.g = r.y == 7 ? 1.0 : 0.0;
+ o.b = r.z == 0 ? 1.0 : 0.0;
+ o.a = r.w == 0 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int modulus undefinedness with negative numbers
+TEST_P(GLSLTest_ES3, IntScalarModulusUB1)
+{
+ ANGLE_SKIP_TEST_IF(!IsMetal());
+
+ constexpr char kFS[] = R"(#version 300 es
+precision highp int;
+precision highp float;
+uniform int u;
+out vec4 o;
+void main() {
+ ivec4 r = ivec4(u) + ivec4(-1, 1, -7, 7);
+ r %= 8;
+ o.r = r.x == -1 ? 1.0 : 0.0;
+ o.g = r.y == 1 ? 1.0 : 0.0;
+ o.b = r.z == -7 ? 1.0 : 0.0;
+ o.a = r.w == 7 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl3_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ drawQuad(testProgram, essl31_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
} // anonymous namespace
ANGLE_INSTANTIATE_TEST_ES2_AND_ES3_AND_ES31_AND_ES32(
diff --git a/src/tests/gl_tests/GLSLUBTest.cpp b/src/tests/gl_tests/GLSLUBTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..07d0c1c6fdb07a6661f086356fbe39fdfaccb57e
--- /dev/null
+++ b/src/tests/gl_tests/GLSLUBTest.cpp
@@ -0,0 +1,619 @@
+//
+// Copyright 2025 The ANGLE Project Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+
+#include "test_utils/ANGLETest.h"
+
+#include "test_utils/angle_test_configs.h"
+#include "test_utils/gl_raii.h"
+#include "util/shader_utils.h"
+
+namespace
+{
+using namespace angle;
+
+class GLSLUBTest : public ANGLETest<>
+{
+ protected:
+ GLSLUBTest()
+ {
+ setWindowWidth(128);
+ setWindowHeight(128);
+ setConfigRedBits(8);
+ setConfigGreenBits(8);
+ setConfigBlueBits(8);
+ setConfigAlphaBits(8);
+ }
+};
+
+// grep TEST_P src/tests/gl_tests/GLSLUBTest.cpp
+// For prefixes Add, Sub find:
+// IntInt
+// IntIvec
+// IvecInt
+// IvecIvec
+// AssignIvecInt
+// AssignIvecIvec
+
+// Test int + int with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, AddIntIntOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ int r0 = u + -1;
+ int r1 = u + 0;
+ int r2 = 2147483646 + u;
+ int r3 = u + 2147483647;
+
+ gl_FragColor.r = r0 == 1 ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == 2 ? 1.0 : 0.0;
+ gl_FragColor.b = r2 == -2147483648 ? 1.0 : 0.0;
+ gl_FragColor.a = r3 == -2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test int + ivec overflow. Expect wraparound.
+TEST_P(GLSLUBTest, AddIntIvecOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ ivec4 r = u + ivec4(0, -1, 1, 2147483647);
+ gl_FragColor.r = r.x == 2 ? 1.0 : 0.0;
+ gl_FragColor.g = r.y == 1 ? 1.0 : 0.0;
+ gl_FragColor.b = r.z == 3 ? 1.0 : 0.0;
+ gl_FragColor.a = r.w == -2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test int + ivec overflow. Expect wraparound.
+TEST_P(GLSLUBTest, AddIvecIntOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, 2147483647) + u;
+ gl_FragColor.r = r.x == 2 ? 1.0 : 0.0;
+ gl_FragColor.g = r.y == 1 ? 1.0 : 0.0;
+ gl_FragColor.b = r.z == 3 ? 1.0 : 0.0;
+ gl_FragColor.a = r.w == -2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test ivec + ivec, ivec + int overflow. Expect wraparound.
+TEST_P(GLSLUBTest, AddIvecIvecOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform ivec4 u;
+void main() {
+ ivec4 r0 = u + ivec4(0, -1, 1, 2147483647);
+ ivec4 r1 = ivec4(0, -1, 1, 2147483647) + u;
+ gl_FragColor.r = r0 == r1 ? 1.0 : 0.0;
+ gl_FragColor.g = r0.y == 1 ? 1.0 : 0.0;
+ gl_FragColor.b = r0.z == 3 ? 1.0 : 0.0;
+ gl_FragColor.a = r0.w == -2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4i(u, 2, 2, 2, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp ivec += int overflow. Expect wraparound.
+TEST_P(GLSLUBTest, AddAssignIvecIntOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, 2147483647);
+ r += u;
+ gl_FragColor.r = r.x == 2 ? 1.0 : 0.0;
+ gl_FragColor.g = r.y == 1 ? 1.0 : 0.0;
+ gl_FragColor.b = r.z == 3 ? 1.0 : 0.0;
+ gl_FragColor.a = r.w == -2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp ivec += ivec overflow. Expect wraparound.
+TEST_P(GLSLUBTest, AddAssignIvecIvecOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform ivec4 u;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, 2147483647);
+ r += u;
+ gl_FragColor.r = r.x == 2 ? 1.0 : 0.0;
+ gl_FragColor.g = r.y == 1 ? 1.0 : 0.0;
+ gl_FragColor.b = r.z == 3 ? 1.0 : 0.0;
+ gl_FragColor.a = r.w == -2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4i(u, 2, 2, 2, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test int - int with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, SubIntIntOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ int r0 = u - (-1);
+ int r1 = u - 0;
+ int r2 = -2147483646 - u;
+ int r3 = u - (-2147483647);
+
+ gl_FragColor.r = r0 == 3 ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == 2 ? 1.0 : 0.0;
+ gl_FragColor.b = r2 == 2147483648 ? 1.0 : 0.0;
+ gl_FragColor.a = r3 == -2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int - ivec underflow. Expect wraparound.
+TEST_P(GLSLUBTest, SubIntIvecUnderflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ ivec4 r = u - ivec4(0, -1, 1, 2147483647);
+ gl_FragColor.r = r.x == 2 ? 1.0 : 0.0;
+ gl_FragColor.g = r.y == 3 ? 1.0 : 0.0;
+ gl_FragColor.b = r.z == 1 ? 1.0 : 0.0;
+ gl_FragColor.a = r.w == -2147483645 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp ivec - int underflow. Expect wraparound.
+TEST_P(GLSLUBTest, SubIvecIntUnderflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, -2147483647) - u;
+ gl_FragColor.r = r.x == -2 ? 1.0 : 0.0;
+ gl_FragColor.g = r.y == -3 ? 1.0 : 0.0;
+ gl_FragColor.b = r.z == -1 ? 1.0 : 0.0;
+ gl_FragColor.a = r.w == 2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec -= scalar underflow. Expect wraparound.
+TEST_P(GLSLUBTest, SubAssignIvecIntUnderflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, -2147483647);
+ r -= u;
+ gl_FragColor.r = r.x == -2 ? 1.0 : 0.0;
+ gl_FragColor.g = r.y == -3 ? 1.0 : 0.0;
+ gl_FragColor.b = r.z == -1 ? 1.0 : 0.0;
+ gl_FragColor.a = r.w == 2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test highp int vec -= scalar underflow. Expect wraparound.
+TEST_P(GLSLUBTest, SubAssignIvecIvecUnderflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform ivec4 u;
+void main() {
+ ivec4 r = ivec4(0, -1, 1, -2147483647);
+ r -= u;
+ gl_FragColor.r = r.x == -2 ? 1.0 : 0.0;
+ gl_FragColor.g = r.y == -3 ? 1.0 : 0.0;
+ gl_FragColor.b = r.z == -1 ? 1.0 : 0.0;
+ gl_FragColor.a = r.w == 2147483647 ? 1.0 : 0.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4i(u, 2, 2, 2, 2);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test ++int with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PreIncrementIntOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ int r0 = u;
+ int r1 = ++r0;
+
+ gl_FragColor.r = r0 == -2147483648 ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == -2147483648 ? 1.0 : 0.0;
+ gl_FragColor.b = u == 2147483647 ? 1.0 : 0.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2147483647);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test int++ with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PostIncrementIntOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ int r0 = u;
+ int r1 = r0++;
+
+ gl_FragColor.r = r0 == -2147483648 ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == 2147483647 ? 1.0 : 0.0;
+ gl_FragColor.b = u == 2147483647 ? 1.0 : 0.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2147483647);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test --int with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PreDecrementIntOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ int r0 = u;
+ int r1 = --r0;
+
+ gl_FragColor.r = r0 == 2147483648 ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == 2147483648 ? 1.0 : 0.0;
+ gl_FragColor.b = u == -2147483647 ? 1.0 : 0.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, -2147483647);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test int-- with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PostDecrementIntOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ int r0 = u;
+ int r1 = r0--;
+
+ gl_FragColor.r = r0 == 2147483648 ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == -2147483647 ? 1.0 : 0.0;
+ gl_FragColor.b = u == -2147483647 ? 1.0 : 0.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, -2147483647);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test ++ivec with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PreIncrementIvecOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform ivec4 u;
+void main() {
+ ivec4 r0 = u;
+ ivec4 r1 = ++r0;
+
+ gl_FragColor.r = r0 == ivec4(1, 2, 3, -2147483648) ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == ivec4(1, 2, 3, -2147483648) ? 1.0 : 0.0;
+ gl_FragColor.b = u == ivec4(0, 1, 2, 2147483647) ? 1.0 : 0.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4i(u, 0, 1, 2, 2147483647);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+// Test ivec++ with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PostIncrementIvecOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform ivec4 u;
+void main() {
+ ivec4 r0 = u;
+ ivec4 r1 = r0++;
+
+ gl_FragColor.r = r0 == ivec4(1, 2, 3, -2147483648) ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == ivec4(0, 1, 2, 2147483647) ? 1.0 : 0.0;
+ gl_FragColor.b = u == ivec4(0, 1, 2, 2147483647) ? 1.0 : 0.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4i(u, 0, 1, 2, 2147483647);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test --ivec with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PreDecrementIvecOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform ivec4 u;
+void main() {
+ ivec4 r0 = u;
+ ivec4 r1 = --r0;
+
+ gl_FragColor.r = r0 == ivec4(-1, 0, 1, 2147483648) ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == ivec4(-1, 0, 1, 2147483648) ? 1.0 : 0.0;
+ gl_FragColor.b = u == ivec4(0, 1, 2, -2147483647) ? 1.0 : 0.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4i(u, 0, 1, 2, -2147483647);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test ivec-- with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PostDecrementIvecOverflow)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform ivec4 u;
+void main() {
+ ivec4 r0 = u;
+ ivec4 r1 = r0--;
+
+ gl_FragColor.r = r0 == ivec4(-1, 0, 1, 2147483648) ? 1.0 : 0.0;
+ gl_FragColor.g = r1 == ivec4(0, 1, 2, -2147483647) ? 1.0 : 0.0;
+ gl_FragColor.b = u == ivec4(0, 1, 2, -2147483647) ? 1.0 : 0.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform4i(u, 0, 1, 2, -2147483647);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test int++ with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PostIncrementIntOverflowInForDynamic)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+uniform int u;
+void main() {
+ int z = 0;
+ for (int i = u; i > 4; i++) {
+ z++;
+ }
+ gl_FragColor.r = z == 7 ? 1.0 : 0.0;
+ gl_FragColor.g = u == 2147483641 ? 1.0 : 0.0;
+ gl_FragColor.b = 1.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ GLint u = glGetUniformLocation(testProgram, "u");
+ EXPECT_NE(-1, u);
+ glUniform1i(u, 2147483641);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+// Test int++ with overflow. Expect wraparound.
+TEST_P(GLSLUBTest, PostIncrementIntOverflowInForStatic)
+{
+ constexpr char kFS[] = R"(
+precision highp int;
+precision highp float;
+void main() {
+ int z = 0;
+ for (int i = 2147483642; i > 4; i++) {
+ z++;
+ }
+ gl_FragColor.r = z == 6 ? 1.0 : 0.0;
+ gl_FragColor.g = 1.0;
+ gl_FragColor.b = 1.0;
+ gl_FragColor.a = 1.0;
+}
+)";
+ ANGLE_GL_PROGRAM(testProgram, essl1_shaders::vs::Simple(), kFS);
+ ASSERT_GL_NO_ERROR();
+ glUseProgram(testProgram);
+ drawQuad(testProgram, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
+ EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor(255, 255, 255, 255));
+ ASSERT_GL_NO_ERROR();
+}
+
+} // anonymous namespace
+
+GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(GLSLUBTest);
+ANGLE_INSTANTIATE_TEST(GLSLUBTest, ES2_METAL(), ES3_METAL());
diff --git a/src/tests/gl_tests/ImageTestMetal.mm b/src/tests/gl_tests/ImageTestMetal.mm
index 249ac9bd9f61fc861487ebef064ce67aa8326f77..bcbf46da98cd4a5c7367fa020735d7e642bb7b32 100644
--- a/src/tests/gl_tests/ImageTestMetal.mm
+++ b/src/tests/gl_tests/ImageTestMetal.mm
@@ -19,7 +19,6 @@
#include <CoreFoundation/CoreFoundation.h>
#include <Metal/Metal.h>
-#include <gmock/gmock.h>
#include <span>
namespace angle
diff --git a/src/tests/gl_tests/PbufferTest.cpp b/src/tests/gl_tests/PbufferTest.cpp
index e16d5e0caefa7caea3e932fa78f21478052af0ff..7801fa39b2a80c452c22752057360efa4524ce6d 100644
--- a/src/tests/gl_tests/PbufferTest.cpp
+++ b/src/tests/gl_tests/PbufferTest.cpp
@@ -306,7 +306,6 @@ TEST_P(PbufferTest, BindTexImageOverwrite)
// Test skipped because Pbuffers are not supported or Pbuffer does not support binding to RGBA
// textures.
ANGLE_SKIP_TEST_IF(!mSupportsPbuffers || !mSupportsBindTexImage);
-
EGLWindow *window = getEGLWindow();
window->makeCurrent();
@@ -536,7 +535,6 @@ TEST_P(PbufferTest, BindTexImageOverwriteReleasesOrphanedPbuffer)
// Test skipped because Pbuffers are not supported or Pbuffer does not support binding to RGBA
// textures.
ANGLE_SKIP_TEST_IF(!mSupportsPbuffers || !mSupportsBindTexImage);
-
EGLWindow *window = getEGLWindow();
window->makeCurrent();
diff --git a/src/tests/gl_tests/PixelLocalStorageTest.cpp b/src/tests/gl_tests/PixelLocalStorageTest.cpp
index 992e31e56a8af614c3a9afafec563693edddaa54..dc6045bd1242f7c29a07f64ba39606a81e0fe854 100644
--- a/src/tests/gl_tests/PixelLocalStorageTest.cpp
+++ b/src/tests/gl_tests/PixelLocalStorageTest.cpp
@@ -10,6 +10,7 @@
#include <sstream>
#include <string>
+#include "common/string_utils.h"
#include "test_utils/ANGLETest.h"
#include "test_utils/gl_raii.h"
@@ -8561,7 +8562,6 @@ TEST_P(PixelLocalStorageCompilerTest, BlendEquationAdvanced_illegal_with_PLS)
layout(binding=0, rgba8i) uniform lowp ipixelLocalANGLE pls;)";
EXPECT_TRUE(log.compileFragmentShader(kRequireBlendAdvanced));
- bool before = true;
for (const char *layoutQualifier : {
"blend_support_multiply",
"blend_support_screen",
@@ -8581,44 +8581,34 @@ TEST_P(PixelLocalStorageCompilerTest, BlendEquationAdvanced_illegal_with_PLS)
"blend_support_all_equations",
})
{
- constexpr char kRequireBlendAdvancedBeforePLS[] = R"(#version 300 es
- #extension GL_ANGLE_shader_pixel_local_storage : require
- #extension GL_KHR_blend_equation_advanced : require
- layout(%s) out;
- void main()
- {}
- layout(binding=0, rgba8i) uniform lowp ipixelLocalANGLE pls;)";
-
- constexpr char kRequireBlendAdvancedAfterPLS[] = R"(#version 300 es
- #extension GL_ANGLE_shader_pixel_local_storage : require
- #extension GL_KHR_blend_equation_advanced : require
- layout(binding=0, rgba8i) uniform lowp ipixelLocalANGLE pls;
- layout(%s) out;
- void main()
- {})";
+ std::string shaderBefore = R"(#version 300 es
+#extension GL_ANGLE_shader_pixel_local_storage : require
+#extension GL_KHR_blend_equation_advanced : require
+layout(%s) out;
+void main()
+{}
+layout(binding=0, rgba8i) uniform lowp ipixelLocalANGLE pls;)";
+ ReplaceSubstring(&shaderBefore, "%s", layoutQualifier);
- const char *formatStr =
- before ? kRequireBlendAdvancedBeforePLS : kRequireBlendAdvancedAfterPLS;
- size_t buffSize =
- snprintf(nullptr, 0, formatStr, layoutQualifier) + 1; // Extra space for '\0'
- std::unique_ptr<char[]> shader(new char[buffSize]);
- std::snprintf(shader.get(), buffSize, formatStr, layoutQualifier);
- EXPECT_FALSE(log.compileFragmentShader(shader.get()));
- if (before)
- {
+ EXPECT_FALSE(log.compileFragmentShader(shaderBefore.c_str()));
EXPECT_TRUE(
log.has("ERROR: 0:4: 'layout' : illegal advanced blend equation when pixel local "
"storage is declared"));
- }
- else
- {
+
+ std::string shaderAfter = R"(#version 300 es
+#extension GL_ANGLE_shader_pixel_local_storage : require
+#extension GL_KHR_blend_equation_advanced : require
+layout(binding=0, rgba8i) uniform lowp ipixelLocalANGLE pls;
+layout(%s) out;
+void main()
+{})";
+ ReplaceSubstring(&shaderAfter, "%s", layoutQualifier);
+
+ EXPECT_FALSE(log.compileFragmentShader(shaderAfter.c_str()));
EXPECT_TRUE(
log.has("ERROR: 0:5: 'layout' : illegal advanced blend equation when pixel local "
"storage is declared"));
}
-
- before = !before;
- }
}
// Check proper validation of PLS function arguments.
diff --git a/src/tests/gl_tests/ProvokingVertexTest.cpp b/src/tests/gl_tests/ProvokingVertexTest.cpp
index 521576e38550d6cf4cd03b27c9247e70d609f0c5..f731f1de96a7c808648c3c24eb19378bcdab8b09 100644
--- a/src/tests/gl_tests/ProvokingVertexTest.cpp
+++ b/src/tests/gl_tests/ProvokingVertexTest.cpp
@@ -16,7 +16,6 @@
#include "GLES2/gl2.h"
#include "test_utils/ANGLETest.h"
#include "test_utils/gl_raii.h"
-#include "util/gles_loader_autogen.h"
using namespace angle;
diff --git a/src/tests/gl_tests/RobustResourceInitTest.cpp b/src/tests/gl_tests/RobustResourceInitTest.cpp
index 5beb889e3d6c1cb3146689ea60d943ec1591be88..ad6230076e459c6be9f107d5dfbc6cc6d8d26f22 100644
--- a/src/tests/gl_tests/RobustResourceInitTest.cpp
+++ b/src/tests/gl_tests/RobustResourceInitTest.cpp
@@ -13,7 +13,6 @@
#include "test_utils/gl_raii.h"
#include "util/EGLWindow.h"
-#include "util/gles_loader_autogen.h"
namespace angle
{
diff --git a/src/tests/gl_tests/SamplersTest.cpp b/src/tests/gl_tests/SamplersTest.cpp
index 9714891f821e4c1ca01b9e6eebd70690a2f85a8f..e90e9a97754ab5aebcdcf7ad948ae5aa2de6cc12 100644
--- a/src/tests/gl_tests/SamplersTest.cpp
+++ b/src/tests/gl_tests/SamplersTest.cpp
@@ -15,7 +15,6 @@
#include "test_utils/angle_test_configs.h"
#include "test_utils/gl_raii.h"
-#include "util/gles_loader_autogen.h"
#include "util/shader_utils.h"
namespace angle
diff --git a/src/tests/gl_tests/TextureTest.cpp b/src/tests/gl_tests/TextureTest.cpp
index 762324b02b48d46e15851086492f2ca6fed1f610..2ed9936d2f70628ea951d27be86b8ebb0d86ca0e 100644
--- a/src/tests/gl_tests/TextureTest.cpp
+++ b/src/tests/gl_tests/TextureTest.cpp
@@ -2005,6 +2005,7 @@ void Texture2DDepthStencilTestES3::TestSampleWithDepthStencilMode(GLenum format,
break;
default:
UNREACHABLE();
+ return;
}
// Set up a color texture.
@@ -11392,7 +11393,7 @@ class TextureLimitsTest : public ANGLETest<>
initTextures(vertexTextureCount + fragmentTextureCount, 0);
glUseProgram(mProgram);
- RGBA8 expectedSum = {0};
+ RGBA8 expectedSum{};
for (GLint texIndex = 0; texIndex < vertexTextureCount; ++texIndex)
{
std::stringstream uniformNameStr;
diff --git a/src/tests/gl_tests/TransformFeedbackTest.cpp b/src/tests/gl_tests/TransformFeedbackTest.cpp
index d8f65dd2a11945044444063284551419a22c7e1e..f85b6d60dc5009dcbd798a9c492c24381abe05d2 100644
--- a/src/tests/gl_tests/TransformFeedbackTest.cpp
+++ b/src/tests/gl_tests/TransformFeedbackTest.cpp
@@ -11,7 +11,6 @@
#include "test_utils/ANGLETest.h"
#include "test_utils/gl_raii.h"
#include "util/EGLWindow.h"
-#include "util/gles_loader_autogen.h"
#include "util/random_utils.h"
#include "util/test_utils.h"
diff --git a/src/tests/gl_tests/UniformTest.cpp b/src/tests/gl_tests/UniformTest.cpp
index 598669fa9183e15c5af5ae4758cd68ac6b21c6d1..a02865c78f6f5a995d429402e326c03b4260e6ce 100644
--- a/src/tests/gl_tests/UniformTest.cpp
+++ b/src/tests/gl_tests/UniformTest.cpp
@@ -13,7 +13,6 @@
#include "test_utils/angle_test_configs.h"
#include "test_utils/angle_test_instantiate.h"
#include "test_utils/gl_raii.h"
-#include "util/gles_loader_autogen.h"
#include "util/shader_utils.h"
#include <array>
@@ -2590,7 +2589,7 @@ TEST_P(UniformTestES3, MatrixUniformUpload)
matrixValues[i] = static_cast<GLfloat>(i);
}
- using UniformMatrixCxRfv = decltype(glUniformMatrix2fv);
+ using UniformMatrixCxRfv = GL_APIENTRY void (*)(GLint, GLsizei, GLboolean, const GLfloat *);
UniformMatrixCxRfv uniformMatrixCxRfv[kMaxDims + 1][kMaxDims + 1] = {
{nullptr, nullptr, nullptr, nullptr, nullptr},
{nullptr, nullptr, nullptr, nullptr, nullptr},
diff --git a/third_party/re2/BUILD.gn b/third_party/re2/BUILD.gn
deleted file mode 100644
index da398564a23289504620f60beef8d0270d797642..0000000000000000000000000000000000000000
--- a/third_party/re2/BUILD.gn
+++ /dev/null
@@ -1,62 +0,0 @@
-# Copyright 2014 The Chromium Authors
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import("//testing/libfuzzer/fuzzer_test.gni")
-
-config("re2_config") {
- include_dirs = [ "src" ]
-}
-
-static_library("re2") {
- sources = [
- "src/re2/bitmap256.cc",
- "src/re2/bitmap256.h",
- "src/re2/bitstate.cc",
- "src/re2/compile.cc",
- "src/re2/dfa.cc",
- "src/re2/filtered_re2.cc",
- "src/re2/filtered_re2.h",
- "src/re2/mimics_pcre.cc",
- "src/re2/nfa.cc",
- "src/re2/onepass.cc",
- "src/re2/parse.cc",
- "src/re2/perl_groups.cc",
- "src/re2/prefilter.cc",
- "src/re2/prefilter.h",
- "src/re2/prefilter_tree.cc",
- "src/re2/prefilter_tree.h",
- "src/re2/prog.cc",
- "src/re2/prog.h",
- "src/re2/re2.cc",
- "src/re2/re2.h",
- "src/re2/regexp.cc",
- "src/re2/regexp.h",
- "src/re2/set.cc",
- "src/re2/set.h",
- "src/re2/simplify.cc",
- "src/re2/sparse_array.h",
- "src/re2/sparse_set.h",
- "src/re2/stringpiece.h",
- "src/re2/tostring.cc",
- "src/re2/unicode_casefold.cc",
- "src/re2/unicode_casefold.h",
- "src/re2/unicode_groups.cc",
- "src/re2/unicode_groups.h",
- "src/re2/walker-inl.h",
- "src/util/rune.cc",
- "src/util/strutil.cc",
- "src/util/strutil.h",
- "src/util/utf.h",
- ]
-
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
- public_configs = [ ":re2_config" ]
- public_deps = [ "//third_party/abseil-cpp:absl" ]
-}
-
-fuzzer_test("third_party_re2_fuzzer") {
- sources = [ "src/re2/fuzzing/re2_fuzzer.cc" ]
- deps = [ ":re2" ]
-}
diff --git a/third_party/re2/DEPS b/third_party/re2/DEPS
deleted file mode 100644
index 82c266c5b6241311da0f83a433d0364f32fc514c..0000000000000000000000000000000000000000
--- a/third_party/re2/DEPS
+++ /dev/null
@@ -1,7 +0,0 @@
-include_rules = [
- '+base',
- '+build',
- '+re2',
- '+utest',
- '+util',
-]
diff --git a/third_party/re2/DIR_METADATA b/third_party/re2/DIR_METADATA
deleted file mode 100644
index 45f7798a6860a53fdfe22765e9d0bee9e1d67678..0000000000000000000000000000000000000000
--- a/third_party/re2/DIR_METADATA
+++ /dev/null
@@ -1,6 +0,0 @@
-monorail: {
- component: "Internals"
-}
-buganizer_public: {
- component_id: 1456292
-}
diff --git a/third_party/re2/LICENSE b/third_party/re2/LICENSE
deleted file mode 100644
index 09e5ec1c74c187adc8fde6c74308c3492ef31f77..0000000000000000000000000000000000000000
--- a/third_party/re2/LICENSE
+++ /dev/null
@@ -1,27 +0,0 @@
-// Copyright (c) 2009 The RE2 Authors. All rights reserved.
-//
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions are
-// met:
-//
-// * Redistributions of source code must retain the above copyright
-// notice, this list of conditions and the following disclaimer.
-// * Redistributions in binary form must reproduce the above
-// copyright notice, this list of conditions and the following disclaimer
-// in the documentation and/or other materials provided with the
-// distribution.
-// * Neither the name of Google Inc. nor the names of its
-// contributors may be used to endorse or promote products derived from
-// this software without specific prior written permission.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff --git a/third_party/re2/OWNERS b/third_party/re2/OWNERS
deleted file mode 100644
index e542f4adc50dc2cfa81fc6a1db6f604959eb4ce6..0000000000000000000000000000000000000000
--- a/third_party/re2/OWNERS
+++ /dev/null
@@ -1,2 +0,0 @@
-junyer@chromium.org
-thakis@chromium.org
diff --git a/third_party/re2/README.chromium b/third_party/re2/README.chromium
deleted file mode 100644
index e4e6ef77acc545582c9603b956c53ccfb8472b8c..0000000000000000000000000000000000000000
--- a/third_party/re2/README.chromium
+++ /dev/null
@@ -1,13 +0,0 @@
-Name: re2 - an efficient, principled regular expression library
-Short Name: re2
-URL: https://github.com/google/re2
-Version: 1e44e72d31ddc66b783a545e9d9fcaa876a146b7
-Date: 2023-05-31
-License: BSD-3-Clause
-License File: LICENSE
-Security Critical: yes
-Shipped: yes
-
-Description:
-RE2 is a fast, safe, thread-friendly alternative to backtracking regular
-expression engines like those used in PCRE, Perl, and Python.
diff --git a/util/autogen/angle_features_autogen.cpp b/util/autogen/angle_features_autogen.cpp
index 6f9b7936880fbc4ee4b679e648dd149c32086c82..67200b1a8d1e618828a4e994a56227883b82de8c 100644
--- a/util/autogen/angle_features_autogen.cpp
+++ b/util/autogen/angle_features_autogen.cpp
@@ -214,6 +214,7 @@ constexpr PackedEnumMap<Feature, const char *> kFeatureNames = {{
{Feature::HasShaderStencilOutput, "hasShaderStencilOutput"},
{Feature::HasStencilAutoResolve, "hasStencilAutoResolve"},
{Feature::HasTextureSwizzle, "hasTextureSwizzle"},
+ {Feature::HasVariableRasterizationRate, "hasVariableRasterizationRate"},
{Feature::InitFragmentOutputVariables, "initFragmentOutputVariables"},
{Feature::InitializeCurrentVertexAttributes, "initializeCurrentVertexAttributes"},
{Feature::InjectAsmStatementIntoLoopBodies, "injectAsmStatementIntoLoopBodies"},
diff --git a/util/autogen/angle_features_autogen.h b/util/autogen/angle_features_autogen.h
index efa668f0258ab3b77ed01aed0a97c231f462adee..4973d096498c6b01f246d338746047cc35ca1552 100644
--- a/util/autogen/angle_features_autogen.h
+++ b/util/autogen/angle_features_autogen.h
@@ -214,6 +214,7 @@ enum class Feature
HasShaderStencilOutput,
HasStencilAutoResolve,
HasTextureSwizzle,
+ HasVariableRasterizationRate,
InitFragmentOutputVariables,
InitializeCurrentVertexAttributes,
InjectAsmStatementIntoLoopBodies,
diff --git a/util/capture/frame_capture_replay_autogen.cpp b/util/capture/frame_capture_replay_autogen.cpp
index d963c6dbbdb39003c44ee97996593c90e479516b..7f4bf9d219ffb13fc1b78bc7c220fb48fb3e6e7d 100644
--- a/util/capture/frame_capture_replay_autogen.cpp
+++ b/util/capture/frame_capture_replay_autogen.cpp
@@ -105,6 +105,10 @@ void ReplayTraceFunctionCall(const CallCapture &call, const TraceFunctionMap &cu
captures[3].value.GLbooleanVal, captures[4].value.GLintVal,
captures[5].value.GLenumVal, captures[6].value.GLenumVal);
break;
+ case angle::EntryPoint::GLBindMetalRasterizationRateMapANGLE:
+ glBindMetalRasterizationRateMapANGLE(
+ captures[0].value.GLuintVal, captures[1].value.GLMTLRasterizationRateMapANGLEVal);
+ break;
case angle::EntryPoint::GLBindProgramPipeline:
glBindProgramPipeline(gProgramPipelineMap[captures[0].value.GLuintVal]);
break;
@@ -1055,6 +1059,11 @@ void ReplayTraceFunctionCall(const CallCapture &call, const TraceFunctionMap &cu
captures[2].value.GLenumVal,
gRenderbufferMap[captures[3].value.GLuintVal]);
break;
+ case angle::EntryPoint::GLFramebufferResolveRenderbufferWEBKIT:
+ glFramebufferResolveRenderbufferWEBKIT(
+ captures[0].value.GLenumVal, captures[1].value.GLenumVal,
+ captures[2].value.GLenumVal, gRenderbufferMap[captures[3].value.GLuintVal]);
+ break;
case angle::EntryPoint::GLFramebufferShadingRateEXT:
glFramebufferShadingRateEXT(captures[0].value.GLenumVal, captures[1].value.GLenumVal,
captures[2].value.GLuintVal, captures[3].value.GLintVal,
diff --git a/util/capture/trace_gles_loader_autogen.cpp b/util/capture/trace_gles_loader_autogen.cpp
index 75fe6e0b4b9ebab89464b249ff6a2addfde93727..2f317f49ec0b0628407913ca33ba25de6501df1c 100644
--- a/util/capture/trace_gles_loader_autogen.cpp
+++ b/util/capture/trace_gles_loader_autogen.cpp
@@ -632,6 +632,8 @@ ANGLE_TRACE_LOADER_EXPORT PFNGLSAMPLEMASKIANGLEPROC t_glSampleMaskiANGLE;
ANGLE_TRACE_LOADER_EXPORT PFNGLTEXSTORAGE2DMULTISAMPLEANGLEPROC t_glTexStorage2DMultisampleANGLE;
ANGLE_TRACE_LOADER_EXPORT PFNGLGETTRANSLATEDSHADERSOURCEANGLEPROC
t_glGetTranslatedShaderSourceANGLE;
+ANGLE_TRACE_LOADER_EXPORT PFNGLBINDMETALRASTERIZATIONRATEMAPANGLEPROC
+ t_glBindMetalRasterizationRateMapANGLE;
ANGLE_TRACE_LOADER_EXPORT PFNGLACQUIRETEXTURESANGLEPROC t_glAcquireTexturesANGLE;
ANGLE_TRACE_LOADER_EXPORT PFNGLRELEASETEXTURESANGLEPROC t_glReleaseTexturesANGLE;
ANGLE_TRACE_LOADER_EXPORT PFNGLBINDUNIFORMLOCATIONCHROMIUMPROC t_glBindUniformLocationCHROMIUM;
@@ -885,6 +887,8 @@ ANGLE_TRACE_LOADER_EXPORT PFNGLTEXTUREFOVEATIONPARAMETERSQCOMPROC
t_glTextureFoveationParametersQCOM;
ANGLE_TRACE_LOADER_EXPORT PFNGLENDTILINGQCOMPROC t_glEndTilingQCOM;
ANGLE_TRACE_LOADER_EXPORT PFNGLSTARTTILINGQCOMPROC t_glStartTilingQCOM;
+ANGLE_TRACE_LOADER_EXPORT PFNGLFRAMEBUFFERRESOLVERENDERBUFFERWEBKITPROC
+ t_glFramebufferResolveRenderbufferWEBKIT;
ANGLE_TRACE_LOADER_EXPORT PFNGLBLENDEQUATIONOESPROC t_glBlendEquationOES;
ANGLE_TRACE_LOADER_EXPORT PFNGLDRAWTEXFOESPROC t_glDrawTexfOES;
ANGLE_TRACE_LOADER_EXPORT PFNGLDRAWTEXFVOESPROC t_glDrawTexfvOES;
@@ -1856,6 +1860,9 @@ void LoadTraceGLES(LoadProc loadProc)
loadProc("glTexStorage2DMultisampleANGLE"));
t_glGetTranslatedShaderSourceANGLE = reinterpret_cast<PFNGLGETTRANSLATEDSHADERSOURCEANGLEPROC>(
loadProc("glGetTranslatedShaderSourceANGLE"));
+ t_glBindMetalRasterizationRateMapANGLE =
+ reinterpret_cast<PFNGLBINDMETALRASTERIZATIONRATEMAPANGLEPROC>(
+ loadProc("glBindMetalRasterizationRateMapANGLE"));
t_glAcquireTexturesANGLE =
reinterpret_cast<PFNGLACQUIRETEXTURESANGLEPROC>(loadProc("glAcquireTexturesANGLE"));
t_glReleaseTexturesANGLE =
@@ -2294,6 +2301,9 @@ void LoadTraceGLES(LoadProc loadProc)
loadProc("glTextureFoveationParametersQCOM"));
t_glEndTilingQCOM = reinterpret_cast<PFNGLENDTILINGQCOMPROC>(loadProc("glEndTilingQCOM"));
t_glStartTilingQCOM = reinterpret_cast<PFNGLSTARTTILINGQCOMPROC>(loadProc("glStartTilingQCOM"));
+ t_glFramebufferResolveRenderbufferWEBKIT =
+ reinterpret_cast<PFNGLFRAMEBUFFERRESOLVERENDERBUFFERWEBKITPROC>(
+ loadProc("glFramebufferResolveRenderbufferWEBKIT"));
t_glBlendEquationOES =
reinterpret_cast<PFNGLBLENDEQUATIONOESPROC>(loadProc("glBlendEquationOES"));
t_glDrawTexfOES = reinterpret_cast<PFNGLDRAWTEXFOESPROC>(loadProc("glDrawTexfOES"));
diff --git a/util/capture/trace_gles_loader_autogen.h b/util/capture/trace_gles_loader_autogen.h
index a86bd89a09353c60e90f99177846ceb78e29a545..16a7f95f8c8fa01ce1220247fca9e046a358bb76 100644
--- a/util/capture/trace_gles_loader_autogen.h
+++ b/util/capture/trace_gles_loader_autogen.h
@@ -597,6 +597,7 @@
#define glSampleMaskiANGLE t_glSampleMaskiANGLE
#define glTexStorage2DMultisampleANGLE t_glTexStorage2DMultisampleANGLE
#define glGetTranslatedShaderSourceANGLE t_glGetTranslatedShaderSourceANGLE
+#define glBindMetalRasterizationRateMapANGLE t_glBindMetalRasterizationRateMapANGLE
#define glAcquireTexturesANGLE t_glAcquireTexturesANGLE
#define glReleaseTexturesANGLE t_glReleaseTexturesANGLE
#define glBindUniformLocationCHROMIUM t_glBindUniformLocationCHROMIUM
@@ -834,6 +835,7 @@
#define glTextureFoveationParametersQCOM t_glTextureFoveationParametersQCOM
#define glEndTilingQCOM t_glEndTilingQCOM
#define glStartTilingQCOM t_glStartTilingQCOM
+#define glFramebufferResolveRenderbufferWEBKIT t_glFramebufferResolveRenderbufferWEBKIT
#define glBlendEquationOES t_glBlendEquationOES
#define glDrawTexfOES t_glDrawTexfOES
#define glDrawTexfvOES t_glDrawTexfvOES
@@ -1525,6 +1527,8 @@ ANGLE_TRACE_LOADER_EXPORT extern PFNGLTEXSTORAGE2DMULTISAMPLEANGLEPROC
t_glTexStorage2DMultisampleANGLE;
ANGLE_TRACE_LOADER_EXPORT extern PFNGLGETTRANSLATEDSHADERSOURCEANGLEPROC
t_glGetTranslatedShaderSourceANGLE;
+ANGLE_TRACE_LOADER_EXPORT extern PFNGLBINDMETALRASTERIZATIONRATEMAPANGLEPROC
+ t_glBindMetalRasterizationRateMapANGLE;
ANGLE_TRACE_LOADER_EXPORT extern PFNGLACQUIRETEXTURESANGLEPROC t_glAcquireTexturesANGLE;
ANGLE_TRACE_LOADER_EXPORT extern PFNGLRELEASETEXTURESANGLEPROC t_glReleaseTexturesANGLE;
ANGLE_TRACE_LOADER_EXPORT extern PFNGLBINDUNIFORMLOCATIONCHROMIUMPROC
@@ -1795,6 +1799,8 @@ ANGLE_TRACE_LOADER_EXPORT extern PFNGLTEXTUREFOVEATIONPARAMETERSQCOMPROC
t_glTextureFoveationParametersQCOM;
ANGLE_TRACE_LOADER_EXPORT extern PFNGLENDTILINGQCOMPROC t_glEndTilingQCOM;
ANGLE_TRACE_LOADER_EXPORT extern PFNGLSTARTTILINGQCOMPROC t_glStartTilingQCOM;
+ANGLE_TRACE_LOADER_EXPORT extern PFNGLFRAMEBUFFERRESOLVERENDERBUFFERWEBKITPROC
+ t_glFramebufferResolveRenderbufferWEBKIT;
ANGLE_TRACE_LOADER_EXPORT extern PFNGLBLENDEQUATIONOESPROC t_glBlendEquationOES;
ANGLE_TRACE_LOADER_EXPORT extern PFNGLDRAWTEXFOESPROC t_glDrawTexfOES;
ANGLE_TRACE_LOADER_EXPORT extern PFNGLDRAWTEXFVOESPROC t_glDrawTexfvOES;
diff --git a/util/capture/trace_interpreter_autogen.cpp b/util/capture/trace_interpreter_autogen.cpp
index caef131a0f80676830e964c7968b18d5a7b0e1ca..8c778e194bce4995254e6b2701240d3fbb78a12f 100644
--- a/util/capture/trace_interpreter_autogen.cpp
+++ b/util/capture/trace_interpreter_autogen.cpp
@@ -910,6 +910,13 @@ CallCapture ParseCallCapture(const Token &nameToken,
paramTokens, strings);
return CallCapture(EntryPoint::GLBindImageTexture, std::move(params));
}
+ if (strcmp(nameToken, "glBindMetalRasterizationRateMapANGLE") == 0)
+ {
+ ParamBuffer params =
+ ParseParameters<std::remove_pointer<PFNGLBINDMETALRASTERIZATIONRATEMAPANGLEPROC>::type>(
+ paramTokens, strings);
+ return CallCapture(EntryPoint::GLBindMetalRasterizationRateMapANGLE, std::move(params));
+ }
if (strcmp(nameToken, "glBindProgramPipeline") == 0)
{
ParamBuffer params =
@@ -2310,6 +2317,13 @@ CallCapture ParseCallCapture(const Token &nameToken,
paramTokens, strings);
return CallCapture(EntryPoint::GLFramebufferRenderbufferOES, std::move(params));
}
+ if (strcmp(nameToken, "glFramebufferResolveRenderbufferWEBKIT") == 0)
+ {
+ ParamBuffer params = ParseParameters<
+ std::remove_pointer<PFNGLFRAMEBUFFERRESOLVERENDERBUFFERWEBKITPROC>::type>(paramTokens,
+ strings);
+ return CallCapture(EntryPoint::GLFramebufferResolveRenderbufferWEBKIT, std::move(params));
+ }
if (strcmp(nameToken, "glFramebufferShadingRateEXT") == 0)
{
ParamBuffer params =
diff --git a/util/gles_loader_autogen.cpp b/util/gles_loader_autogen.cpp
index eb645669d37a83516f6d7fe5dffc1fb856809b2b..54024068b0061eb92d72abb419517a46583b4d81 100644
--- a/util/gles_loader_autogen.cpp
+++ b/util/gles_loader_autogen.cpp
@@ -609,6 +609,8 @@ ANGLE_UTIL_EXPORT PFNGLGETMULTISAMPLEFVANGLEPROC l_glGetMultisamplefvANGLE;
ANGLE_UTIL_EXPORT PFNGLSAMPLEMASKIANGLEPROC l_glSampleMaskiANGLE;
ANGLE_UTIL_EXPORT PFNGLTEXSTORAGE2DMULTISAMPLEANGLEPROC l_glTexStorage2DMultisampleANGLE;
ANGLE_UTIL_EXPORT PFNGLGETTRANSLATEDSHADERSOURCEANGLEPROC l_glGetTranslatedShaderSourceANGLE;
+ANGLE_UTIL_EXPORT PFNGLBINDMETALRASTERIZATIONRATEMAPANGLEPROC
+ l_glBindMetalRasterizationRateMapANGLE;
ANGLE_UTIL_EXPORT PFNGLACQUIRETEXTURESANGLEPROC l_glAcquireTexturesANGLE;
ANGLE_UTIL_EXPORT PFNGLRELEASETEXTURESANGLEPROC l_glReleaseTexturesANGLE;
ANGLE_UTIL_EXPORT PFNGLBINDUNIFORMLOCATIONCHROMIUMPROC l_glBindUniformLocationCHROMIUM;
@@ -854,6 +856,8 @@ ANGLE_UTIL_EXPORT PFNGLSHADINGRATEQCOMPROC l_glShadingRateQCOM;
ANGLE_UTIL_EXPORT PFNGLTEXTUREFOVEATIONPARAMETERSQCOMPROC l_glTextureFoveationParametersQCOM;
ANGLE_UTIL_EXPORT PFNGLENDTILINGQCOMPROC l_glEndTilingQCOM;
ANGLE_UTIL_EXPORT PFNGLSTARTTILINGQCOMPROC l_glStartTilingQCOM;
+ANGLE_UTIL_EXPORT PFNGLFRAMEBUFFERRESOLVERENDERBUFFERWEBKITPROC
+ l_glFramebufferResolveRenderbufferWEBKIT;
ANGLE_UTIL_EXPORT PFNGLBLENDEQUATIONOESPROC l_glBlendEquationOES;
ANGLE_UTIL_EXPORT PFNGLDRAWTEXFOESPROC l_glDrawTexfOES;
ANGLE_UTIL_EXPORT PFNGLDRAWTEXFVOESPROC l_glDrawTexfvOES;
@@ -1824,6 +1828,9 @@ void LoadUtilGLES(LoadProc loadProc)
loadProc("glTexStorage2DMultisampleANGLE"));
l_glGetTranslatedShaderSourceANGLE = reinterpret_cast<PFNGLGETTRANSLATEDSHADERSOURCEANGLEPROC>(
loadProc("glGetTranslatedShaderSourceANGLE"));
+ l_glBindMetalRasterizationRateMapANGLE =
+ reinterpret_cast<PFNGLBINDMETALRASTERIZATIONRATEMAPANGLEPROC>(
+ loadProc("glBindMetalRasterizationRateMapANGLE"));
l_glAcquireTexturesANGLE =
reinterpret_cast<PFNGLACQUIRETEXTURESANGLEPROC>(loadProc("glAcquireTexturesANGLE"));
l_glReleaseTexturesANGLE =
@@ -2262,6 +2269,9 @@ void LoadUtilGLES(LoadProc loadProc)
loadProc("glTextureFoveationParametersQCOM"));
l_glEndTilingQCOM = reinterpret_cast<PFNGLENDTILINGQCOMPROC>(loadProc("glEndTilingQCOM"));
l_glStartTilingQCOM = reinterpret_cast<PFNGLSTARTTILINGQCOMPROC>(loadProc("glStartTilingQCOM"));
+ l_glFramebufferResolveRenderbufferWEBKIT =
+ reinterpret_cast<PFNGLFRAMEBUFFERRESOLVERENDERBUFFERWEBKITPROC>(
+ loadProc("glFramebufferResolveRenderbufferWEBKIT"));
l_glBlendEquationOES =
reinterpret_cast<PFNGLBLENDEQUATIONOESPROC>(loadProc("glBlendEquationOES"));
l_glDrawTexfOES = reinterpret_cast<PFNGLDRAWTEXFOESPROC>(loadProc("glDrawTexfOES"));
diff --git a/util/gles_loader_autogen.h b/util/gles_loader_autogen.h
index ebf31ebca3dbece1e2ced9e3900c1bdd5952972b..7b5a493ebb9c246528730198bfa21636dfbf4921 100644
--- a/util/gles_loader_autogen.h
+++ b/util/gles_loader_autogen.h
@@ -597,6 +597,7 @@
#define glSampleMaskiANGLE l_glSampleMaskiANGLE
#define glTexStorage2DMultisampleANGLE l_glTexStorage2DMultisampleANGLE
#define glGetTranslatedShaderSourceANGLE l_glGetTranslatedShaderSourceANGLE
+#define glBindMetalRasterizationRateMapANGLE l_glBindMetalRasterizationRateMapANGLE
#define glAcquireTexturesANGLE l_glAcquireTexturesANGLE
#define glReleaseTexturesANGLE l_glReleaseTexturesANGLE
#define glBindUniformLocationCHROMIUM l_glBindUniformLocationCHROMIUM
@@ -834,6 +835,7 @@
#define glTextureFoveationParametersQCOM l_glTextureFoveationParametersQCOM
#define glEndTilingQCOM l_glEndTilingQCOM
#define glStartTilingQCOM l_glStartTilingQCOM
+#define glFramebufferResolveRenderbufferWEBKIT l_glFramebufferResolveRenderbufferWEBKIT
#define glBlendEquationOES l_glBlendEquationOES
#define glDrawTexfOES l_glDrawTexfOES
#define glDrawTexfvOES l_glDrawTexfvOES
@@ -1490,6 +1492,8 @@ ANGLE_UTIL_EXPORT extern PFNGLGETMULTISAMPLEFVANGLEPROC l_glGetMultisamplefvANGL
ANGLE_UTIL_EXPORT extern PFNGLSAMPLEMASKIANGLEPROC l_glSampleMaskiANGLE;
ANGLE_UTIL_EXPORT extern PFNGLTEXSTORAGE2DMULTISAMPLEANGLEPROC l_glTexStorage2DMultisampleANGLE;
ANGLE_UTIL_EXPORT extern PFNGLGETTRANSLATEDSHADERSOURCEANGLEPROC l_glGetTranslatedShaderSourceANGLE;
+ANGLE_UTIL_EXPORT extern PFNGLBINDMETALRASTERIZATIONRATEMAPANGLEPROC
+ l_glBindMetalRasterizationRateMapANGLE;
ANGLE_UTIL_EXPORT extern PFNGLACQUIRETEXTURESANGLEPROC l_glAcquireTexturesANGLE;
ANGLE_UTIL_EXPORT extern PFNGLRELEASETEXTURESANGLEPROC l_glReleaseTexturesANGLE;
ANGLE_UTIL_EXPORT extern PFNGLBINDUNIFORMLOCATIONCHROMIUMPROC l_glBindUniformLocationCHROMIUM;
@@ -1736,6 +1740,8 @@ ANGLE_UTIL_EXPORT extern PFNGLSHADINGRATEQCOMPROC l_glShadingRateQCOM;
ANGLE_UTIL_EXPORT extern PFNGLTEXTUREFOVEATIONPARAMETERSQCOMPROC l_glTextureFoveationParametersQCOM;
ANGLE_UTIL_EXPORT extern PFNGLENDTILINGQCOMPROC l_glEndTilingQCOM;
ANGLE_UTIL_EXPORT extern PFNGLSTARTTILINGQCOMPROC l_glStartTilingQCOM;
+ANGLE_UTIL_EXPORT extern PFNGLFRAMEBUFFERRESOLVERENDERBUFFERWEBKITPROC
+ l_glFramebufferResolveRenderbufferWEBKIT;
ANGLE_UTIL_EXPORT extern PFNGLBLENDEQUATIONOESPROC l_glBlendEquationOES;
ANGLE_UTIL_EXPORT extern PFNGLDRAWTEXFOESPROC l_glDrawTexfOES;
ANGLE_UTIL_EXPORT extern PFNGLDRAWTEXFVOESPROC l_glDrawTexfvOES;
diff --git a/util/ios/ios_main.mm b/util/ios/ios_main.mm
index 6df44200413599cbee17741ac8d74380f694bdff..1c8cdb539081b41661c1d96b9058969fcba8ecc0 100644
--- a/util/ios/ios_main.mm
+++ b/util/ios/ios_main.mm
@@ -12,9 +12,9 @@
#include <stdio.h>
static int original_argc;
-static char **original_argv;
+static char *_Nullable *_Nullable original_argv = nullptr;
-int main(int argc, char **argv);
+int main(int argc, char *_Nullable *_Nullable argv);
@interface AngleUtilAppDelegate : UIResponder <UIApplicationDelegate>
@@ -31,8 +31,8 @@ int main(int argc, char **argv);
exit(main(original_argc, original_argv));
}
-- (BOOL)application:(UIApplication *)application
- didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
+- (BOOL)application:(UIApplication *_Nonnull)application
+ didFinishLaunchingWithOptions:(NSDictionary *_Nullable)launchOptions
{
self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
self.window.rootViewController = [[UIViewController alloc] initWithNibName:nil bundle:nil];
@@ -49,7 +49,7 @@ int main(int argc, char **argv);
@end
-extern "C" int ios_main(int argc, char **argv)
+extern "C" int ios_main(int argc, char *_Nonnull *_Nonnull argv)
{
original_argc = argc;
original_argv = argv;
diff --git a/util/posix/test_utils_posix.cpp b/util/posix/test_utils_posix.cpp
index 92dfa30ef88288bceddf4d4447ebeac2fa93311c..5ab5a5c9bd9823cea71cadb3a213817a17c8e0ba 100644
--- a/util/posix/test_utils_posix.cpp
+++ b/util/posix/test_utils_posix.cpp
@@ -360,7 +360,9 @@ void WriteDebugMessage(const char *format, ...)
{
va_list vararg;
va_start(vararg, format);
+ANGLE_DISABLE_NONLITERAL_FORMAT_WARNING
vfprintf(stderr, format, vararg);
+ANGLE_REENABLE_NONLITERAL_FORMAT_WARNING
va_end(vararg);
}
|