File: linux-explicit-synchronization-test.c

package info (click to toggle)
weston 14.0.94-1
  • links: PTS, VCS
  • area: main
  • in suites: experimental
  • size: 11,320 kB
  • sloc: ansic: 166,909; xml: 1,274; cpp: 480; python: 106; makefile: 39; sh: 39
file content (551 lines) | stat: -rw-r--r-- 19,038 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
/*
 * Copyright © 2018 Collabora, Ltd.
 *
 * Permission is hereby granted, free of charge, to any person obtaining
 * a copy of this software and associated documentation files (the
 * "Software"), to deal in the Software without restriction, including
 * without limitation the rights to use, copy, modify, merge, publish,
 * distribute, sublicense, and/or sell copies of the Software, and to
 * permit persons to whom the Software is furnished to do so, subject to
 * the following conditions:
 *
 * The above copyright notice and this permission notice (including the
 * next paragraph) shall be included in all copies or substantial
 * portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 * NONINFRINGEMENT.  IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
 * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
 * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

#include "config.h"

#include <string.h>
#include <unistd.h>

#include "linux-explicit-synchronization-unstable-v1-client-protocol.h"
#include "weston-test-client-helper.h"
#include "wayland-server-protocol.h"
#include "weston-test-fixture-compositor.h"
#include "weston-test-assert.h"

static enum test_result_code
fixture_setup(struct weston_test_harness *harness)
{
	struct compositor_setup setup;

	compositor_setup_defaults(&setup);

	setup.shell = SHELL_TEST_DESKTOP;
	setup.refresh = HIGHEST_OUTPUT_REFRESH;

	/* We need to use the pixman renderer, since a few of the tests depend
	 * on the renderer holding onto a surface buffer until the next one
	 * is committed, which the noop renderer doesn't do. */
	setup.renderer = WESTON_RENDERER_PIXMAN;

	return weston_test_harness_execute_as_client(harness, &setup);
}
DECLARE_FIXTURE_SETUP(fixture_setup);

static struct zwp_linux_explicit_synchronization_v1 *
get_linux_explicit_synchronization(struct client *client)
{
	struct global *g;
	struct global *global_sync = NULL;
	struct zwp_linux_explicit_synchronization_v1 *sync = NULL;

	wl_list_for_each(g, &client->global_list, link) {
		if (strcmp(g->interface,
			   zwp_linux_explicit_synchronization_v1_interface.name))
			continue;

		if (global_sync)
			test_assert_not_reached("Multiple linux explicit sync objects");

		global_sync = g;
	}

	test_assert_ptr_not_null(global_sync);
	test_assert_u32_eq(global_sync->version, 2);

	sync = wl_registry_bind(
			client->wl_registry, global_sync->name,
			&zwp_linux_explicit_synchronization_v1_interface, 2);
	test_assert_ptr_not_null(sync);

	return sync;
}

static struct client *
create_test_client(void)
{
	struct client *cl = create_client_and_test_surface(0, 0, 100, 100);
	test_assert_ptr_not_null(cl);
	return cl;
}

TEST(second_surface_synchronization_on_surface_raises_error)
{
	struct client *client = create_test_client();
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct zwp_linux_surface_synchronization_v1 *surface_sync1;
	struct zwp_linux_surface_synchronization_v1 *surface_sync2;

	surface_sync1 =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, client->surface->wl_surface);
	client_roundtrip(client);

	/* Second surface_synchronization creation should fail */
	surface_sync2 =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, client->surface->wl_surface);
	expect_protocol_error(
		client,
		&zwp_linux_explicit_synchronization_v1_interface,
		ZWP_LINUX_EXPLICIT_SYNCHRONIZATION_V1_ERROR_SYNCHRONIZATION_EXISTS);

	zwp_linux_surface_synchronization_v1_destroy(surface_sync2);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync1);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	client_destroy(client);

	return RESULT_OK;
}

TEST(set_acquire_fence_with_invalid_fence_raises_error)
{
	struct client *client = create_test_client();
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct zwp_linux_surface_synchronization_v1 *surface_sync =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, client->surface->wl_surface);
	int pipefd[2] = { -1, -1 };

	test_assert_int_eq(pipe(pipefd), 0);

	zwp_linux_surface_synchronization_v1_set_acquire_fence(surface_sync,
							       pipefd[0]);
	expect_protocol_error(
		client,
		&zwp_linux_surface_synchronization_v1_interface,
		ZWP_LINUX_SURFACE_SYNCHRONIZATION_V1_ERROR_INVALID_FENCE);

	close(pipefd[0]);
	close(pipefd[1]);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	client_destroy(client);

	return RESULT_OK;
}

TEST(set_acquire_fence_on_destroyed_surface_raises_error)
{
	struct client *client = create_test_client();
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct zwp_linux_surface_synchronization_v1 *surface_sync =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, client->surface->wl_surface);
	int pipefd[2] = { -1, -1 };

	test_assert_int_eq(pipe(pipefd), 0);

	wl_surface_destroy(client->surface->wl_surface);
	client->surface->wl_surface = NULL;
	zwp_linux_surface_synchronization_v1_set_acquire_fence(surface_sync,
							       pipefd[0]);
	expect_protocol_error(
		client,
		&zwp_linux_surface_synchronization_v1_interface,
		ZWP_LINUX_SURFACE_SYNCHRONIZATION_V1_ERROR_NO_SURFACE);

	close(pipefd[0]);
	close(pipefd[1]);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	client_destroy(client);

	return RESULT_OK;
}

TEST(second_buffer_release_in_commit_raises_error)
{
	struct client *client = create_test_client();
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct zwp_linux_surface_synchronization_v1 *surface_sync =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, client->surface->wl_surface);
	struct zwp_linux_buffer_release_v1 *buffer_release1;
	struct zwp_linux_buffer_release_v1 *buffer_release2;

	buffer_release1 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	client_roundtrip(client);

	/* Second buffer_release creation should fail */
	buffer_release2 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	expect_protocol_error(
		client,
		&zwp_linux_surface_synchronization_v1_interface,
		ZWP_LINUX_SURFACE_SYNCHRONIZATION_V1_ERROR_DUPLICATE_RELEASE);

	zwp_linux_buffer_release_v1_destroy(buffer_release2);
	zwp_linux_buffer_release_v1_destroy(buffer_release1);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	client_destroy(client);

	return RESULT_OK;
}

TEST(get_release_without_buffer_raises_commit_error)
{
	struct client *client = create_test_client();
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct zwp_linux_surface_synchronization_v1 *surface_sync =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, client->surface->wl_surface);
	struct wl_surface *surface = client->surface->wl_surface;
	struct zwp_linux_buffer_release_v1 *buffer_release;

	buffer_release =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	wl_surface_commit(surface);
	expect_protocol_error(
		client,
		&zwp_linux_surface_synchronization_v1_interface,
		ZWP_LINUX_SURFACE_SYNCHRONIZATION_V1_ERROR_NO_BUFFER);

	zwp_linux_buffer_release_v1_destroy(buffer_release);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	client_destroy(client);

	return RESULT_OK;
}

TEST(get_release_on_destroyed_surface_raises_error)
{
	struct client *client = create_test_client();
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct zwp_linux_surface_synchronization_v1 *surface_sync =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, client->surface->wl_surface);
	struct zwp_linux_buffer_release_v1 *buffer_release;

	wl_surface_destroy(client->surface->wl_surface);
	client->surface->wl_surface = NULL;
	buffer_release =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	expect_protocol_error(
		client,
		&zwp_linux_surface_synchronization_v1_interface,
		ZWP_LINUX_SURFACE_SYNCHRONIZATION_V1_ERROR_NO_SURFACE);

	zwp_linux_buffer_release_v1_destroy(buffer_release);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	client_destroy(client);

	return RESULT_OK;
}

TEST(get_release_after_commit_succeeds)
{
	struct client *client = create_test_client();
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct wl_surface *surface = client->surface->wl_surface;
	struct zwp_linux_surface_synchronization_v1 *surface_sync =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, surface);
	struct buffer *buf1;
	pixman_color_t black;
	struct zwp_linux_buffer_release_v1 *buffer_release1;
	struct zwp_linux_buffer_release_v1 *buffer_release2;

	color_rgb888(&black, 0, 0, 0);
	buf1 = create_shm_buffer_solid(client, 100, 100, &black);
	buffer_release1 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	client_roundtrip(client);

	wl_surface_attach(surface, buf1->proxy, 0, 0);
	wl_surface_commit(surface);

	buffer_release2 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	client_roundtrip(client);

	buffer_destroy(buf1);
	zwp_linux_buffer_release_v1_destroy(buffer_release2);
	zwp_linux_buffer_release_v1_destroy(buffer_release1);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	client_destroy(client);

	return RESULT_OK;
}

static void
buffer_release_fenced_handler(void *data,
			      struct zwp_linux_buffer_release_v1 *buffer_release,
			      int32_t fence)
{
	test_assert_not_reached("Fenced release not supported yet");
}

static void
buffer_release_immediate_handler(void *data,
				 struct zwp_linux_buffer_release_v1 *buffer_release)
{
	int *released = data;

	*released += 1;
}

struct zwp_linux_buffer_release_v1_listener buffer_release_listener = {
	buffer_release_fenced_handler,
	buffer_release_immediate_handler
};

/* The following release event tests depend on the behavior of the used
 * backend, in this case the pixman backend. This doesn't limit their
 * usefulness, though, since it allows them to check if, given a typical
 * backend implementation, weston core supports the per commit nature of the
 * release events.
 */

TEST(get_release_events_are_emitted_for_different_buffers)
{
	struct client *client = create_test_client();
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct zwp_linux_surface_synchronization_v1 *surface_sync =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, client->surface->wl_surface);
	struct buffer *buf1;
	struct buffer *buf2;
	pixman_color_t black;
	struct wl_surface *surface = client->surface->wl_surface;
	struct zwp_linux_buffer_release_v1 *buffer_release1;
	struct zwp_linux_buffer_release_v1 *buffer_release2;
	int buf_released1 = 0;
	int buf_released2 = 0;
	int frame;

	color_rgb888(&black, 0, 0, 0);
	buf1 = create_shm_buffer_solid(client, 100, 100, &black);
	buf2 = create_shm_buffer_solid(client, 100, 100, &black);

	buffer_release1 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	zwp_linux_buffer_release_v1_add_listener(buffer_release1,
						 &buffer_release_listener,
						 &buf_released1);
	wl_surface_attach(surface, buf1->proxy, 0, 0);
	frame_callback_set(surface, &frame);
	wl_surface_commit(surface);
	frame_callback_wait(client, &frame);
	/* No release event should have been emitted yet (we are using the
	 * pixman renderer, which holds buffers until they are replaced). */
	test_assert_int_eq(buf_released1, 0);

	buffer_release2 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	zwp_linux_buffer_release_v1_add_listener(buffer_release2,
						 &buffer_release_listener,
						 &buf_released2);
	wl_surface_attach(surface, buf2->proxy, 0, 0);
	frame_callback_set(surface, &frame);
	wl_surface_commit(surface);
	frame_callback_wait(client, &frame);
	/* Check that exactly one buffer_release event was emitted for the
	 * previous commit (buf1). */
	test_assert_int_eq(buf_released1, 1);
	test_assert_int_eq(buf_released2, 0);

	wl_surface_attach(surface, buf1->proxy, 0, 0);
	frame_callback_set(surface, &frame);
	wl_surface_commit(surface);
	frame_callback_wait(client, &frame);
	/* Check that exactly one buffer_release event was emitted for the
	 * previous commit (buf2). */
	test_assert_int_eq(buf_released1, 1);
	test_assert_int_eq(buf_released2, 1);

	buffer_destroy(buf2);
	buffer_destroy(buf1);
	zwp_linux_buffer_release_v1_destroy(buffer_release2);
	zwp_linux_buffer_release_v1_destroy(buffer_release1);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	client_destroy(client);

	return RESULT_OK;
}

TEST(get_release_events_are_emitted_for_same_buffer_on_surface)
{
	struct client *client = create_test_client();
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct zwp_linux_surface_synchronization_v1 *surface_sync =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, client->surface->wl_surface);
	struct buffer *buf;
	pixman_color_t black;
	struct wl_surface *surface = client->surface->wl_surface;
	struct zwp_linux_buffer_release_v1 *buffer_release1;
	struct zwp_linux_buffer_release_v1 *buffer_release2;
	int buf_released1 = 0;
	int buf_released2 = 0;
	int frame;

	color_rgb888(&black, 0, 0, 0);
	buf = create_shm_buffer_solid(client, 100, 100, &black);
	buffer_release1 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	zwp_linux_buffer_release_v1_add_listener(buffer_release1,
					   &buffer_release_listener,
					   &buf_released1);
	wl_surface_attach(surface, buf->proxy, 0, 0);
	frame_callback_set(surface, &frame);
	wl_surface_commit(surface);
	frame_callback_wait(client, &frame);
	/* No release event should have been emitted yet (we are using the
	 * pixman renderer, which holds buffers until they are replaced). */
	test_assert_int_eq(buf_released1, 0);

	buffer_release2 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync);
	zwp_linux_buffer_release_v1_add_listener(buffer_release2,
					   &buffer_release_listener,
					   &buf_released2);
	wl_surface_attach(surface, buf->proxy, 0, 0);
	frame_callback_set(surface, &frame);
	wl_surface_commit(surface);
	frame_callback_wait(client, &frame);
	/* Check that exactly one buffer_release event was emitted for the
	 * previous commit (buf). */
	test_assert_int_eq(buf_released1, 1);
	test_assert_int_eq(buf_released2, 0);

	wl_surface_attach(surface, buf->proxy, 0, 0);
	frame_callback_set(surface, &frame);
	wl_surface_commit(surface);
	frame_callback_wait(client, &frame);
	/* Check that exactly one buffer_release event was emitted for the
	 * previous commit (buf again). */
	test_assert_int_eq(buf_released1, 1);
	test_assert_int_eq(buf_released2, 1);

	buffer_destroy(buf);
	zwp_linux_buffer_release_v1_destroy(buffer_release2);
	zwp_linux_buffer_release_v1_destroy(buffer_release1);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	client_destroy(client);

	return RESULT_OK;
}

TEST(get_release_events_are_emitted_for_same_buffer_on_different_surfaces)
{
	struct client *client = create_test_client();
	struct surface *other_surface = create_test_surface(client);
	struct wl_surface *surface1 = client->surface->wl_surface;
	struct wl_surface *surface2 = other_surface->wl_surface;
	struct zwp_linux_explicit_synchronization_v1 *sync =
		get_linux_explicit_synchronization(client);
	struct zwp_linux_surface_synchronization_v1 *surface_sync1 =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, surface1);
	struct zwp_linux_surface_synchronization_v1 *surface_sync2 =
		zwp_linux_explicit_synchronization_v1_get_synchronization(
			sync, surface2);
	struct buffer *buf1;
	struct buffer *buf2;
	pixman_color_t black;
	struct zwp_linux_buffer_release_v1 *buffer_release1;
	struct zwp_linux_buffer_release_v1 *buffer_release2;
	int buf_released1 = 0;
	int buf_released2 = 0;
	int frame;

	color_rgb888(&black, 0, 0, 0);
	buf1 = create_shm_buffer_solid(client, 100, 100, &black);
	buf2 = create_shm_buffer_solid(client, 100, 100, &black);

	weston_test_move_surface(client->test->weston_test, surface2, 0, 0);

	/* Attach buf1 to both surface1 and surface2. */
	buffer_release1 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync1);
	zwp_linux_buffer_release_v1_add_listener(buffer_release1,
					   &buffer_release_listener,
					   &buf_released1);
	wl_surface_attach(surface1, buf1->proxy, 0, 0);
	frame_callback_set(surface1, &frame);
	wl_surface_commit(surface1);
	frame_callback_wait(client, &frame);

	buffer_release2 =
		zwp_linux_surface_synchronization_v1_get_release(surface_sync2);
	zwp_linux_buffer_release_v1_add_listener(buffer_release2,
					   &buffer_release_listener,
					   &buf_released2);
	wl_surface_attach(surface2, buf1->proxy, 0, 0);
	frame_callback_set(surface2, &frame);
	wl_surface_commit(surface2);
	frame_callback_wait(client, &frame);

	test_assert_int_eq(buf_released1, 0);
	test_assert_int_eq(buf_released2, 0);

	/* Attach buf2 to surface1, and check that a buffer_release event for
	 * the previous commit (buf1) for that surface is emitted. */
	wl_surface_attach(surface1, buf2->proxy, 0, 0);
	frame_callback_set(surface1, &frame);
	wl_surface_commit(surface1);
	frame_callback_wait(client, &frame);

	test_assert_int_eq(buf_released1, 1);
	test_assert_int_eq(buf_released2, 0);

	/* Attach buf2 to surface2, and check that a buffer_release event for
	 * the previous commit (buf1) for that surface is emitted. */
	wl_surface_attach(surface2, buf2->proxy, 0, 0);
	frame_callback_set(surface2, &frame);
	wl_surface_commit(surface2);
	frame_callback_wait(client, &frame);

	test_assert_int_eq(buf_released1, 1);
	test_assert_int_eq(buf_released2, 1);

	buffer_destroy(buf2);
	buffer_destroy(buf1);
	zwp_linux_buffer_release_v1_destroy(buffer_release2);
	zwp_linux_buffer_release_v1_destroy(buffer_release1);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync2);
	zwp_linux_surface_synchronization_v1_destroy(surface_sync1);
	zwp_linux_explicit_synchronization_v1_destroy(sync);
	surface_destroy(other_surface);
	client_destroy(client);

	return RESULT_OK;
}