1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
|
# Contributing to wlclock
This file explains how you can contribute to wlclock.
Before you read on, beware that **all** contributing happens over email. If you
found this repository on GitHub, or any other forge I have mirrors of my
projects on, note that I will not respond to that forges contribution system.
Use the mailing list.
For larger contributions, especially for radical changes, I highly recommend you
to ask me whether I will include your commit *before* you start investing time
into it. Also please respect the coding style, even if you do not like it.
## Communication
You can ask questions and start discussions on the [mailing list](mailto:~leon_plickat/public-inbox@lists.sr.ht)
or if you find me on IRC (my nick is "leon-p" and you can often find me on
`#sway@libera.net`).
## Sending Patches
You can send your patches via email to the mailing list. See
[this](https://git-send-email.io/) helpful link to learn how to correctly send
emails with git. Alternatively you can also manually attach a git patch file to
a mail, but beware that this is more work for both you and me.
All code review will happen on the mailing list as well.
Write good commit messages!
## Licensing and Copyright
wlclock is licensed under the GPLv3, which applies to any contributions as
well. I will not accept contributions under a different license, even if you
create new files. The one single exception to this are Wayland protocol
extensions.
You are strongly invited to add your name to the copyright header of the files
you changed and if you made an important contribution also to the authors
sections in the man page and README. A Free Software project is proud of every
contributor.
## Style
This section describes the coding style of wlclock. Try to follow it closely.
Yes, it is not K&R. Cry me a river.
Indent with tabs exclusively (looking at you, Emacs users).
Lines should not exceed 80 characters. It is perfectly fine if a few lines are a
few characters longer, but generally you should break up long lines.
Braces go on the next line with struct declarations being the only exception.
If only a single operation follows a conditional or loop, braces should not be
used.
static void function (void)
{
struct Some_struct some_struct = {
.element_1 = 1,
.element_2 = 2
};
if ( val == 1 )
{
function_2();
function_3();
}
else
function_4();
}
For switches, indent the case labels once and the following code twice.
switch (variable)
{
case 1:
/* do stuff... */
break;
}
Conditionals are only separated by a space from their surrounding parenthesis
if they contain more than just a single variable.
if (condition)
{
/* do stuff... */
}
else if ( variable == value )
{
/* do stuff... */
}
An exception to this are `for` loops, where a space is only but always inserted
after each semicolon.
for (int a = 0; a < 10; a--)
{
/* do stuff... */
}
Logical operators in in-line conditionals or variable declarations / changes do
not necessarily require parenthesis.
bool variable = a == b;
int another_variable = a > b ? 4 : 5;
Use `/* comment */` for permanent comments and `// comment` for temporary
comments.
Sometimes it makes sense to align variable declarations. But only sometimes.
type name_3 = value;
type_1 name_acs = value;
type_scsdc name_23 = value;
type_abc name_advdfv = value;
You can combine multiple declarations and calculations with commas. Just be
careful that the code is still readable.
int a, b;
a = 1 + 2, b = a * 3;
Name your bloody variables! With very, very few exceptions, a variable name
should at least be three characters long. When someone sees your variable, they
should pretty much immediately know what information is stored in it without
needing to read the entire function. Variable names should generally be lower
case, but exceptions are perfectly fine if justified.
DoNotUseCamelCase. Underscores_are_more_readable.
If the data stored in your variable is complex / does complex things /
influences complex things, document that.
Variables usually should have a lower case name, although exceptions are fine if
justified. The very first letter of a struct type or enum type name must be
capitalised. Members of an enum must be fully caps.
enum My_fancy_enum
{
FANCY_1,
FANCY_2,
FANCY_3
}
struct Fancy_struct
{
int variable;
}
int another_variable;
struct Fancy_struct fs;
`switch`, `while` and `for` may be in-lined after an `if` or `else` to
reduce indentation complexity, but only if readability is not compromised and
80 characters are not excessively exceeded. Under the same conditions, `case`
blocks may be in-lined, if they only contains a single operation.
if (condition) switch (mode)
{
case MODE_1: do_stuff_1(); break;
case MODE_2: do_stuff_2(); break;
case MODE_3: do_stuff_3(); returned;
}
else while (stuff)
{
/* Do things... */
}
`if` may be in-lined after `while`, `for` and `else` to reduce indentation
complexity, but only if readability is not compromised and 80 characters are not
excessively exceeded.
while (variable) if (condition)
{
/* Do stuff... */
}
for (int a = b; a > c; a += b) if (condition)
{
/* Do stuff... */
}
if (condition)
{
/* Do stuff... */
}
else if (condition)
{
/* Do stuff... */
}
Never in-line variable declaration or changes, function calls or `return`,
`goto`, `break` and friends.
|
