1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
|
From d7bc1362a992ccf1d0c8aee5998a90acd132d29b Mon Sep 17 00:00:00 2001
From: Sergei Trofimovich <siarheit@google.com>
Date: Sat, 24 Oct 2015 21:44:26 +0100
Subject: [PATCH] OTHER: fix python client: typo in enum declaration
Before the patch build fails as:
[334/391] Compiling _build_/src/clients/lib/python/xmmsapi.c
src/clients/lib/python/xmmsapi.c:2637:84: error: unknown type name 'xmmsc_collection_changed_actions_t'
static CYTHON_INLINE PyObject* __Pyx_PyInt_From_xmmsc_collection_changed_actions_t(xmmsc_collection_changed_actions_t value);
^
Looks like a enum (re)naming typo.
Note (vdust): The typo was silently ignored cython versions prior to 0.23
that didn't actually use the enum real type in internal functions signatures.
---
AUTHORS | 1 +
src/clients/lib/python/cython_include/cxmmsclient.pxd | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index 853e2dd0..dce4670e 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -464,6 +464,7 @@ E: bryan.a.taylor@gmail.com
D: Various fixes
N: Sergei Trofimovich
+E: siarheit@google.com
E: slyich@gmail.com
E: slyfox@gentoo.org
E: slyfox@inbox.ru
diff --git a/src/clients/lib/python/cython_include/cxmmsclient.pxd b/src/clients/lib/python/cython_include/cxmmsclient.pxd
index 71c107f5..622e85d8 100644
--- a/src/clients/lib/python/cython_include/cxmmsclient.pxd
+++ b/src/clients/lib/python/cython_include/cxmmsclient.pxd
@@ -28,7 +28,7 @@ cdef extern from "xmmsc/xmmsc_idnumbers.h":
XMMS_MEDIALIB_ENTRY_STATUS_NOT_AVAILABLE
XMMS_MEDIALIB_ENTRY_STATUS_REHASH
- ctypedef enum xmmsc_collection_changed_actions_t:
+ ctypedef enum xmms_collection_changed_actions_t:
XMMS_COLLECTION_CHANGED_ADD
XMMS_COLLECTION_CHANGED_UPDATE
XMMS_COLLECTION_CHANGED_RENAME
--
2.27.0.rc0
|
