1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685
|
This patch replaces dpatch.c with a newer version of
that file from the xorg cvs.
Additionally it makes dsimple.h contain proper prototypes
and adds a Makefile and changes the manpage.
Additionally it makes xwit compile cleanly with
-Wstrict-prototypes -Wmissing-prototypes and -W
brl
Index: xwit-3.4/dsimple.c
===================================================================
--- xwit-3.4.orig/dsimple.c 1995-10-19 00:59:17.000000000 +0100
+++ xwit-3.4/dsimple.c 2007-12-08 13:10:27.000000000 +0100
@@ -1,25 +1,47 @@
-/* $XConsortium: dsimple.c,v 1.12 91/05/11 21:01:36 gildea Exp $ */
-/* $Id: dsimple.c,v 3.2 95/10/18 16:58:55 dd Exp $ */
+/* $Xorg: dsimple.c,v 1.4 2001/02/09 02:05:54 xorgcvs Exp $ */
+/*
+
+Copyright 1993, 1998 The Open Group
+
+Permission to use, copy, modify, distribute, and sell this software and its
+documentation for any purpose is hereby granted without fee, provided that
+the above copyright notice appear in all copies and that both that
+copyright notice and this permission notice appear in supporting
+documentation.
+
+The above copyright notice and this permission notice shall be included
+in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+IN NO EVENT SHALL THE OPEN GROUP BE LIABLE FOR ANY CLAIM, DAMAGES OR
+OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+OTHER DEALINGS IN THE SOFTWARE.
+
+Except as contained in this notice, the name of The Open Group shall
+not be used in advertising or otherwise to promote the sale, use or
+other dealings in this Software without prior written authorization
+from The Open Group.
+
+*/
+/* $XFree86: xc/programs/xlsfonts/dsimple.c,v 3.6 2001/12/14 20:02:09 dawes Exp $ */
+
#include <X11/Xos.h>
#include <X11/Xlib.h>
#include <X11/Xutil.h>
#include <X11/cursorfont.h>
#include <stdio.h>
+#include <stdlib.h>
+#include <stdarg.h>
/*
* Other_stuff.h: Definitions of routines in other_stuff.
*
* Written by Mark Lillibridge. Last updated 7/1/87
- *
- * Send bugs, etc. to chariot@athena.mit.edu.
*/
-unsigned long Resolve_Color();
-Pixmap Bitmap_To_Pixmap();
-Window Select_Window();
-void out();
-void blip();
-Window Window_With_Name();
-void Fatal_Error();
+#include "dsimple.h"
/*
* Just_display: A group of routines designed to make the writting of simple
@@ -29,24 +51,20 @@
* and screen already defined on entry.
*
* Written by Mark Lillibridge. Last updated 7/1/87
- *
- * Send bugs, etc. to chariot@athena.mit.edu.
*/
/* This stuff is defined in the calling program by just_display.h */
-extern char *program_name;
-extern Display *dpy;
-extern int screen;
-
+char *program_name = "unknown_program";
+Display *dpy;
+int screen;
/*
* Malloc: like malloc but handles out of memory using Fatal_Error.
*/
-char *Malloc(size)
- unsigned size;
+char *Malloc(size_t size)
{
- char *data, *malloc();
+ char *data;
if (!(data = malloc(size)))
Fatal_Error("Out of memory!");
@@ -58,11 +76,9 @@
/*
* Realloc: like Malloc except for realloc, handles NULL using Malloc.
*/
-char *Realloc(ptr, size)
- char *ptr;
- int size;
+char *Realloc(void *ptr,size_t size)
{
- char *new_ptr, *realloc();
+ void *new_ptr;
if (!ptr)
return(Malloc(size));
@@ -78,9 +94,7 @@
* Get_Display_Name (argc, argv) Look for -display, -d, or host:dpy (obselete)
* If found, remove it from command line. Don't go past a lone -.
*/
-char *Get_Display_Name(pargc, argv)
- int *pargc; /* MODIFIED */
- char **argv; /* MODIFIED */
+char *Get_Display_Name(int *pargc, char **argv)
{
int argc = *pargc;
char **pargv = argv+1;
@@ -138,9 +152,7 @@
* for this display is then stored in screen.
* Does not require dpy or screen defined.
*/
-void Setup_Display_And_Screen(argc, argv)
-int *argc; /* MODIFIED */
-char **argv; /* MODIFIED */
+void Setup_Display_And_Screen(int *argc, char **argv)
{
dpy = Open_Display (Get_Display_Name(argc, argv));
screen = DefaultScreen(dpy);
@@ -170,59 +182,6 @@
XBell(dpy, 50);
}
-
-/*
- * ReadBitmapFile: same as XReadBitmapFile except it returns the bitmap
- * directly and handles errors using Fatal_Error.
- */
-static void _bitmap_error(status, filename)
- int status;
- char *filename;
-{
- if (status == BitmapOpenFailed)
- Fatal_Error("Can't open file %s!", filename);
- else if (status == BitmapFileInvalid)
- Fatal_Error("file %s: Bad bitmap format.", filename);
- else
- Fatal_Error("Out of memory!");
-}
-
-Pixmap ReadBitmapFile(d, filename, width, height, x_hot, y_hot)
- Drawable d;
- char *filename;
- int *width, *height, *x_hot, *y_hot;
-{
- Pixmap bitmap;
- int status;
-
- status = XReadBitmapFile(dpy, RootWindow(dpy, screen), filename,
- (unsigned int *)width, (unsigned int *)height,
- &bitmap, x_hot, y_hot);
- if (status != BitmapSuccess)
- _bitmap_error(status, filename);
-
- return(bitmap);
-}
-
-
-/*
- * WriteBitmapFile: same as XWriteBitmapFile except it handles errors
- * using Fatal_Error.
- */
-void WriteBitmapFile(filename, bitmap, width, height, x_hot, y_hot)
- char *filename;
- Pixmap bitmap;
- int width, height, x_hot, y_hot;
-{
- int status;
-
- status= XWriteBitmapFile(dpy, filename, bitmap, width, height, x_hot,
- y_hot);
- if (status != BitmapSuccess)
- _bitmap_error(status, filename);
-}
-
-
/*
* Select_Window_Args: a rountine to provide a common interface for
* applications that need to allow the user to select one
@@ -259,7 +218,7 @@
#define OPTION argv[0]
#define NXTOPTP ++argv, --argc>0
#define NXTOPT if (++argv, --argc==0) usage()
-#define COPYOPT nargv++[0]=OPTION; nargc++
+#define COPYOPT nargv++[0]=OPTION, nargc++
while (NXTOPTP) {
if (!strcmp(OPTION, "-")) {
@@ -285,7 +244,7 @@
w=0;
sscanf(OPTION, "0x%lx", &w);
if (!w)
- sscanf(OPTION, "%ld", &w);
+ sscanf(OPTION, "%lu", &w);
if (!w)
Fatal_Error("Invalid window id format: %s.", OPTION);
continue;
@@ -301,13 +260,8 @@
* Other_stuff: A group of routines which do common X11 tasks.
*
* Written by Mark Lillibridge. Last updated 7/1/87
- *
- * Send bugs, etc. to chariot@athena.mit.edu.
*/
-extern Display *dpy;
-extern int screen;
-
/*
* Resolve_Color: This routine takes a color name and returns the pixel #
* that when used in the window w will be of color name.
@@ -381,7 +335,9 @@
*/
void blip()
{
- outl("blip!");
+ fflush(stdout);
+ fprintf(stderr, "blip!\n");
+ fflush(stderr);
}
@@ -447,7 +403,7 @@
{
Window *children, dummy;
unsigned int nchildren;
- int i;
+ unsigned int i;
Window w=0;
char *window_name;
@@ -467,36 +423,18 @@
}
/*
- * outl: a debugging routine. Flushes stdout then prints a message on stderr
- * and flushes stderr. Used to print messages when past certain points
- * in code so we can tell where we are. Outl may be invoked like
- * printf with up to 7 arguments.
- */
-/* VARARGS1 */
-outl(msg, arg0,arg1,arg2,arg3,arg4,arg5,arg6)
- char *msg;
- char *arg0, *arg1, *arg2, *arg3, *arg4, *arg5, *arg6;
-{
- fflush(stdout);
- fprintf(stderr, msg, arg0, arg1, arg2, arg3, arg4, arg5, arg6);
- fprintf(stderr, "\n");
- fflush(stderr);
-}
-
-
-/*
* Standard fatal error routine - call like printf but maximum of 7 arguments.
* Does not require dpy or screen defined.
*/
-/* VARARGS1 */
-void Fatal_Error(msg, arg0,arg1,arg2,arg3,arg4,arg5,arg6)
-char *msg;
-char *arg0, *arg1, *arg2, *arg3, *arg4, *arg5, *arg6;
+void Fatal_Error(char *msg, ...)
{
+ va_list args;
fflush(stdout);
fflush(stderr);
fprintf(stderr, "%s: error: ", program_name);
- fprintf(stderr, msg, arg0, arg1, arg2, arg3, arg4, arg5, arg6);
+ va_start(args, msg);
+ vfprintf(stderr, msg, args);
+ va_end(args);
fprintf(stderr, "\n");
exit(2);
}
Index: xwit-3.4/dsimple.h
===================================================================
--- xwit-3.4.orig/dsimple.h 1995-08-25 02:26:37.000000000 +0200
+++ xwit-3.4/dsimple.h 2007-12-08 12:54:08.000000000 +0100
@@ -12,26 +12,26 @@
/* Global variables used by routines in just_display.c */
-char *program_name = "unknown_program"; /* Name of this program */
-Display *dpy; /* The current display */
-int screen; /* The current screen */
+extern char *program_name; /* Name of this program */
+extern Display *dpy; /* The current display */
+extern int screen; /* The current screen */
#define INIT_NAME program_name=argv[0] /* use this in main to setup
program_name */
/* Declaritions for functions in just_display.c */
-void Fatal_Error();
-char *Malloc();
-char *Realloc();
-char *Get_Display_Name();
-Display *Open_Display();
-void Setup_Display_And_Screen();
-XFontStruct *Open_Font();
-void Beep();
-Pixmap ReadBitmapFile();
-void WriteBitmapFile();
-Window Select_Window_Args();
+void Fatal_Error(char *msg, ...);
+char *Malloc(size_t);
+char *Realloc(void*,size_t);
+char *Get_Display_Name(int*,char **);
+Display *Open_Display(char *);
+void Setup_Display_And_Screen(int *, char **);
+XFontStruct *Open_Font(char *);
+void Beep(void);
+Pixmap ReadBitmapFile(Drawable,char *,int*,int*,int*,int*);
+void WriteBitmapFile(char *,Pixmap,int,int,int,int);
+Window Select_Window_Args(int *,char **);
#define X_USAGE "[host:display]" /* X arguments handled by
Get_Display_Name */
@@ -45,9 +45,10 @@
* Send bugs, etc. to chariot@athena.mit.edu.
*/
-unsigned long Resolve_Color();
-Pixmap Bitmap_To_Pixmap();
-Window Select_Window();
-void out();
-void blip();
-Window Window_With_Name();
+unsigned long Resolve_Color(Window,char *);
+Pixmap Bitmap_To_Pixmap(Display *,Drawable,GC,Pixmap,int,int);
+Window Select_Window(Display *);
+void out(void);
+void blip(void);
+Window Window_With_Name(Display *,Window,char *);
+void usage(void);
Index: xwit-3.4/Makefile
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ xwit-3.4/Makefile 2007-12-08 12:57:31.000000000 +0100
@@ -0,0 +1,23 @@
+CFLAGS ?= -Wall -O2 -g -Wstrict-prototypes -Wmissing-prototypes
+LDFLAGS ?= -Wl,-z,defs
+LIBRARIES = -lX11
+
+all: xwit
+
+xwit: xwit.o ClientWin.o dsimple.o
+ gcc $(CFLAGS) $(LDFLAGS) $(LIBRARIES) -o $@ $^
+
+%.o: %.c
+ gcc $(CPPFLAGS) $(CFLAGS) -c -o $@ $<
+
+# Headers needed
+dsimple.o: dsimple.h
+xwit.o: dsimple.h ClientWin.h
+ClientWin.o: ClientWin.h
+
+clean:
+ -rm xwit *.o
+
+install: xwit
+ install xwit $(DESTDIR)/usr/bin/
+
Index: xwit-3.4/xwit.man
===================================================================
--- xwit-3.4.orig/xwit.man 2007-12-08 12:53:57.000000000 +0100
+++ xwit-3.4/xwit.man 2007-12-08 13:08:53.000000000 +0100
@@ -1,5 +1,4 @@
-.\" $Id: xwit.man,v 3.4 97/10/20 18:32:54 dd Exp $
-.TH XWIT 1X
+.TH XWIT 1 "22 Oct 2005"
.SH NAME
xwit \- window interface tool: pop or iconify this xterm window or named windows
.SH SYNOPSIS
@@ -70,7 +69,7 @@
strings, or a particular window id given, or the window id found
in the environment variable
.B WINDOWID
-(which is set by xterm for the program it runs).
+(which is set by xterm for the program it runs), or the window under the mouse cursor.
.SH OPTIONS
.TP
-display
@@ -229,5 +228,6 @@
.br
David DiGiacomo, david@slack.com
.SH ACKNOWLEDGEMENTS
-Thanks to Andre Delafontaine, Norman R. McBride, Keith Thompson, and
-Glen R. Walker for bug reports and suggestions.
+Thanks to Andre Delafontaine, Norman R. McBride, Keith Thompson,
+Glen R. Walker, Michael Mauch, Dima Barsky and Decklin Foster
+for bug reports, suggestions and/or patches.
Index: xwit-3.4/ClientWin.c
===================================================================
--- xwit-3.4.orig/ClientWin.c 2007-12-08 12:54:21.000000000 +0100
+++ xwit-3.4/ClientWin.c 2007-12-08 12:55:03.000000000 +0100
@@ -17,14 +17,13 @@
#include <X11/Xlib.h>
#include <X11/Xatom.h>
+#include "ClientWin.h"
-static Window TryChildren();
+static Window TryChildren(Display *,Window,Atom);
/* Find a window with WM_STATE, else return win itself, as per ICCCM */
-Window XmuClientWindow (dpy, win)
- Display *dpy;
- Window win;
+Window XmuClientWindow (Display *dpy,Window win)
{
Atom WM_STATE;
Atom type = None;
@@ -47,10 +46,7 @@
}
static
-Window TryChildren (dpy, win, WM_STATE)
- Display *dpy;
- Window win;
- Atom WM_STATE;
+Window TryChildren (Display *dpy, Window win, Atom WM_STATE)
{
Window root, parent;
Window *children;
Index: xwit-3.4/ClientWin.h
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ xwit-3.4/ClientWin.h 2007-12-08 12:55:03.000000000 +0100
@@ -0,0 +1,2 @@
+
+Window XmuClientWindow (Display *dpy,Window win);
Index: xwit-3.4/xwit.c
===================================================================
--- xwit-3.4.orig/xwit.c 2007-12-08 12:54:21.000000000 +0100
+++ xwit-3.4/xwit.c 2007-12-08 13:07:04.000000000 +0100
@@ -34,8 +34,7 @@
#include <stdlib.h>
#include <sys/time.h>
#include "dsimple.h"
-
-Window XmuClientWindow();
+#include "ClientWin.h"
/* note: called by dsimple.c code, must be global */
void
@@ -129,14 +128,13 @@
static int Gwinfound;
/* forward declarations */
-static void doit();
+static void doit(Window);
/*
* sleep for given millisecs for those without usleep
*/
static void
-mssleep(ms)
-int ms;
+mssleep(int ms)
{
struct timeval tv;
tv.tv_sec = ms/1000;
@@ -148,8 +146,7 @@
* find all windows below this and if name matches call doit on it
*/
static void
-downtree(top)
-Window top;
+downtree(Window top)
{
Window *child, dummy;
unsigned int children, i;
@@ -172,7 +169,7 @@
* [un]set autorepeat for individual keys
*/
static void
-setrepeat()
+setrepeat(void)
{
unsigned long value_mask;
XKeyboardControl values;
@@ -194,9 +191,7 @@
* (based on xwininfo.c)
*/
static void
-getpos(window, xp, yp)
- Window window;
- int *xp, *yp;
+getpos(Window window, int *xp, int *yp)
{
XWindowAttributes attributes;
int rx, ry;
@@ -217,9 +212,7 @@
* get window size
*/
static void
-getsize(window, wp, hp)
- Window window;
- int *wp, *hp;
+getsize(Window window, int *wp, int *hp)
{
XWindowAttributes attributes;
@@ -234,10 +227,7 @@
* set window position
*/
static void
-domove(window, x, y, right, bottom)
- Window window;
- int x, y;
- int right, bottom;
+domove(Window window, int x, int y, int right, int bottom)
{
XWindowChanges values;
unsigned int value_mask;
@@ -307,9 +297,7 @@
* set window size
*/
static void
-doresize(window, w, h)
- Window window;
- int w, h;
+doresize(Window window, int w, int h)
{
XWindowChanges values;
unsigned int value_mask;
@@ -351,9 +339,7 @@
* set row/column size
*/
static void
-rcresize(what, window)
- enum functions what;
- Window window;
+rcresize(enum functions what, Window window)
{
XSizeHints *hints;
long supplied;
@@ -383,10 +369,7 @@
}
static void
-loadbitmap(window, file, pmp)
- Window window;
- char *file;
- Pixmap *pmp;
+loadbitmap(Window window, const char *file, Pixmap *pmp)
{
unsigned int w, h;
int xhot, yhot;
@@ -397,8 +380,7 @@
}
static void
-setbitmap(window)
- Window window;
+setbitmap(Window window)
{
static XWMHints *hints;
static Pixmap bitmap_pm;
@@ -437,8 +419,7 @@
}
static void
-setwinattr(window)
- Window window;
+setwinattr(Window window)
{
XSetWindowAttributes swa;
unsigned long valuemask;
@@ -462,8 +443,7 @@
* iconify the given window, or map and raise it, or whatever
*/
static void
-doit(window)
- Window window;
+doit(Window window)
{
XWindowChanges values;
unsigned int value_mask;
@@ -622,9 +602,7 @@
/* based on xwininfo.c */
static Window
-xwit_select_window(dpy, current)
- Display *dpy;
- int current;
+xwit_select_window(Display *dpy, int current)
{
Window window = None;
Window wroot;
@@ -653,8 +631,7 @@
}
static Window
-getxid(s)
- char *s;
+getxid(const char *s)
{
XID id;
@@ -668,15 +645,12 @@
}
static int
-matchopt(key, nargs, argc, argv)
- char *key;
- int nargs;
- int *argc;
- char **argv;
+matchopt(const char *key, int nargs, int *argc, char **argv)
{
int enough = 0;
int match = 1;
- char *ap, *kp;
+ char *ap;
+ const char *kp;
ap = *argv;
if (*ap == '-')
@@ -741,10 +715,8 @@
return match;
}
-void
-FetchBuffer( dpy, nbuf )
- Display *dpy;
- int nbuf;
+static void
+FetchBuffer(Display *dpy, int nbuf)
{
char *buf;
int size;
@@ -757,10 +729,8 @@
fwrite( buf, 1, size, stdout );
}
-void
-StoreBuffer( dpy, nbuf )
- Display *dpy;
- int nbuf;
+static void
+StoreBuffer(Display *dpy, int nbuf)
{
char *buf = NULL;
int bufsize, nread, total=0;
@@ -778,9 +748,7 @@
}
int
-main(argc, argv)
- int argc;
- char **argv;
+main(int argc, char *argv[])
{
Window window = 0;
int *pargc = &argc;
@@ -1011,7 +979,6 @@
case WID_env:
{
char *s;
- extern char *getenv();
s = getenv("WINDOWID");
if (s != 0)
|