1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
|
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#include <cppunit/CompilerOutputter.h>
#include <cppunit/TestCaller.h>
#include <cppunit/TestFixture.h>
#include <cppunit/extensions/TestFactoryRegistry.h>
#include <cppunit/ui/text/TestRunner.h>
#include <unistd.h>
#include <cstring>
#include <list>
#include "blowfishfactory.hh"
#include "cryptoerror.hh"
#include "file.hh"
#include "securearray.hh"
#include "testpaths.h"
#include "yapeterror.hh"
#include "openssl.hh"
constexpr auto TEST_PASSWORD{"Secret"};
constexpr auto FN{BUILDDIR "/testfile_blowfish.gps"};
constexpr auto ROUNDS{10};
constexpr auto NAME{"Name"};
constexpr auto HOST{"Host"};
constexpr auto USERNAME{"Username"};
constexpr auto PASSWORD{"Password"};
constexpr auto COMMENT{"Comment"};
inline std::string makeName(int number) {
std::string name{NAME};
name += " " + std::to_string(number);
return name;
}
inline yapet::PasswordRecord makePasswordRecord(int number) {
yapet::PasswordRecord passwordRecord{};
passwordRecord.name(makeName(number).c_str());
std::string host = HOST;
host += " " + std::to_string(number);
passwordRecord.host(host.c_str());
std::string username = USERNAME;
username += " " + std::to_string(number);
passwordRecord.username(username.c_str());
std::string password = PASSWORD;
password += " " + std::to_string(number);
passwordRecord.password(password.c_str());
std::string comment = COMMENT;
comment += " " + std::to_string(number);
passwordRecord.comment(comment.c_str());
return passwordRecord;
}
inline std::list<yapet::PasswordListItem> createPasswordList(
std::unique_ptr<yapet::Crypto> &blowfish) {
std::list<yapet::PasswordListItem> passwordList{};
for (int i = 0; i < ROUNDS; i++) {
auto passwordRecord{makePasswordRecord(i)};
auto serializedPasswordRecord{passwordRecord.serialize()};
auto encryptedSerializedPasswordRecord{
blowfish->encrypt(serializedPasswordRecord)};
yapet::PasswordListItem passwordListItem{
makeName(i).c_str(), encryptedSerializedPasswordRecord};
passwordList.push_back(passwordListItem);
}
return passwordList;
}
inline void comparePasswordRecords(const yapet::PasswordRecord &actual,
const yapet::PasswordRecord &expected) {
CPPUNIT_ASSERT(
std::strcmp(reinterpret_cast<const char *>(actual.name()),
reinterpret_cast<const char *>(expected.name())) == 0);
CPPUNIT_ASSERT(
std::strcmp(reinterpret_cast<const char *>(actual.host()),
reinterpret_cast<const char *>(expected.host())) == 0);
CPPUNIT_ASSERT(
std::strcmp(reinterpret_cast<const char *>(actual.username()),
reinterpret_cast<const char *>(expected.username())) == 0);
CPPUNIT_ASSERT(
std::strcmp(reinterpret_cast<const char *>(actual.password()),
reinterpret_cast<const char *>(expected.password())) == 0);
CPPUNIT_ASSERT(
std::strcmp(reinterpret_cast<const char *>(actual.comment()),
reinterpret_cast<const char *>(expected.comment())) == 0);
}
class BlowfishFileTest : public CppUnit::TestFixture {
public:
static CppUnit::TestSuite *suite() {
CppUnit::TestSuite *suiteOfTests =
new CppUnit::TestSuite("Blowfish File");
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should correctly read empty file",
&BlowfishFileTest::createNewFile));
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should correctly read empty file",
&BlowfishFileTest::createAndReadEmptyFile));
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should throw expected exception on invalid password",
&BlowfishFileTest::openEmptyFileWithInvalidPassword));
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should write passwords", &BlowfishFileTest::writePasswords));
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should detect file modification on password save",
&BlowfishFileTest::detectModificationOnSave));
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should force password save on modified file",
&BlowfishFileTest::forceSave));
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should get the correct time when the master password was set",
&BlowfishFileTest::timeMasterPasswordSet));
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should properly set new password",
&BlowfishFileTest::setNewPassword));
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should allow saving passwords after password change",
&BlowfishFileTest::allowSaveAfterPasswordSave));
suiteOfTests->addTest(new CppUnit::TestCaller<BlowfishFileTest>(
"should throw exception on reading corrupt file",
&BlowfishFileTest::corruptFile));
return suiteOfTests;
}
void setUp() { unlink(FN); }
void tearDown() { unlink(FN); }
void createNewFile() {
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
YAPET::File file{factory, FN, true};
auto expectedFileVersion{yapet::toSecureArray("YAPET1.0")};
CPPUNIT_ASSERT(std::memcmp(*file.getFileVersion(), *expectedFileVersion,
expectedFileVersion.size() - 1) == 0);
CPPUNIT_ASSERT(file.getHeaderVersion() ==
yapet::HEADER_VERSION::VERSION_2);
}
void createAndReadEmptyFile() {
{
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
YAPET::File file{factory, FN, true};
}
{
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
YAPET::File file{factory, FN, false};
auto expectedFileVersion{yapet::toSecureArray("YAPET1.0")};
CPPUNIT_ASSERT(std::memcmp(*file.getFileVersion(),
*expectedFileVersion,
expectedFileVersion.size() - 1) == 0);
CPPUNIT_ASSERT(file.getHeaderVersion() ==
yapet::HEADER_VERSION::VERSION_2);
}
}
void openEmptyFileWithInvalidPassword() {
{
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
YAPET::File file{factory, FN, true};
}
{
auto password{yapet::toSecureArray("InvalidPassword")};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
CPPUNIT_ASSERT_THROW((YAPET::File{factory, FN, false}),
yapet::InvalidPasswordError);
}
}
void writePasswords() {
{
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
auto blowfish{factory->crypto()};
YAPET::File file{factory, FN, true};
auto passwordList{createPasswordList(blowfish)};
file.save(passwordList);
}
{
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
auto blowfish{factory->crypto()};
YAPET::File file{factory, FN, false};
std::list<yapet::PasswordListItem> list = file.read();
CPPUNIT_ASSERT(list.size() == ROUNDS);
std::list<yapet::PasswordListItem>::iterator it = list.begin();
for (int i = 0; it != list.end(); i++, it++) {
auto expectedPasswordRecord{makePasswordRecord(i)};
CPPUNIT_ASSERT(
std::strcmp(reinterpret_cast<const char *>(it->name()),
reinterpret_cast<const char *>(
expectedPasswordRecord.name())) == 0);
auto decryptedSerializedPasswordRecord{
blowfish->decrypt(it->encryptedRecord())};
yapet::PasswordRecord actual{decryptedSerializedPasswordRecord};
comparePasswordRecords(actual, expectedPasswordRecord);
}
}
}
void detectModificationOnSave() {
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
YAPET::File file1{factory, FN, true};
YAPET::File file2{factory, FN, false};
std::list<yapet::PasswordListItem> passwordList{};
auto passwordRecord{makePasswordRecord(1)};
auto serializedPasswordRecord{passwordRecord.serialize()};
auto blowfish{factory->crypto()};
auto encryptedSerializedPasswordRecord{
blowfish->encrypt(serializedPasswordRecord)};
yapet::PasswordListItem passwordListItem{
makeName(1).c_str(), encryptedSerializedPasswordRecord};
passwordList.push_back(passwordListItem);
// we're using second resolution, thus sleep one second in order to
// allow the update to be detected
::sleep(1);
// This modifies the mtime of the file
file1.save(passwordList);
// the modification of the file's mtime should be detected here
CPPUNIT_ASSERT_THROW(file2.save(passwordList), yapet::RetryableError);
::sleep(1);
// file1 must allow to re-save
file1.save(passwordList);
}
void forceSave() {
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
YAPET::File file1{factory, FN, true};
YAPET::File file2{factory, FN, false};
std::list<yapet::PasswordListItem> passwordList{};
auto passwordRecord{makePasswordRecord(1)};
auto serializedPasswordRecord{passwordRecord.serialize()};
auto blowfish{factory->crypto()};
auto encryptedSerializedPasswordRecord{
blowfish->encrypt(serializedPasswordRecord)};
yapet::PasswordListItem passwordListItem{
makeName(1).c_str(), encryptedSerializedPasswordRecord};
passwordList.push_back(passwordListItem);
// we're using second resolution, thus sleep one second in order to
// allow the update to be detected
::sleep(1);
// This modifies the mtime of the file
file1.save(passwordList);
passwordRecord = makePasswordRecord(2);
serializedPasswordRecord = passwordRecord.serialize();
encryptedSerializedPasswordRecord =
blowfish->encrypt(serializedPasswordRecord);
yapet::PasswordListItem passwordListItem2{
makeName(2).c_str(), encryptedSerializedPasswordRecord};
std::list<yapet::PasswordListItem> passwordList2{};
passwordList2.push_back(passwordListItem2);
// the modification of the file's mtime should be detected here
CPPUNIT_ASSERT_THROW(file2.save(passwordList2), yapet::RetryableError);
file2.save(passwordList2, true);
auto actual{file2.read()};
CPPUNIT_ASSERT(actual.size() == 1);
auto serializedEncryptedRecord{actual.begin()->encryptedRecord()};
auto serializedRecord{blowfish->decrypt(serializedEncryptedRecord)};
yapet::PasswordRecord actualPasswordRecord{serializedRecord};
comparePasswordRecords(actualPasswordRecord, passwordRecord);
}
void timeMasterPasswordSet() {
std::time_t approxTimePasswordSet{0};
{
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
approxTimePasswordSet = std::time(0);
YAPET::File file{factory, FN, true};
}
{
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
YAPET::File file{factory, FN, false};
int64_t passwordSet{file.getMasterPWSet()};
CPPUNIT_ASSERT(((approxTimePasswordSet - 10) < passwordSet) &&
((approxTimePasswordSet + 10) > passwordSet));
}
}
void setNewPassword() {
{
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
auto blowfish{factory->crypto()};
YAPET::File file{factory, FN, true};
auto passwordList{createPasswordList(blowfish)};
file.save(passwordList);
auto newPassword{yapet::toSecureArray("NewSecret")};
std::shared_ptr<yapet::AbstractCryptoFactory> newCrypto{
new yapet::BlowfishFactory{newPassword, yapet::MetaData{}}};
file.setNewKey(newCrypto);
}
{
auto password{yapet::toSecureArray("NewSecret")};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
auto blowfish{factory->crypto()};
YAPET::File file{factory, FN, false};
std::list<yapet::PasswordListItem> list = file.read();
CPPUNIT_ASSERT(list.size() == ROUNDS);
std::list<yapet::PasswordListItem>::iterator it = list.begin();
for (int i = 0; it != list.end(); i++, it++) {
auto expectedPasswordRecord{makePasswordRecord(i)};
CPPUNIT_ASSERT(
std::strcmp(reinterpret_cast<const char *>(it->name()),
reinterpret_cast<const char *>(
expectedPasswordRecord.name())) == 0);
auto decryptedSerializedPasswordRecord{
blowfish->decrypt(it->encryptedRecord())};
yapet::PasswordRecord actual{decryptedSerializedPasswordRecord};
comparePasswordRecords(actual, expectedPasswordRecord);
}
}
};
void allowSaveAfterPasswordSave() {
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
auto blowfish{factory->crypto()};
YAPET::File file{factory, FN, true};
auto passwordList{createPasswordList(blowfish)};
file.save(passwordList);
// Make sure mtime change may be picked up
::sleep(1);
auto newPassword{yapet::toSecureArray("NewSecret")};
std::shared_ptr<yapet::AbstractCryptoFactory> newCrypto{
new yapet::BlowfishFactory{newPassword, yapet::MetaData{}}};
file.setNewKey(newCrypto);
file.save(passwordList);
}
void corruptFile() {
// The file has the byte at offset 0x2f changed from 0x88 to 0x89,
// messing up the length indicator for the first record
auto password{yapet::toSecureArray(TEST_PASSWORD)};
std::shared_ptr<yapet::BlowfishFactory> factory{
new yapet::BlowfishFactory{password, yapet::MetaData{}}};
YAPET::File file{factory, BUILDDIR "/corrupt_blowfish.pet", false,
false};
CPPUNIT_ASSERT_THROW(file.read(), yapet::EncryptionError);
}
};
int main() {
yapet::OpenSSL::init();
CppUnit::TextUi::TestRunner runner;
runner.addTest(BlowfishFileTest ::suite());
return runner.run() ? 0 : 1;
}
|
