File: test_config.py

package info (click to toggle)
zabbix-cli 3.6.2-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 2,980 kB
  • sloc: python: 19,920; makefile: 5
file content (858 lines) | stat: -rw-r--r-- 28,045 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
from __future__ import annotations

from pathlib import Path
from typing import Any
from typing import Optional
from typing import Union

import pytest

try:
    import tomllib
except ImportError:
    import tomli as tomllib

from inline_snapshot import snapshot
from pydantic import BaseModel
from pydantic import Field
from pydantic import model_validator
from typing_extensions import Self
from zabbix_cli.config.commands import CommandConfig
from zabbix_cli.config.commands import CreateHostOrTemplateGroup
from zabbix_cli.config.constants import OutputFormat
from zabbix_cli.config.constants import SecretMode
from zabbix_cli.config.model import APIConfig
from zabbix_cli.config.model import AppConfig
from zabbix_cli.config.model import AutoUpdateConfig
from zabbix_cli.config.model import Config
from zabbix_cli.config.model import PluginConfig
from zabbix_cli.config.model import PluginsConfig
from zabbix_cli.config.utils import DeprecatedField
from zabbix_cli.config.utils import fmt_deprecated_fields
from zabbix_cli.config.utils import get_deprecated_fields_set
from zabbix_cli.config.utils import replace_deprecated_fields
from zabbix_cli.exceptions import ConfigOptionNotFound
from zabbix_cli.exceptions import PluginConfigTypeError


def test_config_default() -> None:
    """Assert that the config can be instantiated with no arguments."""
    assert Config()


def test_sample_config() -> None:
    """Assert that the sample config can be instantiated."""
    assert Config.sample_config()


@pytest.mark.parametrize(
    "bespoke",
    [True, False],
)
def test_load_config_file_legacy(legacy_config_path: Path, bespoke: bool) -> None:
    if bespoke:
        conf = Config.from_conf_file(legacy_config_path)
    else:
        conf = Config.from_file(legacy_config_path)
    assert conf
    # Should be loaded from the file we specified
    assert conf.config_path == legacy_config_path
    # Should be marked as legacy
    assert conf.app.is_legacy is True
    # Should use legacy JSON format automatically
    assert conf.app.legacy_json_format is True


def remove_path_options(config_path: Path, tmp_path: Path) -> None:
    """Remove all path options from a TOML config file.

    Some config options require a directory or file to exist, which is not always
    possible or desirable in a test environment.
    """
    contents = config_path.read_text()
    new_contents = "\n".join(
        line for line in contents.splitlines() if "/path/to" not in line
    )
    config_path.write_text(new_contents)


def replace_paths(config_path: Path, tmp_path: Path) -> None:
    """Replace all /path/to paths in a file with temporary directories."""
    contents = config_path.read_text()
    new_contents = contents.replace("/path/to", str(tmp_path))
    tmp_path.mkdir(exist_ok=True)
    config_path.write_text(new_contents)


@pytest.mark.parametrize(
    "bespoke",
    [True, False],
)
@pytest.mark.parametrize(
    "with_paths",
    [True, False],
)
def test_load_config_file(
    config_path: Path, tmp_path: Path, bespoke: bool, with_paths: bool
) -> None:
    """Test loading a TOML configuration file."""
    # Test with and without custom file paths
    if with_paths:
        replace_paths(config_path, tmp_path)
    else:
        remove_path_options(config_path, tmp_path)

    # Use bespoke method for loading the given format
    if bespoke:
        conf = Config.from_toml_file(config_path)
    else:
        conf = Config.from_file(config_path)

    assert conf
    # Should be loaded from the file we specified
    assert conf.config_path == config_path
    assert conf.app.is_legacy is False
    assert conf.app.legacy_json_format is False


def test_plugins_config_get() -> None:
    """Test that we can get a plugin configuration."""
    config = PluginsConfig(
        root={
            "test1": PluginConfig(
                enabled=True,
                module="zabbix_cli.plugins.test1",
            ),
            "test2": PluginConfig(
                enabled=True,
                module="zabbix_cli.plugins.test2",
            ),
        }
    )
    assert config.get("test1")
    assert config.get("test2")
    assert not config.get("test3")


def test_plugin_config_get() -> None:
    config = PluginConfig(module="test")
    assert config.get("module") == "test"

    # With type validation
    assert config.get("module", type=str) == "test"

    # Missing option
    with pytest.raises(ConfigOptionNotFound):
        assert config.get("missing") is None

    # Default value
    assert config.get("missing", "default") == "default"

    # Default value with type validation
    assert config.get("missing", "default", type=str) == "default"

    # Extra values
    config = PluginConfig(
        module="test",
        extra1="foo",
        extra2=2,
        extra3=True,
        extra4=[1, 2, 3],
    )
    assert config.get("extra1") == "foo"
    assert config.get("extra2") == 2
    assert config.get("extra3") is True
    assert config.get("extra4") == [1, 2, 3]

    # With type validation
    assert config.get("extra1", type=str) == "foo"
    assert config.get("extra2", type=int) == 2
    assert config.get("extra3", type=bool) is True
    assert config.get("extra4", type=list) == [1, 2, 3]

    # Type validation with coercion
    assert config.get("extra3", type=int) == 1
    assert config.get("extra4", type=tuple) == (1, 2, 3)
    # Cannot coerce int to str by default in Pydantic
    with pytest.raises(PluginConfigTypeError):
        assert config.get("extra2", type=str) == "2"


def test_config_get_with_annotations() -> None:
    """Test PluginConfig.get with more complex annotations"""
    config = PluginConfig(
        module="test",
        extra1="foo",
        extra2=2,
        extra3=True,
        extra4=[1, 2, 3],
        extra5={"foo": [1, 2, 3]},
    )

    assert config.get("extra1", type=Optional[str]) == "foo"
    assert config.get("extra1", 123, type=Optional[str]) == "foo"
    assert config.get("extra1", type=Union[str, int])

    # Invalid default type
    with pytest.raises(PluginConfigTypeError):
        config.get("wrong", 123, type=Optional[str])
    assert config.get("wrong", "123", type=Optional[str]) == "123"

    # List type
    assert config.get("extra4", type=list) == [1, 2, 3]
    assert config.get("extra4", type=list[int]) == [1, 2, 3]
    assert config.get("extra4", type=list[int]) == [1, 2, 3]

    # Dict type
    assert config.get("extra5", type=dict) == {"foo": [1, 2, 3]}
    assert config.get("extra5", type=dict[str, list[int]]) == {"foo": [1, 2, 3]}
    assert config.get("extra5", type=dict[str, list[int]]) == {"foo": [1, 2, 3]}


def test_plugin_config_set() -> None:
    config = PluginConfig()

    # Existing model field
    config.set("module", "new")
    assert config.module == "new"

    # New attribute/field
    config.set("extra", "new")
    assert config.extra == "new"

    # Any type goes
    obj = object()
    config.set("object", obj)
    assert config.object is obj

    # Instantiated with extra values
    config = PluginConfig(
        module="test",
        extra1="extra1",
        extra2=2,
        extra3=True,
    )

    # Override existing values
    config.set("extra1", "new")
    config.set("extra2", 3)
    config.set("extra3", False)

    assert config.extra1 == "new"
    assert config.extra2 == 3
    assert config.extra3 is False

    assert config.model_dump() == snapshot(
        {
            "module": "test",
            "enabled": True,
            "optional": False,
            "extra1": "new",
            "extra2": 3,
            "extra3": False,
        }
    )


@pytest.mark.parametrize(
    "context, expect",
    [
        ({"secrets": SecretMode.HIDE}, SecretMode.HIDE),
        ({"secrets": SecretMode.MASK}, SecretMode.MASK),
        ({"secrets": SecretMode.PLAIN}, SecretMode.PLAIN),
        ({"secrets": "hide"}, SecretMode.HIDE),
        ({"secrets": "mask"}, SecretMode.MASK),
        ({"secrets": "plain"}, SecretMode.PLAIN),
        ({}, SecretMode.MASK),
        (None, SecretMode.MASK),
        (lambda: {}, SecretMode.MASK),  # type: ignore
        ({"secrets": True}, SecretMode.PLAIN),
        ({"secrets": False}, SecretMode.MASK),
    ],
)
def test_secret_mode_from_context(context: Any, expect: SecretMode) -> None:
    assert SecretMode.from_context(context) == expect


def test_secret_mode_default() -> None:
    assert SecretMode._DEFAULT is SecretMode.MASK  # type: ignore


def _get_config_with_secrets() -> Config:
    return Config(
        api=APIConfig(
            username="Admin",
            password="password",
            auth_token="token123",
        )
    )


def test_config_dump_to_file_masked(tmp_path: Path) -> None:
    conf_file = tmp_path / "zabbix-cli.toml"
    conf = _get_config_with_secrets()
    conf.dump_to_file(conf_file, secrets=SecretMode.MASK)

    toml_str = conf_file.read_text()
    config_dict = tomllib.loads(toml_str)
    assert config_dict["api"]["password"] == snapshot("**********")
    assert config_dict["api"]["auth_token"] == snapshot("**********")


def test_deprecated_field_warnings(caplog: pytest.LogCaptureFixture) -> None:
    """Test that deprecated fields are logged."""
    Config(
        app=AppConfig(
            output_format=OutputFormat.JSON,
            use_colors=True,
            use_paging=True,
            system_id="System-User",
            config_auto_update=AutoUpdateConfig(enabled=False),
        )
    )
    assert caplog.record_tuples == snapshot(
        [
            (
                "zabbix_cli",
                30,
                "Config option [configopt]output_format[/] is deprecated. Replaced by: [configopt]app.output.format[/].",
            ),
            (
                "zabbix_cli",
                30,
                "Config option [configopt]system_id[/] is deprecated. Replaced by: [configopt]api.username[/].",
            ),
            (
                "zabbix_cli",
                30,
                "Config option [configopt]use_colors[/] is deprecated. Replaced by: [configopt]app.output.color[/].",
            ),
            (
                "zabbix_cli",
                30,
                "Config option [configopt]use_paging[/] is deprecated. Replaced by: [configopt]app.output.paging[/].",
            ),
            (
                "zabbix_cli",
                30,
                """\
Your configuration file contains deprecated options.
  To update your config file with the new options, run:
  [command]zabbix-cli update_config[/]
  For more information, see the documentation.\
""",
            ),
        ]
    )


def test_get_deprecated_fields_set() -> None:
    config = Config(
        app=AppConfig(
            output_format=OutputFormat.JSON,
            use_colors=True,
            use_paging=True,
            system_id="System-User",
        )
    )
    # Sort because order of `BaseModel.model_fields_set` is not guaranteed
    assert sorted(get_deprecated_fields_set(config)) == snapshot(
        [
            DeprecatedField(
                field_name="app.output_format",
                value=OutputFormat.JSON,
                replacement=["app.output.format"],
            ),
            DeprecatedField(
                field_name="app.system_id",
                value="System-User",
                replacement=["api.username"],
            ),
            DeprecatedField(
                field_name="app.use_colors",
                value=True,
                replacement=["app.output.color"],
            ),
            DeprecatedField(
                field_name="app.use_paging",
                value=True,
                replacement=["app.output.paging"],
            ),
        ]
    )


def test_get_deprecated_fields_deep_nesting() -> None:
    """Test that deprecated fields are found in nested models."""

    class Baz(BaseModel):
        qux: str = ""

    class Bar(BaseModel):
        baz: Baz = Field(default_factory=Baz)
        qux_deprecated: str = Field(
            default="",
            deprecated=True,
            json_schema_extra={"replacement": "bar.baz.qux"},
        )

    class Foo(BaseModel):
        bar: Bar = Field(default_factory=Bar)

        # Copied from zabbix_cli.config.model.Config
        # TODO: to test this better, we could declare a new BaseModel
        # subclass intended for top-level models which automatically implement
        # this validator. That way we can be sure the validator behavior
        # in the test is consistent with the behavior in the actual code.
        @model_validator(mode="after")
        def _set_deprecated_fields_in_new_location(self) -> Self:
            """Set deprecated fields in their new location."""
            replace_deprecated_fields(self)
            return self

    foo = Foo(bar=Bar(qux_deprecated="test123"))

    # Deprecated field should be found
    assert sorted(get_deprecated_fields_set(foo)) == snapshot(
        [
            DeprecatedField(
                field_name="bar.qux_deprecated",
                value="test123",
                replacement=["bar.baz.qux"],
            )
        ]
    )

    # Deprecated field should be automatically assigned to the new field
    assert foo.model_dump() == snapshot(
        {"bar": {"baz": {"qux": "test123"}, "qux_deprecated": "test123"}}
    )


def test_deprecated_fields_updated() -> None:
    """Test that deprecated fields are assigned to the new fields if specified."""
    conf = Config(
        app=AppConfig(
            # Set fields to non-default values for comparison
            output_format=OutputFormat.JSON,
            use_colors=False,
            use_paging=True,
            system_id="System-User",
        )
    )
    assert sorted(conf.app.model_fields_set) == snapshot(
        ["output_format", "system_id", "use_colors", "use_paging"]
    )
    assert sorted(conf.app.output.model_fields_set) == snapshot(
        ["color", "format", "paging"]
    )
    assert conf.app.output.format == OutputFormat.JSON
    assert conf.app.output.color is False
    assert conf.app.output.paging is True
    assert conf.api.username == "System-User"


def get_deprecated_fields(model: Union[type[BaseModel], BaseModel]) -> list[str]:
    """Get a set of names of deprecated fields in a model and its submodels."""
    fields: list[str] = []
    for field_name, field in model.model_fields.items():
        if field.deprecated:
            fields.append(field_name)
        if not field.annotation:
            continue
        try:
            if issubclass(field.annotation, BaseModel):
                submodel_fields = get_deprecated_fields(field.annotation)
                fields.extend(
                    f"{field_name}.{subfield}" for subfield in submodel_fields
                )
        except TypeError:
            pass
    return fields


def test_get_deprecated_fields() -> None:
    """Ensure we are aware of all deprecated fields in the Config model"""
    assert get_deprecated_fields(Config) == snapshot(
        [
            "app.auth_token_file",
            "app.output_format",
            "app.use_colors",
            "app.use_paging",
            "app.system_id",
            "app.default_hostgroups",
            "app.default_admin_usergroups",
            "app.default_create_user_usergroups",
            "app.default_notification_users_usergroups",
            "app.export_directory",
            "app.export_format",
            "app.export_timestamps",
        ]
    )


def test_load_deprecated_config(tmp_path: Path) -> None:
    conf = tmp_path / "zabbix-cli.toml"
    conf.write_text(
        f"""
[api]
url = "http://localhost:8080"

# No username option specified (assigned from app.system_id)

password = ""
auth_token = ""
verify_ssl = true

[app]
use_session_file = true
auth_token_file = "{tmp_path}/.zabbix-cli_auth_token"
auth_file = "{tmp_path}/.zabbix-cli_auth"
history = true
history_file = "{tmp_path}/history"
bulk_mode = "strict"

# Deprecated options (moved)
default_hostgroups = ["All-hosts"]
default_admin_usergroups = ["All-admin-users"]
default_create_user_usergroups = ["All-users"]
default_notification_users_usergroups = ["All-notification-users"]
export_directory = "{tmp_path}/exports"
export_format = "json"
export_timestamps = false
use_colors = false
use_paging = true
output_format = "json"
system_id = "System-User"

# Deprecated options (slated for removal)
allow_insecure_auth_file = true
legacy_json_format = false

# No [app.output] section specified (assigned from deprecated app options)

[logging]
enabled = true
log_level = "DEBUG"
log_file = "{tmp_path}/zabbix-cli.log"

[plugins]
"""
    )
    # Check that we can actually load the config
    config = Config.from_file(conf)

    # Check that the deprecated fields are assigned to the new fields
    assert config.app.commands.create_host.hostgroups == ["All-hosts"]
    assert config.app.commands.create_hostgroup.rw_groups == ["All-admin-users"]
    assert config.app.commands.create_hostgroup.ro_groups == ["All-users"]
    assert config.app.commands.create_notification_user.usergroups == [
        "All-notification-users"
    ]
    assert config.app.commands.create_user.usergroups == ["All-users"]
    assert config.app.commands.export.directory == tmp_path / "exports"
    assert config.app.commands.export.format == OutputFormat.JSON
    assert config.app.commands.export.timestamps is False

    assert config.app.output.color is False
    assert config.app.output.paging is True
    assert config.app.output.format == OutputFormat.JSON
    assert config.api.username == "System-User"  # assigned from app.system_id


def test_load_deprecated_config_with_new_and_old_options(tmp_path: Path) -> None:
    """Test loading a config file where both new and deprecated options are present.

    The deprecated options should _not_ be assigned to the new options, as the new options
    are already set
    """
    conf = tmp_path / "zabbix-cli.toml"
    conf.write_text(
        f"""
##### Deprecated options (should be ignored) #####

[app]
default_hostgroups = ["All-hosts-deprecated"]
default_admin_usergroups = ["All-admin-users-deprecated"]
default_create_user_usergroups = ["All-users-deprecated"]
default_notification_users_usergroups = ["All-notification-users-deprecated"]
export_directory = "{tmp_path}/exports_deprecated"
export_format = "yaml"
export_timestamps = true
use_colors = false
use_paging = true
output_format = "json"
system_id = "System-User"

##### New options (should be used) #####

[api]
username = "Admin"

[app.commands.create_user]
usergroups = ["All-users"]

[app.commands.create_notification_user]
usergroups = ["All-notification-users"]

[app.commands.create_host]
hostgroups = ["All-hosts"]

[app.commands.create_hostgroup]
ro_groups = ["All-users"]
rw_groups = ["All-admin-users"]

[app.commands.export]
directory = "{tmp_path}/exports"
format = "json"
timestamps = false

[app.output]
color = true
format = "table"
paging = false
"""
    )
    config = Config.from_file(conf)

    # New fields should NOT be overwritten by deprecated fields
    assert config.app.commands.create_host.hostgroups == ["All-hosts"]
    assert config.app.commands.create_hostgroup.rw_groups == ["All-admin-users"]
    assert config.app.commands.create_hostgroup.ro_groups == ["All-users"]
    assert config.app.commands.create_user.usergroups == ["All-users"]
    assert config.app.commands.create_notification_user.usergroups == [
        "All-notification-users"
    ]
    assert config.app.commands.create_hostgroup.ro_groups == ["All-users"]
    assert config.app.commands.create_hostgroup.rw_groups == ["All-admin-users"]
    assert config.app.commands.export.directory == tmp_path / "exports"
    assert config.app.commands.export.format == OutputFormat.JSON
    assert config.app.commands.export.timestamps is False
    assert config.api.username == "Admin"
    assert config.app.output.color is True
    assert config.app.output.paging is False
    assert config.app.output.format == OutputFormat.TABLE


def test_load_deprecated_config_legacy(legacy_config_path: Path) -> None:
    """Test loading a legacy .conf config file with deprecated options."""
    config_str = legacy_config_path.read_text()
    assert "system_id=Test" in config_str
    assert "use_colors=ON" in config_str
    assert "use_paging=OFF" in config_str

    # Manipulate config to set default boolean values to opposite
    config_str = config_str.replace("use_colors=ON", "use_colors=OFF")
    config_str = config_str.replace("use_paging=OFF", "use_paging=ON")
    legacy_config_path.write_text(config_str)

    config = Config.from_conf_file(legacy_config_path)

    # Check that the deprecated fields are assigned to the new fields
    assert config.api.username == "Test"
    assert config.app.output.color is False
    assert config.app.output.paging is True

    # Check that the assigned fields are counted as set
    assert "username" in config.api.model_fields_set
    assert "color" in config.app.output.model_fields_set
    assert "paging" in config.app.output.model_fields_set
    assert "format" not in config.app.output.model_fields_set

    # Check that the deprecated fields are also set
    assert "system_id" in config.app.model_fields_set
    assert "use_colors" in config.app.model_fields_set
    assert "use_paging" in config.app.model_fields_set
    assert "output_format" not in config.app.model_fields_set


def test_shared_command_config(tmp_path: Path) -> None:
    """Test that the shared command config is loaded correctly."""

    # Test via kwargs
    config = Config(
        app=AppConfig(
            commands=CommandConfig(
                create_group=CreateHostOrTemplateGroup(
                    ro_groups=["All-users", "Guests"],
                    rw_groups=["All-admin-users", "All-techs"],
                )
            )
        )
    )
    assert config.app.commands.create_hostgroup.ro_groups == snapshot(
        ["All-users", "Guests"]
    )
    assert config.app.commands.create_hostgroup.rw_groups == snapshot(
        ["All-admin-users", "All-techs"]
    )
    assert config.app.commands.create_templategroup.ro_groups == snapshot(
        ["All-users", "Guests"]
    )
    assert config.app.commands.create_templategroup.rw_groups == snapshot(
        ["All-admin-users", "All-techs"]
    )

    # Test via config file
    conf_str = """
    [app.commands.create_group]
    ro_groups = ["All-users", "Guests"]
    rw_groups = ["All-admin-users", "All-techs"]
    """
    conf_path = tmp_path / "zabbix-cli.toml"
    conf_path.write_text(conf_str)
    config_shared = Config.from_toml_file(conf_path)

    assert config_shared.app.commands.create_hostgroup.ro_groups == snapshot(
        ["All-users", "Guests"]
    )
    assert config_shared.app.commands.create_hostgroup.rw_groups == snapshot(
        ["All-admin-users", "All-techs"]
    )
    assert config_shared.app.commands.create_templategroup.ro_groups == snapshot(
        ["All-users", "Guests"]
    )
    assert config_shared.app.commands.create_templategroup.rw_groups == snapshot(
        ["All-admin-users", "All-techs"]
    )

    # Test via config file (create_hostgroup is set: only create_templategroup uses shared)
    conf_str = """
    [app.commands.create_hostgroup]
    ro_groups = ["All-users"]
    rw_groups = ["All-admin-users"]

    [app.commands.create_group]
    ro_groups = ["All-users", "Guests"]
    rw_groups = ["All-admin-users", "All-techs"]
    """
    conf_path = tmp_path / "zabbix-cli_hg_set.toml"
    conf_path.write_text(conf_str)
    conf_hg_set = Config.from_toml_file(conf_path)

    assert conf_hg_set.app.commands.create_hostgroup.ro_groups == snapshot(
        ["All-users"]
    )
    assert conf_hg_set.app.commands.create_hostgroup.rw_groups == snapshot(
        ["All-admin-users"]
    )
    assert conf_hg_set.app.commands.create_templategroup.ro_groups == snapshot(
        ["All-users", "Guests"]
    )
    assert conf_hg_set.app.commands.create_templategroup.rw_groups == snapshot(
        ["All-admin-users", "All-techs"]
    )

    # Test via config file (create_templategroup is set: only create_hostgroup uses shared)
    conf_str = """
    [app.commands.create_templategroup]
    ro_groups = ["All-users"]
    rw_groups = ["All-admin-users"]

    [app.commands.create_group]
    ro_groups = ["All-users", "Guests"]
    rw_groups = ["All-admin-users", "All-techs"]
    """
    conf_path = tmp_path / "zabbix-cli_tg_set.toml"
    conf_path.write_text(conf_str)
    conf_tg_set = Config.from_toml_file(conf_path)

    assert conf_tg_set.app.commands.create_hostgroup.ro_groups == snapshot(
        ["All-users", "Guests"]
    )
    assert conf_tg_set.app.commands.create_hostgroup.rw_groups == snapshot(
        ["All-admin-users", "All-techs"]
    )
    assert conf_tg_set.app.commands.create_templategroup.ro_groups == snapshot(
        ["All-users"]
    )
    assert conf_tg_set.app.commands.create_templategroup.rw_groups == snapshot(
        ["All-admin-users"]
    )


def test_config_command_alias_priority(
    tmp_path: Path, caplog: pytest.LogCaptureFixture
) -> None:
    """Test loading a config file with duplicate sections with different aliases"""
    conf_import_first = """\
[app.commands.import]
format = "csv"

[app.commands.export]
format = "json"
"""
    conf_export_first = """\
[app.commands.export]
format = "json"

[app.commands.import]
format = "csv"
"""

    # Assert that the `import` alias is never used when `export` is defined
    for conf_str in [conf_import_first, conf_export_first]:
        conf_path = tmp_path / "zabbix-cli.toml"
        conf_path.write_text(conf_str)

        with caplog.at_level("WARNING", logger="zabbix_cli.config.commands"):
            conf = Config.from_toml_file(conf_path)

            # Uses the first alias found in the file regardless
            assert conf.app.commands.export.format == OutputFormat.JSON

            # The log record tuple should be the same for both cases
            assert caplog.record_tuples == snapshot(
                [
                    (
                        "zabbix_cli.config.commands",
                        30,
                        "Multiple export/import configuration sections found ([app.commands.export], [app.commands.import]). Using section: [app.commands.export]",
                    )
                ]
            )
            caplog.clear()


def test_fmt_deprecated_fields() -> None:
    deprecated_fields = [
        # A subset of deprecated fields for testing
        DeprecatedField(
            field_name="app.output_format",
            value=OutputFormat.JSON,
            replacement=["app.output.format"],
        ),
        DeprecatedField(
            field_name="app.system_id",
            value="System-User",
            replacement=["api.username"],
        ),
        DeprecatedField(
            field_name="app.use_colors",
            value=True,
            replacement=["app.output.color"],
        ),
        DeprecatedField(
            field_name="app.use_paging",
            value=True,
            replacement=["app.output.paging"],
        ),
        DeprecatedField(
            field_name="default_create_user_usergroups",
            value=[],
            replacement=[
                "app.commands.create_user.usergroups",
                "app.commands.create_hostgroup.ro_groups",
            ],
        ),
    ]
    formatted = fmt_deprecated_fields(deprecated_fields)
    assert formatted == snapshot(
        """\
  - [option]app.output_format[/] (replaced by: [option]app.output.format[/])
  - [option]app.system_id[/] (replaced by: [option]api.username[/])
  - [option]app.use_colors[/] (replaced by: [option]app.output.color[/])
  - [option]app.use_paging[/] (replaced by: [option]app.output.paging[/])
  - [option]default_create_user_usergroups[/] (replaced by: [option]app.commands.create_user.usergroups[/], [option]app.commands.create_hostgroup.ro_groups[/])\
"""
    )