1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
|
#!/usr/bin/env perl
# SPDX-License-Identifier: MIT
#
# Copyright (c) 2023, Rob Norris <robn@despairlabs.com>
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to
# deal in the Software without restriction, including without limitation the
# rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
# sell copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in
# all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
# FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
# IN THE SOFTWARE.
# This program will update the AUTHORS file to include commit authors that are
# in the git history but are not yet credited.
#
# The CONTRIBUTORS section of the AUTHORS file attempts to be a list of
# individual contributors to OpenZFS, with one name, address and line per
# person. This is good for readability, but does not really leave room for the
# that names and emails on commits from the same individual can be different,
# for all kinds of reasons, not limited to:
#
# - a person might change organisations, and so their email address changes
#
# - a person might be paid to work on OpenZFS for their employer, and then hack
# on personal projects in the evening, so commits legitimately come from
# different addresses
#
# - names change for all kinds of reasons
#
# To try and account for this, this program will try to find all the possible
# names and emails for a single contributor, and then select the "best" one to
# add to the AUTHORS file.
#
# The CONTRIBUTORS section of the AUTHORS file is considered the source of
# truth. Once an individual committer is listed in there, that line will not be
# removed regardless of what is discovered in the commit history. However, it
# can't just be _anything_. The name or email still has to match something seen
# in the commit history, so that we're able to undertand that its the same
# contributor.
#
# The bulk of the work is in running `git log` to fetch commit author names and
# emails. For each value, we generate a "slug" to use as an internal id for
# that value, which is mostly just the lowercase of the value with whitespace
# and punctuation removed. Two values with subtle differences can produce the
# same slug, so at this point we also try to keep the "best" pre-slug value as
# the display version. We use this slug to update two maps, one of email->name,
# the other of name->email.
#
# Where possible, we also consider Signed-off-by: trailers in the commit
# message, and if they match the commit author, enter them into the maps also.
# Because a commit can contain multiple signoffs, we only track one if either
# the name or the email address match the commit author (by slug). This is
# mostly aimed at letting an explicit signoff override a generated name or
# email on the same commit (usually a Github noreply), while avoiding every
# signoff ever being treated as a possible canonical ident for some other
# committer. (Also note that this behaviour only works for signoffs that can be
# extracted with git-interpret-trailers, which misses many seen in the OpenZFS
# git history, for various reasons).
#
# Once collected, we then walk all the emails we've seen and get all the names
# associated with every instance. Then for each of those names, we get all the
# emails associated, and so on until we've seen all the connected names and
# emails. This collection is every possible name and email for an individual
# contributor.
#
# Finaly, we consider these groups, and select the "best" name and email for
# the contributor, and add them to the author tables if they aren't there
# already. Once we've done everyone, we write out a new AUTHORS file, and
# that's the whole job.
#
# This is imperfect! Its necessary for the user to examine the diff and make
# sure its sensible. If it hasn't hooked up right, it may necessary to adjust
# the input data (via .mailmap) or improve the heuristics in this program. It
# took a long time to get into good shape when first written (355 new names
# added to AUTHORS!) but hopefully in the future we'll be running this
# regularly so it doesn't fall so far behind.
use 5.010;
use warnings;
use strict;
# Storage for the "best looking" version of name or email, keyed on slug.
my %display_name;
my %display_email;
# First, we load the existing AUTHORS file. We save everything before
# CONTRIBUTORS: line as-is so we can write it back out to the new file. Then
# we extract name,email pairs from the remainder and store them in a pair of
# hashtables, keyed on slug.
my %authors_name;
my %authors_email;
my @authors_header;
for my $line (do { local (@ARGV) = ('AUTHORS'); <> }) {
chomp $line;
state $in_header = 1;
if ($in_header) {
push @authors_header, $line;
$in_header = 0 if $line =~ m/^CONTRIBUTORS:/;
} else {
my ($name, $email) = $line =~ m/^\s+(.+)(?= <) <([^>]+)/;
next unless $name;
my $semail = email_slug($email);
my $sname = name_slug($name);
$authors_name{$semail} = $sname;
$authors_email{$sname} = $semail;
# The name/email in AUTHORS is already the "best looking"
# version, by definition.
$display_name{$sname} = $name;
$display_email{$semail} = $email;
}
}
# Next, we load all the commit authors and signoff pairs, and form name<->email
# mappings, keyed on slug. Note that this format is getting the
# .mailmap-converted form. This lets us control the input to some extent by
# making changes there.
my %seen_names;
my %seen_emails;
# The true email address from commits, by slug. We do this so we can generate
# mailmap entries, which will only match the exact address from the commit,
# not anything "prettified". This lets us remember the prefix part of Github
# noreply addresses, while not including it in AUTHORS if that is truly the
# best option we have.
my %commit_email;
for my $line (reverse qx(git log --pretty=tformat:'%aN:::%aE:::%(trailers:key=signed-off-by,valueonly,separator=:::)')) {
chomp $line;
my ($name, $email, @signoffs) = split ':::', $line;
next unless $name && $email;
my $semail = email_slug($email);
my $sname = name_slug($name);
# Track the committer name and email.
$seen_names{$semail}{$sname} = 1;
$seen_emails{$sname}{$semail} = 1;
# Keep the original commit address.
$commit_email{$semail} = $email;
# Consider if these are the best we've ever seen.
update_display_name($name);
update_display_email($email);
# Check signoffs. any that have a matching name or email as the
# committer (by slug), also track them.
for my $signoff (@signoffs) {
my ($soname, $soemail) = $signoff =~ m/^([^<]+)\s+<(.+)>$/;
next unless $soname && $soemail;
my $ssoname = name_slug($soname);
my $ssoemail = email_slug($soemail);
if (($semail eq $ssoemail) ^ ($sname eq $ssoname)) {
$seen_names{$ssoemail}{$ssoname} = 1;
$seen_emails{$ssoname}{$ssoemail} = 1;
update_display_name($soname);
update_display_email($soemail);
}
}
}
# Now collect unique committers by all names+emails we've ever seen for them.
# We start with emails and resolve all possible names, then we resolve the
# emails for those names, and round and round until there's nothing left.
my @committers;
for my $start_email (sort keys %seen_names) {
# it might have been deleted already through a cross-reference
next unless $seen_names{$start_email};
my %emails;
my %names;
my @check_emails = ($start_email);
my @check_names;
while (@check_emails || @check_names) {
while (my $email = shift @check_emails) {
next if $emails{$email}++;
push @check_names,
sort keys %{delete $seen_names{$email}};
}
while (my $name = shift @check_names) {
next if $names{$name}++;
push @check_emails,
sort keys %{delete $seen_emails{$name}};
}
}
# A "committer" is the collection of connected names and emails.
push @committers, [[sort keys %emails], [sort keys %names]];
}
# Now we have our committers, we can work out what to add to AUTHORS.
for my $committer (@committers) {
my ($emails, $names) = @$committer;
# If this commiter is already in AUTHORS, we must not touch.
next if grep { $authors_name{$_} } @$emails;
next if grep { $authors_email{$_} } @$names;
# Decide on the "best" name and email to use
my $email = best_email(@$emails);
my $name = best_name(@$names);
$authors_email{$name} = $email;
$authors_name{$email} = $name;
# We've now selected our canonical name going forward. If there
# were other options from commit authors only (not signoffs),
# emit mailmap lines for the user to past into .mailmap
my $cemail = $display_email{email_slug($authors_email{$name})};
for my $alias (@$emails) {
next if $alias eq $email;
my $calias = $commit_email{$alias};
next unless $calias;
my $cname = $display_name{$name};
say "$cname <$cemail> <$calias>";
}
}
# Now output the new AUTHORS file
open my $fh, '>', 'AUTHORS' or die "E: couldn't open AUTHORS for write: $!\n";
say $fh join("\n", @authors_header, "");
for my $name (sort keys %authors_email) {
my $cname = $display_name{$name};
my $cemail = $display_email{email_slug($authors_email{$name})};
say $fh " $cname <$cemail>";
}
exit 0;
# "Slugs" are used at the hashtable key for names and emails. They are used to
# making two variants of a value be the "same" for matching. Mostly this is
# to make upper and lower-case versions of a name or email compare the same,
# but we do a little bit of munging to handle some common cases.
#
# Note that these are only used for matching internally; for display, the
# slug will be used to look up the display form.
sub name_slug {
my ($name) = @_;
# Remove spaces and dots, to handle differences in initials.
$name =~ s/[\s\.]//g;
return lc $name;
}
sub email_slug {
my ($email) = @_;
# Remove everything up to and including the first space, and the last
# space and everything after it.
$email =~ s/^(.*\s+)|(\s+.*)$//g;
# Remove the leading userid+ on Github noreply addresses. They're
# optional and we want to treat them as the same thing.
$email =~ s/^[^\+]*\+//g if $email =~ m/\.noreply\.github\.com$/;
return lc $email;
}
# As we accumulate new names and addresses, record the "best looking" version
# of each. Once we decide to add a committer to AUTHORS, we'll take the best
# version of their name and address from here.
#
# Note that we don't record them if they're already in AUTHORS (that is, in
# %authors_name or %authors_email) because that file already contains the
# "best" version, by definition. So we return immediately if we've seen it
# there already.
sub update_display_name {
my ($name) = @_;
my $sname = name_slug($name);
return if $authors_email{$sname};
# For names, "more specific" means "has more non-lower-case characters"
# (in ASCII), guessing that if a person has gone to some effort to
# specialise their name in a later commit, they presumably care more
# about it. If this is wrong, its probably better to add a .mailmap
# entry.
my $cname = $display_name{$sname};
if (!$cname ||
($name =~ tr/a-z //) < ($cname =~ tr/a-z //)) {
$display_name{$sname} = $name;
}
}
sub update_display_email {
my ($email) = @_;
my $semail = email_slug($email);
return if $authors_name{$semail};
# Like names, we prefer uppercase when possible. We also remove any
# leading "plus address" for Github noreply addresses.
$email =~ s/^[^\+]*\+//g if $email =~ m/\.noreply\.github\.com$/;
my $cemail = $display_email{$semail};
if (!$cemail ||
($email =~ tr/a-z //) < ($cemail =~ tr/a-z //)) {
$display_email{$semail} = $email;
}
}
sub best_name {
my @names = sort {
my $cmp;
my ($aa) = $display_name{$a};
my ($bb) = $display_name{$b};
# The "best" name is very subjective, and a simple sort
# produced good-enough results, so I didn't try harder. Use of
# accented characters, punctuation and caps are probably an
# indicator of "better", but possibly we should also take into
# account the most recent name we saw, in case the committer
# has changed their name or nickname or similar.
#
# Really, .mailmap is the place to control this.
return ($aa cmp $bb);
} @_;
return shift @names;
}
sub best_email {
state $internal_re = qr/\.(?:internal|local|\(none\))$/;
state $noreply_re = qr/\.noreply\.github\.com$/;
state $freemail_re = qr/\@(?:gmail|hotmail)\.com$/;
my @emails = sort {
my $cmp;
# prefer address with a single @ over those without
$cmp = (($b =~ tr/@//) == 1) <=> (($a =~ tr/@//) == 1);
return $cmp unless $cmp == 0;
# prefer any address over internal/local addresses
$cmp = (($a =~ $internal_re) <=> ($b =~ $internal_re));
return $cmp unless $cmp == 0;
# prefer any address over github noreply aliases
$cmp = (($a =~ $noreply_re) <=> ($b =~ $noreply_re));
return $cmp unless $cmp == 0;
# prefer any address over freemail providers
$cmp = (($a =~ $freemail_re) <=> ($b =~ $freemail_re));
return $cmp unless $cmp == 0;
# alphabetical by domain
my ($alocal, $adom) = split /\@/, $a;
my ($blocal, $bdom) = split /\@/, $b;
$cmp = ($adom cmp $bdom);
return $cmp unless $cmp == 0;
# alphabetical by local part
return ($alocal cmp $blocal);
} @_;
return shift @emails;
}
|