1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
|
#include "../src/metadata.h"
#include "gtest/gtest.h"
std::string fakePNG()
{
return "\x89PNG\r\n\x1a\n" + std::string(100, 'x');
}
TEST(Metadata, isDefaultConstructible)
{
zim::Metadata m;
(void)m; // suppress compiler's warning about an unused variable
}
TEST(Metadata, detectsAbsenceOfMandatoryEntries)
{
zim::Metadata m;
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"Missing mandatory metadata: Name",
"Missing mandatory metadata: Title",
"Missing mandatory metadata: Language",
"Missing mandatory metadata: Creator",
"Missing mandatory metadata: Publisher",
"Missing mandatory metadata: Date",
"Missing mandatory metadata: Description",
"Missing mandatory metadata: Illustration_48x48@1",
})
);
m.set("Description", "Any nonsense is better than nothing");
m.set("Date", "2020-20-20");
m.set("Creator", "Demiurge");
m.set("Name", "wikipedia_py_all");
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"Missing mandatory metadata: Title",
"Missing mandatory metadata: Language",
"Missing mandatory metadata: Publisher",
"Missing mandatory metadata: Illustration_48x48@1",
})
);
m.set("Title", "Chief Executive Officer");
m.set("Publisher", "Zangak");
m.set("Language", "py3");
m.set("Illustration_48x48@1", fakePNG());
ASSERT_TRUE(m.valid());
ASSERT_TRUE(m.check().empty());
}
zim::Metadata makeValidMetadata()
{
zim::Metadata m;
m.set("Description", "Any nonsense is better than nothing");
m.set("Date", "2020-20-20");
m.set("Creator", "Demiurge");
m.set("Name", "wikipedia_py_all");
m.set("Title", "Chief Executive Officer");
m.set("Publisher", "Zangak");
m.set("Language", "py3");
m.set("Illustration_48x48@1", fakePNG());
return m;
}
TEST(Metadata, nonReservedMetadataIsNotAProblem)
{
zim::Metadata m = makeValidMetadata();
m.set("NonReservedMetadata", "");
ASSERT_TRUE(m.valid());
}
TEST(Metadata, minSizeConstraints)
{
zim::Metadata m = makeValidMetadata();
m.set("Title", "");
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"Title must contain at least 1 characters"
})
);
m.set("Title", "t");
ASSERT_TRUE(m.valid());
}
TEST(Metadata, maxSizeConstraints)
{
zim::Metadata m = makeValidMetadata();
m.set("Title", std::string(31, 'a'));
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"Title must contain at most 30 characters"
})
);
m.set("Title", std::string(30, 'a'));
ASSERT_TRUE(m.valid());
}
TEST(Metadata, regexpConstraints)
{
zim::Metadata m = makeValidMetadata();
m.set("Date", "YYYY-MM-DD");
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"Date doesn't match regex: ^\\d\\d\\d\\d-\\d\\d-\\d\\d$"
})
);
m.set("Date", "1234-56-78"); // Yes, such a date is considered valid
// by the current simple regex
ASSERT_TRUE(m.valid());
m.set("Language", "fre,");
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"Language doesn't match regex: ^\\w{3}(,\\w{3})*$"
})
);
m.set("Language", "fre,nch");
ASSERT_TRUE(m.valid());
m.set("Illustration_48x48@1", "zimdata/favicon.png");
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"Illustration_48x48@1 doesn't match regex: ^\\x89PNG\\x0d\\x0a\\x1a\\x0a"
})
);
}
TEST(Metadata, pngRegexp)
{
const std::string PNG_HEADER = "\x89PNG\r\n\x1a\n";
zim::Metadata m = makeValidMetadata();
{
m.set("Illustration_48x48@1", PNG_HEADER + 'A');
ASSERT_TRUE(m.valid());
}
{
m.set("Illustration_48x48@1", PNG_HEADER + '\n');
ASSERT_TRUE(m.valid());
}
{
m.set("Illustration_48x48@1", PNG_HEADER + '\0');
ASSERT_TRUE(m.valid());
}
}
TEST(Metadata, complexConstraints)
{
zim::Metadata m = makeValidMetadata();
m.set("Description", "Short description");
m.set("LongDescription", "Long description");
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"LongDescription shouldn't be shorter than Description"
})
);
}
TEST(Metadata, mandatoryMetadataAndSimpleChecksAreRunUnconditionally)
{
zim::Metadata m;
m.set("Description", "Blablabla");
m.set("Date", "2020-20-20");
m.set("Creator", "Demiurge");
m.set("Name", "wikipedia_js_maxi");
m.set("Title", "A title that is too long to read for a five year old");
m.set("Publisher", "Zangak");
m.set("Language", "js");
//m.set("Illustration_48x48@1", "");
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"Missing mandatory metadata: Illustration_48x48@1",
"Language must contain at least 3 characters",
"Language doesn't match regex: ^\\w{3}(,\\w{3})*$",
"Title must contain at most 30 characters"
})
);
}
TEST(Metadata, complexChecksAreRunOnlyIfMandatoryMetadataRequirementsAreMet)
{
zim::Metadata m;
m.set("Description", "Blablabla");
m.set("LongDescription", "Blabla");
m.set("Date", "2020-20-20");
m.set("Creator", "TED");
m.set("Name", "TED_bodylanguage");
//m.set("Title", "");
m.set("Publisher", "Kiwix");
m.set("Language", "bod,yla,ngu,age");
m.set("Illustration_48x48@1", fakePNG());
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"Missing mandatory metadata: Title",
})
);
m.set("Title", "Blabluba");
ASSERT_FALSE(m.valid());
ASSERT_EQ(m.check(),
zim::Metadata::Errors({
"LongDescription shouldn't be shorter than Description"
})
);
}
|
