1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329
|
# Copyright 2011 Jaap Karssenberg <jaap.karssenberg@gmail.com>
# This module contains a number of meta test to check coding style
# and packaging
import tests
import os
import sys
import copy
import re
import subprocess
import inspect
def zim_modules():
'''Get the all module in the zim source'''
for file in tests.zim_pyfiles():
name = file[:-3].replace('/', '.')
if os.name == 'nt':
name = name.replace('\\', '.')
if name.endswith('.__init__'):
name = name[:-9]
mod = __import__(name)
for part in name.split('.')[1:]:
mod = getattr(mod, part)
yield name, mod
@tests.skipUnless(os.path.isdir('./.git'), 'Not a git source folder')
class TestGit(tests.TestCase):
def runTest(self):
try:
unknown = subprocess.check_output(['git', 'clean', '-dn'])
except FileNotFoundError:
self.skipTest('git not found')
if unknown:
unknown = unknown.decode(sys.getfilesystemencoding())
raise AssertionError('File unknown to git - need to be added or ignored:\n' + unknown)
else:
pass
class TestCompileAll(tests.TestCase):
def runTest(self):
'''Test if all modules compile'''
for name, module in zim_modules():
#~ print('>>', name)
self.assertIsNotNone(module)
try:
from setup import fix_dist
except ImportError:
fix_dist = None
@tests.slowTest
@tests.skipIf(fix_dist is None, 'Import error in setup.py')
class TestDist(tests.TestCase):
def runTest(self):
# Check build_dist script
fix_dist()
# Check desktop file
try:
subprocess.check_call(['desktop-file-validate', 'xdg/org.zim_wiki.Zim.desktop'])
except OSError:
print("Could not run desktop-file-validate")
#~ @tests.slowTest
#~ class TestNotebookUpgrade(tests.TestCase):
#~
#~ def runTest(self):
#~ '''Test if included notebooks are up to date'''
#~ from zim.newfs import LocalFolder
#~ from zim.notebook import init_notebook
#~ notebook = init_notebook(LocalFolder('data/manual'))
#~ self.assertTrue(not notebook.needs_upgrade)
class TestCoding(tests.TestCase):
'''This test case enforces some coding style items'''
def __init__(self, *a):
self._code_files = []
tests.TestCase.__init__(self, *a)
def list_code(self):
'''Return all python files as text'''
if not self._code_files:
self._read_code()
assert len(self._code_files) > 10
return copy.deepcopy(self._code_files)
def _read_code(self):
self._code_files = []
for root in ('zim', 'tests'):
for dir, dirs, files in os.walk(root):
for basename in files:
if basename.endswith('.py'):
file = dir.replace('\\', '/') + '/' + basename
if file == 'tests/package.py': # skip ourselves
continue
#~ print('READING', file)
fh = open(file, encoding='UTF-8')
self._code_files.append((file, fh.read()))
fh.close()
def testWrongDependencies(self):
'''Check clean dependencies'''
allow_gtk = ('zim/gui/', 'zim/inc/', 'zim/plugins/', 'tests/', 'zim/main/application')
#import_re = re.compile('^from gi.repository import (Gtk|Gdk|Gio|GObject)', re.M)
import_re = re.compile('^from gi.repository import (Gtk|Gdk|Gio)', re.M)
# only match global imports - allow import in limited scope
for file, code in self.list_code():
if os.name == 'nt':
file = file.replace('\\', '/')
if any(map(file.startswith, allow_gtk)):
continue # skip
match = import_re.search(code)
klass = match.group(0) if match else None
self.assertFalse(match, '%s imports %s, this is not allowed' % (file, klass))
def testWrongMethod(self):
'''Check for a couple of constructs to be avoided'''
for file, code in self.list_code():
self.assertFalse('Gtk.Entry(' in code, '%s uses Gtk.Entry - use zim.gui.widgets.InputEntry instead' % file)
#~ self.assertFalse('connect_object(' in code, '%s uses connect_object() - use connect() instead to prevent reference leaking' % file)
self.assertFalse('Gtk.HPaned(' in code, '%s uses Gtk.HPaned - use zim.gui.widgets.HPaned instead' % file)
self.assertFalse('Gtk.VPaned(' in code, '%s uses Gtk.VPaned - use zim.gui.widgets.VPaned instead' % file)
if not file.endswith('pageview.py'):
self.assertFalse('string.letters' in code, '%s uses string.letters - this can case locale dependent issues' % file)
self.assertFalse('string.lowercase' in code, '%s uses string.lowercase - this can case locale dependent issues' % file)
self.assertFalse('string.uppercase' in code, '%s uses string.uppercase - this can case locale dependent issues' % file)
if not file.endswith('widgets.py'):
self.assertFalse('Gtk.ScrolledWindow(' in code, '%s uses Gtk.ScrolledWindow - use zim.gui.widgets.ScrolledWindow instead' % file)
if not file.endswith('clipboard.py'):
self.assertFalse('Gtk.Clipboard(' in code, '%s uses Gtk.Clipboard - use zim.gui.clipboard.Clipboard instead' % file)
if not file.endswith('config.py'):
self.assertFalse('os.environ\\[' in code, '%s uses os.environ - use zim.config.get_environ() instead' % file)
def testIndenting(self):
# FIXME need real parser to be more robust for comments, multi-line strings etc.
# for now we just check lines after a line ending with ":"
# assume python itself warns us for changes in the middle of a block
white = re.compile(r'^(\s*)')
for file, code in self.list_code():
if file.startswith('zim/inc/') or file.endswith('generictreemodel.py'):
continue
lineno = 0
start_block = False
for line in code.splitlines():
lineno += 1
text = line.strip()
def_line = text.startswith('def ') or text.startswith('class ')
if start_block or def_line:
m = white.match(line)
indent = str(m.groups(1))
self.assertFalse(' ' in indent, 'Indenting should use tabs - file: %s line %s' % (file, lineno))
start_block = def_line and line.rstrip().endswith(':')
def testLoggerDefined(self):
# Common to forget this import, and only notice it when an exception
# happens much later
for file, code in self.list_code():
if 'logger.' in code:
assert 'logger = logging.getLogger(' in code, 'Forgot to define "logger" in %s' % file
def testKeys(self):
for file, code in self.list_code():
if file.startswith('zim'):
self.assertFalse('<Ctrl>' in code, '%s uses "<Ctrl>" - use "<Primary>" instead' % file)
@tests.expectedFailure
class TestDocumentation(tests.TestCase):
def runTest(self):
for modname, mod in zim_modules():
self.assertDocumentationOK(mod, modname)
for name, obj in self.walk_code(mod, modname):
if not '.inc.' in name:
self.assertDocumentationOK(obj, name)
if hasattr(obj, '__signals__'):
self.assertSignalSpecOK(obj, mod.__file__)
def walk_code(self, obj, objname):
# Yield classes, methods, and functions top down
for name, member in inspect.getmembers(obj):
if name == '__class__':
continue
name = objname + '.' + name
if inspect.isclass(member):
if member.__module__ != objname:
continue # skip imported class
yield name, member
for child in self.walk_code(member, name): # recurs
yield child
elif inspect.isfunction(member) \
or inspect.ismethod(member):
yield name, member
def assertDocumentationOK(self, obj, name):
#~ print('CHECK docs for', name)
doc = inspect.getdoc(obj)
if not doc:
return # For now do not bitch about missing docs..
# Check fields
fields = self.parseFields(doc, name)
if not fields:
return
# Check call signature for functions
if inspect.isfunction(obj) \
or inspect.ismethod(obj):
# For now we do not complain about missing docs, just mismatches
documented = set(
list(fields.get('param', {}).keys()) +
list(fields.get('keyword', {}).keys())
)
if documented:
(args, varargs, keywords, defaults) = inspect.getargspec(obj)
defined = set(args)
if args and args[0] in ('self', 'klass'):
defined.discard(args[0])
if varargs:
defined.add(varargs)
if keywords:
defined.add(keywords)
if set(defined) != {'arg', 'kwarg'}:
# ignore mismatched due to generic decorators
self.assertEqual(documented, defined,
msg='Mismatch in documented parameters for %s\n'
'Declared: %s\nDocumented: %s' %
(name, tuple(defined), tuple(documented))
)
# TODO can we also check whether doc should define @returns ??
# Check signature for @signal
if 'signal' in fields:
for spec in fields['signal']:
# e.g. "C{signal-name (L{Page}, L{Path})}: Emitted when opening"
if not re.match(r'^C{[\w-]+ \(.*?\)\}:', spec):
self.fail('Signal description in %s does not follow templates\n'
'Is: %s\nShould be like "C{signal-name (arg1, arg2)}: description"'
% (name, spec)
)
known_fields = {
# keys are known fields, if values is True, a param is
# required for the first ":"
'param': True,
'type': True,
'keyword': True,
'returns': False,
'rtype': False,
'raises': True,
'cvar': True,
'ivar': True,
'todo': False,
'note': False,
'newfield': True,
}
collect_fields = ('signal',)
def parseFields(self, doc, name):
# Parse files same as epydoc - and check them on the fly
fields = {}
for line in doc.splitlines():
m = re.match(r'@(\w+)\s*(.*?):', line)
if m:
line = line[m.end():].strip()
field, arg = m.group(1), m.group(2)
if field in self.known_fields:
if self.known_fields[field]:
if not arg:
self.fail('Doc for %s is missing argument for @%s' % (name, field))
else:
if not field in fields:
fields[field] = {}
fields[field][arg] = line
# special case - learn new fields
if field == 'newfield':
self.known_fields[arg] = False
elif field in self.collect_fields:
if not field in fields:
fields[field] = []
fields[field].append(line)
else:
fields[field] = line
else:
self.fail('Doc for %s has unknown field @%s' % (name, field))
elif re.match(r'@(\w+)', line):
self.fail('Syntax error in docs for %s\nMissing \':\' in "%s"' % (name, line))
else:
pass
return fields
def assertSignalSpecOK(self, obj, file):
for name, spec in list(obj.__signals__.items()):
self.assertTrue(
isinstance(spec, tuple) and len(spec) == 3 and isinstance(spec[2], tuple),
msg='Signal spec is malformed for %s::%s in %s' % (obj.__name__, name, file)
)
|