1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
|
# --
# Copyright (C) 2001-2021 OTRS AG, https://otrs.com/
# Copyright (C) 2021 Znuny GmbH, https://znuny.org/
# --
# This software comes with ABSOLUTELY NO WARRANTY. For details, see
# the enclosed file COPYING for license information (GPL). If you
# did not receive this file, see https://www.gnu.org/licenses/gpl-3.0.txt.
# --
## no critic (Modules::RequireExplicitPackage)
use strict;
use warnings;
use utf8;
use vars (qw($Self));
# Get needed objects
$Kernel::OM->ObjectParamAdd(
'Kernel::System::UnitTest::Helper' => {
RestoreDatabase => 1,
},
);
my $HelperObject = $Kernel::OM->Get('Kernel::System::UnitTest::Helper');
my $RandomID1 = $HelperObject->GetRandomID();
my $RandomID2 = $HelperObject->GetRandomID();
#
# Prepare valid config XML and Perl
#
my $ValidSettingXML = <<'EOF';
<?xml version="1.0" encoding="utf-8" ?>
<otrs_config version="2.0" init="Framework">
<Setting Name="Test1" Required="1" Valid="1">
<Description Translatable="1">Test 1.</Description>
<Navigation>Core::Ticket</Navigation>
<Value>
<Item ValueType="String" ValueRegex=".*">Test setting 1</Item>
</Value>
</Setting>
<Setting Name="Test2" Required="1" Valid="1">
<Description Translatable="1">Test 2.</Description>
<Navigation>Core::Ticket</Navigation>
<Value>
<Item ValueType="File">/usr/bin/gpg</Item>
</Value>
</Setting>
</otrs_config>
EOF
my $SysConfigXMLObject = $Kernel::OM->Get('Kernel::System::SysConfig::XML');
my @DefaultSettingAddParams = $SysConfigXMLObject->SettingListParse(
XMLInput => $ValidSettingXML,
);
# Give the unit test an extra scope for the redefined functions.
{
$Kernel::OM->ObjectsDiscard(
Objects => ['Kernel::System::SysConfig::DB'],
);
use Kernel::System::SysConfig::DB;
# Provoke a failure for 2nd setting, this provokes that 1st setting is restored.
no warnings qw( once redefine ); ## no critic
local *Kernel::System::SysConfig::DB::ModifiedSettingVersionAdd = sub {
my ( $Self, %Param ) = @_;
return 0 if $Param{Name} eq $RandomID2;
return 1;
};
# Make sure the system does not complaint for missing added versions.
local *Kernel::System::SysConfig::DB::ModifiedSettingVersionDelete = sub { return 1 };
use warnings;
my $SysConfigDBObject = $Kernel::OM->Get('Kernel::System::SysConfig::DB');
# Add default settings.
my $DefaultSettingID1 = $SysConfigDBObject->DefaultSettingAdd(
Name => $RandomID1,
Description => 'Test',
Navigation => 'ASimple::Path::Structure',
IsInvisible => 0,
IsReadonly => 0,
IsRequired => 0,
IsValid => 1,
HasConfigLevel => 200,
UserModificationPossible => 0,
UserModificationActive => 0,
XMLContentRaw => $DefaultSettingAddParams[0]->{XMLContentRaw},
XMLContentParsed => $DefaultSettingAddParams[0]->{XMLContentParsed},
XMLFilename => 'UnitTest.xml',
EffectiveValue => 'Default',
UserID => 1,
);
my $DefaultSettingID2 = $SysConfigDBObject->DefaultSettingAdd(
Name => $RandomID2,
Description => 'Test',
Navigation => 'ASimple::Path::Structure',
IsInvisible => 0,
IsReadonly => 0,
IsRequired => 0,
IsValid => 1,
HasConfigLevel => 200,
UserModificationPossible => 0,
UserModificationActive => 0,
XMLContentRaw => $DefaultSettingAddParams[1]->{XMLContentRaw},
XMLContentParsed => $DefaultSettingAddParams[1]->{XMLContentParsed},
XMLFilename => 'UnitTest.xml',
EffectiveValue => 'Default',
UserID => 1,
);
# Modify both settings with ResetToDefaut flag to simulate that a restore mechanism is needed
# in case of a failure.
my $ExclusiveLockGUID = $SysConfigDBObject->DefaultSettingLock(
LockAll => 1,
Force => 1,
UserID => 1,
);
my $ModifiedID1 = $SysConfigDBObject->ModifiedSettingAdd(
DefaultID => $DefaultSettingID1,
Name => $RandomID1,
IsValid => 1,
ResetToDefault => 1,
EffectiveValue => 'Modified',
ExclusiveLockGUID => $ExclusiveLockGUID,
UserID => 1,
);
my $ModifiedID2 = $SysConfigDBObject->ModifiedSettingAdd(
DefaultID => $DefaultSettingID2,
Name => $RandomID2,
IsValid => 1,
ResetToDefault => 1,
EffectiveValue => 'Modified',
ExclusiveLockGUID => $ExclusiveLockGUID,
UserID => 1,
);
my $SysConfigObject = $Kernel::OM->Get('Kernel::System::SysConfig');
# Get current setting values.
my %ModifiedSetting1 = $SysConfigObject->SettingGet(
Name => $RandomID1,
UserID => 1,
);
my %ModifiedSetting2 = $SysConfigObject->SettingGet(
Name => $RandomID2,
UserID => 1,
);
my $DeploymentExclusiveLockGUID = $SysConfigDBObject->DeploymentLock(
UserID => 1,
Force => 1,
);
# Call deployment settings handle helper to provoke the restore due to the overwritten
# method above.
my $Success = $SysConfigObject->_HandleSettingsToDeploy(
DirtySettings => [ $RandomID1, $RandomID2 ],
UserID => 1,
DeploymentExclusiveLockGUID => $DeploymentExclusiveLockGUID,
DeploymentTimeStamp => '2016-12-12 12:00:00',
);
# Get setting values again to compare.
my %RestoredSetting1 = $SysConfigObject->SettingGet(
Name => $RandomID1,
UserID => 1,
);
my %RestoredSetting2 = $SysConfigObject->SettingGet(
Name => $RandomID2,
UserID => 1,
);
# Setting one should have the same value but not same ModifiedID.
$Self->Is(
$ModifiedSetting1{EffectiveValue},
$RestoredSetting1{EffectiveValue},
"Setting $RandomID1 keeps the EffectiveValue",
);
$Self->IsNot(
$ModifiedSetting1{ModifiedID},
$RestoredSetting1{ModifiedID},
"Setting $RandomID1 should not keep the same ModifiedID",
);
# Setting two should have the same value and ModifiedID since it was not deleted in the handling.
$Self->Is(
$ModifiedSetting2{EffectiveValue},
$RestoredSetting2{EffectiveValue},
"Setting $RandomID2 keeps the EffectiveValue",
);
$Self->Is(
$ModifiedSetting2{ModifiedID},
$RestoredSetting2{ModifiedID},
"Setting $RandomID2 keeps the ModifiedID",
);
}
1;
|
