1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
|
#
# PloneFolder tests
#
import os, sys
if __name__ == '__main__':
execfile(os.path.join(sys.path[0], 'framework.py'))
from Products.CMFPlone.tests import PloneTestCase
from Products.CMFPlone.tests import dummy
from Products.CMFPlone.utils import _createObjectByType
import transaction
from OFS.IOrderSupport import IOrderedContainer
from AccessControl import Unauthorized
from Products.CMFCore.permissions import DeleteObjects
from zExceptions import NotFound
from zExceptions import BadRequest
class TestPloneFolder(PloneTestCase.PloneTestCase):
def afterSetUp(self):
# Create a bunch of subfolders
self.folder.invokeFactory('Folder', id='sub1')
self.folder.invokeFactory('Folder', id='sub2')
self.folder.invokeFactory('Folder', id='sub3')
def testGetObjectPosition(self):
self.assertEqual(self.folder.getObjectPosition('sub1'), 0)
def testGetObjectPositionRaisesNotFound(self):
self.assertRaises(NotFound, self.folder.getObjectPosition, 'foobar')
def testSortOrder(self):
self.assertEqual(self.folder.objectIds(),
['sub1', 'sub2', 'sub3'])
def testEditFolderKeepsPosition(self):
# Cover http://dev.plone.org/plone/ticket/2796
self.folder.sub2.folder_edit('Foo', 'Description')
self.assertEqual(self.folder.sub2.Title(), 'Foo')
# Order should remain the same
self.assertEqual(self.folder.objectIds(),
['sub1', 'sub2', 'sub3'])
def testRenameFolderKeepsPosition(self):
# Cover http://dev.plone.org/plone/ticket/2796
transaction.savepoint(optimistic=True) # make rename work
self.folder.sub2.folder_edit('Foo', 'Description', id='foo')
self.assertEqual(self.folder.foo.Title(), 'Foo')
# Order should remain the same
self.assertEqual(self.folder.objectIds(),
['sub1', 'foo', 'sub3'])
def testCanViewManagementScreen(self):
# Make sure the ZMI management screen works
self.folder.manage_main()
def testLargePloneFolderIsNotOrdered(self):
_createObjectByType('Large Plone Folder', self.folder, 'lpf')
lpf = self.folder.lpf
self.failIf(IOrderedContainer.isImplementedBy(lpf))
class TestCheckIdAvailable(PloneTestCase.PloneTestCase):
# PortalFolder.checkIdAvailable() did not properly catch
# zExceptions.BadRequest.
# Fixed in CMFCore.PortalFolder, not Plone.
def afterSetUp(self):
_createObjectByType('Large Plone Folder', self.folder, 'lpf')
self.lpf = self.folder.lpf
def testSetObjectRaisesBadRequest(self):
# _setObject() should raise zExceptions.BadRequest
# on duplicate id.
self.folder._setObject('foo', dummy.Item())
try:
self.folder._setObject('foo', dummy.Item())
except BadRequest:
pass
def testCheckIdRaisesBadRequest(self):
# _checkId() should raise zExceptions.BadRequest
# on duplicate id.
self.folder._setObject('foo', dummy.Item())
try:
self.folder._checkId('foo')
except BadRequest:
pass
def testCheckIdAvailableCatchesBadRequest(self):
# checkIdAvailable() should catch zExceptions.BadRequest
self.folder._setObject('foo', dummy.Item())
self.failIf(self.folder.checkIdAvailable('foo'))
def testLPFSetObjectRaisesBadRequest(self):
# _setObject() should raise zExceptions.BadRequest
# on duplicate id.
self.lpf._setObject('foo', dummy.Item())
try:
self.lpf._setObject('foo', dummy.Item())
except BadRequest:
pass
def testLPFCheckIdRaisesBadRequest(self):
# _checkId() should raise zExceptions.BadRequest
# on duplicate id.
self.lpf._setObject('foo', dummy.Item())
try:
self.lpf._checkId('foo')
except BadRequest:
pass
def testLPFCheckIdAvailableCatchesBadRequest(self):
# checkIdAvailable() should catch zExceptions.BadRequest
self.lpf._setObject('foo', dummy.Item())
self.failIf(self.lpf.checkIdAvailable('foo'))
class TestFolderListing(PloneTestCase.PloneTestCase):
# Tests for http://dev.plone.org/plone/ticket/3512
def afterSetUp(self):
self.workflow = self.portal.portal_workflow
# Create some objects to list
self.folder.invokeFactory('Folder', id='sub1')
self.folder.invokeFactory('Folder', id='sub2')
self.folder.invokeFactory('Document', id='doc1')
self.folder.invokeFactory('Document', id='doc2')
def _contentIds(self, folder):
return [ob.getId() for ob in folder.listFolderContents()]
def testListFolderContentsOmitsPrivateObjects(self):
self.workflow.doActionFor(self.folder.doc1, 'hide')
self.logout()
self.assertEqual(self._contentIds(self.folder),
['sub1', 'sub2', 'doc2'])
def testListFolderContentsOmitsPrivateFolders(self):
self.workflow.doActionFor(self.folder.sub1, 'hide')
self.logout()
self.assertEqual(self._contentIds(self.folder),
['sub2', 'doc1', 'doc2'])
def testBugReport(self):
# Perform the steps-to-reproduce in the collector issue:
# 2)
self.folder.invokeFactory('Folder', id='A')
self.workflow.doActionFor(self.folder.A, 'publish')
self.logout()
self.assertEqual(self._contentIds(self.folder.A), [])
# 3)
self.login()
self.folder.A.invokeFactory('Document', id='B')
self.folder.A.B.manage_permission('View', ['Manager', 'Reviewer'], acquire=0)
self.logout()
self.assertEqual(self._contentIds(self.folder.A), [])
# 4)
self.login()
self.folder.A.invokeFactory('Folder', id='C')
self.folder.A.C.manage_permission('View', ['Manager', 'Reviewer'], acquire=0)
# Here comes the reported bug:
self.logout()
self.assertEqual(self._contentIds(self.folder.A), ['C']) # <--
# 4a)
# BUT: removing 'View' is simply not enough!
# When using the workflow all is fine:
self.login()
self.workflow.doActionFor(self.folder.A.C, 'hide')
self.logout()
self.assertEqual(self._contentIds(self.folder.A), [])
# -> For folders you also have to remove 'Access contents information'
# -> Never click around in the ZMI security screens, use the workflow!
def test_folder_contents(self):
self.folder.sub1.invokeFactory('Document', id='sub1doc1')
contents = self.folder.sub1.getFolderContents()
self.assertEqual(len(contents), 1)
self.assertEqual(contents[0].getId, 'sub1doc1')
self.failUnless(self.folder.sub1.folder_contents())
self.folder.sub1.manage_permission('List folder contents', ['Manager'], acquire=0)
self.assertRaises(Unauthorized, self.folder.sub1.folder_contents)
class TestManageDelObjects(PloneTestCase.PloneTestCase):
# manage_delObjects should check 'Delete objects'
# permission on contained items.
def afterSetUp(self):
# Create a bunch of folders
self.folder.invokeFactory('Folder', id='sub1')
self.sub1 = self.folder.sub1
self.sub1.invokeFactory('Folder', id='sub2')
self.sub2 = self.sub1.sub2
def testManageDelObjects(self):
# Should be able to delete sub1
self.folder.manage_delObjects('sub1')
self.failIf('sub1' in self.folder.objectIds())
def testManageDelObjectsIfSub1Denied(self):
# Should NOT be able to delete sub1 due to permission checks in
# Archetypes.BaseFolder.manage_delObjects().
self.sub1.manage_permission(DeleteObjects, ['Manager'], acquire=0)
self.assertRaises(Unauthorized, self.folder.manage_delObjects, 'sub1')
def testManageDelObjectsIfSub2Denied(self):
# We are able to delete sub1 if sub2 is denied
# -> the check is only 1 level deep!
self.sub2.manage_permission(DeleteObjects, ['Manager'], acquire=0)
self.folder.manage_delObjects('sub1')
self.failIf('sub1' in self.folder.objectIds())
class TestManageDelObjectsInPortal(PloneTestCase.PloneTestCase):
def afterSetUp(self):
_createObjectByType('Folder', self.portal, id='sub1')
self.sub1 = self.portal.sub1
def testManageDelObjects(self):
# Should be able to delete sub1
self.portal.manage_delObjects('sub1')
self.failIf('sub1' in self.portal.objectIds())
def testManageDelObjectsIfSub1Denied(self):
# Should be able to delete sub1 as the portal does not implement
# additional permission checks.
self.sub1.manage_permission(DeleteObjects, ['Manager'], acquire=0)
self.assertRaises(Unauthorized, self.portal.manage_delObjects, 'sub1')
def test_suite():
from unittest import TestSuite, makeSuite
suite = TestSuite()
suite.addTest(makeSuite(TestPloneFolder))
suite.addTest(makeSuite(TestCheckIdAvailable))
suite.addTest(makeSuite(TestFolderListing))
suite.addTest(makeSuite(TestManageDelObjects))
suite.addTest(makeSuite(TestManageDelObjectsInPortal))
return suite
if __name__ == '__main__':
framework()
|
