Package: audacity / 3.7.3+dfsg-1

Metadata

Package Version Patches format
audacity 3.7.3+dfsg-1 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
Fix rpath for private libraries on Linux.patch | (download)

CMakeLists.txt | 1 1 + 0 - 0 !
cmake-proxies/cmake-modules/AudacityFunctions.cmake | 18 18 + 0 - 0 !
modules/scripting/mod-script-pipe/CMakeLists.txt | 1 1 + 0 - 0 !
src/CMakeLists.txt | 5 0 + 5 - 0 !
4 files changed, 20 insertions(+), 5 deletions(-)

 fix rpath for private libraries on linux

Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.

The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."

So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.

Fixes: https://github.com/audacity/audacity/issues/3289
Fix setting audacity_use_midi off.patch | (download)

src/Experimental.cmake | 28 16 + 12 - 0 !
1 file changed, 16 insertions(+), 12 deletions(-)

 fix setting audacity_use_midi=off

When disabling MIDI support, cmake will fail:

```
$ cmake -B build -Daudacity_use_midi=off
[...]
CMake Error at cmake-proxies/CMakeLists.txt:314 (message):
  EXPERIMENTAL_MIDI_OUT requires USE_MIDI
```

Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.

Drop UBUNTU_MENUPROXY 0 workaround.patch | (download)

linux/AppImage/AppRun.sh | 1 0 + 1 - 0 !
linux/create_appimage.sh | 1 0 + 1 - 0 !
src/audacity.desktop.in | 2 1 + 1 - 0 !
3 files changed, 1 insertion(+), 3 deletions(-)

 drop ubuntu_menuproxy=0 workaround

wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.

Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.